@truedat/bg 8.12.2 → 8.12.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/bg",
-  "version": "8.12.2",
+  "version": "8.12.4",
   "description": "Truedat Web Business Glossary",
   "sideEffects": [
     "**/*.css",
@@ -57,7 +57,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.12.2",
+    "@truedat/test": "8.12.4",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -90,5 +90,5 @@
     "semantic-ui-react": "^3.0.0-beta.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "b0000f1b2727cad43ce3c3eb2fa29681488dd2ec"
+  "gitHead": "d5bc1af84c4d828bdec676b0da58385cf0d6015f"
 }

package/src/concepts/components/__tests__/ConceptLinksManagement.spec.js

@@ -67,6 +67,7 @@ jest.mock("@truedat/bg/concepts/hooks/useConcepts", () => {
   };
 });
 jest.mock("@truedat/core/hooks/useUserFilters");
+jest.mock("@truedat/bg/hooks/useDomains");
 
 const link = {
   id: 745,

package/src/concepts/components/__tests__/ConceptManageDomainPopup.spec.js

@@ -5,6 +5,8 @@ import { domainsMock } from "@truedat/test/mocks";
 import { ConceptManageDomainPopup } from "../ConceptManageDomainPopup";
 
 describe("<ConceptManageDomainPopup />", () => {
+  beforeEach(() => jest.useRealTimers());
+
   const props = {
     saving: false,
     update_domain: true,
@@ -17,6 +19,11 @@ describe("<ConceptManageDomainPopup />", () => {
         domainActions: undefined,
         ids: undefined,
       }),
+      domainsMock({
+        action: "manageConcept",
+        domainActions: undefined,
+        ids: undefined,
+      }),
     ],
   };
 

package/src/concepts/components/__tests__/Concepts.spec.js

@@ -1,5 +1,4 @@
 import { render, waitForLoad } from "@truedat/test/render";
-import { waitFor } from "@testing-library/react";
 import { Concepts } from "../Concepts";
 import { defaultConceptColumns } from "../../selectors";
 
@@ -45,6 +44,7 @@ jest.mock("@truedat/bg/concepts/hooks/useConcepts", () => {
   };
 });
 jest.mock("@truedat/core/hooks/useUserFilters");
+jest.mock("@truedat/bg/hooks/useDomains");
 
 const state = {
   conceptsColumns: {

package/src/concepts/components/__tests__/ConceptsBulkUpdate.spec.js

@@ -40,6 +40,8 @@ const renderOpts = {
 };
 
 describe("<ConceptsBulkUpdate />", () => {
+  beforeEach(() => jest.useRealTimers());
+
   it("matches the latest snapshot", async () => {
     const rendered = render(<ConceptsBulkUpdate />, renderOpts);
     await waitForLoad(rendered);
@@ -53,8 +55,9 @@ describe("<ConceptsBulkUpdate />", () => {
     await waitForLoad(rendered);
 
     await user.click(rendered.getByText(/foodomain/i));
-    await waitFor(() =>
-      expect(rendered.queryByText(/field1/i)).toBeInTheDocument(),
+    await waitFor(
+      () => expect(rendered.queryByText(/field1/i)).toBeInTheDocument(),
+      { timeout: 5000 },
     );
   });
 
@@ -68,8 +71,9 @@ describe("<ConceptsBulkUpdate />", () => {
     await waitForLoad(rendered);
 
     await user.click(rendered.getByText(/foodomain/i));
-    await waitFor(() =>
-      expect(rendered.queryByText(/field1/i)).toBeInTheDocument(),
+    await waitFor(
+      () => expect(rendered.queryByText(/field1/i)).toBeInTheDocument(),
+      { timeout: 5000 },
     );
 
     await user.type(rendered.getByPlaceholderText(/field1/i), "abc123456");

package/src/concepts/components/__tests__/ConceptsPanel.spec.js

@@ -1,5 +1,4 @@
 import { render, waitForLoad } from "@truedat/test/render";
-import { waitFor } from "@testing-library/react";
 import ConceptsPanel from "../ConceptsPanel";
 import { defaultConceptColumns } from "../../selectors";
 
@@ -44,6 +43,7 @@ jest.mock("@truedat/bg/concepts/hooks/useConcepts", () => {
   };
 });
 jest.mock("@truedat/core/hooks/useUserFilters");
+jest.mock("@truedat/bg/hooks/useDomains");
 
 const state = {
   conceptsColumns: {

package/src/concepts/relations/components/__tests__/ConceptLinksApprovalsRow.spec.js

@@ -1,6 +1,16 @@
+import { fireEvent } from "@testing-library/react";
 import { render, waitForLoad } from "@truedat/test/render";
 import { ConceptLinksApprovalsRow } from "../ConceptLinksApprovalsRow";
 
+const renderRow = (props) =>
+  render(
+    <table>
+      <tbody>
+        <ConceptLinksApprovalsRow {...props} />
+      </tbody>
+    </table>,
+  );
+
 describe("ConceptLinksApprovalsRow", () => {
   const defaultProps = {
     checked: false,
@@ -35,34 +45,28 @@ describe("ConceptLinksApprovalsRow", () => {
   });
 
   it("renders row with checkbox when approveView is true", async () => {
-    const rendered = render(
-      <ConceptLinksApprovalsRow {...defaultProps} approveView={true} />,
-    );
+    const rendered = renderRow({ ...defaultProps, approveView: true });
     await waitForLoad(rendered);
     expect(rendered.container).toMatchSnapshot();
   });
 
   it("renders row without checkbox when approveView is false", async () => {
-    const rendered = render(
-      <ConceptLinksApprovalsRow {...defaultProps} approveView={false} />,
-    );
+    const rendered = renderRow({ ...defaultProps, approveView: false });
     await waitForLoad(rendered);
     expect(rendered.container).toMatchSnapshot();
   });
 
   it("calls onCheckboxChange when checkbox is clicked", async () => {
     const onCheckboxChange = jest.fn();
-    const rendered = render(
-      <ConceptLinksApprovalsRow
-        {...defaultProps}
-        approveView={true}
-        onCheckboxChange={onCheckboxChange}
-      />,
-    );
+    const rendered = renderRow({
+      ...defaultProps,
+      approveView: true,
+      onCheckboxChange,
+    });
     await waitForLoad(rendered);
 
     const checkbox = rendered.container.querySelector("input[type='checkbox']");
-    checkbox.click();
+    fireEvent.click(checkbox);
     expect(onCheckboxChange).toHaveBeenCalled();
   });
 });

package/src/concepts/relations/components/__tests__/ConceptRelationForm.spec.js

@@ -70,6 +70,7 @@ jest.mock("@truedat/bg/concepts/hooks/useConcepts", () => {
 });
 
 jest.mock("@truedat/core/hooks/useUserFilters");
+jest.mock("@truedat/bg/hooks/useDomains");
 
 const concept = {
   id: 1,

package/src/concepts/relations/components/__tests__/ConceptRelationRow.spec.js

@@ -28,7 +28,13 @@ describe("<ConceptRelationRow />", () => {
       tags,
     };
 
-    const rendered = render(<ConceptRelationRow {...props} />);
+    const rendered = render(
+      <table>
+        <tbody>
+          <ConceptRelationRow {...props} />
+        </tbody>
+      </table>,
+    );
     await waitForLoad(rendered);
     expect(rendered.container).toMatchSnapshot();
   });

package/src/concepts/relations/components/__tests__/__snapshots__/ConceptLinksApprovalsRow.spec.js.snap

@@ -6,42 +6,50 @@ exports[`ConceptLinksApprovalsRow renders null when link is empty 1`] = `<div />
 
 exports[`ConceptLinksApprovalsRow renders row with checkbox when approveView is true 1`] = `
 <div>
-  <tr
-    class=""
-  >
-    <td
-      class="collapsing center aligned one wide"
-    >
-      <div
-        class="ui fitted checkbox"
+  <table>
+    <tbody>
+      <tr
+        class=""
       >
-        <input
-          class="hidden"
-          id="123"
-          readonly=""
-          tabindex="0"
-          type="checkbox"
+        <td
+          class="collapsing center aligned one wide"
+        >
+          <div
+            class="ui fitted checkbox"
+          >
+            <input
+              class="hidden"
+              id="123"
+              readonly=""
+              tabindex="0"
+              type="checkbox"
+            />
+            <label
+              for="123"
+            />
+          </div>
+        </td>
+        <td
+          class="left aligned"
         />
-        <label
-          for="123"
-        />
-      </div>
-    </td>
-    <td
-      class="left aligned"
-    />
-  </tr>
+      </tr>
+    </tbody>
+  </table>
 </div>
 `;
 
 exports[`ConceptLinksApprovalsRow renders row without checkbox when approveView is false 1`] = `
 <div>
-  <tr
-    class=""
-  >
-    <td
-      class="left aligned"
-    />
-  </tr>
+  <table>
+    <tbody>
+      <tr
+        class=""
+      >
+        <td
+          class="left aligned"
+        />
+      </tr>
+    </tbody>
+  </table>
 </div>
 `;

package/src/concepts/relations/components/__tests__/__snapshots__/ConceptRelationRow.spec.js.snap

@@ -2,40 +2,44 @@
 
 exports[`<ConceptRelationRow /> matches the latest snapshot 1`] = `
 <div>
-  <tr
-    class=""
-  >
-    <td
-      class=""
-    >
-      source
-    </td>
-    <td
-      class="center aligned"
-    >
-      <div
-        class="ui label"
+  <table>
+    <tbody>
+      <tr
+        class=""
       >
-        -
-      </div>
-    </td>
-    <td
-      class="center aligned"
-    >
-      target
-    </td>
-    <td
-      class="center aligned"
-    >
-      <button
-        class="ui red mini basic compact icon button relation-actions__delete-button"
-      >
-        <i
-          aria-hidden="true"
-          class="red trash alternate outline small icon relation-actions__delete-icon"
-        />
-      </button>
-    </td>
-  </tr>
+        <td
+          class=""
+        >
+          source
+        </td>
+        <td
+          class="center aligned"
+        >
+          <div
+            class="ui label"
+          >
+            -
+          </div>
+        </td>
+        <td
+          class="center aligned"
+        >
+          target
+        </td>
+        <td
+          class="center aligned"
+        >
+          <button
+            class="ui red mini basic compact icon button relation-actions__delete-button"
+          >
+            <i
+              aria-hidden="true"
+              class="red trash alternate outline small icon relation-actions__delete-icon"
+            />
+          </button>
+        </td>
+      </tr>
+    </tbody>
+  </table>
 </div>
 `;

package/src/concepts/relations/selectors/getBusinessConceptsLinksToImplementationsColumns.js

@@ -1,5 +1,4 @@
 import _ from "lodash/fp";
-import { createSelector } from "reselect";
 import { FormattedMessage } from "react-intl";
 import { Link } from "react-router";
 import DateTime from "@truedat/core/components/DateTime";
@@ -100,7 +99,6 @@ export const defaultBusinessConceptsLinksToImplementationsColumns = [
   },
 ];
 
-export const getBusinessConceptsLinksToImplementationsColumns = createSelector(
-  _.prop("businessConceptsLinksToImplementationsColumns"),
-  _.defaultTo(defaultBusinessConceptsLinksToImplementationsColumns),
-);
+export const getBusinessConceptsLinksToImplementationsColumns = (state) =>
+  state.businessConceptsLinksToImplementationsColumns ??
+  defaultBusinessConceptsLinksToImplementationsColumns;

package/src/concepts/selectors/getConceptColumns.js

@@ -1,7 +1,6 @@
 import _ from "lodash/fp";
 import { Icon } from "semantic-ui-react";
 import { FormattedMessage } from "react-intl";
-import { createSelector } from "reselect";
 import Moment from "react-moment";
 import { Link } from "react-router";
 import { linkTo } from "@truedat/core/routes";
@@ -73,9 +72,7 @@ export const defaultConceptColumns = [
   },
 ];
 
-const getColumns = (state) => state.conceptsColumns;
+const defaultColumns = { concepts: defaultConceptColumns };
 
-export const getConceptColumns = createSelector(
-  getColumns,
-  _.defaultTo({ concepts: defaultConceptColumns }),
-);
+export const getConceptColumns = (state) =>
+  state.conceptsColumns ?? defaultColumns;

package/src/concepts/selectors/getConceptUploadEventColumns.js

@@ -1,5 +1,4 @@
 import _ from "lodash/fp";
-import { createSelector } from "reselect";
 import { FormattedMessage } from "react-intl";
 import Moment from "react-moment";
 import { AlertExporter } from "@truedat/core/components/AlertExporter";
@@ -63,9 +62,5 @@ export const defaultConceptsUploadEventColumns = [
   },
 ];
 
-const getColumns = (state) => state.conceptsUploadEventColumns;
-
-export const getConceptUploadEventColumns = createSelector(
-  [getColumns],
-  (columns) => _.defaultTo(defaultConceptsUploadEventColumns)(columns),
-);
+export const getConceptUploadEventColumns = (state) =>
+  state.conceptsUploadEventColumns ?? defaultConceptsUploadEventColumns;

package/src/taxonomy/components/__tests__/DomainForm.spec.js

@@ -1,5 +1,4 @@
 import userEvent from "@testing-library/user-event";
-import { act } from "@testing-library/react";
 import { render, waitForLoad } from "@truedat/test/render";
 import { DomainForm } from "../DomainForm";
 import { useDomains } from "../../../hooks/useDomains";
@@ -82,6 +81,8 @@ const data = [
   },
 ];
 describe("<DomainForm />", () => {
+  beforeEach(() => jest.useRealTimers());
+
   const onSubmit = jest.fn();
   const domain = { id: 1, name: "nn", external_id: "foo", description: "dd" };
   const isSubmitting = false;
@@ -105,16 +106,14 @@ describe("<DomainForm />", () => {
     ).toBeDisabled();
 
     const user = userEvent.setup({ delay: null });
-    await act(async () => {
-      await user.type(
-        await rendered.findByRole("textbox", { name: /name/i }),
-        "name",
-      );
-      await user.type(
-        await rendered.findByRole("textbox", { name: /external_id/i }),
-        "id",
-      );
-    });
+    await user.type(
+      await rendered.findByRole("textbox", { name: /name/i }),
+      "name",
+    );
+    await user.type(
+      await rendered.findByRole("textbox", { name: /external_id/i }),
+      "id",
+    );
 
     expect(
       await rendered.findByRole("button", { name: /save/i }),

package/src/taxonomy/components/__tests__/DomainMembers.spec.js

@@ -1,6 +1,15 @@
 import { render, waitForLoad } from "@truedat/test/render";
 import { DomainMembers } from "../DomainMembers";
 
+jest.mock("@truedat/core/hooks/useAclEntries", () => ({
+  ...jest.requireActual("@truedat/core/hooks/useAclEntries"),
+  useAclEntries: () => ({
+    data: { aclEntries: [], actions: { canCreate: false } },
+    loading: false,
+    mutate: jest.fn(),
+  }),
+}));
+
 jest.mock("react-router", () => ({
   ...jest.requireActual("react-router"),
   useParams: jest.fn().mockReturnValue({ id: "1" }),

package/src/taxonomy/components/__tests__/EditDomain.spec.js

@@ -5,6 +5,7 @@ import { useDomainParentableIds } from "../../../hooks/useDomains";
 
 jest.mock("../../../hooks/useDomains", () => ({
   ...jest.requireActual("../../../hooks/useDomains"),
+  useDomains: jest.fn(() => ({ data: [] })),
   useDomainParentableIds: jest.fn(() => {}),
 }));