@truedat/bg 8.0.3 → 8.1.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/bg",
-  "version": "8.0.3",
+  "version": "8.1.0",
   "description": "Truedat Web Business Glossary",
   "sideEffects": false,
   "module": "src/index.js",
@@ -48,7 +48,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.0.3",
+    "@truedat/test": "8.1.0",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -81,5 +81,5 @@
     "semantic-ui-react": "^3.0.0-beta.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "5be7b14325000a19bb8f18a96dff0bc16757745b"
+  "gitHead": "c954898f854501a4e91a10be48ea563e55967284"
 }

package/src/concepts/selectors/__tests__/getParsedEvents.spec.js

@@ -1018,7 +1018,7 @@ describe("selectors: getParsedEvents", () => {
       });
     });
 
-    it("should NOT handle name field in update_concept", () => {
+    it("should handle name field in update_concept", () => {
       const events = [
         {
           id: 1,
@@ -1035,12 +1035,11 @@ describe("selectors: getParsedEvents", () => {
       const res = getParsedEvents({ events, concept });
 
       expect(res).toHaveLength(1);
-      expect(res[0].payload).not.toContainEqual(
-        expect.objectContaining({
-          msg_key: "changed_field",
-          msg_params: expect.arrayContaining(["name", "New Concept Name"]),
-        })
-      );
+      expect(res[0].payload).toContainEqual({
+        msg_key: "changed_field",
+        msg_params: ["name", "New Concept Name"],
+        msg_via: "single_update",
+      });
     });
 
     it("should handle description field in update_concept_draft", () => {
@@ -1067,7 +1066,7 @@ describe("selectors: getParsedEvents", () => {
       });
     });
 
-    it("should NOT handle description field in update_concept", () => {
+    it("should handle description field in update_concept", () => {
       const events = [
         {
           id: 1,
@@ -1084,12 +1083,11 @@ describe("selectors: getParsedEvents", () => {
       const res = getParsedEvents({ events, concept });
 
       expect(res).toHaveLength(1);
-      expect(res[0].payload).not.toContainEqual(
-        expect.objectContaining({
-          msg_key: "changed_field_without_target",
-          msg_params: ["description"],
-        })
-      );
+      expect(res[0].payload).toContainEqual({
+        msg_key: "changed_field_without_target",
+        msg_params: ["description"],
+        msg_via: "single_update",
+      });
     });
 
     it("should return empty payload when update_concept_draft has no content", () => {
@@ -1151,7 +1149,7 @@ describe("selectors: getParsedEvents", () => {
         msg_via: "bulk_upload",
       });
       expect(res[0].payload).toContainEqual({
-        msg_key: "changed_field_without_target",
+        msg_key: "changed_field",
         msg_params: ["Label", "new_value"],
         msg_via: "bulk_upload",
       });
@@ -1202,7 +1200,7 @@ describe("selectors: getParsedEvents", () => {
         msg_via: "single_update",
       });
       expect(res[0].payload).toContainEqual({
-        msg_key: "added_field_without_target",
+        msg_key: "added_field",
         msg_params: ["Label", "added_value"],
         msg_via: "single_update",
       });

package/src/concepts/selectors/getParsedEvents.js

@@ -18,7 +18,7 @@ const getDeleteConceptDraftEvent = ({ payload, ...e }) => {
   return { ...e, payload: [{ msg_key, msg_params, msg_via: event_via }] };
 };
 
-const getNewConceptDraftEvent = ({ payload, ...e }) => {
+const getNewConceptVersion = ({ payload, ...e }) => {
   const msg_key = "created_version";
   const { version, event_via } = payload;
   const msg_params = [toStr(version)];
@@ -51,10 +51,11 @@ const getConceptFieldChanges = (
   )(fields);
 
 const fromValueType = (msg_key, field, value, fieldsWithoutValue) =>
-  _.includes(field)(fieldsWithoutValue) ||
-    _.isNil(value)
-    ? msg_key + "_without_target"
-    : msg_key;
+  _.isString(value) ? msg_key :
+    _.includes(field)(fieldsWithoutValue) ||
+      _.isNil(value)
+      ? msg_key + "_without_target"
+      : msg_key;
 
 const getFieldLabel = (field, fields) =>
   _.flow(
@@ -113,7 +114,7 @@ const getUpdateConceptEvent = (
     })(field_config);
   }
 
-  if (options.isDraft && description) {
+  if (description) {
     // eslint-disable-next-line fp/no-mutation
     field_config = _.concat({
       msg_key: "changed_field_without_target",
@@ -122,7 +123,7 @@ const getUpdateConceptEvent = (
     })(field_config);
   }
 
-  if (options.isDraft && name) {
+  if (name) {
     // eslint-disable-next-line fp/no-mutation
     field_config = _.concat({
       msg_key: "changed_field",
@@ -249,7 +250,7 @@ const getParsedEvents = createSelector(
     return _.map((e) => {
       const { event } = e;
       if (event === "create_concept_draft") {
-        return getNewConceptDraftEvent(e);
+        return getNewConceptVersion(e);
       } else if (event === "update_concept_draft") {
         return getUpdateConceptEvent(
           e,
@@ -264,8 +265,10 @@ const getParsedEvents = createSelector(
           { isDraft: false });
       } else if (event === "delete_concept_draft") {
         return getDeleteConceptDraftEvent(e);
+      } else if (event === "new_published_version") {
+        return getNewConceptVersion(e);
       } else if (event === "new_concept_draft") {
-        return getNewConceptDraftEvent(e);
+        return getNewConceptVersion(e);
       } else if (
         event === "add_resource_field" ||
         event === "delete_resource_field"