@truedat/bg 7.5.9 → 7.5.10

package/src/concepts/components/__tests__/ConceptHeader.spec.js

@@ -1,6 +1,5 @@
-import React from "react";
-import { render } from "@truedat/test/render";
 import userEvent from "@testing-library/user-event";
+import { render } from "@truedat/test/render";
 import ConceptHeader from "../ConceptHeader";
 
 const template = {
@@ -21,8 +20,8 @@ const contentEn = {
 };
 
 const concept = {
-  id: 1,
-  business_concept_id: 1,
+  id: "1",
+  business_concept_id: "1",
   name: "Concept_en",
   type: "type",
   version: 1,
@@ -52,8 +51,8 @@ const props = {
   selectedLang: "en",
   setSelectedLang: jest.fn(),
   i18nConcept: {
-    en: { id: 1, lang: "en", name: "Concept_en", content: contentEn },
-    es: { id: 2, lang: "es", name: "Concept_es", content: contentEs },
+    en: { id: "1", lang: "en", name: "Concept_en", content: contentEn },
+    es: { id: "2", lang: "es", name: "Concept_es", content: contentEs },
   },
 };
 
@@ -70,12 +69,6 @@ const share = {
 };
 
 const renderOpts = {
-  messages: {
-    en: {
-      "i18n.messages.lang.es": "Es",
-      "i18n.messages.lang.en": "En",
-    },
-  },
   state: {
     concept,
     conceptPermissions: { share },
@@ -89,12 +82,9 @@ describe("<ConceptHeader />", () => {
       ...props,
       setConfidentialConcept: setConfidentialConcept,
     };
-    const { container } = render(
-      <ConceptHeader {...customProps} />,
-      renderOpts
-    );
+    const rendered = render(<ConceptHeader {...customProps} />, renderOpts);
 
-    expect(container).toMatchSnapshot();
+    expect(rendered.container).toMatchSnapshot();
   });
 
   it("does not render ConceptConfidentialButton if no permission for managing confidential concepts", () => {
@@ -107,11 +97,8 @@ describe("<ConceptHeader />", () => {
       },
     };
 
-    const { queryByText } = render(
-      <ConceptHeader {...props} />,
-      customRenderOpts
-    );
-    expect(queryByText("ConceptConfidentialButton")).toBeNull();
+    const rendered = render(<ConceptHeader {...props} />, customRenderOpts);
+    expect(rendered.queryByText("ConceptConfidentialButton")).toBeNull();
   });
 
   it("does not render SharedToDomainsPopup if no permission for updating concepts", () => {
@@ -124,22 +111,17 @@ describe("<ConceptHeader />", () => {
       },
     };
 
-    const { queryByText } = render(
-      <ConceptHeader {...props} />,
-      customRenderOpts
-    );
-    expect(queryByText("SharedToDomainsPopup")).toBeNull();
+    const rendered = render(<ConceptHeader {...props} />, customRenderOpts);
+    expect(rendered.queryByText("SharedToDomainsPopup")).toBeNull();
   });
 
   it("change languaje when click on button", async () => {
-    const { getByText, queryByText } = render(
-      <ConceptHeader {...props} />,
-      renderOpts
-    );
-    expect(queryByText("Concept_en")).toBeInTheDocument();
-    const button = getByText("Es");
+    const rendered = render(<ConceptHeader {...props} />, renderOpts);
+    expect(rendered.queryByText("Concept_en")).toBeInTheDocument();
+    const user = userEvent.setup({ delay: null });
+    const button = rendered.getByText("i18n.messages.lang.es");
 
-    userEvent.click(button);
+    await user.click(button);
 
     expect(props.setSelectedLang).toHaveBeenCalledWith("es");
   });
@@ -154,42 +136,39 @@ describe("<ConceptHeader />", () => {
       },
     };
 
-    const { queryByText } = render(
-      <ConceptHeader {...props} />,
-      customRenderOpts
-    );
-    expect(queryByText("En")).toBeNull();
+    const rendered = render(<ConceptHeader {...props} />, customRenderOpts);
+    expect(
+      rendered.queryByText("i18n.messages.lang.en")
+    ).not.toBeInTheDocument();
   });
 
   it("does not render lang buttons if concept has only one language", () => {
     const customProps = {
       ...props,
       i18nConcept: {
-        en: { id: 1, lang: "en", name: "Concept_en", content: contentEn },
+        en: { id: "1", lang: "en", name: "Concept_en", content: contentEn },
       },
     };
 
-    const { queryByText } = render(
-      <ConceptHeader {...customProps} />,
-      renderOpts
-    );
-    expect(queryByText("En")).toBeNull();
+    const rendered = render(<ConceptHeader {...customProps} />, renderOpts);
+    expect(
+      rendered.queryByText("i18n.messages.lang.en")
+    ).not.toBeInTheDocument();
   });
 
   it("does not render lang buttons if i18nConcept has no content", () => {
     const customProps = {
       ...props,
       i18nConcept: {
-        en: { id: 1, lang: "en", name: "Concept_en", content: {} },
-        es: { id: 2, lang: "es", name: "Concept_es", content: {} },
+        en: { id: "1", lang: "en", name: "Concept_en", content: {} },
+        es: { id: "2", lang: "es", name: "Concept_es", content: {} },
       },
     };
 
-    const { queryByText } = render(
-      <ConceptHeader {...customProps} />,
-      renderOpts
-    );
-    expect(queryByText("En")).toBeNull();
+    const rendered = render(<ConceptHeader {...customProps} />, renderOpts);
+    expect(
+      rendered.queryByText("i18n.messages.lang.en")
+    ).not.toBeInTheDocument();
   });
 
   it("set content name when i18ncontent is undefined", () => {
@@ -200,10 +179,7 @@ describe("<ConceptHeader />", () => {
       },
     };
 
-    const { queryByText } = render(
-      <ConceptHeader {...props} />,
-      customRenderOpts
-    );
-    expect(queryByText("Concept_en")).toBeInTheDocument();
+    const rendered = render(<ConceptHeader {...props} />, customRenderOpts);
+    expect(rendered.queryByText("Concept_en")).toBeInTheDocument();
   });
 });

package/src/concepts/components/__tests__/ConceptLinksManagement.spec.js

@@ -1,9 +1,7 @@
-import React, { Suspense } from "react";
-import { render } from "@truedat/test/render";
-import { waitFor } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
+import { waitFor } from "@testing-library/react";
+import { render, waitForLoad } from "@truedat/test/render";
 import ConceptsLinksManagement from "../ConceptsLinksManagement";
-import en from "../../../messages/en";
 
 const data = {
   data: [
@@ -32,7 +30,15 @@ const filterData = {
     },
   },
 };
-
+jest.mock("@truedat/dd/hooks/useStructures", () => ({
+  ...jest.requireActual("@truedat/dd/hooks/useStructures"),
+  useDataStructureSearch: () => ({
+    trigger: () => ({ then: (callback) => callback({ data: {} }) }),
+  }),
+  useDataStructureFilters: () => ({
+    trigger: () => ({ then: (callback) => callback({ data: {} }) }),
+  }),
+}));
 jest.mock("@truedat/bg/concepts/hooks/useConcepts", () => {
   const originalModule = jest.requireActual(
     "@truedat/bg/concepts/hooks/useConcepts"
@@ -60,18 +66,7 @@ jest.mock("@truedat/bg/concepts/hooks/useConcepts", () => {
     }),
   };
 });
-
-const messages = {
-  en: {
-    ...en,
-    "concepts.status.undefined": "undefined",
-    "search.save_filters": "save filters",
-    "search.clear_filters": "clear filters",
-    "search.applied_filters": "apply filters",
-    "structures.not_found.body": "",
-    "search.placeholder": "Search concepts...",
-  },
-};
+jest.mock("@truedat/core/hooks/useUserFilters");
 
 const link = {
   id: 745,
@@ -98,7 +93,6 @@ const props = {
 
 describe("<ConceptsLinksManagement />", () => {
   const renderOpts = {
-    messages,
     state: {
       loading: false,
       links: [link],
@@ -109,27 +103,26 @@ describe("<ConceptsLinksManagement />", () => {
   };
 
   it("matches the latest snapshot", async () => {
-    const { container, findByText } = render(
-      <ConceptsLinksManagement {...props} />,
-      renderOpts
-    );
-    userEvent.click(await findByText(/some/));
+    const rendered = render(<ConceptsLinksManagement {...props} />, renderOpts);
+    await waitForLoad(rendered);
+    const user = userEvent.setup({ delay: null });
+    await user.click(rendered.getByText(/some/i));
     await waitFor(() => {
-      expect(container.querySelector(".loading")).toBeNull();
+      expect(rendered.container.querySelector(".loading")).toBeNull();
     });
-    await findByText(/18/);
-    expect(container).toMatchSnapshot();
+    await rendered.findByText(/18/i);
+    expect(rendered.container).toMatchSnapshot();
   });
 
   it("select a concept and shows LinkedMessage and structure search table", async () => {
-    const { findByText, queryByText } = render(
-      <Suspense fallback={null}>
-        <ConceptsLinksManagement {...props} />
-      </Suspense>,
-      renderOpts
-    );
+    const rendered = render(<ConceptsLinksManagement {...props} />, renderOpts);
+    await waitForLoad(rendered);
 
-    userEvent.click(await findByText(/foo/));
-    expect(queryByText("Adding a link to a structure")).toBeInTheDocument();
+    const user = userEvent.setup({ delay: null });
+    await user.click(rendered.getByText(/foo/i));
+    await waitForLoad(rendered);
+    expect(
+      rendered.getByText(/concept.events.relation_creating/i)
+    ).toBeInTheDocument();
   });
 });

package/src/concepts/components/__tests__/ConceptLoader.spec.js

@@ -1,52 +1,66 @@
-import React from "react";
-import { shallow, mount } from "enzyme";
+import { render, waitForLoad } from "@truedat/test/render";
 import { ConceptLoader } from "../ConceptLoader";
 
-jest.mock("react-router-dom", () => ({
-  ...jest.requireActual("react-router-dom"),
-  useParams: () => ({ id: 1 })
+jest.mock("react-router", () => ({
+  ...jest.requireActual("react-router"),
+  useParams: () => ({ id: 1 }),
 }));
 
 describe("<ConceptLoader />", () => {
-  const loading = false;
-  const fetchConcept = jest.fn();
-  const clearConcept = jest.fn();
-
-  it("matches the latest snapshot", () => {
-    const loading = true;
-    const props = { clearConcept, fetchConcept, loading };
-    const wrapper = shallow(<ConceptLoader {...props} />);
-    expect(wrapper).toMatchSnapshot();
+  it("matches the latest snapshot", async () => {
+    const props = {
+      clearConcept: jest.fn(),
+      fetchConcept: jest.fn(),
+      loading: true,
+    };
+    const rendered = render(<ConceptLoader {...props} />);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("renders a dimmer if loading is true", () => {
-    const loading = true;
-    const props = { clearConcept, fetchConcept, loading };
-    const wrapper = shallow(<ConceptLoader {...props} />);
-    expect(wrapper.find("Dimmer").length).toBe(1);
+  it("renders a dimmer if loading is true", async () => {
+    const props = {
+      clearConcept: jest.fn(),
+      fetchConcept: jest.fn(),
+      loading: true,
+    };
+    const rendered = render(<ConceptLoader {...props} />);
+    expect(rendered.container.querySelector(".dimmer")).toBeInTheDocument();
   });
 
-  it("renders null if loading is false", () => {
-    const props = { clearConcept, fetchConcept, loading };
-    const wrapper = shallow(<ConceptLoader {...props} />);
-    expect(wrapper.getElement()).toBeNull();
+  it("renders null if loading is false", async () => {
+    const props = {
+      clearConcept: jest.fn(),
+      fetchConcept: jest.fn(),
+      loading: false,
+    };
+    const rendered = render(<ConceptLoader {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container.firstChild).toBeNull();
   });
 
-  it("calls fetchConcept when component mounts but not when it unmounts", () => {
-    const fetchConcept = jest.fn();
-    const props = { clearConcept, fetchConcept, loading };
-    const wrapper = mount(<ConceptLoader {...props} />);
-    expect(fetchConcept.mock.calls.length).toBe(1);
-    wrapper.unmount();
-    expect(fetchConcept.mock.calls.length).toBe(1);
+  it("calls fetchConcept when component mounts but not when it unmounts", async () => {
+    const props = {
+      clearConcept: jest.fn(),
+      fetchConcept: jest.fn(),
+      loading: false,
+    };
+    const rendered = render(<ConceptLoader {...props} />);
+    await waitForLoad(rendered);
+    expect(props.fetchConcept).toHaveBeenCalledTimes(1);
+    rendered.unmount();
+    expect(props.fetchConcept).toHaveBeenCalledTimes(1);
   });
 
-  it("calls clearConcept when component unmounts but not when it mounts", () => {
-    const clearConcept = jest.fn();
-    const props = { clearConcept, fetchConcept, loading };
-    const wrapper = mount(<ConceptLoader {...props} />);
-    expect(clearConcept.mock.calls.length).toBe(0);
-    wrapper.unmount();
-    expect(clearConcept.mock.calls.length).toBe(1);
+  it("calls clearConcept when component unmounts but not when it mounts", async () => {
+    const props = {
+      clearConcept: jest.fn(),
+      fetchConcept: jest.fn(),
+      loading: false,
+    };
+    const rendered = render(<ConceptLoader {...props} />);
+    await waitForLoad(rendered);
+    expect(props.clearConcept).toHaveBeenCalledTimes(0);
+    rendered.unmount();
+    expect(props.clearConcept).toHaveBeenCalledTimes(1);
   });
 });

package/src/concepts/components/__tests__/ConceptManageDomain.spec.js

@@ -1,11 +1,8 @@
-import React from "react";
-import { waitFor } from "@testing-library/react";
-import { render } from "@truedat/test/render";
-import { DOMAINS_QUERY } from "@truedat/core/api/queries";
+import { render, waitForLoad } from "@truedat/test/render";
+import { domainsMock } from "@truedat/test/mocks";
 import { ConceptManageDomain } from "../ConceptManageDomain";
 
 describe("<ConceptManageDomain />", () => {
-  // const id = 5;
   const domainOptions = [
     { id: 1, name: "foo", level: 0 },
     { id: 2, name: "bar", level: 0 },
@@ -19,50 +16,18 @@ describe("<ConceptManageDomain />", () => {
     setToDomain,
   };
 
-  const domains = [
-    {
-      id: 1,
-      name: "foo",
-      parentId: 6,
-      actions: [],
-      externalId: "external_foo",
-    },
-  ];
-  const variables = {
-    action: "manageConcept",
-  };
-
-  const domainsMock = {
-    request: { query: DOMAINS_QUERY, variables },
-    result: { data: { domains: domains } },
-  };
-
   const renderOpts = {
-    mocks: [domainsMock],
-    messages: {
-      en: {
-        "concept.changeDomain.header": "edit domain",
-        "concept.changeDomain.label": "domain",
-        "conceptDomain.actions.update": "update",
-        "domain.selector.label": "domain",
-        "domain.selector.placeholder": "select a domain...",
-      },
-    },
-    fallback: "lazy",
+    mocks: [
+      domainsMock({
+        action: "manageConcept",
+        domainActions: undefined,
+        ids: undefined,
+      }),
+    ],
   };
-
   it("matches the latest snapshot", async () => {
-    const { container, queryByText } = render(
-      <ConceptManageDomain {...props} />,
-      renderOpts
-    );
-    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
-    await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
-
-    await waitFor(() => {
-      expect(container).toMatchSnapshot();
-    });
+    const rendered = render(<ConceptManageDomain {...props} />, renderOpts);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 });

package/src/concepts/components/__tests__/ConceptManageDomainPopup.spec.js

@@ -1,36 +1,77 @@
-import React from "react";
-import { mount } from "enzyme";
-import { intl } from "@truedat/test/intl-stub";
+import userEvent from "@testing-library/user-event";
+import { waitFor } from "@testing-library/react";
+import { render, waitForLoad } from "@truedat/test/render";
+import { domainsMock } from "@truedat/test/mocks";
 import { ConceptManageDomainPopup } from "../ConceptManageDomainPopup";
 
-// workaround for enzyme issue with React.useContext
-// see https://github.com/airbnb/enzyme/issues/2176#issuecomment-532361526
-jest.spyOn(React, "useContext").mockImplementation(() => intl);
-jest.mock("../ConceptManageDomain");
-
 describe("<ConceptManageDomainPopup />", () => {
   const props = {
     saving: false,
     update_domain: true,
   };
 
-  it("matches the latest snapshot", () => {
-    const wrapper = mount(<ConceptManageDomainPopup {...props} />);
-    expect(wrapper).toMatchSnapshot();
+  const renderOpts = {
+    mocks: [
+      domainsMock({
+        action: "manageConcept",
+        domainActions: undefined,
+        ids: undefined,
+      }),
+    ],
+  };
+
+  it("matches the latest snapshot", async () => {
+    const rendered = render(
+      <ConceptManageDomainPopup {...props} />,
+      renderOpts
+    );
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("manages open and close popup", () => {
-    const wrapper = mount(<ConceptManageDomainPopup {...props} />);
-    wrapper.setProps({ saving: true, update_domain: true });
-    expect(wrapper.find("Popup").prop("open")).toBeFalsy();
-    wrapper.find("Popup").find("Portal").find("Button").simulate("click");
-    expect(wrapper.find("Popup").prop("open")).toBeTruthy();
-    wrapper.find("Popup").find("Portal").find("Button").simulate("click");
-    expect(wrapper.find("Popup").prop("open")).toBeFalsy();
-    wrapper.find("Popup").find("Portal").find("Button").simulate("click");
-    expect(wrapper.find("Popup").prop("open")).toBeTruthy();
-    wrapper.setProps({ saving: false, update_domain: true });
-    wrapper.update();
-    expect(wrapper.find("Popup").prop("open")).toBeFalsy();
+  it("manages open and close popup", async () => {
+    const user = userEvent.setup({ delay: null });
+    const rendered = render(
+      <ConceptManageDomainPopup {...props} />,
+      renderOpts
+    );
+    await waitForLoad(rendered);
+
+    const triggerButton = rendered.getByRole("button");
+    // Initial state - popup should be closed
+    expect(
+      rendered.queryByText(/concept.changedomain.header/i)
+    ).not.toBeInTheDocument();
+
+    // Open popup
+    await user.click(triggerButton);
+    await waitFor(() =>
+      expect(
+        rendered.getByText(/concept.changedomain.header/i)
+      ).toBeInTheDocument()
+    );
+
+    // Close popup
+    await user.click(triggerButton);
+    await waitFor(() =>
+      expect(
+        rendered.queryByText(/concept.changedomain.header/i)
+      ).not.toBeInTheDocument()
+    );
+
+    // Open popup again
+    await user.click(triggerButton);
+    await waitFor(() =>
+      expect(
+        rendered.getByText(/concept.changedomain.header/i)
+      ).toBeInTheDocument()
+    );
+
+    // Popup should close when saving is complete
+    rendered.rerender(<ConceptManageDomainPopup {...props} saving={true} />);
+    rendered.rerender(<ConceptManageDomainPopup {...props} saving={false} />);
+    await waitFor(() =>
+      expect(rendered.queryByRole("dialog")).not.toBeInTheDocument()
+    );
   });
 });

package/src/concepts/components/__tests__/ConceptRow.spec.js

@@ -1,22 +1,13 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { ConceptRow } from "../ConceptRow";
 import { getConceptColumns } from "../../selectors";
 
-const renderOpts = {
-  messages: {
-    en: {
-      "concepts.status.draft": "draft",
-    },
-  },
-};
-
 describe("<ConceptRow />", () => {
   it("matches the latest snapshot", () => {
     const columns = getConceptColumns({ conceptColumns: null }).concepts;
     const concept = {
-      business_concept_id: 12,
-      id: 42,
+      business_concept_id: "12",
+      id: "42",
       name: "foo",
       status: "draft",
       bcv_last_change_at: "2018-06-27T07:32:53.154377Z",
@@ -27,8 +18,7 @@ describe("<ConceptRow />", () => {
         <tbody>
           <ConceptRow {...props} />
         </tbody>
-      </table>,
-      renderOpts
+      </table>
     );
     expect(container).toMatchSnapshot();
   });
@@ -36,8 +26,8 @@ describe("<ConceptRow />", () => {
   it("renders concept name as link", () => {
     const columns = getConceptColumns({ conceptColumns: null }).concepts;
     const concept = {
-      business_concept_id: 12,
-      id: 42,
+      business_concept_id: "12",
+      id: "42",
       name: "foo",
       status: "draft",
       bcv_last_change_at: "2018-06-27T07:32:53.154377Z",
@@ -48,8 +38,7 @@ describe("<ConceptRow />", () => {
         <tbody>
           <ConceptRow {...props} />
         </tbody>
-      </table>,
-      renderOpts
+      </table>
     );
 
     const link = wrapper.getByText("foo");

package/src/concepts/components/__tests__/ConceptSubscription.spec.js

@@ -1,5 +1,4 @@
-import React from "react";
-import { shallow } from "enzyme";
+import { render, waitForLoad } from "@truedat/test/render";
 import { ConceptSubscription } from "../ConceptSubscription";
 
 describe("<ConceptSubscription />", () => {
@@ -10,24 +9,25 @@ describe("<ConceptSubscription />", () => {
     scope: {
       events: ["new_concept_draft"],
       resource_id: 1,
-      resource_type: "concept"
+      resource_type: "concept",
     },
     subscriber: {
       id: 3,
       identifier: "2",
-      type: "user"
-    }
+      type: "user",
+    },
   };
   const subscriptionUpdating = false;
 
   const props = {
     concept,
     searchSubscription,
-    subscriptionUpdating
+    subscriptionUpdating,
   };
 
-  it("matches the latest snapshot", () => {
-    const wrapper = shallow(<ConceptSubscription {...props} />);
-    expect(wrapper).toMatchSnapshot();
+  it("matches the latest snapshot", async () => {
+    const rendered = render(<ConceptSubscription {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 });