@truedat/bg 7.5.8 → 7.5.10

package/src/concepts/components/__tests__/ConceptSubscriptionLoader.spec.js

@@ -1,32 +1,36 @@
-import React from "react";
-import { shallow, mount } from "enzyme";
+import { render, waitForLoad } from "@truedat/test/render";
 import { ConceptSubscriptionLoader } from "../ConceptSubscriptionLoader";
 
-jest.mock("react-router-dom", () => ({
-  ...jest.requireActual("react-router-dom"),
-  useParams: () => ({ id: 1 })
+jest.mock("react-router", () => ({
+  ...jest.requireActual("react-router"),
+  useParams: () => ({ id: 1 }),
 }));
 
 describe("<ConceptSubscriptionLoader />", () => {
   const searchSubscriptions = jest.fn();
   const clearSubscriptionsSearch = jest.fn();
 
-  it("matches the latest snapshot", () => {
-    const props = { clearSubscriptionsSearch, searchSubscriptions };
-    const wrapper = shallow(<ConceptSubscriptionLoader {...props} />);
-    expect(wrapper).toMatchSnapshot();
+  const props = { clearSubscriptionsSearch, searchSubscriptions };
+
+  it("matches the latest snapshot", async () => {
+    const rendered = render(<ConceptSubscriptionLoader {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("calls searchSubscriptions when component mounts, clearSubscriptionsSearch when component unmounts", () => {
+  it("calls searchSubscriptions when component mounts, clearSubscriptionsSearch when component unmounts", async () => {
     const searchSubscriptions = jest.fn();
     const clearSubscriptionsSearch = jest.fn();
 
     const props = { searchSubscriptions, clearSubscriptionsSearch };
-    const wrapper = mount(<ConceptSubscriptionLoader {...props} />);
-    expect(clearSubscriptionsSearch.mock.calls.length).toBe(0);
-    expect(searchSubscriptions.mock.calls.length).toBe(1);
-    wrapper.unmount();
-    expect(clearSubscriptionsSearch.mock.calls.length).toBe(1);
-    expect(searchSubscriptions.mock.calls.length).toBe(1);
+    const rendered = render(<ConceptSubscriptionLoader {...props} />);
+    await waitForLoad(rendered);
+
+    expect(clearSubscriptionsSearch).not.toHaveBeenCalled();
+    expect(searchSubscriptions).toHaveBeenCalledTimes(1);
+
+    rendered.unmount();
+    expect(clearSubscriptionsSearch).toHaveBeenCalledTimes(1);
+    expect(searchSubscriptions).toHaveBeenCalledTimes(1);
   });
 });

package/src/concepts/components/__tests__/ConceptSummary.spec.js

@@ -1,5 +1,4 @@
-import React from "react";
-import { render } from "@truedat/test/render";
+import { render, waitForLoad } from "@truedat/test/render";
 import { ConceptSummary } from "../ConceptSummary";
 
 const concept = {
@@ -17,21 +16,23 @@ const concept = {
 const props = { concept };
 
 describe("<ConceptSummary />", () => {
-  it("matches the latest snapshot", () => {
-    const { container } = render(<ConceptSummary {...props} />);
-    expect(container).toMatchSnapshot();
+  it("matches the latest snapshot", async () => {
+    const rendered = render(<ConceptSummary {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("show correct change and user for versioned", () => {
+  it("show correct change and user for versioned", async () => {
     const newProps = {
       concept: {
         ...concept,
         status: "versioned",
       },
     };
-    const { queryByText } = render(<ConceptSummary {...newProps} />);
-    expect(queryByText(/Versioned/)).toBeInTheDocument();
-    expect(queryByText(/foo/)).toBeInTheDocument();
-    expect(queryByText(/2024-01-01/)).toBeInTheDocument();
+    const rendered = render(<ConceptSummary {...newProps} />);
+    await waitForLoad(rendered);
+    expect(rendered.getByText(/versioned/i)).toBeInTheDocument();
+    expect(rendered.getByText(/foo/i)).toBeInTheDocument();
+    expect(rendered.getByText(/2024-01-01/i)).toBeInTheDocument();
   });
 });

package/src/concepts/components/__tests__/ConceptTabPane.spec.js

@@ -1,10 +1,78 @@
 import React from "react";
-import { shallow } from "enzyme";
-import { ConceptTabPane } from "../ConceptTabPane";
+import { render, waitForLoad } from "@truedat/test/render";
+import ConceptTabPane from "../ConceptTabPane";
+import {
+  CONCEPT_VERSION,
+  CONCEPT_ARCHIVE,
+  CONCEPT_EVENTS,
+  CONCEPT_RULES,
+  CONCEPT_RULES_NEW,
+} from "@truedat/core/routes";
+
+// Mock child components
+jest.mock("../ConceptDetails", () => () => <div>ConceptDetails</div>);
+jest.mock("../ConceptArchive", () => () => <div>ConceptArchive</div>);
+jest.mock("../Events", () => () => <div>Events</div>);
+jest.mock("../../relations/components/ConceptRelationsRoutes", () => () => (
+  <div>ConceptRelationsRoutes</div>
+));
+jest.mock("@truedat/dq/components/ConceptRules", () => () => (
+  <div>ConceptRules</div>
+));
+jest.mock("@truedat/dq/components/NewRule", () => () => <div>NewRule</div>);
 
 describe("<ConceptTabPane />", () => {
-  it("matches the latest snapshot", () => {
-    const wrapper = shallow(<ConceptTabPane />);
-    expect(wrapper).toMatchSnapshot();
+  it("renders correctly with default route", async () => {
+    const rendered = render(<ConceptTabPane />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
+  });
+
+  it("renders correctly with concept version route", async () => {
+    const rendered = render(<ConceptTabPane />, {
+      routes: [CONCEPT_VERSION],
+    });
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
+  });
+
+  it("renders correctly with archive route", async () => {
+    const rendered = render(<ConceptTabPane />, {
+      routes: [CONCEPT_ARCHIVE],
+    });
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
+  });
+
+  it("renders correctly with events route", async () => {
+    const rendered = render(<ConceptTabPane />, {
+      routes: [CONCEPT_EVENTS],
+    });
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
+  });
+
+  it("renders correctly with links route", async () => {
+    const rendered = render(<ConceptTabPane />, {
+      routes: [`${CONCEPT_VERSION}/links`],
+    });
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
+  });
+
+  it("renders correctly with rules route", async () => {
+    const rendered = render(<ConceptTabPane />, {
+      routes: [CONCEPT_RULES],
+    });
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
+  });
+
+  it("renders correctly with new rule route", async () => {
+    const rendered = render(<ConceptTabPane />, {
+      routes: [CONCEPT_RULES_NEW],
+    });
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 });

package/src/concepts/components/__tests__/ConceptTabs.spec.js

@@ -1,40 +1,25 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { ConceptTabs } from "../ConceptTabs";
 
 describe("<ConceptTabs />", () => {
-  const renderOpts = {
-    messages: {
-      en: {
-        "tabs.bg.concept": "concept",
-        "tabs.bg.relations_data_field": "relations_data_field",
-        "tabs.bg.relations_business_concept": "relations_business_concept",
-        "tabs.bg.qualityRules": "qualityRules",
-        "tabs.bg.qualityImplementations": "qualityImplementations",
-        "tabs.bg.history": "history",
-        "tabs.bg.audit": "audit",
-      },
-    },
-  };
-
   const props = {
     concept: {
-      id: 1,
-      business_concept_id: 8,
+      id: "1",
+      business_concept_id: "8",
     },
     emptyConceptTags: false,
     emptyImplementationLinks: false,
   };
   it("matches the latest snapshot", () => {
-    const { container } = render(<ConceptTabs {...props} />, renderOpts);
+    const { container } = render(<ConceptTabs {...props} />);
     expect(container).toMatchSnapshot();
   });
 
   it("With concept tags and implementation links", () => {
     const props = {
       concept: {
-        id: 1,
-        business_concept_id: 8,
+        id: "1",
+        business_concept_id: "8",
       },
       emptyConceptTags: true,
       emptyImplementationLinks: true,
@@ -42,7 +27,7 @@ describe("<ConceptTabs />", () => {
       createLinkImplementation: { method: "POST" },
       createImplementation: { method: "POST" },
     };
-    const { container } = render(<ConceptTabs {...props} />, renderOpts);
+    const { container } = render(<ConceptTabs {...props} />);
     expect(container).toMatchSnapshot();
   });
 });

package/src/concepts/components/__tests__/ConceptTaxonomy.spec.js

@@ -1,28 +1,32 @@
-import React from "react";
-import { shallow } from "enzyme";
+import { render, waitForLoad } from "@truedat/test/render";
 import { ConceptTaxonomy } from "../ConceptTaxonomy";
 
 describe("<ConceptTaxonomy />", () => {
   const domainPath = [
     { id: 0, name: "name0", external_id: "eid0" },
     { id: 1, name: "name1", external_id: "eid1" },
-    { id: 2, name: "name2", external_id: "eid2" }
+    { id: 2, name: "name2", external_id: "eid2" },
   ];
-  it("matches the latest snapshot", () => {
+
+  it("matches the latest snapshot", async () => {
     const props = { domainPath };
-    const wrapper = shallow(<ConceptTaxonomy {...props} />);
-    expect(wrapper).toMatchSnapshot();
+    const rendered = render(<ConceptTaxonomy {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("doest not render component when not domainPath provided", () => {
+  it("does not render component when no domainPath provided", async () => {
     const props = { domainPath: [] };
-    const wrapper = shallow(<ConceptTaxonomy {...props} />);
-    expect(wrapper.find("Segment").exists()).toBeFalsy();
+    const rendered = render(<ConceptTaxonomy {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container.querySelector("Segment")).not.toBeInTheDocument();
   });
 
-  it("renders as many items as domains", () => {
+  it("renders as many items as domains", async () => {
     const props = { domainPath };
-    const wrapper = shallow(<ConceptTaxonomy {...props} />);
-    expect(wrapper.find("DomainItem").length).toBe(3);
+    const rendered = render(<ConceptTaxonomy {...props} />);
+    await waitForLoad(rendered);
+
+    expect(rendered.container.querySelectorAll(".highlighted").length).toBe(3);
   });
 });

package/src/concepts/components/__tests__/Concepts.spec.js

@@ -1,5 +1,4 @@
-import React from "react";
-import { render } from "@truedat/test/render";
+import { render, waitForLoad } from "@truedat/test/render";
 import { waitFor } from "@testing-library/react";
 import { Concepts } from "../Concepts";
 import { defaultConceptColumns } from "../../selectors";
@@ -45,20 +44,7 @@ jest.mock("@truedat/bg/concepts/hooks/useConcepts", () => {
     }),
   };
 });
-
-const messages = {
-  en: {
-    "search.placeholder": "Search concepts...",
-    "concepts.searching": "Searching...",
-    "concepts.search.results.empty": "No concepts found",
-    "concepts.retrieved.results": "{count} concepts found",
-    "concepts.props.last_change_at": "Last modification date",
-    "concepts.props.link_count": "Link to field",
-    "concepts.props.rule_count": "Quality rules",
-    "concepts.props.domain": "Domain",
-    "concepts.props.name": "Term",
-  },
-};
+jest.mock("@truedat/core/hooks/useUserFilters");
 
 const state = {
   conceptsColumns: {
@@ -69,7 +55,6 @@ const state = {
 describe("<Concepts />", () => {
   it("matches the latest snapshot", async () => {
     const renderOpts = {
-      messages,
       state,
     };
 
@@ -87,15 +72,10 @@ describe("<Concepts />", () => {
       update,
       create,
     };
-    const { container, findByText } = render(
-      <Concepts {...props} />,
-      renderOpts
-    );
-    await waitFor(() => {
-      expect(container.querySelector(".loading")).toBeNull();
-    });
+    const rendered = render(<Concepts {...props} />, renderOpts);
+    await waitForLoad(rendered);
 
-    await findByText(/7/);
-    expect(container).toMatchSnapshot();
+    await rendered.findByText(/7/i);
+    expect(rendered.container).toMatchSnapshot();
   });
 });

package/src/concepts/components/__tests__/ConceptsActions.spec.js

@@ -1,4 +1,3 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { SearchContextProvider } from "@truedat/core/search/SearchContext";
 import { ConceptsActions } from "../ConceptsActions";

package/src/concepts/components/__tests__/ConceptsBulkUpdate.spec.js

@@ -1,13 +1,12 @@
-import React from "react";
-import { waitFor } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
-import { render } from "@truedat/test/render";
+import { waitFor } from "@testing-library/react";
+import { render, waitForLoad } from "@truedat/test/render";
 import { domainsMock, templateByNameMock } from "@truedat/test/mocks";
 import { bulkUpdate } from "../../routines";
 import ConceptsBulkUpdate from "../ConceptsBulkUpdate";
 
-jest.mock("react-router-dom", () => ({
-  ...jest.requireActual("react-router-dom"),
+jest.mock("react-router", () => ({
+  ...jest.requireActual("react-router"),
   useLocation: () => ({ search: "?concepts" }),
 }));
 
@@ -38,51 +37,47 @@ const renderOpts = {
     templateByNameMock({ name: "template1", domainIds: [1] }),
   ],
   state,
-  fallback: "lazy",
 };
 
 describe("<ConceptsBulkUpdate />", () => {
   it("matches the latest snapshot", async () => {
-    const { container, queryByText } = render(
-      <ConceptsBulkUpdate />,
-      renderOpts
-    );
-
-    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
-    await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
-
-    expect(container).toMatchSnapshot();
+    const rendered = render(<ConceptsBulkUpdate />, renderOpts);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
   it("DynamicForm rendered if template, template_id, selectedDomain informed", async () => {
+    const user = userEvent.setup({ delay: null });
     const props = { applyTemplate: jest.fn() };
-    const { findByText, queryByText } = render(
-      <ConceptsBulkUpdate {...props} />,
-      renderOpts
+    const rendered = render(<ConceptsBulkUpdate {...props} />, renderOpts);
+    await waitForLoad(rendered);
+
+    await user.click(rendered.getByText(/foodomain/i));
+    await waitFor(() =>
+      expect(rendered.queryByText(/field1/i)).toBeInTheDocument()
     );
-    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
-    userEvent.click(await findByText("fooDomain"));
-    await waitFor(() => expect(queryByText(/field1/)).toBeInTheDocument());
   });
 
   it("calls bulkUpdate on onClick", async () => {
+    const user = userEvent.setup({ delay: null });
     const dispatch = jest.fn();
-    const { findByText, queryByText, findByPlaceholderText } = render(
-      <ConceptsBulkUpdate />,
-      {
-        ...renderOpts,
-        dispatch,
-      }
+    const rendered = render(<ConceptsBulkUpdate />, {
+      ...renderOpts,
+      dispatch,
+    });
+    await waitForLoad(rendered);
+
+    await user.click(rendered.getByText(/foodomain/i));
+    await waitFor(() =>
+      expect(rendered.queryByText(/field1/i)).toBeInTheDocument()
     );
-    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
-    userEvent.click(await findByText("fooDomain"));
-    await waitFor(() => expect(queryByText(/field1/)).toBeInTheDocument());
-    userEvent.type(await findByPlaceholderText("field1"), "abc123456");
-    await waitFor(() => expect(queryByText(/Save/)).toBeEnabled());
-    userEvent.click(await findByText("Save"));
-    userEvent.click(await findByText("Yes"));
+
+    await user.type(rendered.getByPlaceholderText(/field1/i), "abc123456");
+    await waitFor(() => expect(rendered.queryByText(/save/i)).toBeEnabled());
+
+    await user.click(rendered.getByText(/save/i));
+    await user.click(rendered.getByText(/yes/i));
+
     await waitFor(() => {
       expect(dispatch).toHaveBeenLastCalledWith(
         bulkUpdate({

package/src/concepts/components/__tests__/ConceptsLabelResults.spec.js

@@ -1,5 +1,4 @@
-import React from "react";
-import { render } from "@truedat/test/render";
+import { render, waitForLoad } from "@truedat/test/render";
 import { SearchContextProvider } from "@truedat/core/search/SearchContext";
 import ConceptsLabelResults from "../ConceptsLabelResults";
 
@@ -32,12 +31,12 @@ const searchProps = {
 
 describe("<ConceptsLabelResults />", () => {
   it("matches the latest snapshot", async () => {
-    const { container, findByText } = render(
+    const rendered = render(
       <SearchContextProvider {...searchProps} defaultFilters={defaultFilters}>
         <ConceptsLabelResults />
       </SearchContextProvider>
     );
-    await findByText(/22 concepts found/);
-    expect(container).toMatchSnapshot();
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 });

package/src/concepts/components/__tests__/ConceptsLinkDecorator.spec.js

@@ -1,12 +1,11 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { ConceptsLinkDecorator } from "../ConceptsLinkDecorator";
 
 describe("<ConceptsLinkDecorator />", () => {
   const concepts = [
-    { id: 1, name: "concept1" },
-    { id: 2, name: "concept2" },
-    { id: 3, name: "concept3" },
+    { id: "1", name: "concept1" },
+    { id: "2", name: "concept2" },
+    { id: "3", name: "concept3" },
   ];
   it("matches the latest snapshot", () => {
     const { container } = render(<>{ConceptsLinkDecorator(concepts)}</>);

package/src/concepts/components/__tests__/ConceptsPanel.spec.js

@@ -1,5 +1,4 @@
-import React from "react";
-import { render } from "@truedat/test/render";
+import { render, waitForLoad } from "@truedat/test/render";
 import { waitFor } from "@testing-library/react";
 import ConceptsPanel from "../ConceptsPanel";
 import { defaultConceptColumns } from "../../selectors";
@@ -44,20 +43,7 @@ jest.mock("@truedat/bg/concepts/hooks/useConcepts", () => {
     }),
   };
 });
-
-const messages = {
-  en: {
-    "search.placeholder": "Search concepts...",
-    "concepts.searching": "Searching...",
-    "concepts.search.results.empty": "No concepts found",
-    "concepts.retrieved.results": "{count} concepts found",
-    "concepts.props.last_change_at": "Last modification date",
-    "concepts.props.link_count": "Link to field",
-    "concepts.props.rule_count": "Quality rules",
-    "concepts.props.domain": "Domain",
-    "concepts.props.name": "Term",
-  },
-};
+jest.mock("@truedat/core/hooks/useUserFilters");
 
 const state = {
   conceptsColumns: {
@@ -66,7 +52,6 @@ const state = {
 };
 
 const renderOpts = {
-  messages,
   state,
 };
 
@@ -75,14 +60,10 @@ describe("<ConceptsPanel />", () => {
     defaultFilters: {},
   };
   it("matches latest snapshot", async () => {
-    const { container, findByText } = render(
-      <ConceptsPanel {...props} />,
-      renderOpts
-    );
-    await waitFor(() => {
-      expect(container.querySelector(".loading")).toBeNull();
-    });
-    await findByText(/7/);
-    expect(container).toMatchSnapshot();
+    const rendered = render(<ConceptsPanel {...props} />, renderOpts);
+    await waitForLoad(rendered);
+
+    await rendered.findByText(/7/i);
+    expect(rendered.container).toMatchSnapshot();
   });
 });