@truedat/bg 7.13.5 → 7.13.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/bg",
-  "version": "7.13.5",
+  "version": "7.13.7",
   "description": "Truedat Web Business Glossary",
   "sideEffects": false,
   "module": "src/index.js",
@@ -48,7 +48,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "7.13.5",
+    "@truedat/test": "7.13.7",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -81,5 +81,5 @@
     "semantic-ui-react": "^3.0.0-beta.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "a82fdfd07c75632206f6639dd7c3b3072a3a9379"
+  "gitHead": "7437522470d6e6eb11f9f5b472b822b23949cb74"
 }

package/src/concepts/components/ConceptTabs.js

@@ -5,6 +5,7 @@ import { Link } from "react-router";
 import { connect } from "react-redux";
 import { FormattedMessage } from "react-intl";
 import { useActiveRoute } from "@truedat/core/hooks";
+import { config } from "@truedat/core/truedatConfig";
 import {
   CONCEPT_ARCHIVE,
   CONCEPT_EVENTS,
@@ -22,7 +23,12 @@ export const ConceptTabs = ({
   emptyImplementationLinks,
   createImplementation,
   createRawImplementation,
+  manageQualityRule,
+  viewQualityRule,
+  isAdmin,
 }) => {
+  const enableQualityRules = config?.enableQualityRules !== false;
+
   const archiveActive = useActiveRoute(CONCEPT_ARCHIVE);
   const conceptActive = useActiveRoute({
     path: CONCEPT_VERSION,
@@ -32,6 +38,13 @@ export const ConceptTabs = ({
   const rulesActive = useActiveRoute(CONCEPT_RULES);
   const implementationsActive = useActiveRoute(CONCEPT_LINKS_IMPLEMENTATIONS);
   const structureLinksActive = useActiveRoute(CONCEPT_LINKS_STRUCTURES);
+  
+  console.clear();
+  console.log("enableQualityRules", enableQualityRules);
+  console.log("manageQualityRule", manageQualityRule);
+  console.log("viewQualityRule", viewQualityRule);
+  console.log("isAdmin", isAdmin);
+  console.log("rule_count", concept.rule_count);
 
   return _.isEmpty(concept) ? null : (
     <Menu attached="top" pointing secondary tabular>
@@ -61,14 +74,19 @@ export const ConceptTabs = ({
           <FormattedMessage id="tabs.bg.relations_business_concept" />
         </Menu.Item>
       )}
-      <Menu.Item
-        active={rulesActive}
-        as={Link}
-        to={linkTo.CONCEPT_RULES(concept)}
-        replace
-      >
-        <FormattedMessage id="tabs.bg.qualityRules" />
-      </Menu.Item>
+      {enableQualityRules &&
+        (isAdmin ||
+          manageQualityRule ||
+          (viewQualityRule && (concept?.rule_count ?? 0) > 0)) && (
+          <Menu.Item
+            active={rulesActive}
+            as={Link}
+            to={linkTo.CONCEPT_RULES(concept)}
+            replace
+          >
+            <FormattedMessage id="tabs.bg.qualityRules" />
+          </Menu.Item>
+        )}
       {(!emptyImplementationLinks ||
         createImplementation ||
         createRawImplementation) && (
@@ -107,6 +125,9 @@ ConceptTabs.propTypes = {
   emptyImplementationLinks: PropTypes.bool,
   createImplementation: PropTypes.object,
   createRawImplementation: PropTypes.object,
+  manageQualityRule: PropTypes.bool,
+  viewQualityRule: PropTypes.bool,
+  isAdmin: PropTypes.bool,
 };
 
 const mapStateToProps = ({
@@ -114,6 +135,7 @@ const mapStateToProps = ({
   conceptPermissions,
   conceptLinks,
   relationTags,
+  authentication,
 }) => ({
   emptyConceptTags: _.flow(
     _.filter(_.pathEq("value.target_type", "business_concept")),
@@ -128,6 +150,9 @@ const mapStateToProps = ({
   createRawImplementation: _.prop("create_raw_implementation")(
     conceptPermissions
   ),
+  manageQualityRule: _.prop("manage_quality_rule")(conceptPermissions),
+  viewQualityRule: _.prop("view_quality_rule")(conceptPermissions),
+  isAdmin: _.propEq("role", "admin")(authentication),
 });
 
 export default connect(mapStateToProps)(ConceptTabs);

package/src/concepts/components/__tests__/ConceptTabs.spec.js

@@ -1,33 +1,134 @@
-import { render } from "@truedat/test/render";
-import { ConceptTabs } from "../ConceptTabs";
+import { render, waitForLoad } from "@truedat/test/render";
+import ConceptTabs from "../ConceptTabs";
+import { setConfig } from "@truedat/core/truedatConfig";
 
 describe("<ConceptTabs />", () => {
-  const props = {
-    concept: {
-      id: "1",
-      business_concept_id: "8",
-    },
-    emptyConceptTags: false,
-    emptyImplementationLinks: false,
+  beforeEach(() => {
+    setConfig({ enableQualityRules: true });
+  });
+
+  afterEach(() => {
+    setConfig({});
+  });
+
+  const baseConcept = {
+    id: "1",
+    business_concept_id: "8",
   };
-  it("matches the latest snapshot", () => {
-    const { container } = render(<ConceptTabs {...props} />);
-    expect(container).toMatchSnapshot();
+
+  const baseState = {
+    concept: baseConcept,
+    conceptLinks: [],
+    relationTags: [],
+    conceptPermissions: {},
+    authentication: { role: "user" },
+  };
+
+  it("matches the latest snapshot", async () => {
+    const rendered = render(<ConceptTabs />, { state: baseState });
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
+  });
+
+  it("With concept tags and implementation links", async () => {
+    const state = {
+      ...baseState,
+      conceptLinks: [{ resource_type: "implementation" }],
+      relationTags: [{ value: { target_type: "business_concept" } }],
+      conceptPermissions: {
+        create_raw_implementation: { method: "POST" },
+        create_link_implementation: { method: "POST" },
+        create_implementation: { method: "POST" },
+        manage_quality_rule: { method: "POST" },
+      },
+    };
+    const rendered = render(<ConceptTabs />, { state });
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
+  });
+
+  it("shows quality rules tab when user is admin", async () => {
+    const state = {
+      ...baseState,
+      authentication: { role: "admin" },
+      concept: { ...baseConcept, rule_count: 0 },
+    };
+    const rendered = render(<ConceptTabs />, { state });
+    await waitForLoad(rendered);
+    expect(rendered.queryByText(/tabs\.bg\.qualityRules/i)).toBeInTheDocument();
+  });
+
+  it("shows quality rules tab when user has manageQualityRule permission", async () => {
+    const state = {
+      ...baseState,
+      conceptPermissions: {
+        manage_quality_rule: { method: "POST" },
+      },
+      concept: { ...baseConcept, rule_count: 0 },
+    };
+    const rendered = render(<ConceptTabs />, { state });
+    await waitForLoad(rendered);
+    expect(rendered.queryByText(/tabs\.bg\.qualityRules/i)).toBeInTheDocument();
+  });
+
+  it("shows quality rules tab when user has viewQualityRule permission and rule_count > 0", async () => {
+    const state = {
+      ...baseState,
+      conceptPermissions: {
+        view_quality_rule: { method: "GET" },
+      },
+      concept: { ...baseConcept, rule_count: 5 },
+    };
+    const rendered = render(<ConceptTabs />, { state });
+    await waitForLoad(rendered);
+    expect(rendered.queryByText(/tabs\.bg\.qualityRules/i)).toBeInTheDocument();
   });
 
-  it("With concept tags and implementation links", () => {
-    const props = {
-      concept: {
-        id: "1",
-        business_concept_id: "8",
+  it("does not show quality rules tab when user has viewQualityRule permission but rule_count is 0", async () => {
+    const state = {
+      ...baseState,
+      conceptPermissions: {
+        view_quality_rule: { method: "GET" },
       },
-      emptyConceptTags: true,
-      emptyImplementationLinks: true,
-      createRawImplementation: { method: "POST" },
-      createLinkImplementation: { method: "POST" },
-      createImplementation: { method: "POST" },
-    };
-    const { container } = render(<ConceptTabs {...props} />);
-    expect(container).toMatchSnapshot();
+      concept: { ...baseConcept, rule_count: 0 },
+    };
+    const rendered = render(<ConceptTabs />, { state });
+    await waitForLoad(rendered);
+    expect(rendered.queryByText(/tabs\.bg\.qualityRules/i)).not.toBeInTheDocument();
+  });
+
+  it("does not show quality rules tab when user has no permissions and no rules", async () => {
+    const state = {
+      ...baseState,
+      conceptPermissions: {},
+      concept: { ...baseConcept, rule_count: 0 },
+    };
+    const rendered = render(<ConceptTabs />, { state });
+    await waitForLoad(rendered);
+    expect(rendered.queryByText(/tabs\.bg\.qualityRules/i)).not.toBeInTheDocument();
+  });
+
+  it("does not show quality rules tab when enableQualityRules is false", async () => {
+    setConfig({ enableQualityRules: false });
+    const state = {
+      ...baseState,
+      authentication: { role: "admin" },
+      concept: { ...baseConcept, rule_count: 5 },
+    };
+    const rendered = render(<ConceptTabs />, { state });
+    await waitForLoad(rendered);
+    expect(rendered.queryByText(/tabs\.bg\.qualityRules/i)).not.toBeInTheDocument();
+  });
+
+  it("shows quality rules tab when enableQualityRules is undefined (defaults to true)", async () => {
+    setConfig({});
+    const state = {
+      ...baseState,
+      authentication: { role: "admin" },
+      concept: { ...baseConcept, rule_count: 0 },
+    };
+    const rendered = render(<ConceptTabs />, { state });
+    await waitForLoad(rendered);
+    expect(rendered.queryByText(/tabs\.bg\.qualityRules/i)).toBeInTheDocument();
   });
 });

package/src/concepts/components/__tests__/__snapshots__/Concept.spec.js.snap

@@ -137,13 +137,6 @@ exports[`<Concept /> matches the latest snapshot 1`] = `
           >
             tabs.bg.relations_data_field
           </a>
-          <a
-            class="item"
-            data-discover="true"
-            href="/concepts/1/versions/1/rules"
-          >
-            tabs.bg.qualityRules
-          </a>
           <a
             class="item"
             data-discover="true"
@@ -527,13 +520,6 @@ exports[`<Concept /> matches the latest snapshot with grantView activated 1`] =
           >
             tabs.bg.relations_data_field
           </a>
-          <a
-            class="item"
-            data-discover="true"
-            href="/concepts/1/versions/1/rules"
-          >
-            tabs.bg.qualityRules
-          </a>
           <a
             class="item"
             data-discover="true"

package/src/concepts/components/__tests__/__snapshots__/ConceptTabs.spec.js.snap

@@ -19,6 +19,13 @@ exports[`<ConceptTabs /> With concept tags and implementation links 1`] = `
     >
       tabs.bg.relations_data_field
     </a>
+    <a
+      class="item"
+      data-discover="true"
+      href="/concepts/8/versions/1/links/concepts"
+    >
+      tabs.bg.relations_business_concept
+    </a>
     <a
       class="item"
       data-discover="true"
@@ -70,27 +77,6 @@ exports[`<ConceptTabs /> matches the latest snapshot 1`] = `
     >
       tabs.bg.relations_data_field
     </a>
-    <a
-      class="item"
-      data-discover="true"
-      href="/concepts/8/versions/1/links/concepts"
-    >
-      tabs.bg.relations_business_concept
-    </a>
-    <a
-      class="item"
-      data-discover="true"
-      href="/concepts/8/versions/1/rules"
-    >
-      tabs.bg.qualityRules
-    </a>
-    <a
-      class="item"
-      data-discover="true"
-      href="/concepts/8/versions/1/links/implementations"
-    >
-      tabs.bg.qualityImplementations
-    </a>
     <a
       class="item"
       data-discover="true"