@truedat/bg 4.54.7 → 4.54.9

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.54.9] 2022-10-28
+
+### Added
+
+- [TD-4977] Implementations tab in domain view
+
 ## [4.54.5] 2022-10-25
 
 ### Changed
@@ -43,7 +49,7 @@
 
 ### Added
 
-- [TD-4975] Structures tab in Domain's view
+- [TD-4975] Structures tab in domain view
 
 ## [4.48.4] 2022-07-11
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/bg",
-  "version": "4.54.7",
+  "version": "4.54.9",
   "description": "Truedat Web Business Glossary",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -34,7 +34,7 @@
     "@testing-library/jest-dom": "^5.16.4",
     "@testing-library/react": "^12.0.0",
     "@testing-library/user-event": "^13.2.1",
-    "@truedat/test": "4.54.7",
+    "@truedat/test": "4.54.9",
     "babel-jest": "^28.1.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -86,8 +86,8 @@
     ]
   },
   "dependencies": {
-    "@truedat/core": "4.54.7",
-    "@truedat/df": "4.54.7",
+    "@truedat/core": "4.54.9",
+    "@truedat/df": "4.54.9",
     "file-saver": "^2.0.5",
     "moment": "^2.24.0",
     "path-to-regexp": "^1.7.0",
@@ -107,5 +107,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "5fc1e696a1449d9e0b68531f109cc7a8a2dd9543"
+  "gitHead": "27f711249723050708a6f6f4de3ab5029069c4d7"
 }

package/src/concepts/components/ConceptsBulkUpdate.js

@@ -54,6 +54,9 @@ const actions = (handleSubmit) => [
     onClick: handleSubmit,
   },
 ];
+
+const isEmptyValue = (value) => !_.isNumber(value) && _.isEmpty(value);
+
 export class ConceptsBulkUpdate extends React.Component {
   static propTypes = {
     loading: PropTypes.bool,
@@ -90,10 +93,6 @@ export class ConceptsBulkUpdate extends React.Component {
 
   isInvalid = () => _.negate(isValid)(this.state);
 
-  isEmptyNumberOrObject = (value) =>
-    (_.isNumber(value) && _.isNil(value)) ||
-    (!_.isNumber(value) && _.isEmpty(value));
-
   handleSubmit = (e) => {
     e.preventDefault();
     const { applyTemplate, bulkUpdate } = this.props;
@@ -102,7 +101,7 @@ export class ConceptsBulkUpdate extends React.Component {
       _.prop("content"),
       (content) => applyTemplate(content, domain_id),
       _.omit(fieldsToOmit),
-      _.omitBy(this.isEmptyNumberOrObject)
+      _.omitBy(isEmptyValue)
     )(this.state);
     bulkUpdate({ update_attributes: { content, domain_id } });
   };

package/src/messages/en.js

@@ -287,6 +287,7 @@ export default {
   "tabs.bg.relations_data_field": "Linkage",
   "tabs.concepts": "Concepts",
   "tabs.domains": "Domains",
+  "tabs.implementations": "Data Quality",
   "tabs.members": "Members",
   "tabs.se.concepts": "Concepts",
   "tabs.structures": "Structures",

package/src/messages/es.js

@@ -291,6 +291,7 @@ export default {
   "tabs.bg.relations_data_field": "Vinculación",
   "tabs.concepts": "Conceptos",
   "tabs.domains": "Dominios",
+  "tabs.implementations": "Calidad",
   "tabs.members": "Roles",
   "tabs.se.concepts": "Conceptos",
   "tabs.structures": "Estructuras",

package/src/taxonomy/components/Domain.js

@@ -4,9 +4,12 @@ import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { Route, Switch } from "react-router-dom";
 import { Segment } from "semantic-ui-react";
+import { Unauthorized } from "@truedat/core/components";
+import { useAuthorized } from "@truedat/core/hooks";
 import {
   DOMAIN,
   DOMAIN_CONCEPTS,
+  DOMAIN_IMPLEMENTATIONS,
   DOMAIN_MEMBERS,
   DOMAIN_STRUCTURES,
   linkTo,
@@ -16,12 +19,16 @@ import DomainActions from "./DomainActions";
 import DomainCards from "./DomainCards";
 import DomainCrumbs from "./DomainCrumbs";
 import DomainDetail from "./DomainDetail";
+import DomainImplementations from "./DomainImplementations";
 import DomainMembers from "./DomainMembers";
 import DomainSearch from "./DomainSearch";
 import DomainStructures from "./DomainStructures";
 import DomainTabs from "./DomainTabs";
 
 export const Domain = ({ hasChildren, domain, domainLoading }) => {
+  const ddAuthorized = useAuthorized("data_dictionary");
+  const dqAuthorized = useAuthorized("quality");
+
   const actions = {
     create: {
       order: 1,
@@ -40,8 +47,8 @@ export const Domain = ({ hasChildren, domain, domainLoading }) => {
         <Segment attached="bottom">
           <Switch>
             <Route
-              path={DOMAIN}
               exact
+              path={DOMAIN}
               render={() => (
                 <>
                   {hasChildren && <DomainSearch />}
@@ -51,19 +58,28 @@ export const Domain = ({ hasChildren, domain, domainLoading }) => {
               )}
             />
             <Route
+              exact
               path={DOMAIN_MEMBERS}
               render={() => <DomainMembers />}
-              exact
             />
             <Route
+              exact
               path={DOMAIN_CONCEPTS}
               render={() => <DomainConcepts />}
-              exact
             />
             <Route
+              exact
               path={DOMAIN_STRUCTURES}
-              render={() => <DomainStructures />}
+              render={() =>
+                ddAuthorized ? <DomainStructures /> : <Unauthorized />
+              }
+            />
+            <Route
               exact
+              path={DOMAIN_IMPLEMENTATIONS}
+              render={() =>
+                dqAuthorized ? <DomainImplementations /> : <Unauthorized />
+              }
             />
           </Switch>
         </Segment>

package/src/taxonomy/components/DomainImplementations.js

@@ -0,0 +1,37 @@
+import React from "react";
+import PropTypes from "prop-types";
+import { connect } from "react-redux";
+
+const ImplementationFiltersLoader = React.lazy(() =>
+  import("@truedat/dq/components/ImplementationFiltersLoader")
+);
+
+const ImplementationsLoader = React.lazy(() =>
+  import("@truedat/dq/components/RuleImplementationsLoader")
+);
+
+const ImplementationSearchResults = React.lazy(() =>
+  import("@truedat/dq/components/ImplementationSearchResults")
+);
+
+export const DomainImplementations = ({ domain = {} }) => {
+  const defaultFilters = {
+    taxonomy: [domain.id],
+    status: ["published"],
+  };
+  return (
+    <>
+      <ImplementationFiltersLoader defaultFilters={defaultFilters} />
+      <ImplementationsLoader defaultFilters={defaultFilters} />
+      <ImplementationSearchResults embedded />
+    </>
+  );
+};
+
+DomainImplementations.propTypes = {
+  domain: PropTypes.object.isRequired,
+};
+
+export const mapStateToProps = ({ domain }) => ({ domain });
+
+export default connect(mapStateToProps)(DomainImplementations);

package/src/taxonomy/components/DomainRoutes.js

@@ -9,6 +9,7 @@ import {
   DOMAINS_NEW,
   DOMAINS_SEARCH,
   DOMAIN_EDIT,
+  DOMAIN_IMPLEMENTATIONS,
   DOMAIN_MEMBERS,
   DOMAIN_MEMBERS_NEW,
   DOMAIN_NEW,
@@ -33,6 +34,7 @@ const DomainRoutes = () => (
     <Route component={DomainMembersLoader} />
     <Route exact path={DOMAIN} component={Domain} />
     <Route exact path={DOMAIN_CONCEPTS} component={Domain} />
+    <Route exact path={DOMAIN_IMPLEMENTATIONS} component={Domain} />
     <Route exact path={DOMAIN_STRUCTURES} component={Domain} />
     <Route exact path={DOMAIN_MEMBERS} component={Domain} />
     <Route exact path={DOMAIN_EDIT} render={() => <EditDomain />} />

package/src/taxonomy/components/DomainTabs.js

@@ -5,10 +5,11 @@ import { FormattedMessage } from "react-intl";
 import { connect } from "react-redux";
 import { Link } from "react-router-dom";
 import { Menu } from "semantic-ui-react";
-import { usePath } from "@truedat/core/hooks";
+import { useAuthorized, usePath } from "@truedat/core/hooks";
 import {
   DOMAIN,
   DOMAIN_CONCEPTS,
+  DOMAIN_IMPLEMENTATIONS,
   DOMAIN_MEMBERS,
   DOMAIN_STRUCTURES,
   linkTo,
@@ -16,6 +17,8 @@ import {
 
 const DomainTabs = ({ domain }) => {
   const path = usePath();
+  const ddAuthorized = useAuthorized("data_dictionary");
+  const dqAuthorized = useAuthorized("quality");
   const id = domain?.id;
   return (
     <Menu attached="top" pointing secondary tabular>
@@ -43,15 +46,26 @@ const DomainTabs = ({ domain }) => {
       >
         <FormattedMessage id="tabs.concepts" />
       </Menu.Item>
-
-      <Menu.Item
-        active={path === DOMAIN_STRUCTURES}
-        as={Link}
-        to={linkTo.DOMAIN_STRUCTURES({ id })}
-        replace
-      >
-        <FormattedMessage id="tabs.structures" />
-      </Menu.Item>
+      {ddAuthorized ? (
+        <Menu.Item
+          active={path === DOMAIN_STRUCTURES}
+          as={Link}
+          to={linkTo.DOMAIN_STRUCTURES({ id })}
+          replace
+        >
+          <FormattedMessage id="tabs.structures" />
+        </Menu.Item>
+      ) : null}
+      {dqAuthorized ? (
+        <Menu.Item
+          active={path === DOMAIN_IMPLEMENTATIONS}
+          as={Link}
+          to={linkTo.DOMAIN_IMPLEMENTATIONS({ id })}
+          replace
+        >
+          <FormattedMessage id="tabs.implementations" />
+        </Menu.Item>
+      ) : null}
     </Menu>
   );
 };

package/src/taxonomy/components/__tests__/Domain.spec.js

@@ -1,21 +1,22 @@
 import React from "react";
-import { shallow } from "enzyme";
-import { Domain } from "../Domain";
+import { render } from "@truedat/test/render";
+import Domain from "../Domain";
 
-describe("<Domain />", () => {
-  const domainLoading = false;
+jest.mock("@truedat/core/hooks", () => ({
+  useAuthorized: jest.fn(() => true),
+  usePath: jest.fn(() => "/domains/:id"),
+}));
 
-  it("matches the latest snapshot (no subdomains)", () => {
-    const domain = { id: 3, name: "domain", childCount: 0 };
-    const props = { domain, domainLoading };
-    const wrapper = shallow(<Domain {...props} />);
-    expect(wrapper).toMatchSnapshot();
-  });
+describe("<Domain />", () => {
+  const renderOpts = {
+    state: {
+      domainLoading: false,
+      domain: { id: 3, name: "DOMAIN NAME" },
+    },
+  };
 
-  it("matches the latest snapshot (with subdomains)", () => {
-    const domain = { id: 3, name: "domain", childCount: 5 };
-    const props = { domain, domainLoading };
-    const wrapper = shallow(<Domain {...props} />);
-    expect(wrapper).toMatchSnapshot();
+  it("matches the latest snapshot", () => {
+    const { container } = render(<Domain />, renderOpts);
+    expect(container).toMatchSnapshot();
   });
 });

package/src/taxonomy/components/__tests__/__snapshots__/Domain.spec.js.snap

@@ -1,73 +1,96 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<Domain /> matches the latest snapshot (no subdomains) 1`] = `
-<Fragment>
-  <Connect(DomainCrumbs) />
-  <Segment>
-    <Connect(DomainDetail) />
-    <Connect(DomainTabs) />
-    <Segment
-      attached="bottom"
+exports[`<Domain /> matches the latest snapshot 1`] = `
+<div>
+  <div
+    class="ui breadcrumb"
+  >
+    <a
+      class="section"
+      href="/domains"
     >
-      <Switch>
-        <Route
-          exact={true}
-          path="/domains/:id"
-          render={[Function]}
-        />
-        <Route
-          exact={true}
-          path="/domains/:id/members"
-          render={[Function]}
-        />
-        <Route
-          exact={true}
-          path="/domains/:id/concepts"
-          render={[Function]}
-        />
-        <Route
-          exact={true}
-          path="/domains/:id/structures"
-          render={[Function]}
-        />
-      </Switch>
-    </Segment>
-  </Segment>
-</Fragment>
-`;
-
-exports[`<Domain /> matches the latest snapshot (with subdomains) 1`] = `
-<Fragment>
-  <Connect(DomainCrumbs) />
-  <Segment>
-    <Connect(DomainDetail) />
-    <Connect(DomainTabs) />
-    <Segment
-      attached="bottom"
+      Taxonomy
+    </a>
+    <i
+      aria-hidden="true"
+      class="right angle icon divider"
+    />
+    <div
+      class="active section"
+    >
+      DOMAIN NAME
+    </div>
+  </div>
+  <div
+    class="ui segment"
+  >
+    <div
+      class="ui grid"
+    >
+      <div
+        class="eight wide column"
+      >
+        <h2
+          class="ui header"
+        >
+          <i
+            aria-hidden="true"
+            class="cube icon"
+          />
+          <div
+            class="content"
+          >
+            DOMAIN NAME
+            <div
+              class="sub header"
+            >
+              Domain
+            </div>
+          </div>
+        </h2>
+      </div>
+      <div
+        class="right aligned eight wide column"
+      />
+    </div>
+    <p />
+    <div
+      class="ui pointing secondary top attached tabular menu"
     >
-      <Switch>
-        <Route
-          exact={true}
-          path="/domains/:id"
-          render={[Function]}
-        />
-        <Route
-          exact={true}
-          path="/domains/:id/members"
-          render={[Function]}
-        />
-        <Route
-          exact={true}
-          path="/domains/:id/concepts"
-          render={[Function]}
-        />
-        <Route
-          exact={true}
-          path="/domains/:id/structures"
-          render={[Function]}
-        />
-      </Switch>
-    </Segment>
-  </Segment>
-</Fragment>
+      <a
+        class="active item"
+        href="/domains/3"
+      >
+        Subdomains
+      </a>
+      <a
+        class="item"
+        href="/domains/3/members"
+      >
+        Members
+      </a>
+      <a
+        class="item"
+        href="/domains/3/concepts"
+      >
+        Concepts
+      </a>
+      <a
+        class="item"
+        href="/domains/3/structures"
+      >
+        Structures
+      </a>
+      <a
+        class="item"
+        href="/domains/3/implementations"
+      >
+        Data Quality
+      </a>
+    </div>
+    <div
+      class="ui bottom attached segment"
+    />
+  </div>
+</div>
 `;