@truedat/bg 4.46.1 → 4.46.4

package/src/concepts/components/__tests__/ConceptsLoader.spec.js

@@ -4,9 +4,8 @@ import { ConceptsLoader } from "../ConceptsLoader";
 
 const getProps = () => ({
   clearConcepts: jest.fn(),
-  clearConceptDefaultFilters: jest.fn(),
   conceptsLoading: false,
-  fetchConcepts: jest.fn()
+  fetchConcepts: jest.fn(),
 });
 
 describe("<ConceptsLoader />", () => {
@@ -18,14 +17,12 @@ describe("<ConceptsLoader />", () => {
     expect(props.fetchConcepts).toHaveBeenCalledTimes(1);
   });
 
-  it("calls clearConcepts and clearConceptDefaultFilters when component unmounts but not when it mounts", () => {
+  it("calls clearConcepts when component unmounts but not when it mounts", () => {
     const props = getProps();
     const wrapper = mount(<ConceptsLoader {...props} />);
     expect(props.clearConcepts).toHaveBeenCalledTimes(0);
-    expect(props.clearConceptDefaultFilters).toHaveBeenCalledTimes(0);
     wrapper.unmount();
     expect(props.clearConcepts).toHaveBeenCalledTimes(1);
-    expect(props.clearConceptDefaultFilters).toHaveBeenCalledTimes(1);
   });
 
   it("merges default filters with query filters", () => {

package/src/concepts/components/__tests__/ConceptsPanel.spec.js

@@ -0,0 +1,25 @@
+import React from "react";
+import { render } from "@truedat/test/render";
+import ConceptsPanel from "../ConceptsPanel";
+
+const renderOpts = {
+  state: {
+    conceptCount: 123,
+    concepts: [
+      {
+        id: 1,
+        name: "concept",
+        domain: { name: "domain" },
+        status: "published",
+        last_change_at: "2020-01-01T00:00:00.000Z",
+      },
+    ],
+  },
+};
+
+describe("<ConceptsPanel />", () => {
+  it("matches latest snapshot", () => {
+    const { container } = render(<ConceptsPanel />, renderOpts);
+    expect(container).toMatchSnapshot();
+  });
+});

package/src/concepts/components/__tests__/__snapshots__/Concept.spec.js.snap

@@ -4,7 +4,7 @@ exports[`<Concept /> matches the latest snapshot 1`] = `
 <Fragment>
   <Connect(ConceptCrumbs) />
   <Connect(ConceptArchiveLoader) />
-  <lazy
+  <Connect(CommentsLoader)
     resource_id={1}
     resource_type="business_concept"
   />

package/src/concepts/components/__tests__/__snapshots__/ConceptArchiveRow.spec.js.snap

@@ -1,34 +1,38 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`<ConceptArchiveRow /> matches the latest snapshot 1`] = `
-<TableRow
-  as="tr"
-  cellAs="td"
-  onClick={[Function]}
->
-  <TableCell
-    as="td"
-    content={
-      <Memo(MemoizedFormattedMessage)
-        id="concepts.status.status"
-      />
-    }
-  />
-  <TableCell
-    as="td"
-    content={1}
-  />
-  <TableCell
-    as="td"
-    content=""
-  />
-  <TableCell
-    as="td"
-    content={
-      <DateTime
-        value="2018-06-27T07:32:53.154377Z"
-      />
-    }
-  />
-</TableRow>
+<div>
+  <table>
+    <tbody>
+      <tr
+        class=""
+      >
+        <td
+          class=""
+        >
+          Draft
+        </td>
+        <td
+          class=""
+        >
+          1
+        </td>
+        <td
+          class=""
+        >
+          
+        </td>
+        <td
+          class=""
+        >
+          <time
+            datetime="1530084773154"
+          >
+            2018-06-27 07:32
+          </time>
+        </td>
+      </tr>
+    </tbody>
+  </table>
+</div>
 `;

package/src/concepts/components/__tests__/__snapshots__/ConceptDetails.spec.js.snap

@@ -11,7 +11,7 @@ exports[`<ConceptDetails /> matches the latest snapshot 1`] = `
       id="concepts.props.description"
     />
   </Header>
-  <lazy
+  <injectIntl(RichTextEditor)
     readOnly={true}
   />
   <lazy

package/src/concepts/components/__tests__/__snapshots__/ConceptForm.spec.js.snap

@@ -203,23 +203,23 @@ exports[`<ConceptForm /> with a single template matches the latest snapshot 1`]
                 autocorrect="on"
                 contenteditable="true"
                 data-gramm="false"
-                data-key="9"
+                data-key="10"
                 data-slate-editor="true"
                 role="textbox"
                 spellcheck="true"
                 style="outline: none; white-space: pre-wrap; word-wrap: break-word;"
               >
                 <div
-                  data-key="10"
+                  data-key="11"
                   data-slate-object="block"
                   style="position: relative;"
                 >
                   <span
-                    data-key="13"
+                    data-key="14"
                     data-slate-object="text"
                   >
                     <span
-                      data-offset-key="13:0"
+                      data-offset-key="14:0"
                       data-slate-leaf="true"
                     >
                       <span>
@@ -516,11 +516,11 @@ exports[`<ConceptForm /> with multiple templates matches the latest snapshot 1`]
                   style="position: relative;"
                 >
                   <span
-                    data-key="3"
+                    data-key="4"
                     data-slate-object="text"
                   >
                     <span
-                      data-offset-key="3:0"
+                      data-offset-key="4:0"
                       data-slate-leaf="true"
                     >
                       <span>

package/src/concepts/components/__tests__/__snapshots__/ConceptTaxonomy.spec.js.snap

@@ -11,7 +11,7 @@ exports[`<ConceptTaxonomy /> matches the latest snapshot 1`] = `
       id="concepts.taxonomy"
     />
   </Header>
-  <lazy
+  <Connect(DomainsConceptLoader)
     actions="manage_business_concepts_domain"
   />
   <Connect(ConceptManageDomainPopup)

package/src/concepts/components/__tests__/__snapshots__/Concepts.spec.js.snap

@@ -26,36 +26,7 @@ exports[`<Concepts /> matches the latest snapshot 1`] = `
     <Segment
       attached="bottom"
     >
-      <Connect(ConceptsActions)
-        concepts={
-          Array [
-            Object {
-              "description": "dd",
-              "id": 1,
-              "name": "s1",
-              "status": "st",
-              "version": "vs",
-            },
-          ]
-        }
-        create={true}
-        update={true}
-      />
-      <Connect(ConceptsSearch) />
-      <ConceptSelectedFilters />
-      <DimmerDimmable
-        dimmed={false}
-      >
-        <Dimmer
-          active={false}
-          inverted={true}
-        >
-          <Loader />
-        </Dimmer>
-        <Connect(ConceptsLabelResults) />
-        <withRouter(Connect(ConceptsTable)) />
-        <Connect(Pagination) />
-      </DimmerDimmable>
+      <Connect(ConceptsPanel) />
     </Segment>
   </Segment>
 </Fragment>

package/src/concepts/components/__tests__/__snapshots__/ConceptsPanel.spec.js.snap

@@ -0,0 +1,157 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<ConceptsPanel /> matches latest snapshot 1`] = `
+<div>
+  <div
+    class="ui action left icon input"
+  >
+    <input
+      placeholder="Search concepts..."
+      type="text"
+      value=""
+    />
+    <i
+      aria-hidden="true"
+      class="search link icon"
+    />
+    <div
+      aria-expanded="false"
+      class="ui button floating labeled scrolling dropdown icon"
+      role="listbox"
+      tabindex="0"
+    >
+      <div
+        aria-atomic="true"
+        aria-live="polite"
+        class="divider text"
+        role="alert"
+      >
+        Filters
+      </div>
+      <i
+        aria-hidden="true"
+        class="filter icon"
+      />
+      <div
+        class="menu transition"
+      >
+        <div
+          class="item"
+          role="option"
+        >
+          <em>
+            (reset all filters)
+          </em>
+        </div>
+      </div>
+    </div>
+  </div>
+  <div
+    class="selectedFilters"
+  />
+  <div
+    class="dimmable"
+  >
+    <div
+      class="ui inverted dimmer"
+    >
+      <div
+        class="content"
+      >
+        <div
+          class="ui loader"
+        />
+      </div>
+    </div>
+    <div
+      class="ui label concepts-label-results"
+    >
+      123 concepts found
+    </div>
+    <table
+      class="ui selectable sortable table"
+    >
+      <thead
+        class=""
+      >
+        <tr
+          class=""
+        >
+          <th
+            class="seven wide"
+          >
+            Term
+          </th>
+          <th
+            class="three wide"
+          >
+            Domain
+          </th>
+          <th
+            class="two wide"
+          >
+            Status
+          </th>
+          <th
+            class="one wide"
+          >
+            Quality rules
+          </th>
+          <th
+            class="one wide"
+          >
+            Link to field
+          </th>
+          <th
+            class="two wide"
+          >
+            Last modification date
+          </th>
+        </tr>
+      </thead>
+      <tbody
+        class=""
+      >
+        <tr
+          class=""
+        >
+          <td
+            class=""
+          >
+            concept
+          </td>
+          <td
+            class=""
+          >
+            domain
+          </td>
+          <td
+            class=""
+          >
+            Published
+          </td>
+          <td
+            class="center aligned"
+          >
+            
+          </td>
+          <td
+            class="center aligned"
+          >
+            
+          </td>
+          <td
+            class="center aligned"
+          >
+            <time
+              datetime="1577836800000"
+            >
+              2020-01-01 00:00
+            </time>
+          </td>
+        </tr>
+      </tbody>
+    </table>
+  </div>
+</div>
+`;

package/src/concepts/components/__tests__/__snapshots__/ConceptsTable.spec.js.snap

@@ -13,13 +13,47 @@ exports[`<ConceptsTable /> matches the latest snapshot 1`] = `
       <TableRow
         as="tr"
         cellAs="td"
-      />
+      >
+        <TableHeaderCell
+          as="th"
+          className="disabled"
+          content={
+            <Memo(MemoizedFormattedMessage)
+              id="concepts.props.name"
+            />
+          }
+          key="0"
+          onClick={[Function]}
+          sorted="ascending"
+        />
+        <TableHeaderCell
+          as="th"
+          className="disabled"
+          content={
+            <Memo(MemoizedFormattedMessage)
+              id="concepts.props.status"
+            />
+          }
+          key="1"
+          onClick={[Function]}
+          sorted="ascending"
+        />
+      </TableRow>
     </TableHeader>
     <TableBody
       as="tbody"
     >
       <ConceptRow
-        columns={Array []}
+        columns={
+          Array [
+            Object {
+              "name": "name",
+            },
+            Object {
+              "name": "status",
+            },
+          ]
+        }
         concept={
           Object {
             "id": 1,

package/src/concepts/reducers/conceptQuery.js

@@ -6,7 +6,7 @@ import {
   toggleConceptFilterValue,
   searchConcepts,
   selectConceptPage,
-  sortConcepts
+  sortConcepts,
 } from "../routines";
 
 const defaultPage = 1;
@@ -18,7 +18,7 @@ export const initialState = {
   query: "",
   page: defaultPage,
   size: defaultSize,
-  sort: byNameSort
+  sort: byNameSort,
 };
 
 const conceptQuery = (state = initialState, { type, payload }) => {

package/src/concepts/reducers/index.js

@@ -16,7 +16,6 @@ import { conceptRedirect } from "./conceptRedirect";
 import { conceptSelectedFilter } from "./conceptSelectedFilter";
 import { concepts } from "./concepts";
 import { conceptsActions } from "./conceptsActions";
-import { conceptsDefaultFilters } from "./conceptsDefaultFilters";
 import { conceptsDownloading } from "./conceptsDownloading";
 import { conceptsLoading } from "./conceptsLoading";
 import { conceptsPageSize } from "./conceptsPageSize";
@@ -39,7 +38,6 @@ export {
   conceptArchive,
   conceptArchiveLoading,
   conceptCount,
-  conceptsDefaultFilters,
   conceptFilters,
   conceptFiltersLoading,
   conceptLinking,

package/src/concepts/relations/components/ConceptImplementationLinks.js

@@ -7,6 +7,7 @@ import { FormattedMessage } from "react-intl";
 import { getConceptImplementationLinks } from "../selectors";
 import { conceptLinkAction } from "../routines";
 import ImplementationLinksAction from "./ImplementationLinksAction";
+
 const RuleImplementationsTable = React.lazy(() =>
   import("@truedat/dq/components/RuleImplementationsTable")
 );

package/src/concepts/relations/components/ConceptSelector.js

@@ -30,9 +30,12 @@ const ConceptSelectorRow = ({ concept, active, onClick, disabled }) => {
       <Table.Cell
         content={
           <Label color={mapStatusColor[status]}>
-            {<FormattedMessage id={`concepts.status.${status}`} /> || (
-              <Icon name="ellipsis vertical" color="grey" />
-            )}
+            {(
+              <FormattedMessage
+                id={`concepts.status.${status}`}
+                defaultMessage={status}
+              />
+            ) || <Icon name="ellipsis vertical" color="grey" />}
           </Label>
         }
       />

package/src/concepts/routines.js

@@ -36,12 +36,6 @@ export const toggleConceptFilterValue = createRoutine(
   "TOGGLE_CONCEPT_FILTER_VALUE"
 );
 export const bulkUpdate = createRoutine("BULK_UPDATE");
-export const setConceptDefaultFilters = createRoutine(
-  "SET_CONCEPT_DEFAULT_FILTERS"
-);
-export const clearConceptDefaultFilters = createRoutine(
-  "CLEAR_CONCEPT_DEFAULT_FILTERS"
-);
 export const saveSharedTo = createRoutine("SAVE_SHARED_TO");
 export const setConfidentialConcept = createRoutine("SET_CONFIDENTIAL_CONCEPT");
 

package/src/messages/en.js

@@ -286,6 +286,7 @@ export default {
   "tabs.bg.qualityImplementations": "Quality Implementations",
   "tabs.bg.relations_business_concept": "Related Concepts",
   "tabs.bg.relations_data_field": "Linkage",
+  "tabs.concepts": "Concepts",
   "tabs.domains": "Domains",
   "tabs.members": "Members",
   "tabs.se.concepts": "Concepts",

package/src/messages/es.js

@@ -290,6 +290,7 @@ export default {
   "tabs.bg.qualityImplementations": "Implementaciones",
   "tabs.bg.relations_business_concept": "Conceptos relacionados",
   "tabs.bg.relations_data_field": "Vinculación",
+  "tabs.concepts": "Conceptos",
   "tabs.domains": "Dominios",
   "tabs.members": "Roles",
   "tabs.se.concepts": "Conceptos",

package/src/taxonomy/components/Domain.js

@@ -4,7 +4,13 @@ import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { Route, Switch } from "react-router-dom";
 import { Segment } from "semantic-ui-react";
-import { DOMAIN, DOMAIN_MEMBERS, linkTo } from "@truedat/core/routes";
+import {
+  DOMAIN,
+  DOMAIN_CONCEPTS,
+  DOMAIN_MEMBERS,
+  linkTo,
+} from "@truedat/core/routes";
+import DomainConcepts from "../../concepts/components/DomainConcepts";
 import DomainActions from "./DomainActions";
 import DomainCrumbs from "./DomainCrumbs";
 import DomainCards from "./DomainCards";
@@ -19,8 +25,8 @@ export const Domain = ({ hasChildren, domain, domainLoading }) => {
       order: 1,
       icon: "cube",
       messageId: "domain.actions.create",
-      action: id => linkTo.DOMAIN_ACTION({ action: "new", id })
-    }
+      action: (id) => linkTo.DOMAIN_NEW({ id }),
+    },
   };
 
   return domainLoading ? null : domain && domain.id ? (
@@ -42,7 +48,16 @@ export const Domain = ({ hasChildren, domain, domainLoading }) => {
                 </>
               )}
             />
-            <Route path={DOMAIN_MEMBERS} component={DomainMembers} exact />
+            <Route
+              path={DOMAIN_MEMBERS}
+              render={() => <DomainMembers />}
+              exact
+            />
+            <Route
+              path={DOMAIN_CONCEPTS}
+              render={() => <DomainConcepts />}
+              exact
+            />
           </Switch>
         </Segment>
       </Segment>
@@ -52,7 +67,8 @@ export const Domain = ({ hasChildren, domain, domainLoading }) => {
 
 Domain.propTypes = {
   hasChildren: PropTypes.bool,
-  domain: PropTypes.object
+  domain: PropTypes.object,
+  domainLoading: PropTypes.bool,
 };
 
 const mapStateToProps = ({ domain, domainLoading, domains }) => ({
@@ -62,7 +78,7 @@ const mapStateToProps = ({ domain, domainLoading, domains }) => ({
     _.filter(_.prop("parent_id")),
     _.filter(_.propEq("parent_id", _.prop("id")(domain))),
     _.negate(_.isEmpty)
-  )(domains)
+  )(domains),
 });
 
 export default connect(mapStateToProps)(Domain);

package/src/taxonomy/components/DomainCrumbs.js

@@ -44,13 +44,14 @@ export const DomainCrumbs = ({ parents, domain, actionCrumb }) => (
 );
 
 DomainCrumbs.propTypes = {
+  actionCrumb: PropTypes.string,
+  domain: PropTypes.object,
   parents: PropTypes.array,
-  domain: PropTypes.object
 };
 
-const mapStateToProps = state => ({
+const mapStateToProps = (state) => ({
   domain: state.domain,
-  parents: getAncestorDomains(state)
+  parents: getAncestorDomains(state),
 });
 
 export default connect(mapStateToProps)(DomainCrumbs);

package/src/taxonomy/components/DomainDetail.js

@@ -8,17 +8,15 @@ import { linkTo } from "@truedat/core/routes";
 
 import DomainActions from "./DomainActions";
 
-const toActionPath = linkTo.DOMAIN_ACTION;
-
 export const DomainDetail = ({ type, name, description, domain_group }) => {
   const available_actions = {
     update: {
       order: 2,
       icon: "edit",
       messageId: "actions.edit",
-      action: id => toActionPath({ action: "edit", id })
+      action: (id) => linkTo.DOMAIN_EDIT({ id }),
     },
-    deleteOption: true
+    deleteOption: true,
   };
   return (
     <>
@@ -57,7 +55,7 @@ DomainDetail.propTypes = {
   type: PropTypes.string,
   name: PropTypes.string,
   description: PropTypes.string,
-  domain_group: PropTypes.object
+  domain_group: PropTypes.object,
 };
 
 const mapStateToProps = ({ domain }) => ({ ...domain });

package/src/taxonomy/components/DomainRoutes.js

@@ -4,13 +4,14 @@ import { Unauthorized } from "@truedat/core/components";
 import { useAuthorized } from "@truedat/core/hooks";
 import {
   DOMAIN,
+  DOMAIN_CONCEPTS,
   DOMAINS,
   DOMAINS_NEW,
   DOMAINS_SEARCH,
   DOMAIN_EDIT,
   DOMAIN_MEMBERS,
   DOMAIN_MEMBERS_NEW,
-  DOMAIN_NEW
+  DOMAIN_NEW,
 } from "@truedat/core/routes";
 import AddDomainMember from "./AddMember";
 import Domain from "./Domain";
@@ -39,6 +40,7 @@ const AuthorizedRoutes = () => (
             <Route component={DomainLoader} />
             <Route component={DomainMembersLoader} />
             <Route path={DOMAIN} component={Domain} exact />
+            <Route path={DOMAIN_CONCEPTS} component={Domain} exact />
             <Route path={DOMAIN_MEMBERS} component={Domain} exact />
             <Route path={DOMAIN_EDIT} component={EditDomain} exact />
             <Route path={DOMAIN_NEW} component={NewDomain} exact />