@truedat/bg 4.45.8 → 4.46.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.46.2] 2022-06-16
+
+### Changed
+
+- [TD-4739] Don't lazily load components from `@truedat/core`
+
 ## [4.45.1] 2022-05-26
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/bg",
-  "version": "4.45.8",
+  "version": "4.46.2",
   "description": "Truedat Web Business Glossary",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -34,7 +34,7 @@
     "@testing-library/jest-dom": "^5.16.4",
     "@testing-library/react": "^12.0.0",
     "@testing-library/user-event": "^13.2.1",
-    "@truedat/test": "4.45.8",
+    "@truedat/test": "4.46.2",
     "babel-jest": "^28.1.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -86,8 +86,8 @@
     ]
   },
   "dependencies": {
-    "@truedat/core": "4.45.8",
-    "@truedat/df": "4.45.8",
+    "@truedat/core": "4.46.2",
+    "@truedat/df": "4.46.2",
     "file-saver": "^2.0.5",
     "moment": "^2.24.0",
     "path-to-regexp": "^1.7.0",
@@ -107,5 +107,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "1b5acb1dc1233181e5a47353fd8a5da1424e7a47"
+  "gitHead": "161f3fae4428ee4e4e26b62fd2f9764ce389d0e2"
 }

package/src/concepts/components/Concept.js

@@ -4,6 +4,7 @@ import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { Route } from "react-router-dom";
 import { Grid, Segment } from "semantic-ui-react";
+import { Comments, CommentsLoader } from "@truedat/core/components";
 import { CONCEPT_VERSION } from "@truedat/core/routes";
 import ConceptRelationsSummary from "../relations/components/ConceptRelationsSummary";
 import ConceptArchiveLoader from "./ConceptArchiveLoader";
@@ -19,13 +20,11 @@ import SharedToDomains from "./SharedToDomains";
 const EventsLoader = React.lazy(() =>
   import("@truedat/audit/components/EventsLoader")
 );
-const Comments = React.lazy(() => import("@truedat/core/components/Comments"));
-const CommentsLoader = React.lazy(() =>
-  import("@truedat/core/components/CommentsLoader")
-);
+
 const RelationsLoader = React.lazy(() =>
   import("@truedat/lm/components/RelationsLoader")
 );
+
 const ConceptRulesLoader = React.lazy(() =>
   import("@truedat/dq/components/ConceptRulesLoader")
 );
@@ -71,11 +70,11 @@ export const Concept = ({ id }) => (
 );
 
 Concept.propTypes = {
-  id: PropTypes.number.isRequired
+  id: PropTypes.number.isRequired,
 };
 
 const mapStateToProps = ({ concept }) => ({
-  id: _.prop("business_concept_id")(concept)
+  id: _.prop("business_concept_id")(concept),
 });
 
 export default connect(mapStateToProps)(Concept);

package/src/concepts/components/ConceptDetails.js

@@ -3,16 +3,14 @@ import PropTypes from "prop-types";
 import { connect } from "react-redux";
 import { Segment, Header } from "semantic-ui-react";
 import { FormattedMessage } from "react-intl";
+import { RichTextEditor } from "@truedat/core/components";
 
 const DynamicFormViewer = React.lazy(() =>
   import("@truedat/df/components/DynamicFormViewer")
 );
-const RichTextEditor = React.lazy(() =>
-  import("@truedat/core/components/RichTextEditor")
-);
 
 export const ConceptDetails = ({
-  concept: { content, description, template }
+  concept: { content, description, template },
 }) => (
   <Segment attached="bottom">
     <Header as="h3">
@@ -24,7 +22,7 @@ export const ConceptDetails = ({
 );
 
 ConceptDetails.propTypes = {
-  concept: PropTypes.object
+  concept: PropTypes.object,
 };
 
 const mapStateToProps = ({ concept }) => ({ concept });

package/src/concepts/components/ConceptEdit.js

@@ -13,7 +13,7 @@ import {
 import { compose } from "redux";
 import { connect } from "react-redux";
 import { injectIntl, FormattedMessage } from "react-intl";
-import { HistoryBackButton } from "@truedat/core/components";
+import { HistoryBackButton, RichTextEditor } from "@truedat/core/components";
 import { selectTemplate, selectDomain } from "@truedat/df/routines";
 import { applyTemplate } from "@truedat/df/utils";
 import { conceptAction } from "../routines";
@@ -22,10 +22,6 @@ const DynamicForm = React.lazy(() =>
   import("@truedat/df/components/DynamicForm")
 );
 
-const RichTextEditor = React.lazy(() =>
-  import("@truedat/core/components/RichTextEditor")
-);
-
 const TemplateLoader = React.lazy(() =>
   import("@truedat/df/templates/components/TemplateLoader")
 );

package/src/concepts/components/ConceptForm.js

@@ -13,7 +13,7 @@ import {
 import { compose } from "redux";
 import { connect } from "react-redux";
 import { injectIntl, FormattedMessage } from "react-intl";
-import { HistoryBackButton } from "@truedat/core/components";
+import { HistoryBackButton, RichTextEditor } from "@truedat/core/components";
 import { conceptAction } from "../routines";
 import DomainDropdownSelector from "../../taxonomy/components/DomainDropdownSelector";
 
@@ -21,10 +21,6 @@ const SelectableDynamicForm = React.lazy(() =>
   import("@truedat/df/components/SelectableDynamicForm")
 );
 
-const RichTextEditor = React.lazy(() =>
-  import("@truedat/core/components/RichTextEditor")
-);
-
 const actionKey = "create";
 
 const staticFields = ["name", "description"];

package/src/concepts/components/ConceptTaxonomy.js

@@ -6,12 +6,9 @@ import { List, Header, Segment } from "semantic-ui-react";
 import { FormattedMessage } from "react-intl";
 import { getConceptDomainPath } from "../selectors";
 import DomainItem from "../../taxonomy/components/DomainItem";
+import DomainsConceptLoader from "../../taxonomy/components/DomainsConceptLoader";
 import ConceptManageDomainPopup from "./ConceptManageDomainPopup";
 
-const DomainsConceptLoader = React.lazy(() =>
-  import("../../taxonomy/components/DomainsConceptLoader")
-);
-
 export const ConceptTaxonomy = ({ domainPath }) =>
   _.negate(_.isEmpty)(domainPath) && (
     <Segment>

package/src/concepts/components/__tests__/__snapshots__/Concept.spec.js.snap

@@ -4,7 +4,7 @@ exports[`<Concept /> matches the latest snapshot 1`] = `
 <Fragment>
   <Connect(ConceptCrumbs) />
   <Connect(ConceptArchiveLoader) />
-  <lazy
+  <Connect(CommentsLoader)
     resource_id={1}
     resource_type="business_concept"
   />

package/src/concepts/components/__tests__/__snapshots__/ConceptDetails.spec.js.snap

@@ -11,7 +11,7 @@ exports[`<ConceptDetails /> matches the latest snapshot 1`] = `
       id="concepts.props.description"
     />
   </Header>
-  <lazy
+  <injectIntl(RichTextEditor)
     readOnly={true}
   />
   <lazy

package/src/concepts/components/__tests__/__snapshots__/ConceptForm.spec.js.snap

@@ -203,23 +203,23 @@ exports[`<ConceptForm /> with a single template matches the latest snapshot 1`]
                 autocorrect="on"
                 contenteditable="true"
                 data-gramm="false"
-                data-key="9"
+                data-key="10"
                 data-slate-editor="true"
                 role="textbox"
                 spellcheck="true"
                 style="outline: none; white-space: pre-wrap; word-wrap: break-word;"
               >
                 <div
-                  data-key="10"
+                  data-key="11"
                   data-slate-object="block"
                   style="position: relative;"
                 >
                   <span
-                    data-key="13"
+                    data-key="14"
                     data-slate-object="text"
                   >
                     <span
-                      data-offset-key="13:0"
+                      data-offset-key="14:0"
                       data-slate-leaf="true"
                     >
                       <span>
@@ -516,11 +516,11 @@ exports[`<ConceptForm /> with multiple templates matches the latest snapshot 1`]
                   style="position: relative;"
                 >
                   <span
-                    data-key="3"
+                    data-key="4"
                     data-slate-object="text"
                   >
                     <span
-                      data-offset-key="3:0"
+                      data-offset-key="4:0"
                       data-slate-leaf="true"
                     >
                       <span>

package/src/concepts/components/__tests__/__snapshots__/ConceptTaxonomy.spec.js.snap

@@ -11,7 +11,7 @@ exports[`<ConceptTaxonomy /> matches the latest snapshot 1`] = `
       id="concepts.taxonomy"
     />
   </Header>
-  <lazy
+  <Connect(DomainsConceptLoader)
     actions="manage_business_concepts_domain"
   />
   <Connect(ConceptManageDomainPopup)

package/src/concepts/relations/components/ConceptImplementationLinks.js

@@ -7,6 +7,7 @@ import { FormattedMessage } from "react-intl";
 import { getConceptImplementationLinks } from "../selectors";
 import { conceptLinkAction } from "../routines";
 import ImplementationLinksAction from "./ImplementationLinksAction";
+
 const RuleImplementationsTable = React.lazy(() =>
   import("@truedat/dq/components/RuleImplementationsTable")
 );