@truedat/auth 4.44.5 → 4.45.4

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [4.45.4] 2022-06-03
+
+### Changed
+
+- Removed password and rep_password field from UserForm user update to avoid 403 error
+
 ## [4.44.4] 2022-05-19
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/auth",
-  "version": "4.44.5",
+  "version": "4.45.4",
   "description": "Truedat Web Auth",
   "sideEffects": false,
   "jsnext:main": "src/index.js",
@@ -34,7 +34,7 @@
     "@testing-library/jest-dom": "^5.16.4",
     "@testing-library/react": "^12.0.0",
     "@testing-library/user-event": "^13.2.1",
-    "@truedat/test": "4.44.5",
+    "@truedat/test": "4.45.1",
     "babel-jest": "^28.1.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
     "babel-plugin-lodash": "^3.3.4",
@@ -87,7 +87,7 @@
     ]
   },
   "dependencies": {
-    "@truedat/core": "4.44.5",
+    "@truedat/core": "4.45.1",
     "auth0-js": "^9.12.2",
     "immutable": "^4.0.0-rc.12",
     "jwt-decode": "^2.2.0",
@@ -109,5 +109,5 @@
     "react-dom": ">= 16.8.6 < 17",
     "semantic-ui-react": ">= 0.88.2 < 2.1"
   },
-  "gitHead": "5a339468198c803592b285eddd0dd0c0b0eced93"
+  "gitHead": "40ec430c50a2da5eca991e9b946e8e47ffe1e477"
 }

package/src/users/components/UserForm.js

@@ -126,7 +126,21 @@ export const UserForm = ({ isSubmitting, onSubmit, user, groups }) => {
       rep_password: "",
       ...user,
     },
+    /*
+     * Remove PasswordFormFields' inputs (password, rep_password) if it is not
+     * mounted (user update). Keep them if it is mounted (user creation).
+     * Otherwise, td-auth returns forbidden because password updates are handled
+     * in the Password form, using /api/password, not in this UserForm that
+     * PUTs to /api/users/<user_id>
+     * https://stackoverflow.com/q/70105636
+     * This was not needed in v6, but it is in v7:
+     * https://react-hook-form.com/migrate-v6-to-v7/
+     *   Important: input value and reference will no longer get removed after
+     *   unmount unless shouldUnregister is true.
+     */
+    shouldUnregister: true,
   });
+
   const { errors, isDirty, isValid } = formState;
   return (
     <Form onSubmit={handleSubmit(onSubmit)}>

package/src/users/sagas/__tests__/updateUser.spec.js

@@ -0,0 +1,96 @@
+import { testSaga } from "redux-saga-test-plan";
+import { apiJsonPut, JSON_OPTS } from "@truedat/core/services/api";
+import { takeLatest } from "redux-saga/effects";
+import {
+  updateUserRequestSaga,
+  updateUserSaga,
+  updatePasswordSaga,
+} from "../updateUser";
+import { updateUser, updatePassword } from "../../routines";
+import { API_USER } from "../../api";
+
+describe("sagas: updateUserRequestSaga", () => {
+  it("should invoke updateUserSaga on updateUser.TRIGGER", () => {
+    expect(() => {
+      testSaga(updateUserRequestSaga)
+        .next()
+        .all([
+          takeLatest(updateUser.TRIGGER, updateUserSaga),
+          takeLatest(updatePassword.TRIGGER, updatePasswordSaga),
+        ])
+        .finish()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should throw exception if an unhandled action is received", () => {
+    expect(() => {
+      testSaga(updateUserRequestSaga)
+        .next()
+        .takeLatest("FOO", updateUserRequestSaga);
+    }).toThrow();
+  });
+});
+
+describe("sagas: updateUserSaga", () => {
+  const userId = 1;
+  const user = {
+    id: userId,
+    user_name: "uname",
+    email: "email@email.com",
+    full_name: "User Full Name",
+    groups: "[]",
+    role: "admin",
+  };
+  const payload = {
+    user,
+  };
+  const request_data = {
+    user,
+  };
+
+  it("should put a success action when a response is returned", () => {
+    expect(() => {
+      testSaga(updateUserSaga, { payload: user })
+        .next()
+        .put({ ...updateUser.request() })
+        .next()
+        .call(
+          apiJsonPut,
+          API_USER.replace(":id", userId),
+          request_data,
+          JSON_OPTS
+        )
+        .next({ data: payload })
+        .put({ ...updateUser.success(payload) })
+        .next()
+        .put(updateUser.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+
+  it("should put a failure action when the call returns an error", () => {
+    const message = "Request failed";
+    const error = { message };
+
+    expect(() => {
+      testSaga(updateUserSaga, { payload: user })
+        .next()
+        .put({ ...updateUser.request() })
+        .next()
+        .call(
+          apiJsonPut,
+          API_USER.replace(":id", userId),
+          request_data,
+          JSON_OPTS
+        )
+        .throw(error)
+        .put(updateUser.failure(message))
+        .next()
+        .put(updateUser.fulfill())
+        .next()
+        .isDone();
+    }).not.toThrow();
+  });
+});

package/src/users/sagas/updateUser.js

@@ -39,6 +39,6 @@ export function* updatePasswordSaga({ payload }) {
 export function* updateUserRequestSaga() {
   yield all([
     takeLatest(updateUser.TRIGGER, updateUserSaga),
-    takeLatest(updatePassword.TRIGGER, updatePasswordSaga)
+    takeLatest(updatePassword.TRIGGER, updatePasswordSaga),
   ]);
 }