@trops/dash-core 0.1.546 → 0.1.548

package/dist/electron/index.js

@@ -29742,6 +29742,8 @@ const menuItemsController$1 = {
 
 var menuItemsController_1 = menuItemsController$1;
 
+var cliController$3 = {exports: {}};
+
 var mcp = {};
 
 var server$1 = {};
@@ -50366,6 +50368,114 @@ function safeSend(win, channel, data) {
   }
 }
 
+/**
+ * Resolve the working directory the spawned CLI should run in.
+ *
+ * Pure / no I/O — extracted so it can be unit-tested. The actual
+ * mkdir + spawnOpts.cwd assignment happens at the spawn site.
+ *
+ * Why this exists: when the widget-builder modal launches the CLI in
+ * lockdown mode, the spawned process inherits the parent (Electron)
+ * process cwd. In a dev build that's the dash-electron project root,
+ * which contains a CLAUDE.md describing the 4-phase development
+ * workflow. The CLI auto-loads that file and the AI announces "Let me
+ * scan the existing project to understand what's already here." —
+ * exactly what the lockdown was meant to prevent.
+ *
+ * Resolution order:
+ *   1. Caller passed an explicit cwd → use that (caller wins).
+ *   2. disableTools: true and no cwd → scratch dir under os.tmpdir().
+ *   3. Otherwise → null (caller doesn't set spawnOpts.cwd; the child
+ *      inherits the parent's cwd, preserving AssistantPanel behavior
+ *      where project context may be wanted).
+ *
+ * @param {object}  opts
+ * @param {string=} opts.cwd
+ * @param {boolean=} opts.disableTools
+ * @returns {string|null}
+ */
+function resolveLockdownCwd({ cwd, disableTools = false } = {}) {
+  if (cwd) return cwd;
+  if (disableTools) {
+    const os = require$$2$1;
+    const path = require$$1$1;
+    return path.join(os.tmpdir(), "dash-widget-builder-cli");
+  }
+  return null;
+}
+
+/**
+ * Build the argv array for spawning the Claude Code CLI.
+ *
+ * Pure / no I/O — extracted as a top-level helper so it can be unit-
+ * tested without spawning a child process.
+ *
+ * Defaults preserve AssistantPanel behavior: system prompt is APPENDED
+ * to Claude Code's default (so the AI still sees its tool / MCP /
+ * skill preamble) and built-in tools stay available. The widget
+ * builder modal opts into a stricter mode by passing both
+ * `replaceSystemPrompt: true` (replace the default rather than append
+ * — strips the tool / skill preamble) and `disableTools: true` (deny
+ * all built-in tools so the AI cannot invoke Skill / Bash / Read /
+ * Glob / etc.).
+ *
+ * @param {object}  opts
+ * @param {string=} opts.model
+ * @param {string=} opts.systemPrompt
+ * @param {string=} opts.sessionId
+ * @param {boolean=} opts.replaceSystemPrompt
+ * @param {boolean=} opts.disableTools
+ * @returns {string[]}
+ */
+function buildClaudeCliArgs({
+  model,
+  systemPrompt,
+  sessionId,
+  replaceSystemPrompt = false,
+  disableTools = false,
+} = {}) {
+  const args = [
+    "-p",
+    "--disable-slash-commands",
+    "--permission-mode",
+    "bypassPermissions",
+    "--output-format",
+    "stream-json",
+    "--verbose",
+  ];
+
+  if (disableTools) {
+    // Empty-string value documented in `claude --help` as "disable
+    // all tools". Catches Skill / Bash / Read / Glob / Grep / Edit /
+    // Write — every built-in tool the AI might otherwise invoke from
+    // inside the modal where only text + code-block output is wanted.
+    args.push("--tools", "");
+  }
+
+  if (model) {
+    args.push("--model", model);
+  }
+
+  if (systemPrompt) {
+    // --system-prompt REPLACES the default Claude Code preamble (the
+    // one that introduces tools and auto-loads project skills by
+    // description match). --append-system-prompt KEEPS the default
+    // and adds ours below — fine for the assistant panel where MCP
+    // tools are wanted, wrong for the widget builder modal where
+    // any tool advertisement undermines the no-tools rule.
+    args.push(
+      replaceSystemPrompt ? "--system-prompt" : "--append-system-prompt",
+      systemPrompt,
+    );
+  }
+
+  if (sessionId) {
+    args.push("--resume", sessionId);
+  }
+
+  return args;
+}
+
 const cliController$2 = {
   /**
    * isAvailable
@@ -50390,7 +50500,15 @@ const cliController$2 = {
    * @param {object} params - { model, messages, systemPrompt, maxToolRounds, widgetUuid }
    */
   sendMessage: async (win, requestId, params) => {
-    const { model, messages, systemPrompt, widgetUuid, cwd } = params;
+    const {
+      model,
+      messages,
+      systemPrompt,
+      widgetUuid,
+      cwd,
+      replaceSystemPrompt = false,
+      disableTools = false,
+    } = params;
 
     const binaryPath = resolveCliBinary();
     if (!binaryPath) {
@@ -50403,34 +50521,23 @@ const cliController$2 = {
       return;
     }
 
-    // Build CLI args.
+    // Build CLI args via the pure helper (see top of file). Defaults
+    // preserve the AssistantPanel behavior (append-system-prompt,
+    // tools available, MCP wired). The widget builder modal opts
+    // into `replaceSystemPrompt + disableTools` to lock the AI to
+    // text + code-block output with no tool invocations.
     //
-    // --disable-slash-commands: prevent Claude from auto-triggering project
-    // skills by description match. When running in a project with a
-    // `.claude/skills/<name>/SKILL.md`, Claude would otherwise internalize
-    // that skill's content even when the host app's system prompt says not
-    // to — causing long reasoning loops or silent hangs. We pass only the
-    // caller's `systemPrompt` as context.
-    //
-    // --permission-mode bypassPermissions: in an embedded in-app assistant,
-    // the user has already opted into the configured MCP servers (they
-    // ran `claude mcp add` themselves). Prompting for tool-use approval
-    // on every call produces "I need permission to..." replies instead of
-    // actual actions. Bypassing matches the user's intent — if they
-    // didn't want the assistant to use a tool, they wouldn't have
-    // configured it.
-    //
-    // (We intentionally avoid `--bare` — it also disables keychain reads,
-    // which breaks OAuth login for users authenticated via `claude login`.)
-    const args = [
-      "-p",
-      "--disable-slash-commands",
-      "--permission-mode",
-      "bypassPermissions",
-      "--output-format",
-      "stream-json",
-      "--verbose",
-    ];
+    // The model + systemPrompt + sessionId pieces are added inside
+    // buildClaudeCliArgs; below we only add args that depend on
+    // runtime state (MCP config file paths) the helper can't know.
+    const sessionIdForResume = widgetUuid ? sessions.get(widgetUuid) : null;
+    const args = buildClaudeCliArgs({
+      model,
+      systemPrompt,
+      sessionId: sessionIdForResume,
+      replaceSystemPrompt,
+      disableTools,
+    });
 
     // Auto-wire the hosted Dash MCP server so the assistant can use Dash
     // tools (apply_theme, create_dashboard, add_widget, etc.) without
@@ -50454,9 +50561,15 @@ const cliController$2 = {
     // works for non-Dash queries, and the setup banner remains visible
     // as a manual fallback.
     let mcpConfigFilePath = null;
+    // Skip MCP wiring entirely when the caller has asked for a
+    // tool-free invocation. There's no point loading remote tools
+    // the AI cannot call, and avoiding the temp-file write keeps
+    // the lockdown mode side-effect-free.
     try {
       const mcpDashServerController = mcpDashServerController_1;
-      const status = mcpDashServerController.getStatus?.(win);
+      const status = disableTools
+        ? null
+        : mcpDashServerController.getStatus?.(win);
       if (status?.running) {
         const token = mcpDashServerController.getOrCreateToken?.(win);
         if (token) {
@@ -50511,20 +50624,6 @@ const cliController$2 = {
       mcpConfigFilePath = null;
     };
 
-    if (model) {
-      args.push("--model", model);
-    }
-
-    if (systemPrompt) {
-      args.push("--append-system-prompt", systemPrompt);
-    }
-
-    // Resume existing session for conversation continuity
-    const sessionId = widgetUuid ? sessions.get(widgetUuid) : null;
-    if (sessionId) {
-      args.push("--resume", sessionId);
-    }
-
     // Extract the user message (last user message in the array)
     const lastUserMsg = [...messages].reverse().find((m) => m.role === "user");
     const userText =
@@ -50556,12 +50655,13 @@ const cliController$2 = {
         // files directly without a shell — ENOENT otherwise.
         shell: IS_WINDOWS,
       };
-      if (cwd) {
+      const resolvedCwd = resolveLockdownCwd({ cwd, disableTools });
+      if (resolvedCwd) {
         const fs = require("fs");
-        if (!fs.existsSync(cwd)) {
-          fs.mkdirSync(cwd, { recursive: true });
+        if (!fs.existsSync(resolvedCwd)) {
+          fs.mkdirSync(resolvedCwd, { recursive: true });
         }
-        spawnOpts.cwd = cwd;
+        spawnOpts.cwd = resolvedCwd;
       }
       const spawnCmd = IS_WINDOWS ? windowsQuote(binaryPath) : binaryPath;
       const spawnArgs = IS_WINDOWS ? args.map(windowsQuote) : args;
@@ -50754,7 +50854,11 @@ const cliController$2 = {
 
         if (code !== 0 && code !== null) {
           // Check if resume failed and retry without it
-          if (sessionId && !retried && stderrBuffer.includes("session")) {
+          if (
+            sessionIdForResume &&
+            !retried &&
+            stderrBuffer.includes("session")
+          ) {
             retried = true;
             if (widgetUuid) sessions.delete(widgetUuid);
             // Retry without --resume
@@ -50877,7 +50981,11 @@ const cliController$2 = {
   },
 };
 
-var cliController_1 = cliController$2;
+cliController$3.exports = cliController$2;
+cliController$3.exports.buildClaudeCliArgs = buildClaudeCliArgs;
+cliController$3.exports.resolveLockdownCwd = resolveLockdownCwd;
+
+var cliControllerExports = cliController$3.exports;
 
 /**
  * toolDefinitions.js
@@ -56092,7 +56200,7 @@ var toolHandlers$1 = {
 
 const Anthropic = require$$0$b;
 const mcpController$2 = mcpControllerExports;
-const cliController$1 = cliController_1;
+const cliController$1 = cliControllerExports;
 const toolDefinitions = toolDefinitions$1;
 const toolHandlers = toolHandlers$1;
 const {
@@ -68067,7 +68175,7 @@ const algoliaController = algoliaController_1;
 const openaiController = openaiController_1;
 const menuItemsController = menuItemsController_1;
 const llmController = llmController_1;
-const cliController = cliController_1;
+const cliController = cliControllerExports;
 const dashboardConfigController = dashboardConfigController$1;
 const registryAuthController = registryAuthController$2;
 const registryApiController = registryApiController$3;