@trojs/openapi-dereference 1.1.2 → 1.2.0

package/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@trojs/openapi-dereference",
     "description": "OpenAPI dereference",
-    "version": "1.1.2",
+    "version": "1.2.0",
     "author": {
         "name": "Pieter Wigboldus",
         "url": "https://trojs.org/"

package/src/dereference.js

@@ -1,6 +1,3 @@
-/* eslint-disable sonarjs/cognitive-complexity */
-/* eslint-disable no-param-reassign */
-/* eslint-disable no-restricted-syntax */
 import { klona } from './klona.js'
 import { resolveRefSync } from './resolveRef.js'
 
@@ -9,51 +6,85 @@ import { resolveRefSync } from './resolveRef.js'
  * @typedef {import('./types').DereferencedJSONSchema} DereferencedJSONSchema
  */
 
+const PROHIBITED_KEYS = new Set(['__proto__', 'constructor', 'prototype'])
 const cache = new Map()
 
+/**
+ * Removes prohibited keys from an object (shallow).
+ * @param {object} obj
+ * @returns {object}
+ */
+function filterProhibitedKeys (obj) {
+  return Object.fromEntries(
+    Object.entries(obj).filter(([key]) => !PROHIBITED_KEYS.has(key))
+  )
+}
+
 /**
  * Resolves all $ref pointers in a schema and returns a new schema without any $ref pointers.
- * @param {JSONSchema} schema
- * @returns {DereferencedJSONSchema}
+ * Handles circular references and deeply nested $refs.
+ * @param {JSONSchema} schema - The JSON schema to dereference.
+ * @returns {DereferencedJSONSchema} The dereferenced schema.
  */
 export const dereferenceSync = (schema) => {
-  if (cache.has(schema)) {
-    return cache.get(schema)
-  }
+  if (cache.has(schema)) return cache.get(schema)
+
+  // Filter prohibited keys at the root level
+  const filtered = typeof schema === 'object' && schema !== null && !Array.isArray(schema)
+    ? filterProhibitedKeys(schema)
+    : schema
 
-  const visitedNodes = new Set()
-  const cloned = klona(schema)
+  const cloned = klona(filtered)
+  const seen = new WeakMap()
 
+  /**
+   * Recursively resolves a value (object, array, or primitive).
+   * @param {any} current - The current value to resolve.
+   * @param {string} path - The current JSON pointer path.
+   * @returns {any} The resolved value.
+   */
   const resolve = (current, path) => {
-    if (typeof current === 'object' && current !== null) {
-      // make sure we don't visit the same node twice
-      if (visitedNodes.has(current)) {
-        return current
+    if (typeof current !== 'object' || current === null) return current
+
+    // Handle circular references
+    if (seen.has(current)) return seen.get(current)
+
+    // Handle arrays
+    if (Array.isArray(current)) {
+      const arr = current.map((item, i) => resolve(item, `${path}/${i}`))
+      seen.set(current, arr)
+      return arr
+    }
+
+    // Handle $ref
+    if ('$ref' in current && typeof current.$ref === 'string') {
+      const ref = resolveRefSync(cloned, current.$ref)
+      if (!ref) {
+        return null
+      }
+      if (seen.has(ref)) {
+        return seen.get(ref)
       }
-      visitedNodes.add(current)
-
-      if (Array.isArray(current)) {
-        // array
-        for (let index = 0; index < current.length; index++) {
-          current[index] = resolve(current[index], `${path}/${index}`)
-        }
-      } else {
-        // object
-        if ('$ref' in current && typeof current.$ref === 'string') {
-          let ref = current
-          do {
-            ref = resolveRefSync(cloned, ref.$ref)
-          } while (ref?.$ref)
-          return ref
-        }
-
-        for (const key in current) {
-          current[key] = resolve(current[key], `${path}/${key}`)
-        }
+      if (Array.isArray(ref)) {
+        const resolvedArray = resolve(ref, current.$ref)
+        seen.set(ref, resolvedArray)
+        return resolvedArray
       }
+      const placeholder = {}
+      seen.set(current, placeholder)
+      const resolved = resolve(ref, current.$ref)
+      Object.assign(placeholder, resolved)
+      return resolved
     }
 
-    return current
+    // Handle objects
+    const obj = Object.fromEntries(
+      Object.entries(current)
+        .filter(([key]) => !PROHIBITED_KEYS.has(key))
+        .map(([key, value]) => [key, resolve(value, `${path}/${key}`)])
+    )
+    seen.set(current, obj)
+    return obj
   }
 
   const result = resolve(cloned, '#')