@tritard/waterbrother 0.8.38 → 0.8.40

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tritard/waterbrother",
-  "version": "0.8.38",
+  "version": "0.8.40",
   "description": "Waterbrother: Grok-powered coding CLI with local tools, sessions, operator modes, and approval controls",
   "type": "module",
   "bin": {

package/src/cli.js

@@ -16,6 +16,7 @@ import { computeImpactMap } from "./impact.js";
 import { reviewTurn } from "./reviewer.js";
 import {
   buildFrontendExecutionContext,
+  getFrontendAcceptanceFailure,
   buildFrontendRebuildPrompt,
   buildFrontendRevisionPrompt,
   captureFrontendScreenshot,
@@ -1316,6 +1317,14 @@ async function maybeReviseInteractiveFrontend({
     };
   }
 
+  const acceptanceFailure = getFrontendAcceptanceFailure({
+    frontend: frontendExecutionContext.frontend || null,
+    slop: artifacts.designSlop
+  });
+  if (acceptanceFailure) {
+    throw new Error(acceptanceFailure.reason);
+  }
+
   return { response: activeResponse, receipt: activeReceipt, artifacts };
 }
 

package/src/frontend.js

@@ -257,6 +257,67 @@ const BENCHMARK_STARTERS = {
   ]
 };
 
+const BENCHMARK_STARTER_VARIANTS = {
+  blog: [
+    {
+      key: "architectural-journal",
+      label: "architectural journal",
+      starter: [
+        "Variant shape: severe image-text split with one offset note card and one lean secondary pair.",
+        "Palette should feel mineral, paper, and shadow-driven rather than warm lifestyle-editorial.",
+        "Finish with one restrained final gesture, not a generic footer label."
+      ]
+    },
+    {
+      key: "art-book-minimal",
+      label: "art-book minimal",
+      starter: [
+        "Variant shape: oversized white space, one dominant visual surface, one short text block, one caption-like secondary band.",
+        "Treat typography like exhibition text: sparse, quiet, and deliberate.",
+        "Avoid default editorial chrome entirely; let spacing and crop do the work."
+      ]
+    },
+    {
+      key: "review-folio",
+      label: "review folio",
+      starter: [
+        "Variant shape: folio-like review page with strong masthead mark, one lead essay, and one compact pair of related notes.",
+        "Use stronger typographic contrast and one unexpected compositional move, not a generic archive scaffold.",
+        "Closing section should feel like a designed coda rather than a footer."
+      ]
+    }
+  ],
+  store: [
+    {
+      key: "cold-premium-tech",
+      label: "cold premium tech",
+      starter: [
+        "Variant shape: hard-edged flagship PDP with dark hero, precise specification accents, and a compact proof/guarantee band.",
+        "Use crisp hierarchy, hard contrast, and performance language rather than luxury-lifestyle filler.",
+        "Cart UI should feel real and quiet; no gimmicks, no fake app chrome."
+      ]
+    },
+    {
+      key: "warm-object-craft",
+      label: "warm object craft",
+      starter: [
+        "Variant shape: tactile product story with warm neutral palette, close material crop, and trust/objection handling near the CTA.",
+        "Lead with material, construction, weight, care, and use-case details.",
+        "Keep the page commercially sharp, but let the object feel physical and desirable."
+      ]
+    },
+    {
+      key: "dense-conversion-pdp",
+      label: "dense conversion pdp",
+      starter: [
+        "Variant shape: stronger purchase stack with nearby shipping, returns, warranty, and one compact objection-handling block.",
+        "Use a more aggressive conversion rhythm than the minimalist variants, but keep it authored and clean.",
+        "Hero and cart item surfaces must both feel product-real, not abstract placeholders."
+      ]
+    }
+  ]
+};
+
 const BENCHMARK_FEWSHOT_EXAMPLES = {
   blog: {
     good: [
@@ -351,6 +412,38 @@ function getBenchmarkStarter(siteType, benchmarkMode) {
   return BENCHMARK_STARTERS[siteType] || null;
 }
 
+function stablePromptHash(text = "") {
+  const value = String(text || "");
+  let hash = 0;
+  for (let index = 0; index < value.length; index += 1) {
+    hash = ((hash * 31) + value.charCodeAt(index)) >>> 0;
+  }
+  return hash;
+}
+
+function chooseBenchmarkStarterVariant({ siteType, promptText = "", archetype = "" } = {}) {
+  const variants = BENCHMARK_STARTER_VARIANTS[siteType] || [];
+  if (variants.length === 0) return null;
+  const text = String(promptText || "").toLowerCase();
+  if (siteType === "blog") {
+    if (/\b(?:architecture|architectural|concrete|brutalis|ando|chapel|osaka|kyoto|sao paulo)\b/.test(text)) {
+      return variants.find((variant) => variant.key === "architectural-journal") || variants[0];
+    }
+    if (/\b(?:gallery|art book|art-book|folio|exhibition|museum)\b/.test(text)) {
+      return variants.find((variant) => variant.key === "art-book-minimal") || variants[0];
+    }
+  }
+  if (siteType === "store") {
+    if (/\b(?:audio|headphones|speaker|tech|wireless|anc|bluetooth)\b/.test(text) || archetype === "high-contrast-tech") {
+      return variants.find((variant) => variant.key === "cold-premium-tech") || variants[0];
+    }
+    if (/\b(?:lamp|chair|desk|leather|tote|wallet|wood|ceramic|object)\b/.test(text)) {
+      return variants.find((variant) => variant.key === "warm-object-craft") || variants[0];
+    }
+  }
+  return variants[stablePromptHash(text) % variants.length];
+}
+
 function getBenchmarkExamples(siteType, benchmarkMode) {
   if (!benchmarkMode) return null;
   return BENCHMARK_FEWSHOT_EXAMPLES[siteType] || null;
@@ -499,6 +592,7 @@ export function buildFrontendExecutionContext({ promptText = "", profile = "code
   const assetPolicy = inferAssetPolicy(text);
   const layoutStarter = getLayoutStarter(siteType, archetype);
   const benchmarkStarter = getBenchmarkStarter(siteType, benchmarkMode);
+  const benchmarkVariant = chooseBenchmarkStarterVariant({ siteType, promptText: text, archetype });
   const benchmarkExamples = getBenchmarkExamples(siteType, benchmarkMode);
   const siteTypeRules = getSiteTypeRules(siteType);
   const benchmarkSiteTypeRules = getBenchmarkSiteTypeRules(siteType, benchmarkMode);
@@ -507,6 +601,7 @@ export function buildFrontendExecutionContext({ promptText = "", profile = "code
     `Content mode: ${contentMode}. Asset policy: ${assetPolicy}.`,
     layoutStarter ? `Layout starter: ${layoutStarter[0]}` : "",
     ...(benchmarkStarter ? [`Benchmark starter skeleton:\n- ${benchmarkStarter.join("\n- ")}`] : []),
+    ...(benchmarkVariant ? [`Benchmark starter variant: ${benchmarkVariant.label}\n- ${benchmarkVariant.starter.join("\n- ")}`] : []),
     ...(benchmarkExamples ? [
       `Benchmark few-shot guide:\nGood:\n- ${benchmarkExamples.good.join("\n- ")}\nBad:\n- ${benchmarkExamples.bad.join("\n- ")}`
     ] : []),
@@ -528,6 +623,8 @@ export function buildFrontendExecutionContext({ promptText = "", profile = "code
       assetPolicy,
       layoutStarter: layoutStarter ? layoutStarter[0] : null,
       benchmarkStarter: benchmarkStarter ? benchmarkStarter[0] : null,
+      benchmarkVariant: benchmarkVariant?.label || null,
+      benchmarkVariantStarter: benchmarkVariant?.starter || null,
       benchmarkMode,
       siteTypeRules,
       benchmarkSiteTypeRules
@@ -806,6 +903,24 @@ export function shouldForceFrontendRebuild({ frontend = null, slop = null, revis
   return revisionCount < 2;
 }
 
+export function getFrontendAcceptanceFailure({ frontend = null, slop = null } = {}) {
+  if (!frontend?.benchmarkMode || !slop?.hardBlock) return null;
+  const flags = Array.isArray(slop.flags) ? slop.flags : [];
+  if (frontend.siteType === "store") {
+    const blocking = flags.filter((flag) =>
+      /Tailwind CDN|Font Awesome|placeholder product imagery|placeholder imagery|fake proof or badge chrome|fake keyboard or shortcut chrome|demo behavior|demo page explanation copy|fake cart or checkout fallback behavior|generic luxury-commerce copy/i.test(flag)
+    );
+    if (blocking.length > 0) {
+      return {
+        siteType: frontend.siteType,
+        reason: `benchmark store acceptance failed: ${blocking.join(", ")}`,
+        flags: blocking
+      };
+    }
+  }
+  return null;
+}
+
 export function buildFrontendRevisionPrompt({
   originalPrompt = "",
   designReview = null,
@@ -814,6 +929,7 @@ export function buildFrontendRevisionPrompt({
 } = {}) {
   const siteType = pickByPattern(String(originalPrompt || ""), SITE_TYPES, "landing");
   const benchmarkMode = isBenchmarkFrontendTask(originalPrompt);
+  const benchmarkVariant = chooseBenchmarkStarterVariant({ siteType, promptText: originalPrompt });
   const benchmarkExamples = getBenchmarkExamples(siteType, benchmarkMode);
   const issues = Array.isArray(designReview?.issues) ? designReview.issues.slice(0, 6) : [];
   const nextPass = Array.isArray(designReview?.nextPass) ? designReview.nextPass.slice(0, 6) : [];
@@ -826,6 +942,7 @@ export function buildFrontendRevisionPrompt({
     issues.length > 0 ? `Problems to fix:\n- ${issues.join("\n- ")}` : "",
     visualIssues.length > 0 ? `Visible screenshot problems:\n- ${visualIssues.join("\n- ")}` : "",
     slopFlags.length > 0 ? `Deterministic slop flags:\n- ${slopFlags.join("\n- ")}` : "",
+    benchmarkVariant ? `Preserve this benchmark variant direction: ${benchmarkVariant.label}\n- ${benchmarkVariant.starter.join("\n- ")}` : "",
     benchmarkExamples ? `Benchmark example guide:\nGood:\n- ${benchmarkExamples.good.join("\n- ")}\nBad:\n- ${benchmarkExamples.bad.join("\n- ")}` : "",
     nextPass.length > 0 ? `Revision priorities:\n- ${nextPass.join("\n- ")}` : "",
     visualNextPass.length > 0 ? `Screenshot revision priorities:\n- ${visualNextPass.join("\n- ")}` : "",
@@ -862,6 +979,9 @@ export function buildFrontendRebuildPrompt({
 } = {}) {
   const siteType = pickByPattern(String(originalPrompt || ""), SITE_TYPES, "landing");
   const benchmarkMode = isBenchmarkFrontendTask(originalPrompt);
+  const benchmarkVariant = frontend?.benchmarkVariantStarter?.length
+    ? { label: frontend.benchmarkVariant || "selected benchmark variant", starter: frontend.benchmarkVariantStarter }
+    : chooseBenchmarkStarterVariant({ siteType, promptText: originalPrompt, archetype: frontend?.archetype || "" });
   const benchmarkExamples = getBenchmarkExamples(siteType, benchmarkMode);
   const slopFlags = Array.isArray(slop?.flags) ? slop.flags.slice(0, 8) : [];
   const issues = Array.isArray(designReview?.issues) ? designReview.issues.slice(0, 6) : [];
@@ -871,6 +991,7 @@ export function buildFrontendRebuildPrompt({
     "Rebuild the affected frontend files from scratch within the same contract.",
     `Original task: ${String(originalPrompt || "").trim()}`,
     starter ? `Required starter skeleton:\n- ${starter.join("\n- ")}` : "",
+    benchmarkVariant ? `Required benchmark variant direction: ${benchmarkVariant.label}\n- ${benchmarkVariant.starter.join("\n- ")}` : "",
     benchmarkExamples ? `Benchmark example guide:\nGood:\n- ${benchmarkExamples.good.join("\n- ")}\nBad:\n- ${benchmarkExamples.bad.join("\n- ")}` : "",
     slopFlags.length > 0 ? `Banned patterns that must be removed completely:\n- ${slopFlags.join("\n- ")}` : "",
     issues.length > 0 ? `Design issues to correct in the rebuild:\n- ${issues.join("\n- ")}` : "",

package/src/workflow.js

@@ -3,6 +3,7 @@ import { computeImpactMap, summarizeImpactMap } from "./impact.js";
 import { reviewTurn, challengeReceipt } from "./reviewer.js";
 import {
   buildFrontendExecutionContext,
+  getFrontendAcceptanceFailure,
   buildFrontendRebuildPrompt,
   buildFrontendRevisionPrompt,
   captureFrontendScreenshot,
@@ -253,6 +254,14 @@ export async function runBuildWorkflow({
     };
   }
 
+  const acceptanceFailure = getFrontendAcceptanceFailure({
+    frontend: frontendCtx?.frontend || null,
+    slop: designSlop
+  });
+  if (acceptanceFailure) {
+    throw new Error(acceptanceFailure.reason);
+  }
+
   // Update receipt with impact and review
   const updates = {};
   if (impact) updates.impact = impact;