@tritard/waterbrother 0.8.36 → 0.8.38

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tritard/waterbrother",
-  "version": "0.8.36",
+  "version": "0.8.38",
   "description": "Waterbrother: Grok-powered coding CLI with local tools, sessions, operator modes, and approval controls",
   "type": "module",
   "bin": {

package/src/cli.js

@@ -1219,7 +1219,8 @@ async function maybeReviseInteractiveFrontend({
   while (shouldAutoReviseFrontend({
     designReview: artifacts.designReview,
     slop: artifacts.designSlop,
-    revisionCount
+    revisionCount,
+    frontend: frontendExecutionContext.frontend || null
   })) {
     const passNumber = revisionCount + 1;
     const forceRebuild = shouldForceFrontendRebuild({

package/src/frontend.js

@@ -251,6 +251,7 @@ const BENCHMARK_STARTERS = {
     "Section 4: material/specification or craftsmanship band with objection handling.",
     "Section 5: compact FAQ or guarantee block if still needed.",
     "No Tailwind starter shell, no fake reviews, no fake badges, no placeholder gallery, no emoji or dashed placeholder hero, no alert-based checkout, no keyboard shortcut chrome, no demo footer copy.",
+    "If you do not implement a real cart drawer or checkout flow, keep cart UI passive. Do not use alert/prompt fallbacks that explain what would happen in a real Shopify store.",
     "The hero must merchandise the product with a believable product surface and product-specific benefit language, not generic luxury-commerce filler.",
     "Use a real product image URL or an authored SVG/CSS product silhouette with material/shadow treatment. Never use text-only image placeholders."
   ]
@@ -280,7 +281,7 @@ const BENCHMARK_FEWSHOT_EXAMPLES = {
     ],
     bad: [
       "Generic luxury filler like considered life, timeless essentials, or modern living.",
-      "Demo cart toasts, console narration, or 'in a real Shopify store' copy.",
+      "Demo cart toasts, alert-based cart fallbacks, or 'in a real Shopify store' copy.",
       "Placeholder gallery or weak hero that does not merchandise the product.",
       "Fake proof chrome like bestseller badges, sold-this-month counters, or made-up review totals."
     ]
@@ -296,6 +297,7 @@ const BENCHMARK_GRADERS = {
   ],
   store: [
     { key: "no_demo_js", label: "grader failed: benchmark store still contains demo JS behavior", pattern: /\b(?:alert\(|prompt\(|console\.log|showToast|static demo|in a real shopify store)\b/i, weight: 4, hardBlock: true },
+    { key: "no_fake_cart_fallback", label: "grader failed: benchmark store still uses fake cart or checkout fallback behavior", pattern: /\b(?:cart would open here|would go to checkout|would continue to checkout|would appear here)\b/i, weight: 4, hardBlock: true },
     { key: "no_fake_proof", label: "grader failed: benchmark store still uses fake proof or badge chrome", pattern: /\b(?:best seller|bestseller|\d[\d,]*\s+reviews|\d[\d,]*\s+\w+\s+sold\s+this\s+month|sold this month|as featured in|featured in|trusted by)\b/i, weight: 4, hardBlock: true },
     { key: "no_generic_luxury_copy", label: "grader failed: benchmark store still relies on generic luxury-commerce copy", pattern: /\b(?:objects for a considered life|considered life|timeless essentials|designed for modern living|carry less\. keep more\.)\b/i, weight: 3, hardBlock: true },
     { key: "product_specific_copy", label: "grader failed: benchmark store copy is missing product-specific merchandising detail", missing: /\b(?:material|materials|capacity|fits|carry|pocket|warranty|care|dimensions?|full-grain|canvas|leather|zip|strap)\b/i, weight: 2, hardBlock: false }
@@ -708,6 +710,58 @@ export async function inspectFrontendArtifacts({ cwd, receipt = null, frontend =
         flags.push(`benchmark ${frontend.siteType} still contains demo behavior or explanation copy`);
         score += 3;
       }
+      if (/cdn\.tailwindcss\.com/i.test(htmlText)) {
+        flags.push(`benchmark ${frontend.siteType} still contains Tailwind CDN starter theming`);
+        score += 4;
+      }
+      if (/(?:cdnjs\.cloudflare\.com\/ajax\/libs\/font-awesome|fontawesome)/i.test(htmlText)) {
+        flags.push(`benchmark ${frontend.siteType} still contains Font Awesome chrome`);
+        score += 3;
+      }
+      if (/\b(?:picsum\.photos|placehold\.co|placeholder\.com)\b/i.test(htmlText)) {
+        flags.push(`benchmark ${frontend.siteType} still contains placeholder imagery`);
+        score += 4;
+      }
+      if (/\b(?:metaKey && e\.key === ['"]k['"]|command palette|keyboard shortcuts?)\b/i.test(htmlText)) {
+        flags.push(`benchmark ${frontend.siteType} still contains fake keyboard or shortcut chrome`);
+        score += 4;
+      }
+      if (frontend.siteType === "store") {
+        if (/\b(?:cart would open here|would go to checkout|would continue to checkout|would appear here)\b/i.test(htmlText)) {
+          flags.push("benchmark store still contains fake cart or checkout fallback behavior");
+          score += 4;
+        }
+        if (/\b(?:best seller|bestseller|\d[\d,]*\s+reviews|\d[\d,]*\s+\w+\s+sold\s+this\s+month|sold this month|as featured in|featured in|trusted by)\b/i.test(htmlText)) {
+          flags.push("benchmark store still contains fake proof or badge chrome");
+          score += 4;
+        }
+        if (/\b(?:objects for a considered life|considered life|timeless essentials|designed for modern living|carry less\. keep more\.)\b/i.test(htmlText)) {
+          flags.push("benchmark store still contains generic luxury-commerce copy");
+          score += 3;
+        }
+        if (!/\b(?:material|materials|capacity|fits|carry|pocket|warranty|care|dimensions?|full-grain|canvas|leather|zip|strap)\b/i.test(htmlText)) {
+          flags.push("benchmark store still lacks product-specific merchandising detail");
+          score += 2;
+        }
+      }
+      if (frontend.siteType === "blog") {
+        if (/\bfont-family:\s*system-ui|font-family:\s*-apple-system|BlinkMacSystemFont|Segoe UI\b/i.test(htmlText)) {
+          flags.push("benchmark blog still leans on raw system-ui body typography");
+          score += 2;
+        }
+        if (/\b(?:Archive|Essays|Conversations|Featured Essay|Latest Dispatches|Notes|Print Edition|Submit Work|Journal)\b/i.test(htmlText)) {
+          flags.push("benchmark blog still contains publication-shell framing");
+          score += 4;
+        }
+        if (/\b(?:by [A-Z][A-Za-z]+(?:\s+[A-Z][A-Za-z]+)+|contributor|essay by|interview by)\b/i.test(htmlText)) {
+          flags.push("benchmark blog still contains named bylines or contributor credits");
+          score += 4;
+        }
+        if (/\b(?:architecture of silence|material memory|craft of attention|quiet power|brutalist interior|in praise of slowness|on attention|measure of restraint|deliberate life|value of slowness)\b/i.test(htmlText)) {
+          flags.push("benchmark blog still contains generic editorial filler copy");
+          score += 3;
+        }
+      }
     }
   }
 
@@ -735,8 +789,9 @@ export function mergeFrontendSlop(base = null, extra = null) {
   };
 }
 
-export function shouldAutoReviseFrontend({ designReview = null, slop = null, revisionCount = 0 } = {}) {
-  if (revisionCount >= 3) return false;
+export function shouldAutoReviseFrontend({ designReview = null, slop = null, revisionCount = 0, frontend = null } = {}) {
+  const maxPasses = frontend?.benchmarkMode && frontend?.siteType === "store" ? 5 : 3;
+  if (revisionCount >= maxPasses) return false;
   if (!designReview) return false;
   if (slop?.hardBlock) return true;
   if (designReview.verdict === "weak") return true;
@@ -747,6 +802,7 @@ export function shouldAutoReviseFrontend({ designReview = null, slop = null, rev
 export function shouldForceFrontendRebuild({ frontend = null, slop = null, revisionCount = 0 } = {}) {
   if (!frontend?.benchmarkMode) return false;
   if (!slop?.hardBlock) return false;
+  if (frontend.siteType === "store") return revisionCount < 4;
   return revisionCount < 2;
 }
 

package/src/workflow.js

@@ -198,7 +198,7 @@ export async function runBuildWorkflow({
   let revisionCount = 0;
   const revisionHistory = [];
 
-  while (shouldAutoReviseFrontend({ designReview, slop: designSlop, revisionCount })) {
+  while (shouldAutoReviseFrontend({ designReview, slop: designSlop, revisionCount, frontend: frontendCtx?.frontend || null })) {
     const passNumber = revisionCount + 1;
     const forceRebuild = shouldForceFrontendRebuild({ frontend: frontendCtx?.frontend, slop: designSlop, revisionCount });
     revisionHistory.push({