@tritard/waterbrother 0.8.30 → 0.8.31

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tritard/waterbrother",
-  "version": "0.8.30",
+  "version": "0.8.31",
   "description": "Waterbrother: Grok-powered coding CLI with local tools, sessions, operator modes, and approval controls",
   "type": "module",
   "bin": {

package/src/frontend.js

@@ -55,7 +55,7 @@ const UNIVERSAL_FRONTEND_REMINDERS = [
   "Prefer hand-authored CSS variables and layout rules over generic template utility sprawl when feasible.",
   "Cut fake credibility elements, fake brands, fake testimonials, and filler interface chrome unless explicitly requested.",
   "Do not add fake keyboard shortcuts, fake command palettes, or demo-only interactive chrome unless the interface truly needs them.",
-  "Avoid placeholder image services, Inter/Playfair default pairings, Tailwind CDN starter aesthetics, and generic premium-blog tropes.",
+  "Avoid placeholder image services, Font Awesome CDN chrome, Inter/Playfair default pairings, Tailwind CDN starter aesthetics, and generic premium-blog tropes.",
   "Prefer fewer sections with stronger hierarchy over a long page full of low-value widgets."
 ];
 
@@ -70,15 +70,15 @@ const BENCHMARK_SITE_TYPE_RULES = {
     "Benchmark blog mode: use neutral structural placeholders or concrete subject matter instead of publication worldbuilding or reflective-editorial atmosphere prose.",
     "Benchmark blog mode: do not wrap the page in a generic publication shell like Journal, Featured Essay, Latest Dispatches, Print Edition, Submit Work, or similar magazine-site framing.",
     "Benchmark blog mode: avoid the default editorial scaffold of hero, story list, archive rail, topics grid, and publication footer unless the user explicitly asked for a magazine-style site.",
-    "Benchmark blog mode: do not use Tailwind CDN starter theming, picsum/placehold imagery, or fake keyboard/search chrome."
+    "Benchmark blog mode: do not use Tailwind CDN starter theming, Font Awesome chrome, picsum/placehold imagery, fake keyboard/search chrome, or demo-only modal article previews."
   ],
   store: [
     "Benchmark ecommerce mode: prioritize conversion architecture over editorial styling. The page should sell, not just look clean.",
     "Benchmark ecommerce mode: include proof, objection handling, and trust signals that belong on a real single-product PDP.",
     "Benchmark ecommerce mode: do not leave the main merchandising surface as a literal placeholder or demo box.",
-    "Benchmark ecommerce mode: do not use Tailwind CDN starter theming or placeholder product images such as picsum/placehold on the live merchandising surface.",
-    "Benchmark ecommerce mode: fake command palettes, fake app shortcuts, and unrelated theme chrome are disallowed.",
-    "Benchmark ecommerce mode: fake review counts, fake bestseller labels, and fake as-featured-in proof are disallowed."
+    "Benchmark ecommerce mode: do not use Tailwind CDN starter theming, Font Awesome chrome, or placeholder product images such as picsum/placehold on the live merchandising surface.",
+    "Benchmark ecommerce mode: fake command palettes, fake app shortcuts, demo-only cart gimmicks, and unrelated theme chrome are disallowed.",
+    "Benchmark ecommerce mode: fake review counts, fake bestseller labels, fake sales counters, and fake as-featured-in proof are disallowed."
   ]
 };
 
@@ -240,12 +240,14 @@ const GENERIC_EDITORIAL_LAYOUT_PATTERNS = [
 const SLOP_PATTERNS = [
   { key: "placeholder_images", label: "placeholder image service", pattern: /\b(?:picsum\.photos|placehold\.co|placeholder\.com)\b/i, weight: 3 },
   { key: "tailwind_cdn", label: "Tailwind CDN starter styling", pattern: /cdn\.tailwindcss\.com/i, weight: 2 },
+  { key: "font_awesome_cdn", label: "Font Awesome CDN chrome", pattern: /cdnjs\.cloudflare\.com\/ajax\/libs\/font-awesome|fontawesome/i, weight: 2 },
   { key: "inter_playfair", label: "generic Inter/Playfair premium pairing", pattern: /Inter|Playfair\s+Display/i, weight: 2 },
   { key: "browser_default_type", label: "browser-default serif/sans fallback typography", pattern: /\b(?:Georgia|Times New Roman|serif;|system-ui|BlinkMacSystemFont|Segoe UI|Helvetica|Arial)\b/i, weight: 2 },
   { key: "fake_prestige", label: "fake prestige or publication badge", pattern: /\b(?:featured in|as seen in|forbes|the atlantic|wall street journal|award-winning)\b/i, weight: 3 },
   { key: "fake_founder_lore", label: "fake founder or studio lore", pattern: /\b(?:founded in|est\s+20\d{2}|from the studio|published from a small studio|founder\s*&\s*essayist)\b/i, weight: 2 },
   { key: "newsletter_cliche", label: "generic newsletter promise copy", pattern: /\b(?:no spam, ever|respect your inbox|join the newsletter|subscribe to the journal|receive the next dispatch|quarterly letters from the edge of attention|only the essential)\b/i, weight: 2 },
   { key: "fake_ui_chrome", label: "fake low-value UI chrome", pattern: /\b(?:search|filterCategory|showPostModal|toggleSearch|Latest Stories|Recent Dispatches|command palette would open here|metaKey && e\.key === ['"]k['"])\b/i, weight: 2 },
+  { key: "demo_modal_chrome", label: "demo modal or prompt/alert interaction chrome", pattern: /\b(?:prompt\(|alert\(|modal|demo only|structural preview|select an essay to read a structural preview)\b/i, weight: 2 },
   { key: "premium_blog_trope", label: "generic premium-blog editorial trope", pattern: /\b(?:thoughtful living|slow living|curated reflections|crafted with intention|made with intention|a quiet publication|made with restraint|journal of attention|discipline of seeing|private notes made public)\b/i, weight: 2 },
   { key: "reflective_editorial_copy", label: "generic reflective-editorial copy trope", pattern: /\b(?:quiet architecture of attention|great thinkers understood|value of slowness|the examined life|deliberate cultivation of focus|most radical act|what we have forgotten|how everyday items carry|still matters)\b/i, weight: 2 },
   { key: "fictional_publication_brand", label: "invented publication/author scaffolding", pattern: /\b(?:by [A-Z][a-z]+ [A-Z][a-z]+|photography by [A-Z][a-z]+ [A-Z][a-z]+|journal of attention|vesper|lumen|dispatches|vol\.\s*\d+|winter 20\d{2}|autumn 20\d{2}|spring 20\d{2}|summer 20\d{2}|the quarterly|editorial\.)\b/i, weight: 3 },
@@ -438,14 +440,22 @@ export function detectFrontendSlop({ promptText = "", assistantText = "", receip
     flags.push("benchmark store relied on Tailwind CDN starter theming");
     score += 4;
   }
+  if (siteType === "store" && benchmarkMode && /(?:cdnjs\.cloudflare\.com\/ajax\/libs\/font-awesome|fontawesome)/i.test(haystack)) {
+    flags.push("benchmark store relied on Font Awesome chrome");
+    score += 3;
+  }
   if (siteType === "store" && benchmarkMode && /\b(?:picsum\.photos|placehold\.co|placeholder\.com)\b/i.test(haystack)) {
     flags.push("benchmark store used placeholder product imagery");
     score += 4;
   }
-  if (siteType === "store" && benchmarkMode && /\b(?:best seller|best seller|\d[\d,]*\s+reviews|as featured in|featured in|trusted by|studio engineers approved)\b/i.test(haystack)) {
+  if (siteType === "store" && benchmarkMode && /\b(?:best seller|bestseller|\d[\d,]*\s+reviews|\d[\d,]*\s+\w+\s+sold\s+this\s+month|sold this month|as featured in|featured in|trusted by|studio engineers approved)\b/i.test(haystack)) {
     flags.push("benchmark store used fake proof or badge chrome");
     score += 4;
   }
+  if (siteType === "store" && benchmarkMode && /\b(?:metaKey && e\.key === ['"]k['"]|command palette|keyboard shortcuts?)\b/i.test(haystack)) {
+    flags.push("benchmark store used fake keyboard or shortcut chrome");
+    score += 4;
+  }
   if (siteType === "store" && benchmarkMode && !/\b(?:review|reviews|testimonial|rated|stars?|customers?)\b/i.test(haystack)) {
     flags.push("benchmark store lacks social proof or review architecture");
     score += 2;
@@ -470,10 +480,18 @@ export function detectFrontendSlop({ promptText = "", assistantText = "", receip
     flags.push("benchmark blog relied on Tailwind CDN starter theming");
     score += 4;
   }
+  if (siteType === "blog" && benchmarkMode && /(?:cdnjs\.cloudflare\.com\/ajax\/libs\/font-awesome|fontawesome)/i.test(haystack)) {
+    flags.push("benchmark blog relied on Font Awesome chrome");
+    score += 3;
+  }
   if (siteType === "blog" && benchmarkMode && /\b(?:picsum\.photos|placehold\.co|placeholder\.com)\b/i.test(haystack)) {
     flags.push("benchmark blog used placeholder imagery");
     score += 4;
   }
+  if (siteType === "blog" && benchmarkMode && /\b(?:prompt\(|alert\(|toggleSearch|viewPost\(|modal|structural preview|subscribe)\b/i.test(haystack)) {
+    flags.push("benchmark blog used demo interaction chrome");
+    score += 3;
+  }
   if (/\b(?:command palette would open here|metaKey && e\.key === ['"]k['"]|keyboard accessibility)\b/i.test(haystack)) {
     flags.push("fake keyboard or command-palette gimmick");
     score += 3;
@@ -492,14 +510,14 @@ export function detectFrontendSlop({ promptText = "", assistantText = "", receip
   return {
     score,
     flags,
-    hardBlock: flags.some((flag) => /fictional publication identity|generic publication-shell framing|fake keyboard|reflective-editorial atmosphere|primary merchandising surface as a placeholder|Tailwind CDN starter theming|placeholder product imagery|placeholder imagery|fake proof or badge chrome/.test(flag)),
+    hardBlock: flags.some((flag) => /fictional publication identity|generic publication-shell framing|fake keyboard|reflective-editorial atmosphere|primary merchandising surface as a placeholder|Tailwind CDN starter theming|Font Awesome chrome|placeholder product imagery|placeholder imagery|fake proof or badge chrome|demo interaction chrome/.test(flag)),
     severe: score >= 5,
     summary: flags.length > 0 ? `frontend slop flags: ${flags.join(", ")}` : "no deterministic frontend slop flags"
   };
 }
 
 export function shouldAutoReviseFrontend({ designReview = null, slop = null, revisionCount = 0 } = {}) {
-  if (revisionCount >= 2) return false;
+  if (revisionCount >= 3) return false;
   if (!designReview) return false;
   if (slop?.hardBlock) return true;
   if (designReview.verdict === "weak") return true;
@@ -528,16 +546,18 @@ export function buildFrontendRevisionPrompt({
     visualNextPass.length > 0 ? `Screenshot revision priorities:\n- ${visualNextPass.join("\n- ")}` : "",
     "Do not add new filler sections.",
     "Do not add fake prestige, fake testimonials, fake brands, placeholder-image services, or fictional publication/persona lore unless the user explicitly asked for that worldbuilding.",
+    "Do not use Tailwind CDN or Font Awesome CDN for benchmark pages. Use authored CSS and native SVG or plain text/icon treatment instead.",
     "If this is a blog or editorial site, prefer structural labels and a stronger layout idea over invented magazines, authors, newsletter promises, or atmosphere-copy.",
     "Do not use browser-default serif/sans fallback stacks as the end-state typography. Pick a deliberate type system or simplify until the typography feels intentional.",
     "Remove fake keyboard shortcuts, fake command palettes, and demo-only interaction flourishes that do not help the page.",
     "Cut reflective-editorial filler copy and replace it with either concrete language or neutral structural placeholders.",
     "For benchmark blog tasks, default to neutral structural placeholder content instead of invented publication framing, issue metadata, or named contributors.",
     "For benchmark blog tasks, do not use generic publication-shell labels like Journal, Featured Essay, Latest Dispatches, Print Edition, Submit Work, or publication-footer framing.",
-    "For benchmark blog tasks, do not use Tailwind CDN starter theming, picsum-style placeholder imagery, or fake search/shortcut chrome.",
+    "For benchmark blog tasks, do not use Tailwind CDN starter theming, Font Awesome chrome, picsum-style placeholder imagery, fake search/shortcut chrome, subscribe/newsletter CTA chrome, or demo modal article previews.",
     "For benchmark store tasks, do not leave the product image area as a labeled placeholder. Use product-shaped merchandising composition, proof, and objection-handling blocks instead.",
-    "For benchmark store tasks, do not use Tailwind CDN starter theming, picsum-style placeholder imagery, or fake command-palette behavior.",
-    "For benchmark store tasks, do not invent review counts, bestseller labels, or as-featured-in proof unless the user explicitly requested fictional marketing chrome.",
+    "For benchmark store tasks, do not use Tailwind CDN starter theming, Font Awesome chrome, picsum-style placeholder imagery, or fake command-palette behavior.",
+    "For benchmark store tasks, do not invent review counts, bestseller labels, sold-this-month counters, or as-featured-in proof unless the user explicitly requested fictional marketing chrome.",
+    slop?.hardBlock ? "Hard-fail benchmark patterns are still present. Rebuild the page from scratch if needed rather than preserving those patterns." : "",
     "Reduce section count if needed and push one stronger asymmetrical composition instead of a sequence of balanced blocks.",
     "Simplify the page if needed. Stronger direction with fewer elements is preferred over busier generic output.",
     "Rewrite the weakest sections rather than making superficial tweaks."

package/src/tools.js

@@ -506,11 +506,20 @@ function normalizeContractArgs(args = {}) {
     summary: String(args.summary || "").trim(),
     paths: normalizePathList(args.paths || []),
     commands: uniqueStrings(args.commands || []),
-    verification: uniqueStrings(args.verification || []),
+    verification: uniqueStrings((args.verification || []).map((command) => normalizeVerificationCommand(command))),
     risk: ["low", "medium", "high"].includes(String(args.risk || "").toLowerCase()) ? String(args.risk).toLowerCase() : "medium"
   };
 }
 
+function normalizeVerificationCommand(command) {
+  const raw = String(command || "").trim();
+  if (!raw) return raw;
+  return raw
+    .replace(/(^|[\s("'`])\/desktop(?=\/|$)/gi, `$1${shellEscape(path.join(os.homedir(), "Desktop"))}`)
+    .replace(/(^|[\s("'`])\/downloads(?=\/|$)/gi, `$1${shellEscape(path.join(os.homedir(), "Downloads"))}`)
+    .replace(/(^|[\s("'`])\/documents(?=\/|$)/gi, `$1${shellEscape(path.join(os.homedir(), "Documents"))}`);
+}
+
 function getTouchedPathsForTool(toolName, args = {}) {
   if (toolName === "write_file" || toolName === "replace_in_file" || toolName === "make_directory" || toolName === "delete_path") {
     return normalizePathList([args.path || ""]);