@trim21/personal-pi-extensions 0.1.611 → 0.1.612

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@trim21/personal-pi-extensions",
-  "version": "0.1.611",
+  "version": "0.1.612",
   "type": "module",
   "description": "Custom pi coding-agent extensions: bwrap sandbox, workspace guard, opencode edit, and more",
   "keywords": [
@@ -52,7 +52,7 @@
     "eslint-plugin-import-x": "^4.17.1",
     "eslint-plugin-promise": "7.3.0",
     "eslint-plugin-simple-import-sort": "14.0.0",
-    "eslint-plugin-unicorn": "74.0.0",
+    "eslint-plugin-unicorn": "76.0.0",
     "eslint-plugin-unused-imports": "4.4.1",
     "husky": "^9.1.7",
     "jiti": "^2.7.0",

package/src/aft/tools.ts

@@ -152,7 +152,7 @@ export function registerOutlineTool(pi: ExtensionAPI, ctx: AftToolContext): void
       }
       const rawArgs = compactArgs({
         target: filesMode ? target : resolved,
-        files: filesMode ? true : undefined,
+        files: filesMode || undefined,
         includeTests: params.includeTests,
       });
 
@@ -232,7 +232,7 @@ export function registerZoomTool(pi: ExtensionAPI, ctx: AftToolContext): void {
           1,
           Number.MAX_SAFE_INTEGER,
         ),
-        callgraph: coerceBoolean(params.callgraph) ? true : undefined,
+        callgraph: coerceBoolean(params.callgraph) || undefined,
       });
 
       const subtitle = buildZoomSubtitle(extCtx.cwd, params);

package/src/bwrap/approval-rules.ts

@@ -140,10 +140,15 @@ function collectCommand(node: Node, all: Node[]): BashCommand | undefined {
   // 自身且每次返回新 wrapper，`===` 比较失效会无限递归。
   const nested: BashCommand[] = [];
   for (const descendant of all) {
-    if (descendant === node) continue;
-    if (descendant.startIndex >= node.startIndex && descendant.endIndex <= node.endIndex) {
-      const inner = collectCommand(descendant, all);
-      if (inner) nested.push(inner);
+    if (descendant === node) {
+      continue;
+    }
+    if (descendant.startIndex < node.startIndex || descendant.endIndex > node.endIndex) {
+      continue;
+    }
+    const inner = collectCommand(descendant, all);
+    if (inner) {
+      nested.push(inner);
     }
   }
   return { name, args, raw: node.text, nested };

package/src/bwrap/runtime.ts

@@ -209,11 +209,13 @@ class BashOutput {
       this.tailBytes -= this.tail[0].length;
       this.tail.shift();
     }
-    if (this.tailBytes > BASH_TAIL_LIMIT_BYTES && this.tail.length === 1) {
-      // 单个 chunk 超过上限：截掉头部，只保留尾部
-      this.tail[0] = this.tail[0].subarray(this.tailBytes - BASH_TAIL_LIMIT_BYTES);
-      this.tailBytes = BASH_TAIL_LIMIT_BYTES;
+    if (this.tailBytes <= BASH_TAIL_LIMIT_BYTES || this.tail.length !== 1) {
+      return;
     }
+
+    // 单个 chunk 超过上限：截掉头部，只保留尾部
+    this.tail[0] = this.tail[0].subarray(this.tailBytes - BASH_TAIL_LIMIT_BYTES);
+    this.tailBytes = BASH_TAIL_LIMIT_BYTES;
   }
 
   close(): Promise<void> {

package/src/lib/cli.ts

@@ -304,13 +304,14 @@ export function parseCommand<TFlags extends TObject>(
         );
       }
     }
-    if (typeof raw === "string" && f.kind === "number") {
-      const n = Number(raw);
-      if (Number.isNaN(n)) {
-        return errorResult(spec, `Invalid value for '--${f.key}': '${raw}'`);
-      }
-      rawFlags[f.key] = n;
+    if (typeof raw !== "string" || f.kind !== "number") {
+      continue;
+    }
+    const n = Number(raw);
+    if (Number.isNaN(n)) {
+      return errorResult(spec, `Invalid value for '--${f.key}': '${raw}'`);
     }
+    rawFlags[f.key] = n;
   }
 
   const { min, max } = spec.arity ?? {};

package/src/lib/lsp/lsp.ts

@@ -274,12 +274,13 @@ function validateConfig(config: ResolvedLspConfig, adapters?: LspServerAdapter[]
     adapters ? adapters.map((adapter) => adapter.id) : Object.keys(config.servers),
   );
   const unknown = config.enabled === undefined ? [] : [...config.enabled.difference(available)];
-  if (unknown.length > 0) {
-    const list = [...available].toSorted().join(", ") || "none";
-    throw new Error(
-      `lsp.json: unknown server id in enabled: ${unknown.join(", ")} (available: ${list})`,
-    );
+  if (unknown.length === 0) {
+    return;
   }
+  const list = [...available].toSorted().join(", ") || "none";
+  throw new Error(
+    `lsp.json: unknown server id in enabled: ${unknown.join(", ")} (available: ${list})`,
+  );
 }
 
 /** 合并 watch 段：全局为基底、本地逐字段覆盖；ignore 取并集去重（全局在前）。两边都未配置时返回 undefined，调用方据此省略 watch 键。 */
@@ -764,14 +765,17 @@ export function createLspService(
     updateStatusText();
     const reporter = sessionNotify ?? notify;
     const lastNotified = state.brokenNotifiedAt.get(key);
-    if (reporter && (lastNotified === undefined || now - lastNotified >= notifyIntervalMs)) {
-      state.brokenNotifiedAt.set(key, now);
-      reporter(
-        `LSP server "${serverID}" failed to start for ${root}: ${cause}. ` +
-          `Fix the issue or run /lsp-reload ${serverID} to retry now.`,
-        "error",
-      );
+    const due = lastNotified === undefined || now - lastNotified >= notifyIntervalMs;
+    if (!reporter || !due) {
+      return;
     }
+
+    state.brokenNotifiedAt.set(key, now);
+    reporter(
+      `LSP server "${serverID}" failed to start for ${root}: ${cause}. ` +
+        `Fix the issue or run /lsp-reload ${serverID} to retry now.`,
+      "error",
+    );
   }
 
   /**

package/src/opencode/edit-engine.ts

@@ -119,20 +119,21 @@ const LineTrimmedReplacer: Replacer = function* (content, find) {
         break;
       }
     }
-    if (matches) {
-      let matchStartIndex = 0;
-      for (let k = 0; k < i; k++) {
-        matchStartIndex += originalLines[k].length + 1;
-      }
-      let matchEndIndex = matchStartIndex;
-      for (let k = 0; k < searchLines.length; k++) {
-        matchEndIndex += originalLines[i + k].length;
-        if (k < searchLines.length - 1) {
-          matchEndIndex += 1;
-        }
+    if (!matches) {
+      continue;
+    }
+    let matchStartIndex = 0;
+    for (let k = 0; k < i; k++) {
+      matchStartIndex += originalLines[k].length + 1;
+    }
+    let matchEndIndex = matchStartIndex;
+    for (let k = 0; k < searchLines.length; k++) {
+      matchEndIndex += originalLines[i + k].length;
+      if (k < searchLines.length - 1) {
+        matchEndIndex += 1;
       }
-      yield content.slice(matchStartIndex, matchEndIndex);
     }
+    yield content.slice(matchStartIndex, matchEndIndex);
   }
 };
 
@@ -230,26 +231,29 @@ const BlockAnchorReplacer: Replacer = function* (content, find) {
     } else {
       similarity = 1;
     }
-    if (similarity > maxSimilarity) {
-      maxSimilarity = similarity;
-      bestMatch = candidate;
+    if (similarity <= maxSimilarity) {
+      continue;
     }
+
+    maxSimilarity = similarity;
+    bestMatch = candidate;
   }
-  if (bestMatch && maxSimilarity >= MULTIPLE_CANDIDATES_SIMILARITY_THRESHOLD) {
-    const { startLine, endLine } = bestMatch;
-    let matchStartIndex = 0;
-    for (let k = 0; k < startLine; k++) {
-      matchStartIndex += originalLines[k].length + 1;
-    }
-    let matchEndIndex = matchStartIndex;
-    for (let k = startLine; k <= endLine; k++) {
-      matchEndIndex += originalLines[k].length;
-      if (k < endLine) {
-        matchEndIndex += 1;
-      }
+  if (!bestMatch || maxSimilarity < MULTIPLE_CANDIDATES_SIMILARITY_THRESHOLD) {
+    return;
+  }
+  const { startLine, endLine } = bestMatch;
+  let matchStartIndex = 0;
+  for (let k = 0; k < startLine; k++) {
+    matchStartIndex += originalLines[k].length + 1;
+  }
+  let matchEndIndex = matchStartIndex;
+  for (let k = startLine; k <= endLine; k++) {
+    matchEndIndex += originalLines[k].length;
+    if (k < endLine) {
+      matchEndIndex += 1;
     }
-    yield content.slice(matchStartIndex, matchEndIndex);
   }
+  yield content.slice(matchStartIndex, matchEndIndex);
 };
 
 function normalizeWhitespace(text: string): string {
@@ -370,11 +374,13 @@ const ContextAwareReplacer: Replacer = function* (content, find) {
           for (let k = 1; k < blockLines.length - 1; k++) {
             const blockLine = blockLines[k].trim();
             const findLine = findLines[k].trim();
-            if (blockLine.length > 0 || findLine.length > 0) {
-              totalNonEmptyLines++;
-              if (blockLine === findLine) {
-                matchingLines++;
-              }
+            if (blockLine.length === 0 && findLine.length === 0) {
+              continue;
+            }
+
+            totalNonEmptyLines++;
+            if (blockLine === findLine) {
+              matchingLines++;
             }
           }
           if (totalNonEmptyLines === 0 || matchingLines / totalNonEmptyLines >= 0.5) {

package/src/opencode/ripgrep.ts

@@ -88,10 +88,12 @@ export function runRipgrep<R>(
       }
       if (item === undefined) return;
       items.push(item);
-      if (items.length > options.limit) {
-        state.truncated = true;
-        stop();
+      if (items.length <= options.limit) {
+        return;
       }
+
+      state.truncated = true;
+      stop();
     };
 
     child.stderr.setEncoding("utf8");

package/src/session-name.ts

@@ -171,12 +171,10 @@ export function extractFirstUserPrompt(
   currentPrompt: string,
 ): string | undefined {
   const trimmed = currentPrompt.trim();
-  if (branch.length > 0) {
-    for (const entry of branch) {
-      if (entry.type !== "message") continue;
-      const text = messageText(entry.message?.content);
-      if (text) return text;
-    }
+  for (const entry of branch) {
+    if (entry.type !== "message") continue;
+    const text = messageText(entry.message?.content);
+    if (text) return text;
   }
   return trimmed || undefined;
 }

package/src/spawn-agent.ts

@@ -286,10 +286,12 @@ export function overrideExtensionPaths(tools: string[]): string[] {
   const paths: string[] = [];
   for (const tool of tools) {
     const ext = TOOL_EXTENSION_OVERRIDES[tool];
-    if (ext && !loaded.has(ext)) {
-      loaded.add(ext);
-      paths.push(extensionPath(ext));
+    if (!ext || loaded.has(ext)) {
+      continue;
     }
+
+    loaded.add(ext);
+    paths.push(extensionPath(ext));
   }
   return paths;
 }

package/src/talk/policy.ts

@@ -68,11 +68,12 @@ export class OutboundPolicy {
     this.sentAt.push(this.now());
     this.recentBodies.set(`${body}\u0000${target ?? ""}`, this.now());
     // bound the dedupe map
-    if (this.recentBodies.size > 200) {
-      const cutoff = this.now() - DEDUPE_WINDOW_MS;
-      for (const [key, ts] of this.recentBodies) {
-        if (ts < cutoff) this.recentBodies.delete(key);
-      }
+    if (this.recentBodies.size <= 200) {
+      return;
+    }
+    const cutoff = this.now() - DEDUPE_WINDOW_MS;
+    for (const [key, ts] of this.recentBodies) {
+      if (ts < cutoff) this.recentBodies.delete(key);
     }
   }
 }

package/src/talk/registry.ts

@@ -169,7 +169,8 @@ function pidAlive(pid: number, pidStart?: number): boolean {
   }
   if (pidStart === undefined) return true;
   const start = readStartTime(pid);
-  return start === undefined ? true : start === pidStart;
+  // 读不到启动时间时保守认为「pid 还活着」，只有两边都读到且不同才判定被复用
+  return start === undefined || start === pidStart;
 }
 
 export function presenceOf(record: AgentRecord): Presence {