@trenskow/app 0.9.80 → 0.9.82

package/.vscode/settings.json

@@ -1,18 +1,14 @@
 {
-    "cSpell.words": [
-        "caseit",
-        "concat",
-        "getheader",
-        "getheadernames",
-        "hasheader",
-        "linebreak",
-        "quuries",
-        "removeheader",
-        "setheader",
-        "writehead"
-    ],
-    "[javascript]": {
-        "editor.formatOnSave": true,
-        "editor.formatOnPaste": true
-    }
+	"cSpell.words": [
+		"caseit",
+		"concat",
+		"getheader",
+		"getheadernames",
+		"hasheader",
+		"linebreak",
+		"quuries",
+		"removeheader",
+		"setheader",
+		"writehead"
+	]
 }

package/lib/response.js

@@ -12,24 +12,31 @@ import { ServerResponse } from 'http';
 
 export default class Response extends ServerResponse {
 
-	#headerListeners;
-	#headersProxy;
+	#_headerListeners;
+	#_headersProxy;
+	#_vary;
 
 	constructor(...args) {
 		super(...args);
-		this.#headerListeners = [];
+		this.#_headerListeners = [];
+		this.#_vary = new Set();
+	}
+
+	vary(headerName) {
+		this.#_vary.add(
+			caseit(headerName));
 	}
 
 	get headers() {
-		return this.#headersProxy || (this.#headersProxy = new Proxy(this, {
+		return this.#_headersProxy || (this.#_headersProxy = new Proxy(this, {
 			get: function (target, prop) {
 
 				if (prop === 'on') return (name, callback) => {
 
 					name = caseit(name);
 
-					target.#headerListeners[name] = target.#headerListeners[name] || [];
-					target.#headerListeners[name].push(callback);
+					target.#_headerListeners[name] = target.#_headerListeners[name] || [];
+					target.#_headerListeners[name].push(callback);
 
 				};
 
@@ -58,16 +65,17 @@ export default class Response extends ServerResponse {
 
 		name = caseit(name);
 
-		if (this.#headerListeners[name]?.some((callback) => callback(value) === false)) return;
+		if (this.#_headerListeners[name]?.some((callback) => callback(value) === false)) return;
 
 		return super.setHeader(caseit(name, 'http'), value);
+
 	}
 
 	removeHeader(name) {
 
 		name = caseit(name);
 
-		if (this.#headerListeners[name]?.some((callback) => callback() === false)) return;
+		if (this.#_headerListeners[name]?.some((callback) => callback() === false)) return;
 
 		return super.removeHeader(caseit(name, 'http'));
 
@@ -91,6 +99,13 @@ export default class Response extends ServerResponse {
 		Object.entries(headers || {})
 			.forEach(([name, value]) => this.setHeader(name, value));
 
+		const vary = Array.from(this.#_vary)
+			.filter((headerName) => this.getHeaderNames().includes(headerName));
+
+		if (vary.length) {
+			this.setHeader('vary', vary.map((name) => caseit(name, 'http')).join(', '));
+		}
+
 		super.writeHead(statusCode, statusMessage);
 
 		this.emit('writeHead');

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@trenskow/app",
-	"version": "0.9.80",
+	"version": "0.9.82",
 	"description": "A small HTTP router.",
 	"type": "module",
 	"main": "index.js",
@@ -30,7 +30,7 @@
 		"chai": "^6.2.2",
 		"eslint": "^10.4.0",
 		"globals": "^17.6.0",
-		"mocha": "^11.7.5",
+		"mocha": "^11.7.6",
 		"supertest": "^7.2.2"
 	},
 	"dependencies": {

package/test/index.js

@@ -439,6 +439,27 @@ describe('Application', () => {
 
 		});
 
+		it ('should come back with `Vary` header set.', async () => {
+
+			app.root(
+				new Endpoint()
+					.use(({ response }) => {
+						response.vary('contentLanguage');
+					})
+					.use(({ response }) => {
+						response.headers.contentLanguage = 'en';
+					})
+					.get(() => 'Hello, World!')
+			);
+
+			await request
+				.get('/')
+				.expect('Content-Language', 'en')
+				.expect('Vary', 'Content-Language')
+				.expect(200, 'Hello, World!');
+
+		});
+
 		after(async () => {
 			await app.close({ awaitAllConnections: true });
 		});