@trenskow/app 0.5.12 → 0.6.0

package/README.md

@@ -497,6 +497,10 @@ Supported HTTP methods are the same as those returned by [`http.METHODS`](https:
 
 You can only call these methods once per method per endpoint – calling it multiple times will result in only the last one getting used.
 
+These also ends routing. After a method route has been called, the routing will go strait to the renderer.
+
+> Notice: If no `head` method is implemented on endpoint, `get` will instead be called (if availble). When client requests a `head` the result will be ignored.
+
 > Returns the endpoint.
 
 ###### Parameters
@@ -505,7 +509,7 @@ You can only call these methods once per method per endpoint – calling it mult
 | ---------- | ------------------------------ | :------------------------------------------------------: | :----------------: | :-----------: |
 | `handlers` | A (or an array of) handlers. * | Function, AsyncFunction or Array ([see also](#handlers)) | :white_check_mark: |               |
 
-> \* When more than one handler are provided all but the last are treated as `.use` handlers (but specific to the HTTP method). Only the return value of the last handler is sent to the renderer.
+> \* When more than one handler is provided only the return value of the last handler that returned a non-undefined value will be send the the renderer.
 
 ###### Example
 

package/lib/endpoint.js

@@ -226,7 +226,7 @@ export default class Endpoint extends Router {
 
 				let underlyingMethod = context.request.method.toLowerCase();
 
-				if (underlyingMethod === 'head') {
+				if (underlyingMethod === 'head' && !this._layers.some((layer) => layer.method === 'head')) {
 					underlyingMethod = 'get';
 				}
 
@@ -235,8 +235,9 @@ export default class Endpoint extends Router {
 
 				for (let handler of layer.handlers) {
 					const result = await handler(context);
+					if (layer.underlyingMethod === 'head') return;
 					if (context.state !== 'routing') return;
-					context.result = result;
+					if (typeof result !== 'undefined') context.result = result;
 				}
 
 				return context.result;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@trenskow/app",
-  "version": "0.5.12",
+  "version": "0.6.0",
   "description": "A small HTTP router.",
   "type": "module",
   "main": "index.js",
@@ -25,12 +25,12 @@
   },
   "homepage": "https://github.com/trenskow/app#readme",
   "devDependencies": {
-    "eslint": "^8.2.0",
-    "mocha": "^9.1.3",
-    "supertest": "^6.1.6"
+    "eslint": "^8.13.0",
+    "mocha": "^9.2.2",
+    "supertest": "^6.2.2"
   },
   "dependencies": {
-    "@trenskow/api-error": "^2.2.4",
-    "@trenskow/caseit": "^1.1.1"
+    "@trenskow/api-error": "^2.2.5",
+    "@trenskow/caseit": "^1.1.4"
   }
 }

package/test/index.js

@@ -74,7 +74,24 @@ describe('Application', () => {
 
 		});
 
-		it ('should respond with 200 and no content when a GET method is configured and HEAD is requested.', async () => {
+		it ('should respond with 200 when HEAD method is configured and HEAD method is requested', async () => {
+
+			app.root(
+				new Endpoint()
+					.get(() => 'Hello, World!')
+					.head(({ response }) => {
+						response.statusCode = 204;
+						return 'Hello, World!';
+					})
+			);
+
+			await request
+				.head('/')
+				.expect(204, undefined);
+
+		});
+
+		it ('should respond with 200 and no content when a GET method is configured (but no HEAD method) and HEAD is requested.', async () => {
 
 			app.root(
 				new Endpoint()
@@ -93,7 +110,9 @@ describe('Application', () => {
 				new Endpoint()
 					.get(() => 'Ignore this!')
 					.post(() => 'Not used')
-					.get(() => 'Hello, World!')
+					.get(
+						() => 'Hello, World!',
+						() => { /* Ignore this */ })
 			);
 
 			await request