@trendai-crem/claude-skills 0.6.3 → 0.7.0

package/cli.js

@@ -57,7 +57,7 @@ if (externalFailed.length > 0) {
   console.warn(`\nWARN: ${externalFailed.length} external source(s) failed — team skills installed successfully.`);
 }
 
-// Configure auto-update hook in ~/.claude/settings.json
+// Configure update-check hooks
 setupAutoUpdate();
 
 function setupAutoUpdate() {
@@ -65,34 +65,31 @@ function setupAutoUpdate() {
     readFileSync(join(__dir, 'package.json'), 'utf8')
   );
 
-  const homeDir = homedir();
-  const claudeDir = join(homeDir, '.claude');
-  const hooksDir = join(claudeDir, 'hooks');
-  const cacheDir = join(homeDir, '.cache');
-  const hookScript = join(hooksDir, 'auto-update-claude-skills.sh');
-  const stampFile = join(cacheDir, 'claude-skills-update.json');
+  const claudeDir    = join(homedir(), '.claude');
+  const hooksDir     = join(claudeDir, 'hooks');
+  const hookScript   = join(hooksDir, 'auto-update-claude-skills.sh');
+  const stampFile    = join(homedir(), '.cache', 'claude-skills-version-check.json');
   const settingsPath = join(claudeDir, 'settings.json');
 
-  // Write the auto-update hook script
   mkdirSync(hooksDir, { recursive: true });
+  mkdirSync(join(homedir(), '.cache'), { recursive: true });
   writeFileSync(hookScript, buildHookScript(stampFile, installedVersion), { mode: 0o755 });
 
-  // Merge SessionStart hook into ~/.claude/settings.json (idempotent)
+  // Merge hooks into ~/.claude/settings.json (idempotent)
   let settings = {};
   if (existsSync(settingsPath)) {
     try {
       settings = JSON.parse(readFileSync(settingsPath, 'utf8'));
     } catch (err) {
-      // Back up corrupt file rather than silently overwriting
       const backup = `${settingsPath}.bak.${Date.now()}`;
       copyFileSync(settingsPath, backup);
-      console.warn(`\nWARN: ~/.claude/settings.json has invalid JSON — backed up to ${backup}`);
-      console.warn('A fresh settings file will be created with the auto-update hook only.');
-      console.warn('Manually merge your settings from the backup if needed.\n');
+      console.warn(`\nWARN: ~/.claude/settings.json has invalid JSON — backed up to ${backup}\n`);
     }
   }
 
   settings.hooks ??= {};
+
+  // SessionStart — check once at session start
   settings.hooks.SessionStart ??= [];
   settings.hooks.SessionStart = settings.hooks.SessionStart.filter(
     e => !e.hooks?.some(h => typeof h.command === 'string' && h.command === hookScript)
@@ -101,158 +98,63 @@ function setupAutoUpdate() {
     hooks: [{ type: 'command', command: hookScript }]
   });
 
-  // Atomic write — prevents corruption if process is killed mid-write
+  // UserPromptSubmit — periodic in-session check (throttled by stamp file)
+  settings.hooks.UserPromptSubmit ??= [];
+  settings.hooks.UserPromptSubmit = settings.hooks.UserPromptSubmit.filter(
+    e => !e.hooks?.some(h => typeof h.command === 'string' && h.command === hookScript)
+  );
+  settings.hooks.UserPromptSubmit.push({
+    hooks: [{ type: 'command', command: hookScript, async: true }]
+  });
+
+  // Atomic write
   const tmpPath = join(tmpdir(), `claude-settings-${process.pid}.json`);
   writeFileSync(tmpPath, JSON.stringify(settings, null, 2) + '\n');
   renameSync(tmpPath, settingsPath);
 
-  if (process.platform === 'darwin') {
-    const launchAgentsDir = join(homeDir, 'Library', 'LaunchAgents');
-    const launchdPlistPath = join(
-      launchAgentsDir,
-      'com.trendai.claude-skills-updater.plist'
-    );
-    const launchdLogPath = join(cacheDir, 'claude-skills-launchd.log');
-    const plistTmpPath = join(tmpdir(), `claude-skills-launchd-${process.pid}.plist`);
-
-    mkdirSync(cacheDir, { recursive: true });
-    mkdirSync(launchAgentsDir, { recursive: true });
-
-    // Unload existing agent before writing new plist — ensures reinstall applies updated config
-    try {
-      execFileSync('launchctl', ['unload', launchdPlistPath], { stdio: 'pipe' });
-    } catch (_) {
-      // Not yet loaded — expected on first install
-    }
-
-    // Bake current PATH into plist so npm/npx are findable in launchd's stripped environment
-    const launchdPath = process.env.PATH ?? '/usr/local/bin:/usr/bin:/bin';
-    writeFileSync(
-      plistTmpPath,
-      buildLaunchAgentPlist(hookScript, launchdLogPath, launchdPath)
-    );
-    renameSync(plistTmpPath, launchdPlistPath);
-
-    try {
-      execFileSync('launchctl', ['load', '-w', launchdPlistPath], { stdio: 'pipe' });
-    } catch (error) {
-      const details = error.stderr?.toString().trim() || error.stdout?.toString().trim();
-      console.warn(`\nWARN: launchctl load failed — agent may need manual activation.${details ? ` ${details}` : ''}`);
-    }
-  }
-
-  const schedule = process.platform === 'darwin'
-    ? 'every 24h via launchd and at session start'
-    : 'daily at session start';
-  console.log(`\n✓ Auto-update configured (runs ${schedule})`);
+  console.log('\n✓ Update-check hooks configured (SessionStart + UserPromptSubmit)');
 }
 
 function buildHookScript(stampFile, installedVersion) {
-  // Validate installedVersion is semver before embedding in bash
   if (!/^\d+\.\d+\.\d+(-[\w.]+)?$/.test(installedVersion)) {
     throw new Error(`Invalid version format in package.json: ${installedVersion}`);
   }
 
-  const notifyFile = stampFile.replace('.json', '-pending-notification.txt');
-
   return `#!/usr/bin/env bash
-# Auto-update @trendai-crem/claude-skills — runs at session start and via launchd (macOS).
+# claude-skills update check — runs at session start and periodically during session.
+# If a newer version is available, outputs a systemMessage notification (no auto-install).
 set -euo pipefail
 
 STAMP="${stampFile}"
-NOTIFY="${notifyFile}"
 PACKAGE="@trendai-crem/claude-skills"
-MIN_INTERVAL=$((60 * 60 * 24))
-LOG="$(dirname "$STAMP")/claude-skills-update.log"
+INSTALLED="${installedVersion}"
+MIN_INTERVAL=$((60 * 60 * 2))  # check at most every 2h
 
 mkdir -p "$(dirname "$STAMP")"
 
-# Show pending update notification from previous background update
-if [ -f "$NOTIFY" ]; then
-  cat "$NOTIFY"
-  rm -f "$NOTIFY"
-fi
-
-# Read stamp using sys.argv to avoid shell injection
+# Throttle: skip if checked recently
 LAST_TS=0
-CURRENT_VER="${installedVersion}"
 if [ -f "$STAMP" ]; then
   LAST_TS=$(python3 -c "import json,sys; print(json.load(open(sys.argv[1])).get('ts',0))" "$STAMP" 2>/dev/null || echo 0)
-  CURRENT_VER=$(python3 -c "import json,sys; print(json.load(open(sys.argv[1])).get('version',sys.argv[2]))" "$STAMP" "${installedVersion}" 2>/dev/null || echo "${installedVersion}")
 fi
-
-# Guard against corrupt stamp values
 [[ "$LAST_TS" =~ ^[0-9]+$ ]] || LAST_TS=0
 
 NOW=$(date +%s)
 [ $(( NOW - LAST_TS )) -lt $MIN_INTERVAL ] && exit 0
 
-# Write timestamp now to prevent parallel session runs
-python3 -c "import json,sys; json.dump({'ts': int(sys.argv[1]), 'version': sys.argv[2]}, open(sys.argv[3],'w'))" "$NOW" "$CURRENT_VER" "$STAMP"
+# Update timestamp
+python3 -c "import json,sys; json.dump({'ts': int(sys.argv[1])}, open(sys.argv[2],'w'))" "$NOW" "$STAMP"
 
+# Check latest version on npm
 LATEST=$(npm view "$PACKAGE" version 2>/dev/null || echo "")
-{ [ -z "$LATEST" ] || [ "$LATEST" = "$CURRENT_VER" ]; } && exit 0
-
-# Validate LATEST is semver before executing
-[[ "$LATEST" =~ ^[0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9.]+)?$ ]] || { echo "[$(date -Iseconds)] Invalid version from npm: $LATEST" >> "$LOG"; exit 1; }
-
-# Update in background — use nohup+disown so launchd doesn't kill child on job exit
-echo "🔄 Updating claude-skills: $CURRENT_VER → $LATEST (background)"
-echo "[$(date -Iseconds)] Updating $CURRENT_VER → $LATEST" >> "$LOG"
-STAMP_V="$STAMP" NOTIFY_V="$NOTIFY" LOG_V="$LOG" NOW_V="$NOW" \
-  PKG_V="\${PACKAGE}" LATEST_V="\${LATEST}" OLD_V="$CURRENT_VER" \
-  nohup bash -s << 'UPDATER' >> "$LOG" 2>&1 &
-  INSTALL_DIR="$(mktemp -d)"
-  if npm install --prefix "$INSTALL_DIR" "$PKG_V@$LATEST_V" --silent \
-     && node "$INSTALL_DIR/node_modules/$PKG_V/cli.js"; then
-    rm -rf "$INSTALL_DIR"
-    python3 -c "import json,sys; json.dump({'ts': int(sys.argv[1]), 'version': sys.argv[2]}, open(sys.argv[3],'w'))" "$NOW_V" "$LATEST_V" "$STAMP_V"
-    echo "[$(date -Iseconds)] Update successful"
-    echo "✓ claude-skills updated: $OLD_V → $LATEST_V" > "$NOTIFY_V"
-    osascript -e "display notification \"Updated to $LATEST_V\" with title \"claude-skills\"" 2>/dev/null || true
-  else
-    rm -rf "$INSTALL_DIR"
-    echo "[$(date -Iseconds)] Update failed — will retry next session"
-  fi
-UPDATER
-disown
-`;
-}
+[ -z "$LATEST" ] && exit 0
+[ "$LATEST" = "$INSTALLED" ] && exit 0
 
-function escapeXml(value) {
-  return value
-    .replaceAll('&', '&amp;')
-    .replaceAll('<', '&lt;')
-    .replaceAll('>', '&gt;')
-    .replaceAll('"', '&quot;')
-    .replaceAll("'", '&apos;');
-}
+# Validate semver
+[[ "$LATEST" =~ ^[0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9.]+)?$ ]] || exit 0
 
-function buildLaunchAgentPlist(hookScript, logPath, envPath) {
-  return `<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
-  <key>Label</key>
-  <string>com.trendai.claude-skills-updater</string>
-  <key>ProgramArguments</key>
-  <array>
-    <string>${escapeXml(hookScript)}</string>
-  </array>
-  <key>EnvironmentVariables</key>
-  <dict>
-    <key>PATH</key>
-    <string>${escapeXml(envPath)}</string>
-  </dict>
-  <key>RunAtLoad</key>
-  <false/>
-  <key>StartInterval</key>
-  <integer>86400</integer>
-  <key>StandardOutPath</key>
-  <string>${escapeXml(logPath)}</string>
-  <key>StandardErrorPath</key>
-  <string>${escapeXml(logPath)}</string>
-</dict>
-</plist>
+# Notify via Claude Code systemMessage (shows in UI)
+printf '{"systemMessage": "claude-skills update available: %s → %s\\nRun: npx @trendai-crem/claude-skills@latest"}' \
+  "$INSTALLED" "$LATEST"
 `;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@trendai-crem/claude-skills",
-  "version": "0.6.3",
+  "version": "0.7.0",
   "description": "Claude Code skills installer for the trendai-crem team",
   "license": "UNLICENSED",
   "repository": {