@trebco/treb 32.6.4 → 32.6.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@trebco/treb",
-  "version": "32.6.4",
+  "version": "32.6.6",
   "license": "LGPL-3.0-or-later",
   "homepage": "https://treb.app",
   "repository": {

package/treb-base-types/src/value-type.ts

@@ -166,23 +166,22 @@ export enum ValueType {
   // OK we use it all the time now
   object = 5,
 
+  function = 6, // why was this inserted in the middle?
+
   // error is a STRING VALUE... object errors are layered on top? is that 
   // correct? (...) it sort of makes sense... since we have separate typing
-  error = 6,
+  error = 7,
 
   // complex is pretty stable by now
-  complex = 7,
+  complex = 8,
 
   // this is new though. this is not a cell value, it's 
   // only for union types. perhaps we should move or rename 
   // this array, and then cells could have a subset?
-  array = 8,
+  array = 9,
 
   // adding DQ to union
-  dimensioned_quantity = 9,
-
-  // new for lambdas
-  function = 10,
+  dimensioned_quantity = 10,
 
 }
 

package/treb-calculator/src/functions/base-functions.ts

@@ -366,9 +366,9 @@ export const BaseFunctionLibrary: FunctionMap = {
 
       if (integer) {
         const range = max - min + 1;
-        for (let i = 0; i < rows; i++) {
+        for (let i = 0; i < columns; i++) {
           const row: UnionValue[] = [];
-          for (let j = 0; j < columns; j++) {
+          for (let j = 0; j < rows; j++) {
             row.push({
               type: ValueType.number,
               value: Math.floor(Math.random() * range + min),
@@ -380,9 +380,9 @@ export const BaseFunctionLibrary: FunctionMap = {
       else {
         const range = max - min;
 
-        for (let i = 0; i < rows; i++) {
+        for (let i = 0; i < columns; i++) {
           const row: UnionValue[] = [];
-          for (let j = 0; j < columns; j++) {
+          for (let j = 0; j < rows; j++) {
             row.push({
               type: ValueType.number,
               value: Math.random() * range + min,
@@ -391,7 +391,7 @@ export const BaseFunctionLibrary: FunctionMap = {
           value.push(row);
         }
       }
-
+      
       return {
         type: ValueType.array,
         value,

package/treb-calculator/src/functions/statistics-functions.ts

@@ -486,7 +486,7 @@ export const StatisticsFunctionLibrary: FunctionMap = {
   'Norm.S.Inv': {
     description: 'Inverse of the standard normal cumulative distribution', 
     arguments: [
-      {name: 'probability'},
+      {name: 'probability', unroll: true },
     ],
     xlfn: true,
     fn: (q: number): UnionValue => {

package/treb-data-model/src/data_model.ts

@@ -105,7 +105,14 @@ export class DataModel {
     }
     
     const sheet = this.sheets.ID(sheet_name);
-    return this.named.Get_(parts[1], sheet || 0, true); // require scope in this case
+
+    // Q: why require scope in this case? if there _is_ a global name,
+    // and no scoped name, why not return that? that seems to be the 
+    // behavior in excel, although I can't be sure
+
+    // test: default false
+
+    return this.named.Get_(parts[1], sheet || 0, false); // true); // require scope in this case
 
 
   }

package/treb-data-model/src/named.ts

@@ -201,14 +201,17 @@ export class NamedRangeManager {
    * that implies that if there are both, we'll prefer the scoped name.
    * 
    * now possible to require scope, for qualified scoped names 
+   * 
+   * Q: why require scope? what's the benefit of that? (...)
+   * 
    */
   public Get_(name: string, scope: number, require_scope = false) {
-
+     
     if (require_scope) {
       return this.named.get(this.ScopedName(name, scope));
     }
    
-    return this.named.get(this.ScopedName(name, scope)) || this.named.get(name.toLowerCase());
+    return this.named.get(this.ScopedName(name, scope)) ?? this.named.get(name.toLowerCase());
   }
 
   /**

package/treb-embed/style/tab-bar.scss

@@ -59,6 +59,12 @@
       margin: 0;
       overflow-x: scroll;
       overflow-y: hidden;
+      
+      scrollbar-width: none; /* For Firefox */
+      &::-webkit-scrollbar {
+        display: none;
+      }
+
     }
 
     &[hidden] {