@trebco/treb 27.11.1 → 27.11.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@trebco/treb",
-  "version": "27.11.1",
+  "version": "27.11.4",
   "license": "LGPL-3.0-or-later",
   "homepage": "https://treb.app",
   "repository": {

package/treb-embed/src/embedded-spreadsheet.ts

@@ -565,12 +565,33 @@ export class EmbeddedSpreadsheet {
     // this one should not be done for a split view, but we should still
     // do it if the toll flag is set, and storage key is set. 
 
+    // FIXME: shouldn't this gate on dirty? (...)
+    // ALSO: check if we can use a different event. see
+    //
+    // https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event#usage_notes
+    //
+    // and, including the alternatives:
+    //
+    // https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event
+    //
+
     if (this.options.local_storage && !options.model ) {
+
+      window.addEventListener('visibilitychange', event => {
+        if (document.visibilityState === 'hidden') {
+          if (this.options.local_storage && this.dirty) {
+            this.SaveLocalStorage(this.options.local_storage);
+          }
+        }
+      });
+
+      /*
       window.addEventListener('beforeunload', () => {
-        if (this.options.local_storage) {
+        if (this.options.local_storage && this.dirty) {
           this.SaveLocalStorage(this.options.local_storage);
         }
       });
+      */
     }
 
     let container: HTMLElement | undefined;
@@ -5077,9 +5098,27 @@ export class EmbeddedSpreadsheet {
 
       // console.info(json);
 
+      // why are we saving this here? and should we not route
+      // through the method? I guess the question should be, is
+      // the visibilitychange handler not sufficient to save the
+      // file? (...)
+
+      // I would prefer to just save once, on visibilitychange -> hidden.
+      // the problem is that this method gets called on "data" events,
+      // which should not trigger saving. we could check the flag?
+
+      // if this does come back, (1) use a method -- maybe split the 
+      // SaveLocalStorage method in two, and call the inner half (because
+      // we've already serialized); and (2) gate on dirty.
+
+      // but for the time being we're removing it.
+
+      /*
       if (this.options.local_storage) {
         localStorage.setItem(this.options.local_storage, json);
       }
+      */
+
       if (this.options.undo) {
         this.PushUndo(json, undo_selection, false);
       }

package/treb-embed/style/overlay-editor.scss

@@ -90,6 +90,15 @@
       white-space: nowrap;
       position: relative;
       // -webkit-user-modify: read-write;
+
+      // this fixes the firefox issue (firefox removing spaces), but 
+      // I'm not sure if it will cause other problems. for the overlay
+      // editor we're trapping CR, so it shouldn't be a typing problem --
+      // it might be an issue on paste though. also need to check safari
+      // with pre here.
+
+      white-space: pre; 
+
     }
 
     /** fix for firefox layout bug */

package/treb-grid/src/editors/editor.ts

@@ -1113,6 +1113,35 @@ export class Editor<E = FormulaEditorEvent> extends EventSource<E|FormulaEditorE
 
     const Consume = (element: Node, range: Range) => {
 
+      // it only seems to happen in firefox, but sometimes we'll get 
+      // a non-text node that is the start container and endcontainer.
+      //
+      // in that case we need to interpret the endOffset as nodes, not 
+      // characters. that's what's causing the firefox issues. I guess
+      // that applies to startoffset as well? 
+
+      // not sure if this is bugged or what but when we hit this case,
+      // it's always "all the text in there" regardless of the offsets.
+      // not sure what the offsets are even referring to, since we get
+      // offsets > the number of child nodes. is this a bug in firefox?
+
+      if (element === range.startContainer && element === range.endContainer && !(element instanceof Text)) {
+
+        /*
+        if (range.startOffset !== 0 || range.endOffset !== 0) {
+          console.info("warn offset", range.startOffset, range.endOffset);
+          console.info(element);
+        }
+        */
+
+        complete[0] = complete[1] = true;
+
+        result[0] += element.textContent;
+        result[1] += element.textContent;
+
+        return;
+      }
+
       if (element === range.startContainer) {
         result[0] += (element.textContent || '').substring(0, range.startOffset);
         complete[0] = true;