@trawlme/cli 3.12.0 → 3.12.1

package/dist/lib/skills.d.ts

@@ -1,198 +1,23 @@
 export declare function getBundledSkillsVersion(): string;
 export declare function listBundledSkills(): string[];
-/**
- * #184 defect 1 — the ownership-refusal thrown below serves two different
- * audiences on two different channels, and one string can't correctly serve
- * both:
- *
- *  - A human who just typed `trawl skills install`/`update` reaches this via
- *    an uncaught throw (index.ts's generic error path prints `.message`
- *    verbatim) — that reader can decide whether to add `--force`, so the
- *    guidance belongs on this channel. `.message` (below) keeps it.
- *  - `bootstrapSkillsOnLogin` also catches this exact throw and relays its
- *    text into `skipped[].reason`, which `login.ts` prints to stderr — a
- *    channel this feature's own doc comments say must never carry a command
- *    phrased as an instruction, because this CLI is driven by AI agents and
- *    this platform can feed a CLI's own stderr back into an agent's own
- *    context. `Pass --force to overwrite it anyway` is exactly that kind of
- *    instruction: an agent "obeying" it calls `installSkill`'s own
- *    `rmSync(recursive)` on a directory the user owns and trawl did not
- *    create — the destroy-the-user's-files incident this class of bug
- *    produces.
- *
- * `.relayableReason` carries the identical fact — this path exists, trawl
- * did not create it, so it was left untouched — with the imperative sentence
- * removed, for every channel that is not a direct, synchronous reply to a
- * human's own typed command.
- */
 export declare class SkillOwnershipRefusalError extends Error {
     readonly relayableReason: string;
     constructor(dest: string);
 }
-/**
- * Ownership guard (#73, extended #86 finding 7): this does `rmSync(recursive)`
- * on the target dir before reinstalling, so it must never do that to a dir
- * the CLI didn't install. `autoUpdateInstalledSkills()` already checks this
- * itself before ever calling here (it skips marker-less dirs outright), but
- * the explicit `trawl skills install`/`update` commands used to call straight
- * through with no such check — a pre-existing user-authored
- * `.claude/skills/<name>` dir that happens to collide with a bundled skill
- * name would get silently deleted and overwritten. A missing `.version`
- * marker on an EXISTING dest now refuses the install/reinstall unless
- * `force` is passed.
- */
 export declare function installSkill(name: string, scope: 'user' | 'local', opts?: {
     force?: boolean;
 }): string;
 export declare function uninstallSkill(name: string, scope: 'user' | 'local'): string | null;
 export declare function getInstalledVersion(name: string, scope: 'user' | 'local'): string | null;
 export declare function isSkillInstalled(name: string, scope: 'user' | 'local'): boolean;
-/**
- * #86 review — orphan cleanup. The re-sync loop in autoUpdateInstalledSkills
- * iterates listBundledSkills() — the NEW package's names only. When a bundled
- * skill is RENAMED between package versions (1.0.0 shipped `trawl`, 1.3.1
- * renamed it `trawl-cli`), the old marker-owned dir is never visited again: a
- * stale ghost skill teaching outdated CLI usage stays installed forever,
- * alongside the new one. This sweeps each scope's skills base dir for
- * installed dirs that (a) carry a `.version` marker — the same ownership
- * proof as everywhere else; a marker-less user-authored dir is NEVER touched,
- * whatever its name — and (b) are no longer in the bundled set, and removes
- * them with one honest stderr line (same style as the re-sync line).
- * Returns the removed names (for the explicit `skills update` path to
- * summarize).
- */
 export declare function removeOrphanedSkills(scope: 'user' | 'local'): string[];
-/**
- * Re-installs any CLI-owned skill whose installed version doesn't match the
- * bundled one, and removes CLI-owned skills that are no longer bundled at all
- * (renamed/dropped upstream — see removeOrphanedSkills). Called on CLI
- * startup to keep skills in sync with the CLI version. Never throws —
- * failures are silent so they don't break unrelated commands.
- *
- * Ownership guard (#73): `installSkill` does `rmSync(recursive)` on the target
- * dir, so this MUST only ever touch dirs the CLI itself installed. Proof of
- * ownership is a `.version` marker. A user-created `.claude/skills/<name>` dir
- * that happens to collide with a bundled skill name carries no marker, so it is
- * left untouched instead of being silently deleted + overwritten.
- *
- * Opt-out: `TRAWL_SKILLS_SYNC=0` disables auto-sync entirely (mirrors
- * `TRAWL_TELEMETRY=0`), for users who manage their skills by hand.
- */
 export declare function autoUpdateInstalledSkills(): void;
-/**
- * #184 — one line, reused everywhere the CLI installs a skill mid-invocation
- * (login's bootstrap below, lib/skillsNudge.ts's two nudges): skills are
- * discovered at Claude Code SESSION START, so a skill written to disk right
- * now is invisible to whatever session is already running. Stated as a
- * fact, never an imperative ("restart Claude Code") — this text can be
- * relayed into an AI agent's own context (this CLI's whole incident was an
- * agent driving it), and a command phrased there must never read as an
- * instruction the agent is being told to obey.
- */
 export declare const RESTART_CLAUDE_CODE_NOTE = "Claude Code must be restarted to see them \u2014 skills are loaded at session start, not mid-session.";
-/**
- * #184 — pure gate shared by every skills-related write/print that must
- * never fire under `--json` (a machine consumer needs pure stdout and there
- * is no human reading a suggestion anyway), on a non-TTY invocation (a CI
- * runner or an agent driving this CLI as a subprocess has no Claude Code
- * session to discover a newly-installed skill in the first place), or when
- * `TRAWL_SKILLS_SYNC=0` (the existing auto-sync opt-out, extended here: a
- * user who manages skills by hand does not want the CLI touching that dir
- * for ANY reason — install or nudge alike). Every signal is a parameter,
- * exactly like lib/tips.ts's `isReferralTipDue`, so this is testable
- * without mocking env/TTY. `isTTY`'s exact definition (stdout-only vs
- * stdin+stdout) is the CALLER's call — see bootstrapSkillsOnLogin below vs
- * lib/skillsNudge.ts for the two different answers this codebase already
- * gives elsewhere (confirm.ts's `isInteractive` vs tips.ts's own check).
- */
 export declare function isSkillsActionAllowed(opts: {
     json?: boolean;
     isTTY: boolean;
     optedOut: boolean;
 }): boolean;
-/**
- * #184 — the "install on login, and only there" half of the never-installed
- * bootstrap (see the module doc comment on `autoUpdateInstalledSkills`
- * above for the "elsewhere: suggest, never install" half, which lives in
- * lib/skillsNudge.ts instead). `autoUpdateInstalledSkills` deliberately
- * never installs (`if (!isSkillInstalled) continue`) — it only keeps an
- * EXISTING install in sync. A user who has never run any `trawl skills`
- * command and never logged in before this shipped has nothing installed at
- * all, and nothing in the CLI's startup path ever puts anything there: the
- * CLI is competent, the agent reading its skills is not — the incident this
- * issue exists to prevent. `login` is the one intentional human setup
- * moment (the only place a human types credentials), so it is the ONLY
- * place this function is ever called from (see commands/login.ts) — never
- * from the generic startup path.
- *
- * Gated by `isSkillsActionAllowed` exactly like every other skills-related
- * side effect: a non-interactive `trawl login` (CI's `TRAWL_TOKEN=x trawl
- * login --json`, or any non-TTY invocation) writes nothing — that machine
- * has no Claude Code session to discover a skill in, and `--json`'s stdout
- * contract has no room for a plain-text confirmation line anyway. Also
- * skipped entirely under `TRAWL_SKILLS_SYNC=0`.
- *
- * Installs every bundled skill NOT YET OWNED by trawl at `scope` (default
- * 'user' — the global location a fresh `npx @trawlme/cli login` writes to;
- * 'local' is opt-in via the same --local convention `trawl skills install`
- * already uses everywhere else, kept for parity/tests). "Owned" means a
- * readable `.version` marker (#184 review MAJOR — NOT mere path existence:
- * see below for why that distinction matters here). One skill's install
- * throwing must never blank out the others (#91's posture, applied here):
- * each is wrapped individually, and the function reports exactly what
- * landed. Returns `null` (nothing written, nothing to report) ONLY when
- * gated out, or when every bundled skill is already owned (the re-sync
- * loop above already keeps an existing install's version current) — the
- * genuine "nothing to do" case. Never throws — a broken bootstrap must
- * never turn a successful login into a failed one.
- *
- * #184 review (BLOCK + MAJOR) — two cases used to collapse into the exact
- * same `null`/silence as genuine "nothing to do":
- *
- *  1. (BLOCK) Every install attempt failing outright (an unwritable
- *     `~/.claude/skills`, e.g.) used to return `null` — indistinguishable
- *     from "already installed" or "never attempted at all" on a first-run
- *     machine, the precise false-success shape #184 exists to prevent.
- *  2. (MAJOR) A bundled skill name colliding with a PRE-EXISTING,
- *     marker-less directory the CLI doesn't own. The action set here used
- *     to be computed from `isSkillInstalled` (mere `existsSync`), which
- *     can't tell "we already installed this" from "something else already
- *     lives at this path" — a foreign dir was silently read as "already
- *     installed, nothing to do", so `installSkill`'s ownership-refusal
- *     guard was never even reached and the collision went unreported
- *     anywhere. The action set below is computed from *ownership*
- *     (`getInstalledVersion(...) !== null`) instead, so a foreign
- *     collision is genuinely attempted — hits the same guard `installSkill`
- *     already enforces elsewhere, throws, and is captured below — rather
- *     than silently skipped as if it were a prior trawl install.
- *
- * Whenever there was anything to attempt, the result is now ALWAYS a
- * non-null object reporting both what landed (`installed`) and what didn't
- * (`skipped`, each with a RELAYABLE reason — see `SkillOwnershipRefusalError`
- * above: the ownership-refusal case reports `.relayableReason` [fact only,
- * no `--force` imperative], every other throw [skill-not-found, raw fs
- * errors like EACCES] reports `.message` as before, since those were never
- * imperative to begin with), so `login.ts` can print an honest, distinct
- * line for a skip instead of falling through to the generic "not installed"
- * nudge as if login had done nothing, or silently omitting a name from the
- * success line as if it had never been requested.
- *
- * #184 defect 2 — `error` (present whenever the function returns non-null)
- * distinguishes a THIRD case from both "nothing to do" (`null`) and "one or
- * more skills failed" (`skipped`): "could not even determine what to
- * install" — `listBundledSkills()` returning an empty list (its own
- * contract silently swallows a missing/renamed `skills/` dir into `[]`; see
- * its doc comment) or `getSkillsPackageRoot()` throwing outright (the
- * `@trawlme/skills` package itself unresolvable — a broken node_modules
- * entry). Both used to fall through to `notOwned.length === 0` or the outer
- * catch below, landing on the exact same `null` as a fully-up-to-date
- * install — a genuinely corrupted bundle produced ZERO signal, not even a
- * failed-attempt line, because nothing was ever attempted. `error` is
- * `null` on every ordinary path (including genuine "all already owned",
- * which still short-circuits to the `null` return below) and non-null only
- * for this diagnostic-failure case, where `installed`/`skipped` are both
- * empty because no skill name was ever known to attempt.
- */
 export declare function bootstrapSkillsOnLogin(opts?: {
     json?: boolean;
     isTTY?: boolean;

package/dist/lib/skills.js

@@ -24,31 +24,6 @@ function getSkillsBase(scope) {
     const base = scope === 'local' ? join(process.cwd(), '.claude') : join(homedir(), '.claude');
     return join(base, 'skills');
 }
-/**
- * #184 defect 1 — the ownership-refusal thrown below serves two different
- * audiences on two different channels, and one string can't correctly serve
- * both:
- *
- *  - A human who just typed `trawl skills install`/`update` reaches this via
- *    an uncaught throw (index.ts's generic error path prints `.message`
- *    verbatim) — that reader can decide whether to add `--force`, so the
- *    guidance belongs on this channel. `.message` (below) keeps it.
- *  - `bootstrapSkillsOnLogin` also catches this exact throw and relays its
- *    text into `skipped[].reason`, which `login.ts` prints to stderr — a
- *    channel this feature's own doc comments say must never carry a command
- *    phrased as an instruction, because this CLI is driven by AI agents and
- *    this platform can feed a CLI's own stderr back into an agent's own
- *    context. `Pass --force to overwrite it anyway` is exactly that kind of
- *    instruction: an agent "obeying" it calls `installSkill`'s own
- *    `rmSync(recursive)` on a directory the user owns and trawl did not
- *    create — the destroy-the-user's-files incident this class of bug
- *    produces.
- *
- * `.relayableReason` carries the identical fact — this path exists, trawl
- * did not create it, so it was left untouched — with the imperative sentence
- * removed, for every channel that is not a direct, synchronous reply to a
- * human's own typed command.
- */
 export class SkillOwnershipRefusalError extends Error {
     relayableReason;
     constructor(dest) {
@@ -58,18 +33,6 @@ export class SkillOwnershipRefusalError extends Error {
         this.relayableReason = `"${dest}" already exists and was not installed by trawl (no .version marker) — left untouched.`;
     }
 }
-/**
- * Ownership guard (#73, extended #86 finding 7): this does `rmSync(recursive)`
- * on the target dir before reinstalling, so it must never do that to a dir
- * the CLI didn't install. `autoUpdateInstalledSkills()` already checks this
- * itself before ever calling here (it skips marker-less dirs outright), but
- * the explicit `trawl skills install`/`update` commands used to call straight
- * through with no such check — a pre-existing user-authored
- * `.claude/skills/<name>` dir that happens to collide with a bundled skill
- * name would get silently deleted and overwritten. A missing `.version`
- * marker on an EXISTING dest now refuses the install/reinstall unless
- * `force` is passed.
- */
 export function installSkill(name, scope, opts = {}) {
     const src = join(getSkillsPackageRoot(), 'skills', name);
     if (!existsSync(src)) {
@@ -77,12 +40,6 @@ export function installSkill(name, scope, opts = {}) {
     }
     const dest = join(getSkillsBase(scope), name);
     if (existsSync(dest)) {
-        // #91 — an unreadable `.version` (e.g. EISDIR from a directory instead of
-        // a file, a corrupted/interrupted install) is NOT proof of ownership
-        // either — treat it exactly like a missing marker (unowned) instead of
-        // letting the raw fs error crash the whole batch (`skills install`/
-        // `update` with no skill argument loops over every bundled skill; one
-        // malformed dest must not block installing the others).
         let installedVersion;
         try {
             installedVersion = getInstalledVersion(name, scope);
@@ -117,20 +74,6 @@ export function getInstalledVersion(name, scope) {
 export function isSkillInstalled(name, scope) {
     return existsSync(join(getSkillsBase(scope), name));
 }
-/**
- * #86 review — orphan cleanup. The re-sync loop in autoUpdateInstalledSkills
- * iterates listBundledSkills() — the NEW package's names only. When a bundled
- * skill is RENAMED between package versions (1.0.0 shipped `trawl`, 1.3.1
- * renamed it `trawl-cli`), the old marker-owned dir is never visited again: a
- * stale ghost skill teaching outdated CLI usage stays installed forever,
- * alongside the new one. This sweeps each scope's skills base dir for
- * installed dirs that (a) carry a `.version` marker — the same ownership
- * proof as everywhere else; a marker-less user-authored dir is NEVER touched,
- * whatever its name — and (b) are no longer in the bundled set, and removes
- * them with one honest stderr line (same style as the re-sync line).
- * Returns the removed names (for the explicit `skills update` path to
- * summarize).
- */
 export function removeOrphanedSkills(scope) {
     const base = getSkillsBase(scope);
     if (!existsSync(base))
@@ -144,15 +87,10 @@ export function removeOrphanedSkills(scope) {
                 continue;
         }
         catch {
-            continue; // raced away / unreadable — nothing to clean
+            continue;
         }
         if (bundled.has(name))
             continue;
-        // No `.version` marker → not ours → never delete it. Read is wrapped:
-        // a weird `.version` (e.g. a directory instead of a file → EISDIR on
-        // readFileSync) must skip only THIS entry, not blow up the whole sweep —
-        // a single malformed install must never leave every other entry
-        // unswept. (#88 item 12)
         let installedVersion;
         try {
             installedVersion = getInstalledVersion(name, scope);
@@ -168,22 +106,6 @@ export function removeOrphanedSkills(scope) {
     }
     return removed;
 }
-/**
- * Re-installs any CLI-owned skill whose installed version doesn't match the
- * bundled one, and removes CLI-owned skills that are no longer bundled at all
- * (renamed/dropped upstream — see removeOrphanedSkills). Called on CLI
- * startup to keep skills in sync with the CLI version. Never throws —
- * failures are silent so they don't break unrelated commands.
- *
- * Ownership guard (#73): `installSkill` does `rmSync(recursive)` on the target
- * dir, so this MUST only ever touch dirs the CLI itself installed. Proof of
- * ownership is a `.version` marker. A user-created `.claude/skills/<name>` dir
- * that happens to collide with a bundled skill name carries no marker, so it is
- * left untouched instead of being silently deleted + overwritten.
- *
- * Opt-out: `TRAWL_SKILLS_SYNC=0` disables auto-sync entirely (mirrors
- * `TRAWL_TELEMETRY=0`), for users who manage their skills by hand.
- */
 export function autoUpdateInstalledSkills() {
     if (process.env['TRAWL_SKILLS_SYNC'] === '0')
         return;
@@ -193,14 +115,6 @@ export function autoUpdateInstalledSkills() {
             for (const scope of ['user', 'local']) {
                 if (!isSkillInstalled(name, scope))
                     continue;
-                // #91 — mirrors removeOrphanedSkills' guard below: a weird `.version`
-                // marker (e.g. a directory instead of a file, from a corrupted /
-                // interrupted install) throws EISDIR on readFileSync. Without this
-                // per-entry guard, that throw was caught by this function's OUTER
-                // try/catch (below) — which aborts the ENTIRE function, so every
-                // remaining bundled skill silently stopped syncing AND the orphan
-                // sweep (removeOrphanedSkills, called after this loop) never ran
-                // either. Must skip only THIS entry, never abort the whole sweep.
                 let installed;
                 try {
                     installed = getInstalledVersion(name, scope);
@@ -208,53 +122,22 @@ export function autoUpdateInstalledSkills() {
                 catch {
                     continue;
                 }
-                // No `.version` marker → not ours → never delete it.
                 if (installed === null)
                     continue;
                 if (installed === bundledVersion)
                     continue;
                 installSkill(name, scope);
-                // One honest line so a destructive-looking re-sync is never silent.
-                // stderr keeps stdout clean for --json consumers.
                 process.stderr.write(`trawl: re-synced skill "${name}" (${scope}) ${installed} → ${bundledVersion}\n`);
             }
         }
-        // Migration gap (#86 review): also drop marker-owned dirs whose skill
-        // was renamed/removed upstream, or they linger as stale ghosts forever.
         for (const scope of ['user', 'local']) {
             removeOrphanedSkills(scope);
         }
     }
     catch {
-        // Silent: skill auto-update should never block the CLI
     }
 }
-/**
- * #184 — one line, reused everywhere the CLI installs a skill mid-invocation
- * (login's bootstrap below, lib/skillsNudge.ts's two nudges): skills are
- * discovered at Claude Code SESSION START, so a skill written to disk right
- * now is invisible to whatever session is already running. Stated as a
- * fact, never an imperative ("restart Claude Code") — this text can be
- * relayed into an AI agent's own context (this CLI's whole incident was an
- * agent driving it), and a command phrased there must never read as an
- * instruction the agent is being told to obey.
- */
 export const RESTART_CLAUDE_CODE_NOTE = 'Claude Code must be restarted to see them — skills are loaded at session start, not mid-session.';
-/**
- * #184 — pure gate shared by every skills-related write/print that must
- * never fire under `--json` (a machine consumer needs pure stdout and there
- * is no human reading a suggestion anyway), on a non-TTY invocation (a CI
- * runner or an agent driving this CLI as a subprocess has no Claude Code
- * session to discover a newly-installed skill in the first place), or when
- * `TRAWL_SKILLS_SYNC=0` (the existing auto-sync opt-out, extended here: a
- * user who manages skills by hand does not want the CLI touching that dir
- * for ANY reason — install or nudge alike). Every signal is a parameter,
- * exactly like lib/tips.ts's `isReferralTipDue`, so this is testable
- * without mocking env/TTY. `isTTY`'s exact definition (stdout-only vs
- * stdin+stdout) is the CALLER's call — see bootstrapSkillsOnLogin below vs
- * lib/skillsNudge.ts for the two different answers this codebase already
- * gives elsewhere (confirm.ts's `isInteractive` vs tips.ts's own check).
- */
 export function isSkillsActionAllowed(opts) {
     if (opts.json)
         return false;
@@ -264,89 +147,6 @@ export function isSkillsActionAllowed(opts) {
         return false;
     return true;
 }
-/**
- * #184 — the "install on login, and only there" half of the never-installed
- * bootstrap (see the module doc comment on `autoUpdateInstalledSkills`
- * above for the "elsewhere: suggest, never install" half, which lives in
- * lib/skillsNudge.ts instead). `autoUpdateInstalledSkills` deliberately
- * never installs (`if (!isSkillInstalled) continue`) — it only keeps an
- * EXISTING install in sync. A user who has never run any `trawl skills`
- * command and never logged in before this shipped has nothing installed at
- * all, and nothing in the CLI's startup path ever puts anything there: the
- * CLI is competent, the agent reading its skills is not — the incident this
- * issue exists to prevent. `login` is the one intentional human setup
- * moment (the only place a human types credentials), so it is the ONLY
- * place this function is ever called from (see commands/login.ts) — never
- * from the generic startup path.
- *
- * Gated by `isSkillsActionAllowed` exactly like every other skills-related
- * side effect: a non-interactive `trawl login` (CI's `TRAWL_TOKEN=x trawl
- * login --json`, or any non-TTY invocation) writes nothing — that machine
- * has no Claude Code session to discover a skill in, and `--json`'s stdout
- * contract has no room for a plain-text confirmation line anyway. Also
- * skipped entirely under `TRAWL_SKILLS_SYNC=0`.
- *
- * Installs every bundled skill NOT YET OWNED by trawl at `scope` (default
- * 'user' — the global location a fresh `npx @trawlme/cli login` writes to;
- * 'local' is opt-in via the same --local convention `trawl skills install`
- * already uses everywhere else, kept for parity/tests). "Owned" means a
- * readable `.version` marker (#184 review MAJOR — NOT mere path existence:
- * see below for why that distinction matters here). One skill's install
- * throwing must never blank out the others (#91's posture, applied here):
- * each is wrapped individually, and the function reports exactly what
- * landed. Returns `null` (nothing written, nothing to report) ONLY when
- * gated out, or when every bundled skill is already owned (the re-sync
- * loop above already keeps an existing install's version current) — the
- * genuine "nothing to do" case. Never throws — a broken bootstrap must
- * never turn a successful login into a failed one.
- *
- * #184 review (BLOCK + MAJOR) — two cases used to collapse into the exact
- * same `null`/silence as genuine "nothing to do":
- *
- *  1. (BLOCK) Every install attempt failing outright (an unwritable
- *     `~/.claude/skills`, e.g.) used to return `null` — indistinguishable
- *     from "already installed" or "never attempted at all" on a first-run
- *     machine, the precise false-success shape #184 exists to prevent.
- *  2. (MAJOR) A bundled skill name colliding with a PRE-EXISTING,
- *     marker-less directory the CLI doesn't own. The action set here used
- *     to be computed from `isSkillInstalled` (mere `existsSync`), which
- *     can't tell "we already installed this" from "something else already
- *     lives at this path" — a foreign dir was silently read as "already
- *     installed, nothing to do", so `installSkill`'s ownership-refusal
- *     guard was never even reached and the collision went unreported
- *     anywhere. The action set below is computed from *ownership*
- *     (`getInstalledVersion(...) !== null`) instead, so a foreign
- *     collision is genuinely attempted — hits the same guard `installSkill`
- *     already enforces elsewhere, throws, and is captured below — rather
- *     than silently skipped as if it were a prior trawl install.
- *
- * Whenever there was anything to attempt, the result is now ALWAYS a
- * non-null object reporting both what landed (`installed`) and what didn't
- * (`skipped`, each with a RELAYABLE reason — see `SkillOwnershipRefusalError`
- * above: the ownership-refusal case reports `.relayableReason` [fact only,
- * no `--force` imperative], every other throw [skill-not-found, raw fs
- * errors like EACCES] reports `.message` as before, since those were never
- * imperative to begin with), so `login.ts` can print an honest, distinct
- * line for a skip instead of falling through to the generic "not installed"
- * nudge as if login had done nothing, or silently omitting a name from the
- * success line as if it had never been requested.
- *
- * #184 defect 2 — `error` (present whenever the function returns non-null)
- * distinguishes a THIRD case from both "nothing to do" (`null`) and "one or
- * more skills failed" (`skipped`): "could not even determine what to
- * install" — `listBundledSkills()` returning an empty list (its own
- * contract silently swallows a missing/renamed `skills/` dir into `[]`; see
- * its doc comment) or `getSkillsPackageRoot()` throwing outright (the
- * `@trawlme/skills` package itself unresolvable — a broken node_modules
- * entry). Both used to fall through to `notOwned.length === 0` or the outer
- * catch below, landing on the exact same `null` as a fully-up-to-date
- * install — a genuinely corrupted bundle produced ZERO signal, not even a
- * failed-attempt line, because nothing was ever attempted. `error` is
- * `null` on every ordinary path (including genuine "all already owned",
- * which still short-circuits to the `null` return below) and non-null only
- * for this diagnostic-failure case, where `installed`/`skipped` are both
- * empty because no skill name was ever known to attempt.
- */
 export function bootstrapSkillsOnLogin(opts = {}) {
     try {
         const optedOut = process.env['TRAWL_SKILLS_SYNC'] === '0';
@@ -359,9 +159,6 @@ export function bootstrapSkillsOnLogin(opts = {}) {
             bundled = listBundledSkills();
         }
         catch (err) {
-            // getSkillsPackageRoot() threw (require.resolve failed — the
-            // `@trawlme/skills` package itself isn't resolvable). Report as a
-            // diagnostic failure, not the outer catch's generic `null`.
             return {
                 installed: [],
                 skipped: [],
@@ -370,10 +167,6 @@ export function bootstrapSkillsOnLogin(opts = {}) {
             };
         }
         if (bundled.length === 0) {
-            // The package resolved but reports zero skills — in practice this
-            // package always ships at least one, so an empty list here is
-            // corruption (e.g. its `skills/` dir renamed/deleted underneath it),
-            // not a legitimate "nothing to do".
             return {
                 installed: [],
                 skipped: [],
@@ -386,9 +179,6 @@ export function bootstrapSkillsOnLogin(opts = {}) {
                 return getInstalledVersion(name, scope) === null;
             }
             catch {
-                // An unreadable `.version` (e.g. EISDIR) is no more proof of
-                // ownership than a missing one — treat it as actionable too, same
-                // as installSkill's own owned-check does (#91's posture).
                 return true;
             }
         });
@@ -402,11 +192,6 @@ export function bootstrapSkillsOnLogin(opts = {}) {
                 installed.push(name);
             }
             catch (err) {
-                // One bad skill (e.g. a marker-less foreign dir refusing overwrite,
-                // or an EACCES on an unwritable skills dir) must not blank the
-                // others — skip it, keep going, but never drop WHY silently: the
-                // caller needs this to tell "attempted and failed" apart from
-                // "nothing to do".
                 const reason = err instanceof SkillOwnershipRefusalError
                     ? err.relayableReason
                     : err instanceof Error

package/dist/lib/skillsNudge.d.ts

@@ -1,10 +1,5 @@
 export declare const SKILLS_NUDGE_TEXT = "Claude skills not installed \u2014 `trawl skills install` installs them (Claude Code must be restarted to see them \u2014 skills are loaded at session start, not mid-session.)";
 export declare const AUTH_WALL_SKILLS_NUDGE_TEXT = "This looks like a login wall and Claude skills are not installed \u2014 `trawl skills install` installs the guidance for it too (Claude Code must be restarted to see them \u2014 skills are loaded at session start, not mid-session.)";
-/**
- * Pure gate — true when the throttled, generic "elsewhere" suggestion
- * should print. Every external signal is a parameter, exactly like
- * isReferralTipDue, so this is testable without mocking fs/env/Date.
- */
 export declare function isSkillsNudgeDue(opts: {
     json?: boolean;
     isTTY: boolean;
@@ -13,21 +8,9 @@ export declare function isSkillsNudgeDue(opts: {
     lastShownAt: number;
     now: number;
 }): boolean;
-/**
- * Best-effort generic nudge (#184 point 2) — called once per CLI invocation
- * from index.ts's runCli, on every command. Never throws.
- */
 export declare function maybeSuggestSkillsInstall(opts?: {
     json?: boolean;
 }): void;
-/**
- * Safety-net nudge (#184 point 5) — called from `doctor`/`run-info` right
- * when the run they just showed carries a live `failureKind:'auth'` verdict
- * (see commands/doctor.ts's `isAuthWall`). Deliberately unthrottled by the
- * 7-day timestamp — see this module's doc comment for why — but still
- * capped to one nudge per process via the same `nudgedThisProcess` flag the
- * generic nudge sets. Never throws.
- */
 export declare function maybeSuggestSkillsForAuthWall(opts?: {
     json?: boolean;
 }): void;