@travetto/image 5.0.0-rc.7 → 5.0.0-rc.9

package/README.md

@@ -15,7 +15,7 @@ yarn add @travetto/image
 
 This module provides functionality for image resizing, and png optimization. This is primarily meant to be used in conjunction with other modules, like the [Asset](https://github.com/travetto/travetto/tree/main/module/asset#readme "Modular library for storing and retrieving binary assets") module or the [Email Compilation Support](https://github.com/travetto/travetto/tree/main/module/email-compiler#readme "Email compiling module") module. It can also be invoked directly as needed (as it can be very handy for batch processing images on the command line). 
 
-The utility's primary structure revolves around the [CommandOperation](https://github.com/travetto/travetto/tree/main/module/command/src/command.ts#L12) from the [Command](https://github.com/travetto/travetto/tree/main/module/command#readme "Support for executing complex commands at runtime.") module.  The [CommandOperation](https://github.com/travetto/travetto/tree/main/module/command/src/command.ts#L12)  allows for declaration of a local executable, and a fall-back docker container (mainly meant for development).  The [ImageConverter](https://github.com/travetto/travetto/tree/main/module/image/src/convert.ts#L37) utilizes [ImageMagick](https://imagemagick.org/index.php), [pngquant](https://pngquant.org/), and  [Jpegoptim](https://github.com/tjko/jpegoptim) as the backing for image resizing and png compression, respectively.
+The utility's primary structure revolves around the [CommandOperation](https://github.com/travetto/travetto/tree/main/module/command/src/command.ts#L12) from the [Command](https://github.com/travetto/travetto/tree/main/module/command#readme "Support for executing complex commands at runtime.") module.  The [CommandOperation](https://github.com/travetto/travetto/tree/main/module/command/src/command.ts#L12)  allows for declaration of a local executable, and a fall-back docker container (mainly meant for development).  The [ImageConverter](https://github.com/travetto/travetto/tree/main/module/image/src/convert.ts#L38) utilizes [ImageMagick](https://imagemagick.org/index.php), [pngquant](https://pngquant.org/), and  [Jpegoptim](https://github.com/tjko/jpegoptim) as the backing for image resizing and png compression, respectively.
 
 **Code: Simple Image Resize**
 ```typescript

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@travetto/image",
-  "version": "5.0.0-rc.7",
+  "version": "5.0.0-rc.9",
   "description": "Image support, resizing, and optimization",
   "keywords": [
     "images",
@@ -23,8 +23,8 @@
     "directory": "module/image"
   },
   "dependencies": {
-    "@travetto/runtime": "^5.0.0-rc.7",
-    "@travetto/command": "^5.0.0-rc.7"
+    "@travetto/runtime": "^5.0.0-rc.9",
+    "@travetto/command": "^5.0.0-rc.9"
   },
   "travetto": {
     "displayName": "Image"

package/src/convert.ts

@@ -5,6 +5,7 @@ import { ChildProcess } from 'node:child_process';
 import { pipeline } from 'node:stream/promises';
 
 import { CommandOperation } from '@travetto/command';
+import { castTo } from '@travetto/runtime';
 
 /**
  * Image output options
@@ -48,7 +49,7 @@ export class ImageConverter {
    * Compressor
    */
   static PNG_COMPRESSOR = new CommandOperation({
-    containerImage: 'agregad/pngquant',
+    containerImage: 'agregad/pngquant:latest',
     localCheck: ['pngquant', ['-h']]
   });
 
@@ -62,16 +63,11 @@ export class ImageConverter {
 
   static async #stream<T extends ImageType>(proc: ChildProcess, input: T): Promise<T> {
     if (Buffer.isBuffer(input)) {
-      const [_, output] = await Promise.all([
-        pipeline(Readable.from(input), proc.stdin!),
-        toBuffer(proc.stdout!)
-      ]);
-      // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-      return output as T;
+      Readable.from(input).pipe(proc.stdin!);
+      return castTo(toBuffer(proc.stdout!));
     } else {
       input.pipe(proc.stdin!); // Start the process
-      // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-      return proc.stdout! as T;
+      return castTo(proc.stdout);
     }
   }
 
@@ -90,7 +86,7 @@ export class ImageConverter {
   }
 
   /**
-   * Optimize png using pngquant
+   * Optimize image
    */
   static async optimize<T extends ImageType>(format: 'png' | 'jpeg', image: T): Promise<T> {
     let proc: ChildProcess;