@travetto/eslint 6.0.0-rc.1 → 6.0.0

package/README.md

@@ -24,14 +24,14 @@ In a new project, the first thing that will need to be done, post installation,
 ```bash
 $ trv lint:register
 
-Wrote eslint config to <workspace-root>/eslint.config.js
+Wrote eslint config to <workspace-root>/eslint.config.cjs
 ```
 
 This is the file the linter will use, and any other tooling (e.g. IDEs).
 
 **Code: Sample configuration**
 ```javascript
-process.env.TRV_MANIFEST = './.trv/output/node_modules/@travetto/eslint';
+process.env.TRV_MANIFEST = './.trv/output/node_modules/@travetto/mono-repo';
 
 const { buildConfig } = require('./.trv/output/node_modules/@travetto/eslint/support/bin/eslint-config.js');
 const { RuntimeIndex } = require('./.trv/output/node_modules/@travetto/runtime/__index__.js');

package/__index__.ts

@@ -1 +1 @@
-export * from './support/bin/types';
+export * from './support/bin/types.ts';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@travetto/eslint",
-  "version": "6.0.0-rc.1",
+  "version": "6.0.0",
   "description": "ES Linting Rules",
   "keywords": [
     "eslint",
@@ -24,17 +24,17 @@
     "directory": "module/eslint"
   },
   "dependencies": {
-    "@eslint/js": "^9.19.0",
-    "@stylistic/eslint-plugin": "^3.0.1",
-    "@travetto/runtime": "^6.0.0-rc.1",
+    "@eslint/js": "^9.25.1",
+    "@stylistic/eslint-plugin": "^4.2.0",
+    "@travetto/runtime": "^6.0.0",
     "@types/eslint": "^9.6.1",
-    "@types/eslint__js": "^8.42.3",
-    "@typescript-eslint/eslint-plugin": "^8.23.0",
-    "@typescript-eslint/parser": "^8.23.0",
-    "eslint": "^9.19.0"
+    "@typescript-eslint/eslint-plugin": "^8.31.0",
+    "@typescript-eslint/parser": "^8.31.0",
+    "eslint": "^9.25.1",
+    "eslint-plugin-unused-imports": "^4.1.4"
   },
   "peerDependencies": {
-    "@travetto/cli": "^6.0.0-rc.1"
+    "@travetto/cli": "^6.0.0"
   },
   "peerDependenciesMeta": {
     "@travetto/cli": {

package/support/bin/eslint-config-file.ts

@@ -8,7 +8,15 @@ export async function buildEslintConfig(): Promise<string> {
   const ext = Runtime.workspace.type === 'commonjs' ? '.cjs' : '.mjs';
   const tpl = await fs.readFile(path.resolve(root, 'resources', `eslint-config-file${ext}`), 'utf8');
 
+  // Get path to repo-root output
+  const outputPath = path.join(
+    Runtime.workspace.path,
+    RuntimeIndex.manifest.build.outputFolder,
+    'node_modules',
+    Runtime.workspace.name
+  );
+
   return tpl
     .replace(/'(@travetto\/[^']+)'/g, (_, v) => `'${RuntimeIndex.resolveFileImport(v)}'`)
-    .replace('%MANIFEST_FILE%', RuntimeIndex.mainModule.outputPath);
+    .replace('%MANIFEST_FILE%', outputPath);
 }

package/support/bin/eslint-config.ts

@@ -3,12 +3,13 @@ import { existsSync, readFileSync } from 'node:fs';
 import { configs } from '@eslint/js';
 import tsEslintPlugin from '@typescript-eslint/eslint-plugin';
 import stylisticPlugin from '@stylistic/eslint-plugin';
+import unusedImports from 'eslint-plugin-unused-imports';
 
 import { Runtime } from '@travetto/runtime';
 
-import { IGNORES, GLOBALS, TS_OPTIONS } from './eslint-common';
-import { STD_RULES } from './eslint-std-rules';
-import { TrvEslintPlugin } from './types';
+import { IGNORES, GLOBALS, TS_OPTIONS } from './eslint-common.ts';
+import { STD_RULES } from './eslint-std-rules.ts';
+import { TrvEslintPlugin } from './types.ts';
 
 export function buildConfig(pluginMaps: Record<string, TrvEslintPlugin>[]): readonly unknown[] {
   const plugins: TrvEslintPlugin[] = pluginMaps.map(Object.values).flat();
@@ -36,6 +37,7 @@ export function buildConfig(pluginMaps: Record<string, TrvEslintPlugin>[]): read
         '@typescript-eslint': {
           rules: tsEslintPlugin.rules,
         },
+        'unused-imports': unusedImports,
         ...(Object.fromEntries(plugins.map(x => [x.name, x])))
       },
       rules: {
@@ -52,7 +54,8 @@ export function buildConfig(pluginMaps: Record<string, TrvEslintPlugin>[]): read
       plugins: {
         '@stylistic': {
           rules: stylisticPlugin.rules
-        }
+        },
+        'unused-imports': unusedImports,
       },
       rules: {
         ...Object.fromEntries(Object.entries(STD_RULES).filter(x => !x[0].startsWith('@typescript'))),
@@ -70,6 +73,7 @@ export function buildConfig(pluginMaps: Record<string, TrvEslintPlugin>[]): read
       rules: {
         'max-len': 0,
         'no-unused-private-class-members': 0,
+        '@typescript-eslint/no-unused-vars': 0,
         '@typescript-eslint/explicit-function-return-type': 0
       }
     },
@@ -87,6 +91,7 @@ export function buildConfig(pluginMaps: Record<string, TrvEslintPlugin>[]): read
       files: ['**/test/**/*.ts', '**/test/**/*.tsx', '**/support/test/**/*.ts', '**/support/test/**/*.tsx'],
       ignores: [...IGNORES, 'module/test/src/**'],
       rules: {
+        '@typescript-eslint/no-unused-vars': 0,
         '@typescript-eslint/explicit-function-return-type': 0
       }
     },

package/support/bin/eslint-std-rules.ts

@@ -63,7 +63,11 @@ export const STD_RULES = {
   'require-atomic-updates': 0,
   '@typescript-eslint/no-unused-vars': [
     'error',
-    { varsIgnorePattern: '^(_|[A-Z])[A-Za-z0-9]*', args: 'none' }
+    {
+      varsIgnorePattern: '^(_|[A-Z])[A-Za-z0-9]*',
+      argsIgnorePattern: '^_',
+      args: 'after-used'
+    }
   ],
   '@stylistic/quotes': [
     'error',
@@ -203,6 +207,7 @@ export const STD_RULES = {
   'no-useless-escape': 0,
   'no-unused-expressions': 0,
   'no-unused-labels': 'error',
+  'unused-imports/no-unused-imports': 'error',
   'no-var': 'error',
   'object-shorthand': 'error',
   'prefer-const': 'error',

package/support/cli.lint.ts

@@ -42,7 +42,7 @@ export class LintCommand implements CliCommandShape {
       files = [];
     }
 
-    const res = await ExecUtil.getResult(spawn('npx', [
+    const result = await ExecUtil.getResult(spawn('npx', [
       'eslint',
       '--cache',
       '--cache-location', Runtime.toolPath('.eslintcache'),
@@ -55,6 +55,6 @@ export class LintCommand implements CliCommandShape {
       shell: false
     }), { catch: true });
 
-    process.exitCode = res.code;
+    process.exitCode = result.code;
   }
 }

package/support/cli.lint_register.ts

@@ -3,19 +3,19 @@ import fs from 'node:fs/promises';
 import { CliCommandShape, CliCommand } from '@travetto/cli';
 import { Runtime } from '@travetto/runtime';
 
-import { buildEslintConfig } from './bin/eslint-config-file';
+import { buildEslintConfig } from './bin/eslint-config-file.ts';
 
 /**
  * Writes the lint configuration file
  */
-@CliCommand()
+@CliCommand({})
 export class LintConfigureCommand implements CliCommandShape {
 
   async main(): Promise<void> {
     const content = await buildEslintConfig();
-    const output = Runtime.workspaceRelative('eslint.config.js');
+    const ext = Runtime.workspace.type === 'commonjs' ? '.cjs' : '.mjs';
+    const output = Runtime.workspaceRelative(`eslint.config${ext}`);
     await fs.writeFile(output, content.replaceAll(Runtime.workspace.path, '.').trim());
-
     console.log(`Wrote eslint config to ${output}`);
   }
 }