@transportme/load-ptv-gtfs 1.2.1 → 1.2.2

package/lib/gtfs-parser/GTFSAgency.mjs

@@ -5,6 +5,8 @@ export default class GTFSAgency {
   website
   phone
 
+  static UNKNOWN_AGENCY = new GTFSAgency({ id: '-1', name: 'Unknown', website: '', phone: '' })
+
   constructor({ id, name, website, phone }) {
     this.id = id
     this.name = name

package/lib/loader/RouteLoader.mjs

@@ -2,6 +2,7 @@ import GTFSRouteReader from '../gtfs-parser/readers/GTFSRouteReader.mjs'
 import GTFSAgencyReader from '../gtfs-parser/readers/GTFSAgencyReader.mjs'
 import { STOP_UTILS } from '@transportme/transportvic-utils'
 import GTFSRoute from '../gtfs-parser/GTFSRoute.mjs'
+import GTFSAgency from '../gtfs-parser/GTFSAgency.mjs'
 
 const { sanitiseName } = STOP_UTILS
 
@@ -109,7 +110,9 @@ export default class RouteLoader {
   }
 
   getOperator(id) {
-    return this.#operators[id]
+    let operator = this.#operators[id]
+    if (operator) return operator
+    return GTFSAgency.UNKNOWN_AGENCY
   }
 
   getRouteIDMap() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@transportme/load-ptv-gtfs",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "",
   "main": "index.mjs",
   "scripts": {

package/test/gtfs-route-loader.test.mjs

@@ -7,6 +7,7 @@ import { TRANSIT_MODES } from '../lib/constants.mjs'
 import path from 'path'
 import url from 'url'
 import { expect } from 'chai'
+import GTFSAgency from '../lib/gtfs-parser/GTFSAgency.mjs'
 
 const __filename = url.fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
@@ -18,6 +19,8 @@ const agencyFile = path.join(__dirname, 'sample-data', 'routes', 'agency.txt')
 const wgtFile = path.join(__dirname, 'sample-data', 'routes', 'west_gipp_transit.txt')
 const vlineFile = path.join(__dirname, 'sample-data', 'routes', 'vline.txt')
 
+const badRoutesFile_NoAgency = path.join(__dirname, 'sample-data', 'routes', 'bad_routes.txt')
+
 describe('The GTFS Agency Reader', () => {
   it('Should read the agencies one line at a time', async () => {
     let reader = new GTFSAgencyReader(agencyFile)
@@ -187,4 +190,19 @@ describe('The GTFS Routes Loader', () => {
     expect(traralgon.routeName).to.equal('Traralgon - Melbourne Via Pakenham, Moe & Morwell')
     expect(traralgon.operators).to.have.members(['V/Line'])
   })
+
+  it('Should handle invalid agency references', async () => {
+    let database = new LokiDatabaseConnection('test-db')
+    let routes = await database.createCollection('routes')
+
+    let loader = new RouteLoader(badRoutesFile_NoAgency, agencyFile, TRANSIT_MODES.bus, database)
+    await loader.loadRoutes()
+
+    let skybus = await routes.findDocument({
+      routeGTFSID: '11-SKY'
+    })
+
+    expect(skybus).to.not.be.null
+    expect(skybus.operators).to.deep.equal([GTFSAgency.UNKNOWN_AGENCY.name]) 
+  })
 })

package/test/sample-data/routes/bad_routes.txt

@@ -0,0 +1,4 @@
+route_id,agency_id,route_short_name,route_long_name,route_type,route_color,route_text_color
+"11-SK4-mjp-1","","","Frankston - Melbourne Airport","3","ED1C24","FFFFFF"
+"11-Ska-mjp-1","","","Melbourne City - Avalon Airport","3","ED1C24","FFFFFF"
+"11-SKY-mjp-1","","","City - Melbourne Airport","3","ED1C24","FFFFFF"