@transitrix/diagrams 1.8.6 → 1.8.7

package/src/theme/__tests__/tokens.test.ts

@@ -1,185 +0,0 @@
-/**
- * Brand default-theme regression tests (hub issue #548).
- *
- * Locks in the three-role brand mapping from `brand/transitrix_brand.md`:
- *   - Petrol = structure (node/edge stroke) and hierarchy depth (fill tint).
- *   - A depth ramp never switches hue — only lightness/saturation move.
- *   - Text stays WCAG-AA readable against every fill it can be drawn on.
- * `hc` (VS Code high-contrast) is intentionally excluded — it's an
- * accessibility override, not one of the three brand-contract themes.
- */
-import { describe, expect, it } from 'vitest';
-import {
-  BRAND,
-  BRAND_EMPHASIS,
-  LAYER_COLORS,
-  LEVEL_COLORS,
-  MATURITY_COLORS,
-  TREE_MATURITY_COLORS,
-  STRUCTURAL,
-  TREE_LEVEL_COLORS,
-} from '../tokens.js';
-
-function hexToRgb(hex: string): [number, number, number] {
-  const n = hex.replace('#', '');
-  return [0, 2, 4].map((i) => parseInt(n.slice(i, i + 2), 16)) as [number, number, number];
-}
-
-function relativeLuminance([r, g, b]: [number, number, number]): number {
-  const f = (v: number): number => {
-    const c = v / 255;
-    return c <= 0.03928 ? c / 12.92 : Math.pow((c + 0.055) / 1.055, 2.4);
-  };
-  const [R, G, B] = [f(r), f(g), f(b)];
-  return 0.2126 * R + 0.7152 * G + 0.0722 * B;
-}
-
-/** WCAG 2.x contrast ratio between two hex colors (1..21). */
-function contrast(a: string, b: string): number {
-  const la = relativeLuminance(hexToRgb(a));
-  const lb = relativeLuminance(hexToRgb(b));
-  const [hi, lo] = la > lb ? [la, lb] : [lb, la];
-  return (hi + 0.05) / (lo + 0.05);
-}
-
-/** Hue in degrees (0-360) from a hex color; undefined (grey) hues return -1. */
-function hue(hex: string): number {
-  const [r, g, b] = hexToRgb(hex).map((v) => v / 255);
-  const max = Math.max(r, g, b), min = Math.min(r, g, b);
-  const delta = max - min;
-  if (delta < 0.001) return -1; // achromatic
-  let h: number;
-  if (max === r) h = ((g - b) / delta) % 6;
-  else if (max === g) h = (b - r) / delta + 2;
-  else h = (r - g) / delta + 4;
-  h *= 60;
-  return h < 0 ? h + 360 : h;
-}
-
-const PETROL_HUE = hue(BRAND.petrol);
-const HUE_TOLERANCE = 6; // degrees — rounding slop from hand-tuned hex values
-
-function expectSameHueFamily(hexes: string[], label: string): void {
-  for (const hex of hexes) {
-    const h = hue(hex);
-    const diff = Math.min(Math.abs(h - PETROL_HUE), 360 - Math.abs(h - PETROL_HUE));
-    expect(diff, `${label} ${hex} should stay in the petrol hue family (got hue ${h.toFixed(1)}, petrol is ${PETROL_HUE.toFixed(1)})`).toBeLessThanOrEqual(HUE_TOLERANCE);
-  }
-}
-
-// Minimum AA text-contrast ratios this design targets. Primary/secondary text
-// is small (10-12px) so we hold the full 4.5:1 normal-text bar for the name
-// label, and the calibrated ~4.0 bar the pre-brand palette already shipped
-// for the muted secondary/id label (see brand-ramp calibration in PR #548).
-const MIN_PRIMARY_CONTRAST = 4.5;
-const MIN_SECONDARY_CONTRAST = 4.0;
-
-describe('brand default theme (#548) — structure is petrol', () => {
-  it('nodeStroke and edgeStroke are brand petrol in the light theme', () => {
-    expect(STRUCTURAL.nodeStroke.light).toBe(BRAND.petrol);
-    expect(STRUCTURAL.edgeStroke.light).toBe(BRAND.petrol);
-  });
-
-  it('nodeStroke/edgeStroke stay in the petrol hue family in the dark theme', () => {
-    expectSameHueFamily([STRUCTURAL.nodeStroke.dark, STRUCTURAL.edgeStroke.dark], 'dark stroke');
-  });
-});
-
-describe('brand default theme (#548) — tint depth never switches hue', () => {
-  it('LEVEL_COLORS light ramp stays in the petrol hue family', () => {
-    expectSameHueFamily([...LEVEL_COLORS.light], 'LEVEL light');
-  });
-  it('LEVEL_COLORS dark ramp stays in the petrol hue family', () => {
-    expectSameHueFamily([...LEVEL_COLORS.dark], 'LEVEL dark');
-  });
-  it('LAYER_COLORS (DGCA/DGA columns) stay in the petrol hue family, both themes', () => {
-    const keys = ['driver', 'factor', 'goal', 'change', 'activity'] as const;
-    expectSameHueFamily(keys.map((k) => LAYER_COLORS[k].light), 'LAYER light');
-    expectSameHueFamily(keys.map((k) => LAYER_COLORS[k].dark), 'LAYER dark');
-  });
-  it('TREE_LEVEL_COLORS (capability map bands) stay in the petrol hue family, both themes', () => {
-    const keys = ['band0', 'band1', 'band2'] as const;
-    expectSameHueFamily(keys.map((k) => TREE_LEVEL_COLORS[k].light), 'BAND light');
-    expectSameHueFamily(keys.map((k) => TREE_LEVEL_COLORS[k].dark), 'BAND dark');
-  });
-});
-
-describe('brand default theme (#548) — WCAG-AA text-on-fill contrast', () => {
-  function checkFills(label: string, fills: string[], textPrimary: string, textSecondary: string): void {
-    for (const fill of fills) {
-      expect(contrast(fill, textPrimary), `${label} ${fill} vs text-primary`).toBeGreaterThanOrEqual(MIN_PRIMARY_CONTRAST);
-      expect(contrast(fill, textSecondary), `${label} ${fill} vs text-secondary`).toBeGreaterThanOrEqual(MIN_SECONDARY_CONTRAST);
-    }
-  }
-
-  it('LEVEL_COLORS — every slot, both themes', () => {
-    checkFills('LEVEL light', [...LEVEL_COLORS.light], STRUCTURAL.textPrimary.light, STRUCTURAL.textSecondary.light);
-    checkFills('LEVEL dark', [...LEVEL_COLORS.dark], STRUCTURAL.textPrimary.dark, STRUCTURAL.textSecondary.dark);
-  });
-
-  it('LAYER_COLORS — every column, both themes', () => {
-    const keys = ['driver', 'factor', 'goal', 'change', 'activity'] as const;
-    checkFills('LAYER light', keys.map((k) => LAYER_COLORS[k].light), STRUCTURAL.textPrimary.light, STRUCTURAL.textSecondary.light);
-    checkFills('LAYER dark', keys.map((k) => LAYER_COLORS[k].dark), STRUCTURAL.textPrimary.dark, STRUCTURAL.textSecondary.dark);
-  });
-
-  it('TREE_LEVEL_COLORS — every band, both themes', () => {
-    const keys = ['band0', 'band1', 'band2'] as const;
-    checkFills('BAND light', keys.map((k) => TREE_LEVEL_COLORS[k].light), STRUCTURAL.textPrimary.light, STRUCTURAL.textSecondary.light);
-    checkFills('BAND dark', keys.map((k) => TREE_LEVEL_COLORS[k].dark), STRUCTURAL.textPrimary.dark, STRUCTURAL.textSecondary.dark);
-  });
-
-  it('textPrimary/textSecondary stay readable against the shell background', () => {
-    expect(contrast(STRUCTURAL.textPrimary.light, '#ffffff')).toBeGreaterThanOrEqual(MIN_PRIMARY_CONTRAST);
-    expect(contrast(STRUCTURAL.textPrimary.dark, '#0a1628')).toBeGreaterThanOrEqual(MIN_PRIMARY_CONTRAST);
-  });
-});
-
-describe('brand default theme (#548) — amber/orange emphasis stays distinct from functional colors', () => {
-  it('does not reuse brand amber/orange for functional status', () => {
-    // FUNCTIONAL warning/error must remain visually distinct from the brand
-    // accents so a red error is never confused with brand orange, per
-    // brand/transitrix_brand.md "Don't reuse brand orange as semantic error".
-    expect(BRAND_EMPHASIS.orange.light).toBe(BRAND.orange);
-    expect(BRAND_EMPHASIS.amber.light).toBe(BRAND.amber);
-  });
-
-  it('critical-path emphasis tint pairs with the orange stroke, both themes', () => {
-    expect(contrast(BRAND_EMPHASIS.orange.light, BRAND_EMPHASIS.orangeTint.light)).toBeGreaterThan(1.5);
-    expect(contrast(BRAND_EMPHASIS.orange.dark, BRAND_EMPHASIS.orangeTint.dark)).toBeGreaterThan(1.5);
-  });
-});
-
-describe('maturity Likert ramp — one harmonious scale, white-label contrast', () => {
-  // .maturity-pill / tree-maturity badges hardcode white label text
-  // (capability-map-preview.ts, render-capability-tree.ts) regardless of
-  // theme, so every step needs AA (light/dark) or AAA (hc, since VS Code
-  // high-contrast mode exists specifically to demand stronger contrast)
-  // against white — not against the page's own text-primary/secondary.
-  const MIN_WHITE_CONTRAST_AA = 4.5;
-  const MIN_WHITE_CONTRAST_AAA = 7;
-
-  it('MATURITY_COLORS — every step reads white text at AA, light + dark', () => {
-    for (const hex of MATURITY_COLORS.light) {
-      expect(contrast(hex, '#ffffff'), `MATURITY light ${hex} vs white`).toBeGreaterThanOrEqual(MIN_WHITE_CONTRAST_AA);
-    }
-    for (const hex of MATURITY_COLORS.dark) {
-      expect(contrast(hex, '#ffffff'), `MATURITY dark ${hex} vs white`).toBeGreaterThanOrEqual(MIN_WHITE_CONTRAST_AA);
-    }
-  });
-
-  it('MATURITY_COLORS hc — every step reads white text at AAA', () => {
-    for (const hex of MATURITY_COLORS.hc) {
-      expect(contrast(hex, '#ffffff'), `MATURITY hc ${hex} vs white`).toBeGreaterThanOrEqual(MIN_WHITE_CONTRAST_AAA);
-    }
-  });
-
-  it('TREE_MATURITY_COLORS is the same harmonious ramp as MATURITY_COLORS', () => {
-    // Previously a divergent DSM-matching pink/yellow/blue set (plus a grey
-    // L1, an odd "no signal" hue for the worst rating) — "maturity" now
-    // means the same colors everywhere it's shown.
-    expect(TREE_MATURITY_COLORS.light).toEqual(MATURITY_COLORS.light);
-    expect(TREE_MATURITY_COLORS.dark).toEqual(MATURITY_COLORS.dark);
-    expect(TREE_MATURITY_COLORS.hc).toEqual(MATURITY_COLORS.hc);
-  });
-});

package/src/webview/__tests__/entity-text-layout.test.ts

@@ -1,182 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import {
-  layoutCenteredEntityText,
-  layoutLeafBlockText,
-  layoutHeaderBlockText,
-  LINE_H_PRIMARY,
-  LINE_H_SECONDARY,
-  TEXT_MARGIN_Y,
-  maxCharsForInnerWidth,
-  ROW_GROUP_GAP,
-  wrapWords,
-  wrapTextLines,
-} from '../entity-text-layout.js';
-import { ENTITY_NODE_SIZE } from '../../node-size-presets.js';
-
-describe('entity-text-layout', () => {
-  it('wrapWords respects max lines and truncates with ellipsis', () => {
-    const long = 'one two three four five six seven eight nine ten eleven twelve';
-    const lines = wrapWords(long, 12, 2);
-    expect(lines.length).toBeLessThanOrEqual(2);
-    expect(lines[lines.length - 1]).toMatch(/…$/);
-  });
-
-  it('maxCharsForInnerWidth scales with inner width', () => {
-    expect(maxCharsForInnerWidth(160, 7)).toBeGreaterThan(maxCharsForInnerWidth(120, 7));
-  });
-
-  it('layoutCenteredEntityText keeps name and type labels separated', () => {
-    const specs = layoutCenteredEntityText({
-      boxX: 0,
-      boxY: 0,
-      boxWidth: 250,
-      boxHeight: 80,
-      name: 'Grow enterprise value',
-      type: 'Strategic',
-      id: 'GOAL-VALUE-1',
-      nameMaxLines: 2,
-      idMaxLines: 1,
-    });
-    const nameY = specs.find((l) => l.cls === 'text-primary')!.y;
-    const typeY = specs.find((l) => l.cls === 'text-secondary')!.y;
-    const minGap = typeY - nameY - LINE_H_PRIMARY / 2 - LINE_H_SECONDARY / 2;
-    expect(minGap).toBeGreaterThanOrEqual(ROW_GROUP_GAP - 1);
-  });
-
-  it('layoutCenteredEntityText emits more name capacity on wide boxes', () => {
-    const narrow = layoutCenteredEntityText({
-      boxX: 0,
-      boxY: 0,
-      boxWidth: 200,
-      boxHeight: 80,
-      name: 'Improve customer onboarding experience across regions',
-      id: 'GOAL-001',
-      nameMaxLines: 2,
-      idMaxLines: 1,
-    });
-    const wide = layoutCenteredEntityText({
-      boxX: 0,
-      boxY: 0,
-      boxWidth: 320,
-      boxHeight: 80,
-      name: 'Improve customer onboarding experience across regions',
-      id: 'GOAL-001',
-      nameMaxLines: 2,
-      idMaxLines: 1,
-    });
-    const narrowPrimary = narrow.filter((l) => l.cls === 'text-primary').map((l) => l.text).join(' ');
-    const widePrimary = wide.filter((l) => l.cls === 'text-primary').map((l) => l.text).join(' ');
-    expect(widePrimary.replace(/…/g, '').length).toBeGreaterThanOrEqual(narrowPrimary.replace(/…/g, '').length);
-  });
-
-  it('wrapTextLines hard-breaks oversized tokens (blueprint cells)', () => {
-    const lines = wrapTextLines('supercalifragilisticexpialidocious word', 10, 3);
-    expect(lines.length).toBeGreaterThan(1);
-    expect(lines.every((l) => l.length <= 10)).toBe(true);
-  });
-});
-
-// Approximate half-extent (px) of each text class's glyphs around its centre
-// y — font-size / 2, the same heuristic the render-blocks overlap regression
-// test (#419) uses. Used below to assert text never visually crosses the box
-// border, not just that the *nominal* line-height budget fits.
-const HALF_EXTENT: Record<string, number> = {
-  'text-primary': 6, // 12px font
-  'text-secondary': 6, // 11px font, rounded up
-  'text-id': 5, // 10px font
-};
-
-describe('entity text layout — never overflows the box, always keeps padding', () => {
-  const PRESETS = Object.entries(ENTITY_NODE_SIZE); // compact/normal/wide
-  const NAMES = [
-    'Short',
-    'Achieve full GDPR & NIS2 compliance',
-    'A name so long it would need three or more lines to render in full without any height limit at all',
-  ];
-
-  function assertNoOverflowAndPadded(
-    specs: { cls: string; y: number }[],
-    boxTop: number,
-    boxBottom: number,
-  ): void {
-    for (const s of specs) {
-      const half = HALF_EXTENT[s.cls] ?? 6;
-      expect(s.y - half).toBeGreaterThanOrEqual(boxTop);
-      expect(s.y + half).toBeLessThanOrEqual(boxBottom);
-    }
-  }
-
-  for (const [presetName, size] of PRESETS) {
-    for (const withType of [false, true]) {
-      for (const name of NAMES) {
-        it(`layoutCenteredEntityText: ${presetName} preset, type=${withType}, name="${name.slice(0, 20)}…" stays inside the box`, () => {
-          const boxY = 0;
-          const specs = layoutCenteredEntityText({
-            boxX: 0,
-            boxY,
-            boxWidth: size.width,
-            boxHeight: size.height,
-            name,
-            type: withType ? 'Strategic Goal' : undefined,
-            id: 'GOAL-EU-COMPLIANCE-1',
-            nameMaxLines: 2,
-            idMaxLines: 1,
-          });
-          assertNoOverflowAndPadded(specs, boxY, boxY + size.height);
-        });
-      }
-    }
-  }
-
-  it('reproduces the reported case (wide preset, 2-line name + type + long id) with real padding on all sides', () => {
-    const size = ENTITY_NODE_SIZE.normal;
-    const boxY = 100;
-    const specs = layoutCenteredEntityText({
-      boxX: 0,
-      boxY,
-      boxWidth: size.width,
-      boxHeight: size.height,
-      name: 'Achieve full GDPR & NIS2 compliance',
-      type: 'Project Goal',
-      id: 'GOAL-EU-COMPLIANCE-1',
-      nameMaxLines: 2,
-      idMaxLines: 1,
-    });
-    const nameLines = specs.filter((s) => s.cls === 'text-primary');
-    expect(nameLines.length).toBe(2); // normal preset is tall enough to keep both lines
-    assertNoOverflowAndPadded(specs, boxY, boxY + size.height);
-    // Explicit padding, not just "doesn't cross the border".
-    const firstTop = Math.min(...specs.map((s) => s.y - (HALF_EXTENT[s.cls] ?? 6)));
-    const lastBottom = Math.max(...specs.map((s) => s.y + (HALF_EXTENT[s.cls] ?? 6)));
-    expect(firstTop - boxY).toBeGreaterThanOrEqual(TEXT_MARGIN_Y);
-    expect(boxY + size.height - lastBottom).toBeGreaterThanOrEqual(TEXT_MARGIN_Y);
-  });
-
-  it('layoutLeafBlockText stays inside the box for compact preset with a long name and id', () => {
-    const size = ENTITY_NODE_SIZE.compact;
-    const boxY = 0;
-    const specs = layoutLeafBlockText({
-      boxX: 0,
-      boxY,
-      boxWidth: size.width,
-      boxHeight: size.height,
-      name: 'Personal data records that linger after consent withdrawal across many systems and archives',
-      id: 'VERY_LONG_BLOCK_IDENTIFIER_WITH_MANY_SEGMENTS_AND_MORE',
-    });
-    assertNoOverflowAndPadded(specs, boxY, boxY + size.height);
-  });
-
-  it('layoutHeaderBlockText stays inside a short header strip', () => {
-    const boxY = 0;
-    const headerHeight = 28;
-    const specs = layoutHeaderBlockText({
-      boxX: 0,
-      boxY,
-      boxWidth: 250,
-      headerHeight,
-      name: 'A fairly long container name here',
-      id: 'VERY_LONG_CONTAINER_IDENTIFIER',
-    });
-    assertNoOverflowAndPadded(specs, boxY, boxY + headerHeight);
-  });
-});

package/src/webview/__tests__/entry-notations.test.ts

@@ -1,77 +0,0 @@
-/**
- * Step 4 parity check: every supported notation must render through the
- * webview bundle's `render(kind, source)` API from the same example fixtures
- * the VS Code previews consume — a valid document yields `status: 'ok'` with
- * non-empty markup, and a malformed document degrades to the error panel
- * (structured errors, no thrown exception reaching the JVM host).
- */
-import { readFileSync } from 'node:fs';
-import path from 'node:path';
-import { fileURLToPath } from 'node:url';
-
-import { describe, expect, it } from 'vitest';
-
-import { api, render, type NotationKind } from '../entry.js';
-
-const EXAMPLES = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../../../../../tests/fixtures/notation-corpus');
-
-interface Fixture {
-  kind: NotationKind;
-  file: string;
-  /** The markup wrapper the renderer emits: an <svg> diagram or an HTML <section>. */
-  markup: 'svg' | 'section';
-}
-
-// Mirrors the fixtures used by the VS Code previews. One representative
-// example per notation is enough to prove the dispatch + renderer wiring.
-const FIXTURES: Fixture[] = [
-  { kind: 'goals', file: 'goals/strategy-2026.goals.transitrix.yaml', markup: 'svg' },
-  { kind: 'dgca', file: 'dgca/strategy-2026.dgca.transitrix.yaml', markup: 'svg' },
-  { kind: 'dga', file: 'dga/strategy-2026.dga.transitrix.yaml', markup: 'svg' },
-  { kind: 'action', file: 'action/platform-launch.action.transitrix.yaml', markup: 'svg' },
-  { kind: 'action-card', file: 'action-card/eu-programme.action-card.transitrix.yaml', markup: 'svg' },
-  { kind: 'process-blueprint', file: 'process-blueprint/order-fulfilment.process-blueprint.transitrix.yaml', markup: 'svg' },
-  { kind: 'blocks', file: 'blocks/architecture.blocks.transitrix.yaml', markup: 'svg' },
-  { kind: 'applications', file: 'applications/portfolio-2026.applications.transitrix.yaml', markup: 'section' },
-  { kind: 'products', file: 'products/portfolio-2026.products.transitrix.yaml', markup: 'section' },
-  { kind: 'process-map', file: 'process-map/enterprise.process-map.transitrix.yaml', markup: 'section' },
-  { kind: 'scenarios', file: 'scenarios/omnichannel-2028.scenarios.transitrix.yaml', markup: 'section' },
-  { kind: 'capability-map', file: 'capability-map/business.capability-map.transitrix.yaml', markup: 'section' },
-];
-
-describe('webview/entry — Step 4 notation coverage', () => {
-  it('wires every supported kind (no kind left on NOTATION-NOT-WIRED)', () => {
-    // The fixture table must cover the full supported-kinds surface, so a new
-    // kind added to the bundle without a renderer fails this test loudly.
-    const covered = new Set(FIXTURES.map((f) => f.kind));
-    for (const kind of api.supportedKinds) {
-      expect(covered.has(kind)).toBe(true);
-    }
-  });
-
-  for (const fx of FIXTURES) {
-    it(`renders ${fx.kind} from its example fixture`, () => {
-      const source = readFileSync(path.join(EXAMPLES, fx.file), 'utf8');
-      const r = render(fx.kind, source);
-      expect(r.notation).toBe(fx.kind);
-      expect(r.errors).toEqual([]);
-      expect(r.status).toBe('ok');
-      expect(r.svg.length).toBeGreaterThan(0);
-      expect(r.svg).toContain(fx.markup === 'svg' ? '<svg ' : '<section');
-    });
-  }
-
-  it('degrades malformed input to the error panel for a diagram notation', () => {
-    const r = render('process-blueprint', 'process_blueprint:\n  stages: "not a list"\n');
-    expect(r.status).toBe('error');
-    expect(r.errors.length).toBeGreaterThan(0);
-    expect(r.svg).toBe('');
-  });
-
-  it('degrades malformed input to the error panel for a catalogue notation', () => {
-    const r = render('applications', 'applications_catalogue:\n  applications: "not a list"\n');
-    expect(r.status).toBe('error');
-    expect(r.errors.length).toBeGreaterThan(0);
-    expect(r.svg).toBe('');
-  });
-});

package/src/webview/__tests__/entry.test.ts

@@ -1,64 +0,0 @@
-import { describe, expect, it } from 'vitest';
-
-import { api, render } from '../entry.js';
-
-const VALID_GOALS_DOC = `
-notation: goals
-id: GOALS-WEBVIEW-1
-name: "Webview entry smoke test"
-goal_types:
-  - { name: "Strategy", level: 0 }
-goals:
-  - id: GOAL-MOON-1
-    name: "Reach the moon"
-    type: "Strategy"
-    level: 0
-`;
-
-describe('webview/entry — Step 2 host API', () => {
-  it('exposes a version + supportedKinds + render() trio', () => {
-    expect(api.version).toMatch(/^\d+\.\d+\.\d+/);
-    expect(api.supportedKinds).toContain('goals');
-    expect(typeof api.render).toBe('function');
-  });
-
-  it('parses + validates + renders SVG for a well-formed goals document', () => {
-    const r = render('goals', VALID_GOALS_DOC);
-    expect(r.notation).toBe('goals');
-    expect(r.status).toBe('ok');
-    expect(r.errors).toEqual([]);
-    // Step 3 wires the goals renderer — SVG must now be non-empty and contain
-    // the goal name from the YAML.
-    expect(r.svg).toContain('<svg ');
-    expect(r.svg).toContain('Reach the moon');
-  });
-
-  it('returns YAML-PARSE on malformed input — no exception escapes to the host', () => {
-    const r = render('goals', 'goals:\n  - id: g1\n    name: [unterminated');
-    expect(r.status).toBe('error');
-    expect(r.errors[0].code).toBe('YAML-PARSE');
-  });
-
-  it('returns KIND-UNKNOWN for a non-Transitrix notation kind', () => {
-    const r = render('plantuml', VALID_GOALS_DOC);
-    expect(r.status).toBe('error');
-    expect(r.errors[0].code).toBe('KIND-UNKNOWN');
-  });
-
-  it('routes non-goals kinds to their validator after Step 4 (no NOTATION-NOT-WIRED)', () => {
-    // Every supported kind is now wired to its validator + renderer. A
-    // malformed dgca document must surface a structured validation error from
-    // the dgca validator — never the Step-2/3 "not wired" placeholder.
-    const r = render('dgca', 'changes: []\n');
-    expect(r.status).toBe('error');
-    expect(r.errors.length).toBeGreaterThan(0);
-    expect(r.errors.every((e) => e.code !== 'NOTATION-NOT-WIRED')).toBe(true);
-  });
-
-  it('surfaces goals validation errors structurally (e.g. missing notation header)', () => {
-    const r = render('goals', 'goals: []\n');
-    expect(r.status).toBe('error');
-    // parseCanonicalGoals emits GOALS-* codes for canonical-shape violations.
-    expect(r.errors.some((e) => e.code.startsWith('GOALS-'))).toBe(true);
-  });
-});

package/src/webview/__tests__/render-activities.test.ts

@@ -1,100 +0,0 @@
-/**
- * Unit tests for renderActivitiesSvg — project-node suppression (#421).
- *
- * Convention: activities with activity_type === 'project' are omitted from
- * the Network/PSND layout by default (suppressProjectNodes: true). Text/Tree
- * views keep them via the caller; data is never mutated.
- */
-import { describe, it, expect } from 'vitest';
-import { renderActivitiesSvg } from '../render-activities.js';
-import type { ActivityDoc } from '../../activities/types.js';
-
-const BASE_DOC: ActivityDoc = {
-  notation: 'action',
-  activities: [
-    {
-      id: 'PROJ-1',
-      name: 'Platform Launch',
-      activity_type: 'project',
-    },
-    {
-      id: 'TASK-1',
-      name: 'Design',
-      activity_type: 'task',
-      parent: 'PROJ-1',
-    },
-    {
-      id: 'TASK-2',
-      name: 'Implement',
-      activity_type: 'task',
-      parent: 'PROJ-1',
-      predecessors: ['TASK-1'],
-    },
-  ],
-};
-
-describe('renderActivitiesSvg — project-node suppression (#421)', () => {
-  it('suppresses project-type nodes in the network SVG by default', () => {
-    const svg = renderActivitiesSvg(BASE_DOC);
-    // TASK-1 and TASK-2 should appear as rendered nodes.
-    expect(svg).toContain('TASK-1');
-    expect(svg).toContain('TASK-2');
-    // The project container should not appear as a rendered node.
-    expect(svg).not.toContain('PROJ-1');
-  });
-
-  it('suppresses project nodes when suppressProjectNodes is explicitly true', () => {
-    const svg = renderActivitiesSvg(BASE_DOC, { suppressProjectNodes: true });
-    expect(svg).not.toContain('PROJ-1');
-    expect(svg).toContain('TASK-1');
-  });
-
-  it('renders project nodes when suppressProjectNodes is false', () => {
-    const svg = renderActivitiesSvg(BASE_DOC, { suppressProjectNodes: false });
-    expect(svg).toContain('PROJ-1');
-    expect(svg).toContain('TASK-1');
-    expect(svg).toContain('TASK-2');
-  });
-
-  it('does not mutate the original doc', () => {
-    const original = BASE_DOC.activities.length;
-    renderActivitiesSvg(BASE_DOC);
-    expect(BASE_DOC.activities).toHaveLength(original);
-  });
-
-  it('suppresses project_type matching case-insensitively', () => {
-    const doc: ActivityDoc = {
-      notation: 'action',
-      activities: [
-        { id: 'P1', name: 'Container', activity_type: 'Project' },
-        { id: 'T1', name: 'Leaf', activity_type: 'task' },
-      ],
-    };
-    const svg = renderActivitiesSvg(doc);
-    expect(svg).not.toContain('P1');
-    expect(svg).toContain('T1');
-  });
-
-  it('renders a valid SVG when all activities are project-type (graceful degrade)', () => {
-    const doc: ActivityDoc = {
-      notation: 'action',
-      activities: [{ id: 'P1', name: 'Only project', activity_type: 'project' }],
-    };
-    const svg = renderActivitiesSvg(doc);
-    // When all activities are filtered out, the renderer returns an empty SVG.
-    expect(svg).toContain('<svg');
-  });
-
-  it('renders activities without activity_type unchanged', () => {
-    const doc: ActivityDoc = {
-      notation: 'action',
-      activities: [
-        { id: 'A1', name: 'Analysis', duration: 5 },
-        { id: 'A2', name: 'Design', duration: 3, predecessors: ['A1'] },
-      ],
-    };
-    const svg = renderActivitiesSvg(doc);
-    expect(svg).toContain('A1');
-    expect(svg).toContain('A2');
-  });
-});