@transitrix/diagrams 1.10.0 → 1.11.0

package/src/repo-validate/check-process-parent.ts

@@ -0,0 +1,184 @@
+// process_parent relation checks — 17-relations.md §3 / §5 (REL-007, REL-008)
+// and endpoint TYPE (PROCESS → PROCESS), plus the in-effect edge collector
+// that process-blueprint BP-014 consumes.
+//
+// REL-007 is single-file (from === to). REL-008 is cross-cutting over the
+// admitted process_parent graph and is a warning, parallel to REL-006.
+
+import { docId, endpointId } from './validate-repo.js';
+import type { ProcessParentEdge } from '../process-blueprint/validate.js';
+import type { RepoFinding, RepoModelInput } from './types.js';
+
+const PScope: RepoFinding['scope'] = 'repo';
+
+function isProcessNotation(n: unknown): boolean {
+  return n === 'process';
+}
+
+function isoDate(value: unknown): string | undefined {
+  return typeof value === 'string' && /^\d{4}-\d{2}-\d{2}/.test(value) ? value.slice(0, 10) : undefined;
+}
+
+/** Inclusive window: in effect at `asOf` iff valid_from ≤ asOf and (valid_to is null or asOf ≤ valid_to). */
+export function relationInEffectAt(data: Record<string, unknown>, asOf: string): boolean {
+  const from = isoDate(data['valid_from']);
+  if (from && from > asOf) return false;
+  const to = data['valid_to'];
+  if (to === null || to === undefined) return true;
+  const toDate = isoDate(to);
+  if (!toDate) return true;
+  return asOf <= toDate;
+}
+
+export function todayIsoDate(now: Date = new Date()): string {
+  return now.toISOString().slice(0, 10);
+}
+
+/** In-effect `process_parent` edges (child → parent) among loaded REL files. */
+export function collectInEffectProcessParentEdges(
+  input: RepoModelInput,
+  asOf: string = todayIsoDate(),
+): ProcessParentEdge[] {
+  const edges: ProcessParentEdge[] = [];
+  for (const doc of input.relations) {
+    if (!doc.data) continue;
+    if (doc.data['type'] !== 'process_parent') continue;
+    if (!relationInEffectAt(doc.data, asOf)) continue;
+    const fromId = endpointId(doc.data['from']) ?? endpointId(doc.data['source']);
+    const toId = endpointId(doc.data['to']) ?? endpointId(doc.data['target']);
+    if (!fromId || !toId) continue;
+    edges.push({ from: fromId, to: toId });
+  }
+  return edges;
+}
+
+interface ParentRel {
+  relId: string;
+  fromId: string;
+  toId: string;
+}
+
+function processParentRels(input: RepoModelInput): ParentRel[] {
+  const out: ParentRel[] = [];
+  for (const doc of input.relations) {
+    if (!doc.data) continue;
+    if (doc.data['type'] !== 'process_parent') continue;
+    const fromId = endpointId(doc.data['from']) ?? endpointId(doc.data['source']);
+    const toId = endpointId(doc.data['to']) ?? endpointId(doc.data['target']);
+    if (!fromId || !toId) continue;
+    out.push({ relId: docId(doc) ?? '', fromId, toId });
+  }
+  return out;
+}
+
+/** REL-007 — process_parent self-reference. */
+function checkSelfReference(rels: ParentRel[], findings: RepoFinding[]): void {
+  for (const rel of rels) {
+    if (rel.fromId === rel.toId) {
+      findings.push({
+        scope: PScope,
+        id: rel.relId,
+        ruleId: 'REL-007',
+        message: `REL-007: process_parent relation '${rel.relId}' has from equal to to ('${rel.fromId}').`,
+      });
+    }
+  }
+}
+
+/** REL-008 — cycle in the process_parent graph (warning). */
+function checkCycle(rels: ParentRel[], findings: RepoFinding[]): void {
+  const childrenOf = new Map<string, string[]>();
+  const relByChildParent = new Map<string, string>();
+  const nodes = new Set<string>();
+  for (const rel of rels) {
+    if (rel.fromId === rel.toId) continue;
+    nodes.add(rel.fromId);
+    nodes.add(rel.toId);
+    const list = childrenOf.get(rel.fromId);
+    if (list) list.push(rel.toId);
+    else childrenOf.set(rel.fromId, [rel.toId]);
+    relByChildParent.set(`${rel.fromId}\0${rel.toId}`, rel.relId);
+  }
+
+  const UNVISITED = 0;
+  const VISITING = 1;
+  const DONE = 2;
+  const state = new Map<string, number>();
+  let hit: string | undefined;
+
+  function walk(id: string): boolean {
+    const s = state.get(id) ?? UNVISITED;
+    if (s === DONE) return false;
+    if (s === VISITING) {
+      hit = id;
+      return true;
+    }
+    state.set(id, VISITING);
+    for (const parent of childrenOf.get(id) ?? []) {
+      if (nodes.has(parent) && walk(parent)) return true;
+    }
+    state.set(id, DONE);
+    return false;
+  }
+
+  for (const id of nodes) {
+    if (walk(id)) break;
+  }
+  if (!hit) return;
+
+  const relId =
+    [...relByChildParent.entries()].find(([key]) => key.startsWith(`${hit}\0`))?.[1] ?? hit;
+  findings.push({
+    scope: PScope,
+    id: relId,
+    ruleId: 'REL-008',
+    severity: 'warning',
+    message: `REL-008: process_parent graph contains a cycle involving '${hit}'.`,
+  });
+}
+
+/**
+ * Endpoint TYPE for process_parent: both ends must be PROCESS when they
+ * resolve. Unknown endpoints stay with referential integrity; this pass only
+ * fires when the element exists and is the wrong notation.
+ */
+function checkEndpointTypes(input: RepoModelInput, rels: ParentRel[], findings: RepoFinding[]): void {
+  const elementById = new Map<string, Record<string, unknown>>();
+  for (const doc of input.elements) {
+    const id = docId(doc);
+    if (id && doc.data) elementById.set(id, doc.data);
+  }
+
+  for (const rel of rels) {
+    const from = elementById.get(rel.fromId);
+    if (from && !isProcessNotation(from['notation'])) {
+      findings.push({
+        scope: PScope,
+        id: rel.relId,
+        ruleId: 'REL-002',
+        message:
+          `Layer-semantics: '${rel.relId}' type 'process_parent' requires from to be ` +
+          `PROCESS; got notation='${from['notation']}'.`,
+      });
+    }
+    const to = elementById.get(rel.toId);
+    if (to && !isProcessNotation(to['notation'])) {
+      findings.push({
+        scope: PScope,
+        id: rel.relId,
+        ruleId: 'REL-002',
+        message:
+          `Layer-semantics: '${rel.relId}' type 'process_parent' requires to to be ` +
+          `PROCESS; got notation='${to['notation']}'.`,
+      });
+    }
+  }
+}
+
+export function checkProcessParentSemantics(input: RepoModelInput, findings: RepoFinding[]): void {
+  const rels = processParentRels(input);
+  if (rels.length === 0) return;
+  checkSelfReference(rels, findings);
+  checkCycle(rels, findings);
+  checkEndpointTypes(input, rels, findings);
+}

package/src/repo-validate/index.ts

@@ -1,3 +1,8 @@
 export { validateRepoModel } from './validate-repo.js';
 export { resolveRepoModel } from './resolve-model.js';
+export {
+  checkProcessParentSemantics,
+  collectInEffectProcessParentEdges,
+  todayIsoDate,
+} from './check-process-parent.js';
 export type { RepoDoc, RepoFinding, RepoModelInput, ResolvedElementRecord, ResolvedRelationRecord, ResolvedRepoModel } from './types.js';

package/src/repo-validate/validate-repo.ts

@@ -31,6 +31,7 @@ import { checkStrategyChainSemantics } from './check-strategy-chain.js';
 import { checkElementHygiene } from './check-element-hygiene.js';
 import { checkVersionedAttributes } from './check-versioned-attributes.js';
 import { checkCandidateFields } from './check-candidate-fields.js';
+import { checkProcessParentSemantics } from './check-process-parent.js';
 import type { RepoDoc, RepoFinding, RepoModelInput } from './types.js';
 
 const PScope: RepoFinding['scope'] = 'repo';
@@ -161,6 +162,7 @@ function checkReferentialIntegrity(input: RepoModelInput, findings: RepoFinding[
  *   realizes        — BUSINESS_SERVICE → CAPABILITY           (25-business-services.md)
  *   hosts           — NODE → TECHNOLOGY_SERVICE               (25-nodes.md / 26-technology-services.md)
  *   uses            — APPLICATION → TECHNOLOGY_SERVICE        (26-technology-services.md)
+ *   process_parent  — PROCESS → PROCESS (17-relations.md §3; REL-007/008)
  *
  * Implemented element checks:
  *   TSVC-003        — TECHNOLOGY_SERVICE.node must resolve to NODE notation
@@ -423,6 +425,7 @@ export function validateRepoModel(input: RepoModelInput): RepoFinding[] {
   checkAtomicity(input, findings);
   checkReferentialIntegrity(input, findings);
   checkLayerSemantics(input, findings);
+  checkProcessParentSemantics(input, findings);
   checkPolicy(input, findings);
   // Phase 7 — strategy-chain semantic rules ported from DSM's Go Validate*
   // functions (GOALS-010, ACT-006..009, FGCA-008..011).

package/src/webview/render-fgca.ts

@@ -121,7 +121,7 @@ export function renderFgcaSvg(doc: FGCADoc, options: RenderFgcaOptions = {}): st
     nodeSizePreset = 'normal',
     layoutOptions,
   } = options;
-  const hideChanges = variant === 'dga';
+  const hideChanges = variant === 'dga' || doc.hideChanges === true;
   const nodeSize = resolveDgcaNodeSize(parseNodeSizePreset(nodeSizePreset));
 
   const { nodes, edges, columns, width, height } = layoutFGCAPreview(doc, {

package/src/webview/render-process.ts

@@ -75,11 +75,48 @@ export interface ProcessDiagramLayout {
   associations: ProcessAssociation[];
 }
 
+export interface BpmnTypography {
+  taskFontPx: number;
+  headerFontPx: number;
+  labelFontPx: number;
+  taskChars: number;
+  taskLineH: number;
+  labelChars: number;
+  labelLineH: number;
+  headerCharW: number;
+}
+
+/** Interactive-preview / default-export type sizes. */
+export const DEFAULT_BPMN_TYPOGRAPHY: BpmnTypography = {
+  taskFontPx: 11,
+  headerFontPx: 11,
+  labelFontPx: 10,
+  taskChars: 14,
+  taskLineH: 14,
+  labelChars: 18,
+  labelLineH: 13,
+  headerCharW: 6.5,
+};
+
+/** Presentation-export type sizes (20 px floor, wrap tuned to default node boxes). */
+export const PRESENTATION_BPMN_TYPOGRAPHY: BpmnTypography = {
+  taskFontPx: 20,
+  headerFontPx: 20,
+  labelFontPx: 20,
+  taskChars: 9,
+  taskLineH: 22,
+  labelChars: 14,
+  labelLineH: 22,
+  headerCharW: 11.5,
+};
+
 export interface RenderProcessOptions {
   /** Raw SVG injected after `<style>` — a title line or full title block. */
   title?: string;
   /** Extra vertical space (px) reserved above the pool for a title block. */
   topInset?: number;
+  /** Label metrics. Omit for the interactive-preview defaults. */
+  typography?: BpmnTypography;
 }
 
 // ---------------------------------------------------------------------------
@@ -92,49 +129,52 @@ const LANE_LABEL_BAND = 44;
 /** End margin (px) along the header height axis for rotated pool/lane captions. */
 const HEADER_LABEL_AXIS_PAD = 32;
 
-/** Estimated horizontal advance (px) per character at the header label font size. */
-const HEADER_LABEL_CHAR_W = 6.5;
-
-/** Maximum characters per wrapped line inside a task box. */
-const TASK_CHARS = 14;
+/** Active wrap/font metrics for the current render call (sync, restored after). */
+let typo: BpmnTypography = DEFAULT_BPMN_TYPOGRAPHY;
 
-/** Line height for wrapped task-name text (px). */
-const TASK_LINE_H = 14;
-
-/** Maximum characters per line for below-element labels (events, gateways). */
-const LABEL_CHARS = 18;
-
-/** Line height for multi-line below-element labels (px). */
-const LABEL_LINE_H = 13;
+function runWithTypography<T>(t: BpmnTypography, fn: () => T): T {
+  const prev = typo;
+  typo = t;
+  try {
+    return fn();
+  } finally {
+    typo = prev;
+  }
+}
 
 // ---------------------------------------------------------------------------
 // BPMN-specific CSS — no font-style:italic per CLAUDE.md design rule
 // ---------------------------------------------------------------------------
 
-export const BPMN_PROCESS_CSS = `
+export function bpmnProcessCss(t: BpmnTypography = DEFAULT_BPMN_TYPOGRAPHY): string {
+  return `
 .bpmn-pool { fill: var(--ts-bg-surface,#f8fafc); stroke: var(--ts-node-stroke,#004d67); stroke-width: 1.5; }
 .bpmn-pool-name { fill: var(--ts-bg-elevated,#f1f5f9); stroke: var(--ts-node-stroke,#004d67); stroke-width: 0.75; }
 .bpmn-lane { fill: var(--ts-bg,#ffffff); stroke: var(--ts-node-stroke,#004d67); stroke-width: 0.75; }
 .bpmn-lane-header { fill: var(--ts-bg-elevated,#f1f5f9); stroke: var(--ts-node-stroke,#004d67); stroke-width: 0.75; }
-.bpmn-pool-label { fill: var(--ts-text-primary,#0d2b35); font-family: var(--vscode-font-family, system-ui, -apple-system, sans-serif); font-size: 11px; font-weight: 700; }
-.bpmn-lane-label { fill: var(--ts-text-primary,#0d2b35); font-family: var(--vscode-font-family, system-ui, -apple-system, sans-serif); font-size: 11px; font-weight: 600; }
+.bpmn-pool-label { fill: var(--ts-text-primary,#0d2b35); font-family: var(--vscode-font-family, system-ui, -apple-system, sans-serif); font-size: ${t.headerFontPx}px; font-weight: 700; }
+.bpmn-lane-label { fill: var(--ts-text-primary,#0d2b35); font-family: var(--vscode-font-family, system-ui, -apple-system, sans-serif); font-size: ${t.headerFontPx}px; font-weight: 600; }
 .bpmn-task { fill: var(--ts-bg,#ffffff); stroke: var(--ts-node-stroke,#004d67); stroke-width: 1.5; }
-.bpmn-task-name { fill: var(--ts-text-primary,#0d2b35); font-family: var(--vscode-font-family, system-ui, -apple-system, sans-serif); font-size: 11px; text-anchor: middle; }
+.bpmn-task-name { fill: var(--ts-text-primary,#0d2b35); font-family: var(--vscode-font-family, system-ui, -apple-system, sans-serif); font-size: ${t.taskFontPx}px; text-anchor: middle; }
 .bpmn-event { fill: var(--ts-bg,#ffffff); stroke: var(--ts-node-stroke,#004d67); }
 .bpmn-event-start { stroke-width: 1.5; }
 .bpmn-event-end { stroke-width: 4; }
-.bpmn-event-label { fill: var(--ts-text-secondary,#516970); font-family: var(--vscode-font-family, system-ui, -apple-system, sans-serif); font-size: 10px; text-anchor: middle; }
+.bpmn-event-label { fill: var(--ts-text-secondary,#516970); font-family: var(--vscode-font-family, system-ui, -apple-system, sans-serif); font-size: ${t.labelFontPx}px; text-anchor: middle; }
 .bpmn-gateway { fill: var(--ts-bg,#ffffff); stroke: var(--ts-node-stroke,#004d67); stroke-width: 1.5; }
 .bpmn-gateway-marker { stroke: var(--ts-node-stroke,#004d67); stroke-width: 2.5; stroke-linecap: round; fill: none; }
-.bpmn-gateway-label { fill: var(--ts-text-secondary,#516970); font-family: var(--vscode-font-family, system-ui, -apple-system, sans-serif); font-size: 10px; text-anchor: middle; }
+.bpmn-gateway-label { fill: var(--ts-text-secondary,#516970); font-family: var(--vscode-font-family, system-ui, -apple-system, sans-serif); font-size: ${t.labelFontPx}px; text-anchor: middle; }
 .bpmn-seq-flow { fill: none; stroke: var(--ts-edge-stroke,#004d67); stroke-width: 1.5; }
 .bpmn-default-mark { stroke: var(--ts-edge-stroke,#004d67); stroke-width: 1.5; stroke-linecap: round; }
 .bpmn-assoc { fill: none; stroke: var(--ts-edge-stroke,#004d67); stroke-width: 1; stroke-dasharray: 4 2; }
 .bpmn-data-obj { fill: var(--ts-bg,#ffffff); stroke: var(--ts-node-stroke,#004d67); stroke-width: 1; }
-.bpmn-data-obj-label { fill: var(--ts-text-secondary,#516970); font-size: 10px; text-anchor: middle; }
+.bpmn-data-obj-label { fill: var(--ts-text-secondary,#516970); font-size: ${t.labelFontPx}px; text-anchor: middle; }
 .bpmn-event-intermediate { fill: none; stroke: var(--ts-node-stroke,#004d67); stroke-width: 1; }
 .bpmn-event-icon { fill: none; stroke: var(--ts-node-stroke,#004d67); stroke-width: 1.5; stroke-linecap: round; stroke-linejoin: round; }
 `;
+}
+
+/** Default-preview CSS (11 px / 10 px). Presentation export builds its own via `bpmnProcessCss`. */
+export const BPMN_PROCESS_CSS = bpmnProcessCss(DEFAULT_BPMN_TYPOGRAPHY);
 
 // ---------------------------------------------------------------------------
 // Internal helpers
@@ -153,54 +193,56 @@ function wordTruncate(text: string, maxChars: number): string {
 }
 
 function fitRotatedHeaderText(name: string, spanPx: number): string {
-  const maxChars = Math.max(4, Math.floor(spanPx / HEADER_LABEL_CHAR_W));
+  const maxChars = Math.max(4, Math.floor(spanPx / typo.headerCharW));
   return wordTruncate(name, maxChars);
 }
 
 function wrapTaskName(name: string): string[] {
   if (!name) return [];
+  const limit = typo.taskChars;
   const words = name.split(/\s+/);
   const lines: string[] = [];
   let cur = '';
   for (const w of words) {
-    const token = w.length > TASK_CHARS ? w.slice(0, TASK_CHARS - 1) + '…' : w;
+    const token = w.length > limit ? w.slice(0, limit - 1) + '…' : w;
     if (!cur) {
       cur = token;
-    } else if (cur.length + 1 + token.length <= TASK_CHARS) {
+    } else if (cur.length + 1 + token.length <= limit) {
       cur += ' ' + token;
     } else {
       lines.push(cur);
       if (lines.length === 3) {
-        if (lines[2].length > TASK_CHARS - 1) lines[2] = lines[2].slice(0, TASK_CHARS - 1) + '…';
+        if (lines[2].length > limit - 1) lines[2] = lines[2].slice(0, limit - 1) + '…';
         return lines;
       }
       cur = token;
     }
   }
   if (cur && lines.length < 3) lines.push(cur);
-  if (lines.length === 0) lines.push(name.slice(0, TASK_CHARS));
+  if (lines.length === 0) lines.push(name.slice(0, limit));
   return lines;
 }
 
 function taskNameSvg(name: string | undefined, cx: number, cy: number): string {
   if (!name) return '';
   const lines = wrapTaskName(name);
-  const totalH = lines.length * TASK_LINE_H;
-  const startY = cy - totalH / 2 + TASK_LINE_H * 0.8;
+  const totalH = lines.length * typo.taskLineH;
+  const startY = cy - totalH / 2 + typo.taskLineH * 0.8;
   const tspans = lines
-    .map((ln, i) => `<tspan x="${r(cx)}" y="${r(startY + i * TASK_LINE_H)}">${escXml(ln)}</tspan>`)
+    .map((ln, i) => `<tspan x="${r(cx)}" y="${r(startY + i * typo.taskLineH)}">${escXml(ln)}</tspan>`)
     .join('');
   return `<text class="bpmn-task-name">${tspans}</text>`;
 }
 
 function wrapBelowLabel(name: string): string[] {
+  const limit = typo.labelChars;
   const words = name.split(/\s+/).filter(Boolean);
   const allLines: string[] = [];
   let cur = '';
   for (const word of words) {
-    const tok = word.length > LABEL_CHARS ? word.slice(0, LABEL_CHARS - 1) + '…' : word;
+    const tok = word.length > limit ? word.slice(0, limit - 1) + '…' : word;
     const test = cur ? `${cur} ${tok}` : tok;
-    if (test.length <= LABEL_CHARS) {
+    if (test.length <= limit) {
       cur = test;
     } else {
       if (cur) allLines.push(cur);
@@ -208,11 +250,11 @@ function wrapBelowLabel(name: string): string[] {
     }
   }
   if (cur) allLines.push(cur);
-  if (allLines.length === 0) return [name.slice(0, LABEL_CHARS)];
+  if (allLines.length === 0) return [name.slice(0, limit)];
   if (allLines.length <= 3) return allLines;
   const lines = allLines.slice(0, 3);
   const last = lines[2];
-  lines[2] = last.length + 1 <= LABEL_CHARS ? last + '…' : last.slice(0, LABEL_CHARS - 1) + '…';
+  lines[2] = last.length + 1 <= limit ? last + '…' : last.slice(0, limit - 1) + '…';
   return lines;
 }
 
@@ -226,7 +268,7 @@ function belowLabelSvg(name: string | undefined, cls: string, cx: number, belowY
     return `<text class="${cls}" x="${r(textX)}" y="${startY}">${escXml(lines[0])}</text>`;
   }
   const tspans = lines
-    .map((ln, i) => `<tspan x="${r(textX)}" dy="${i === 0 ? 0 : LABEL_LINE_H}">${escXml(ln)}</tspan>`)
+    .map((ln, i) => `<tspan x="${r(textX)}" dy="${i === 0 ? 0 : typo.labelLineH}">${escXml(ln)}</tspan>`)
     .join('');
   return `<text class="${cls}" x="${r(textX)}" y="${startY}">${tspans}</text>`;
 }
@@ -488,20 +530,23 @@ export function renderProcessLayoutSvg(
   options: RenderProcessOptions = {},
 ): string {
   const { title = '', topInset = title ? 32 : 0 } = options;
-  const pb = layout.poolBounds;
-  const PAD = 16;
-
-  const svgW = r(pb.x + pb.width + PAD);
-  const svgH = r(pb.y + pb.height + PAD + topInset);
-
-  const embedCss = generateSvgEmbedCss('transitrix') + BPMN_PROCESS_CSS;
-  const body = renderProcessBody(layout, 0, topInset);
-
-  return (
-    `<svg xmlns="http://www.w3.org/2000/svg" width="${svgW}" height="${svgH}" viewBox="0 0 ${svgW} ${svgH}">\n` +
-    `<style>${embedCss}</style>\n` +
-    (title ? `${title}\n` : '') +
-    `${body}\n` +
-    `</svg>`
-  );
+  const t = options.typography ?? DEFAULT_BPMN_TYPOGRAPHY;
+  return runWithTypography(t, () => {
+    const pb = layout.poolBounds;
+    const PAD = 16;
+
+    const svgW = r(pb.x + pb.width + PAD);
+    const svgH = r(pb.y + pb.height + PAD + topInset);
+
+    const embedCss = generateSvgEmbedCss('transitrix') + bpmnProcessCss(t);
+    const body = renderProcessBody(layout, 0, topInset);
+
+    return (
+      `<svg xmlns="http://www.w3.org/2000/svg" width="${svgW}" height="${svgH}" viewBox="0 0 ${svgW} ${svgH}">\n` +
+      `<style>${embedCss}</style>\n` +
+      (title ? `${title}\n` : '') +
+      `${body}\n` +
+      `</svg>`
+    );
+  });
 }