@transferwise/components 46.140.0 → 46.141.0

package/src/nudge/Nudge.tsx

@@ -1,6 +1,6 @@
 import { Illustration, Assets, type IllustrationNames } from '@wise/art';
 import { clsx } from 'clsx';
-import { ReactNode, useEffect, useState, MouseEvent } from 'react';
+import { ReactNode, useEffect, useState, MouseEvent, useCallback } from 'react';
 
 import Body from '../body';
 import { Typography } from '../common';
@@ -96,8 +96,27 @@ const Nudge = ({
   action,
 }: Props) => {
   const intl = useIntl();
-  const [isDismissed, setIsDismissed] = useState(false);
-  const [isMounted, setIsMounted] = useState(false);
+  const getIsDismissed = useCallback(
+    () => (persistDismissal && id ? !!getLocalStorage()?.find((item) => item === id) : false),
+    [persistDismissal, id],
+  );
+
+  const [nudgeState, setNudgeState] = useState(() => ({
+    isDismissed: getIsDismissed(),
+    isMounted: false,
+  }));
+
+  useEffect(() => {
+    // eslint-disable-next-line react-hooks/set-state-in-effect -- Setting mount state in mount effect
+    setNudgeState((prev) => ({ ...prev, isMounted: true }));
+  }, []);
+
+  useEffect(() => {
+    // eslint-disable-next-line react-hooks/set-state-in-effect -- Syncing dismissed state from localStorage on prop change
+    setNudgeState((prev) => ({ ...prev, isDismissed: getIsDismissed() }));
+  }, [getIsDismissed, id, persistDismissal]);
+
+  const { isDismissed } = nudgeState;
 
   const handleOnDismiss = () => {
     const dismissedNudgesStorage = getLocalStorage();
@@ -105,9 +124,9 @@ const Nudge = ({
     if (persistDismissal && id) {
       try {
         localStorage.setItem(STORAGE_NAME, JSON.stringify([...dismissedNudgesStorage, id]));
-      } catch (error) {}
+      } catch {}
 
-      setIsDismissed(true);
+      setNudgeState((prev) => ({ ...prev, isDismissed: true }));
     }
 
     if (onDismiss) {
@@ -116,25 +135,15 @@ const Nudge = ({
   };
 
   useEffect(() => {
-    if (persistDismissal && id) {
+    if (persistDismissal && id && isPreviouslyDismissed) {
       const dismissedNudgesStorage = getLocalStorage();
-      let isDismissed = false;
-
-      if (dismissedNudgesStorage?.find((item) => item === id)) {
-        setIsDismissed(true);
-        isDismissed = true;
-      }
-
-      if (isPreviouslyDismissed) {
-        isPreviouslyDismissed(isDismissed);
-      }
+      const wasDismissed = !!dismissedNudgesStorage?.find((item) => item === id);
+      isPreviouslyDismissed(wasDismissed);
     }
-
-    setIsMounted(true);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [id, persistDismissal]);
 
-  if (persistDismissal && (isDismissed || !isMounted)) {
+  if (persistDismissal && (isDismissed || !nudgeState.isMounted)) {
     return null;
   }
 
@@ -143,7 +152,7 @@ const Nudge = ({
       {!!mediaName && (
         <div className="wds-nudge-media">
           <Illustration
-            name={mediaName as IllustrationNames}
+            name={mediaName}
             className={clsx(`wds-nudge-media-${mediaName}`)}
             size="small"
             disablePadding

package/src/phoneNumberInput/PhoneNumberInput.test.tsx

@@ -283,6 +283,22 @@ describe('PhoneNumberInput', () => {
         expect(props.onChange).toHaveBeenCalledWith('+201111111', '+20');
       });
     });
+
+    describe('onChange deduplication', () => {
+      it('should not call onChange when the composed phone number has not changed', () => {
+        const onChangeMock = jest.fn();
+        const { rerender } = render(
+          <PhoneNumberInput initialValue="+441234567890" onChange={onChangeMock} />,
+        );
+
+        onChangeMock.mockClear();
+
+        // Rerender with the same initialValue - internal state should not trigger onChange
+        rerender(<PhoneNumberInput initialValue="+441234567890" onChange={onChangeMock} />);
+
+        expect(onChangeMock).not.toHaveBeenCalled();
+      });
+    });
   });
 
   describe('when selectProps is supplied', () => {

package/src/phoneNumberInput/PhoneNumberInput.tsx

@@ -75,12 +75,13 @@ const PhoneNumberInput = ({
 
   const { locale, formatMessage } = useIntl();
 
+  const [randomId] = useState(() => Math.random().toString(36).slice(2, 8));
+
   const createId = (customID: string | undefined, backup: string): string => {
     if (customID) {
       return customID + (backup ? `-${backup}` : '');
     }
-    const random = Math.random().toString(36).slice(2, 8);
-    return `${backup}-${random}`;
+    return `${backup}-${randomId}`;
   };
 
   // Link the first non-disabled input to the the Field label, if present
@@ -107,14 +108,16 @@ const PhoneNumberInput = ({
 
     return explodeNumberModel(cleanValue);
   });
-  const [broadcastedValue, setBroadcastedValue] = useState<PhoneNumber | null>(null);
+  const broadcastedValueRef = useRef<PhoneNumber>(internalValue);
 
   const [suffixDirty, setSuffixDirty] = useState(false);
+
   useEffect(() => {
-    if (internalValue.suffix) {
+    if (!suffixDirty && internalValue.suffix) {
+      // eslint-disable-next-line react-hooks/set-state-in-effect -- Tracking when suffix becomes dirty
       setSuffixDirty(true);
     }
-  }, [internalValue.suffix]);
+  }, [internalValue.suffix, suffixDirty]);
 
   const countriesByPrefix = useMemo(
     () =>
@@ -152,13 +155,8 @@ const PhoneNumberInput = ({
   };
 
   useEffect(() => {
-    if (broadcastedValue === null) {
-      setBroadcastedValue(internalValue);
-      return;
-    }
-
     const internalPhoneNumber = `${internalValue.prefix ?? ''}${internalValue.suffix}`;
-    const broadcastedPhoneNumber = `${broadcastedValue.prefix ?? ''}${broadcastedValue.suffix}`;
+    const broadcastedPhoneNumber = `${broadcastedValueRef.current.prefix ?? ''}${broadcastedValueRef.current.suffix}`;
 
     if (internalPhoneNumber === broadcastedPhoneNumber) {
       return;
@@ -172,8 +170,8 @@ const PhoneNumberInput = ({
       newValue,
       internalValue.prefix ?? '', // TODO: Allow `null` in public API
     );
-    setBroadcastedValue(internalValue);
-  }, [onChange, broadcastedValue, internalValue]);
+    broadcastedValueRef.current = internalValue;
+  }, [onChange, internalValue]);
 
   useEffect(() => {
     const labelRef = fieldLabelRef?.current;

package/src/promoCard/PromoCard.story.tsx

@@ -47,7 +47,7 @@ export const TaskCard: Story = {
     isSmall: true,
     useDisplayFont: false,
     className: 'taskCard',
-  } as PromoCardLinkProps,
+  },
   decorators: [
     (Story) => (
       <div>
@@ -90,7 +90,7 @@ export const TaskCardWithCustomIcon: Story = {
   args: {
     ...TaskCard.args,
     indicatorIcon: <StarFill size={24} aria-hidden="true" />,
-  } as PromoCardLinkProps,
+  },
   decorators: TaskCard.decorators,
 };
 
@@ -101,7 +101,7 @@ export const TaskCardCompleted: Story = {
     href: undefined,
     indicatorIcon: 'check',
     className: 'taskCard taskCard--completed np-theme--personal np-theme-personal--forest-green',
-  } as PromoCardLinkProps,
+  },
   decorators: TaskCard.decorators,
 };
 

package/src/promoCard/PromoCardGroup.tsx

@@ -67,8 +67,45 @@ const PromoCardGroup: FunctionComponent<PromoCardGroupProps> = ({
   onChange = () => {},
   testId,
 }) => {
-  const [state, setState] = useState<string>(defaultChecked);
-  const [containerRole, setContainerRole] = useState<string | null>(null);
+  const [promoCardState, setPromoCardState] = useState<{
+    defaultChecked: string;
+    state: string;
+  }>({
+    defaultChecked,
+    state: defaultChecked,
+  });
+
+  useEffect(() => {
+    if (promoCardState.defaultChecked !== defaultChecked) {
+      // eslint-disable-next-line react-hooks/set-state-in-effect -- Syncing defaultChecked prop to internal state
+      setPromoCardState({
+        defaultChecked,
+        state: defaultChecked,
+      });
+    }
+  }, [defaultChecked, promoCardState.defaultChecked]);
+
+  const { state } = promoCardState;
+  const setState = (newState: string) =>
+    setPromoCardState((prev) => ({ ...prev, state: newState }));
+
+  // Derive container role from children
+  const containerRole = useMemo(() => {
+    // Collect an array of types from the children PromoCard components
+    const types =
+      React.Children.map(children, (child) => {
+        if (React.isValidElement<PromoCardProps>(child) && child.props.type) {
+          return child.props.type;
+        }
+        return null;
+      })?.filter((type): type is 'radio' | 'checkbox' => type !== null && type !== undefined) ?? [];
+
+    // Check if all types are the same
+    const allTypesAreTheSame = types.every((type) => type === types[0]);
+
+    // If all types are the same and the type is 'radio', return 'radiogroup'
+    return allTypesAreTheSame && types[0] === 'radio' ? 'radiogroup' : null;
+  }, [children]);
 
   /**
    * The context value for the PromoCardGroup.
@@ -103,25 +140,6 @@ const PromoCardGroup: FunctionComponent<PromoCardGroupProps> = ({
     role: containerRole as AriaRoleRadioGroup | undefined, // Add the role attribute here
   };
 
-  useEffect(() => {
-    setState(defaultChecked);
-
-    // Collect an array of types from the children PromoCard components
-    const types =
-      React.Children.map(children, (child) => {
-        if (React.isValidElement<PromoCardProps>(child) && child.props.type) {
-          return child.props.type;
-        }
-        return null;
-      })?.filter((type): type is 'radio' | 'checkbox' => type !== null && type !== undefined) ?? [];
-
-    // Check if all types are the same
-    const allTypesAreTheSame = types.every((type) => type === types[0]);
-
-    // If all types are the same and the type is 'radio', set the container role
-    setContainerRole(allTypesAreTheSame && types[0] === 'radio' ? 'radiogroup' : null);
-  }, [defaultChecked, children]);
-
   return (
     <PromoCardContext.Provider value={contextValue}>
       <div {...commonProps}>{children}</div>

package/src/segmentedControl/SegmentedControl.test.tsx

@@ -188,4 +188,29 @@ describe('SegmentedControl', () => {
       'SegmentedControl only supports up to 3 segments. Please refer to: https://wise.design/components/segmented-control',
     );
   });
+
+  describe('animation behavior', () => {
+    it('skips animation on initial render', () => {
+      renderSegmentedControl();
+
+      // On initial render, the component should render without triggering animation
+      // The isMountedRef ensures animation is skipped on first render
+      const segmentedControl = screen.getByTestId('segmented-control');
+
+      // Verify the component renders successfully
+      expect(segmentedControl).toBeInTheDocument();
+    });
+
+    it('enables animation after value change', async () => {
+      renderSegmentedControl();
+
+      // Change value by clicking on a different segment
+      const payroll = screen.getByRole('radio', { name: 'Payroll' });
+      await userEvent.click(payroll);
+
+      // After a value change, the component should have completed at least one update cycle
+      // verifying that the isMountedRef tracking works correctly
+      expect(onChange).toHaveBeenCalledWith('payroll');
+    });
+  });
 });

package/src/segmentedControl/SegmentedControl.tsx

@@ -38,6 +38,7 @@ const SegmentedControl = ({
   segments,
   onChange,
 }: SegmentedControlProps) => {
+  const isMountedRef = useRef(false);
   const [animate, setAnimate] = useState(false);
 
   const segmentsRef = useRef<HTMLDivElement>(null);
@@ -67,7 +68,12 @@ const SegmentedControl = ({
   };
 
   useEffect(() => {
-    setAnimate(true);
+    if (isMountedRef.current) {
+      setAnimate(true);
+    } else {
+      isMountedRef.current = true;
+    }
+
     updateSegmentPosition();
 
     const handleWindowSizeChange = () => {

package/src/select/Select.story.tsx

@@ -43,7 +43,7 @@ const ImageIcon = () => (
 );
 
 const isSelectOptionItem = (option: SelectItem | null): option is SelectOptionItem => {
-  return option !== null && typeof option.value !== 'undefined';
+  return typeof option?.value !== 'undefined';
 };
 
 export const Basic: Story = {

package/src/styles/less/core/viewport-themes.css

@@ -1,47 +1,51 @@
 @media (max-width: 320px) {
   .np-theme-personal {
-    --delta: 2;
-    --size-4: calc(4px / var(--delta));
-    --size-5: calc(5px / var(--delta));
-    --size-8: calc(8px / var(--delta));
-    --size-10: calc(10px / var(--delta));
-    --size-12: calc(12px / var(--delta));
-    --size-14: calc(14px / var(--delta));
-    --size-16: calc(16px / var(--delta));
-    --size-24: calc(24px / var(--delta));
-    --size-32: calc(32px / var(--delta));
-    --size-40: calc(40px / var(--delta));
-    --size-48: calc(48px / var(--delta));
-    --size-52: calc(52px / var(--delta));
-    --size-56: calc(56px / var(--delta));
-    --size-60: calc(60px / var(--delta));
-    --size-64: calc(64px / var(--delta));
-    --size-72: calc(72px / var(--delta));
-    --size-80: calc(80px / var(--delta));
-    --size-88: calc(88px / var(--delta));
-    --size-96: calc(96px / var(--delta));
-    --size-104: calc(104px / var(--delta));
-    --size-112: calc(112px / var(--delta));
-    --size-120: calc(120px / var(--delta));
-    --size-126: calc(126px / var(--delta));
-    --size-128: calc(128px / var(--delta));
-    --size-146: calc(146px / var(--delta));
-    --size-154: calc(154px / var(--delta));
-    --size-x-small: calc(24px / var(--delta));
-    --size-small: calc(32px / var(--delta));
-    --size-medium: calc(40px / var(--delta));
-    --size-large: calc(48px / var(--delta));
-    --size-x-large: calc(56px / var(--delta));
-    --size-2x-large: calc(72px / var(--delta));
-    --space-content-horizontal: calc(16px / var(--delta));
-    --space-small: calc(16px / var(--delta));
-    --space-medium: calc(32px / var(--delta));
-    --space-large: calc(40px / var(--delta));
-    --space-x-large: calc(56px / var(--delta));
-    --padding-x-small: var(--size-8);
-    --padding-small: var(--size-16);
-    --padding-medium: var(--size-24);
-    --padding-large: var(--size-32);
+    --padding-x-small: 4px;
+    --padding-small: 8px;
+    --padding-medium: 12px;
+    --padding-large: 16px;
+    --size-4: 2px;
+    --size-5: 2.5px;
+    --size-8: 4px;
+    --size-10: 5px;
+    --size-12: 6px;
+    --size-14: 7px;
+    --size-16: 8px;
+    --size-24: 12px;
+    --size-32: 16px;
+    --size-40: 20px;
+    --size-48: 24px;
+    --size-52: 26px;
+    --size-56: 28px;
+    --size-60: 30px;
+    --size-64: 32px;
+    --size-72: 36px;
+    --size-80: 40px;
+    --size-88: 44px;
+    --size-96: 48px;
+    --size-104: 52px;
+    --size-112: 56px;
+    --size-120: 60px;
+    --size-126: 63px;
+    --size-128: 64px;
+    --size-146: 73px;
+    --size-154: 77px;
+    --size-160: 80px;
+    --size-x-small: 12px;
+    --size-small: 16px;
+    --size-medium: 20px;
+    --size-large: 24px;
+    --size-x-large: 28px;
+    --size-2x-large: 36px;
+    --space-content-horizontal: 8px;
+    --space-small: 8px;
+    --space-medium: 16px;
+    --space-large: 20px;
+    --space-x-large: 28px;
+  }
+}
+@media (max-width: 320px) {
+  .np-theme-personal {
     --input-height-base: var(--size-32);
     --input-height-large: var(--input-height-small);
     --input-padding: var(--input-padding-small);

package/src/styles/less/core/viewport-themes.less

@@ -1,51 +1,8 @@
-@import '@transferwise/neptune-tokens/themes/personal/tokens.less';
+@import "@transferwise/neptune-tokens/themes/personal/tokens.less";
+@import "@transferwise/neptune-tokens/tiny-viewport.less";
 
 @media (--screen-400-zoom) {
   .np-theme-personal {
-    --delta: 2;
-
-    --size-4: calc(@size-4 / var(--delta));
-    --size-5: calc(@size-5 / var(--delta));
-    --size-8: calc(@size-8 / var(--delta));
-    --size-10: calc(@size-10 / var(--delta));
-    --size-12: calc(@size-12 / var(--delta));
-    --size-14: calc(@size-14 / var(--delta));
-    --size-16: calc(@size-16 / var(--delta));
-    --size-24: calc(@size-24 / var(--delta));
-    --size-32: calc(@size-32 / var(--delta));
-    --size-40: calc(@size-40 / var(--delta));
-    --size-48: calc(@size-48 / var(--delta));
-    --size-52: calc(@size-52 / var(--delta));
-    --size-56: calc(@size-56 / var(--delta));
-    --size-60: calc(@size-60 / var(--delta));
-    --size-64: calc(@size-64 / var(--delta));
-    --size-72: calc(@size-72 / var(--delta));
-    --size-80: calc(@size-80 / var(--delta));
-    --size-88: calc(@size-88 / var(--delta));
-    --size-96: calc(@size-96 / var(--delta));
-    --size-104: calc(@size-104 / var(--delta));
-    --size-112: calc(@size-112 / var(--delta));
-    --size-120: calc(@size-120 / var(--delta));
-    --size-126: calc(@size-126 / var(--delta));
-    --size-128: calc(@size-128 / var(--delta));
-    --size-146: calc(@size-146 / var(--delta));
-    --size-154: calc(@size-154 / var(--delta));
-    --size-x-small: calc(@size-x-small / var(--delta));
-    --size-small: calc(@size-small / var(--delta));
-    --size-medium: calc(@size-medium / var(--delta));
-    --size-large: calc(@size-large / var(--delta));
-    --size-x-large: calc(@size-x-large / var(--delta));
-    --size-2x-large: calc(@size-2x-large / var(--delta));
-    --space-content-horizontal: calc(@space-content-horizontal / var(--delta));
-    --space-small: calc(@space-small / var(--delta));
-    --space-medium: calc(@space-medium / var(--delta));
-    --space-large: calc(@space-large / var(--delta));
-    --space-x-large: calc(@space-x-large / var(--delta));
-    --padding-x-small: var(--size-8);
-    --padding-small: var(--size-16);
-    --padding-medium: var(--size-24);
-    --padding-large: var(--size-32);
-
     --input-height-base: var(--size-32);
     --input-height-large: var(--input-height-small);
     --input-padding: var(--input-padding-small);