@transferwise/components 0.0.0-experimental-991400c → 0.0.0-experimental-fb447f5

package/build/types/alert/Alert.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"Alert.d.ts","sourceRoot":"","sources":["../../../src/alert/Alert.js"],"names":[],"mappings":";AA8BA,gEAiGC"}
+{"version":3,"file":"Alert.d.ts","sourceRoot":"","sources":["../../../src/alert/Alert.js"],"names":[],"mappings":";AA8BA,gEAyFC"}

package/build/types/instructionsList/InstructionsList.d.ts

@@ -3,7 +3,15 @@ import { CommonProps } from '../common';
 type Props = CommonProps & {
     dos?: ReactNode[];
     donts?: ReactNode[];
+    /**
+     * Add meaning to "do" icon of "do" items
+     */
+    ['do-aria-label']?: string;
+    /**
+     * Add meaning to "don't" icon of "don't" items
+     */
+    ['dont-aria-label']?: string;
 };
-declare const InstructionsList: (props: Props) => import("react").JSX.Element;
+declare const InstructionsList: ({ dos, donts, "do-aria-label": doAriaLabel, "dont-aria-label": dontAriaLabel, }: Props) => import("react").JSX.Element;
 export default InstructionsList;
 //# sourceMappingURL=InstructionsList.d.ts.map

package/build/types/instructionsList/InstructionsList.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"InstructionsList.d.ts","sourceRoot":"","sources":["../../../src/instructionsList/InstructionsList.tsx"],"names":[],"mappings":"AAEA,OAAO,EAAE,SAAS,EAAE,MAAM,OAAO,CAAC;AAGlC,OAAO,EAAE,WAAW,EAAE,MAAM,WAAW,CAAC;AAGxC,KAAK,KAAK,GAAG,WAAW,GAAG;IACzB,GAAG,CAAC,EAAE,SAAS,EAAE,CAAC;IAClB,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC;CACrB,CAAC;AAEF,QAAA,MAAM,gBAAgB,UAAW,KAAK,gCA8BrC,CAAC;AAEF,eAAe,gBAAgB,CAAC"}
+{"version":3,"file":"InstructionsList.d.ts","sourceRoot":"","sources":["../../../src/instructionsList/InstructionsList.tsx"],"names":[],"mappings":"AACA,OAAO,EAAE,SAAS,EAAE,MAAM,OAAO,CAAC;AAGlC,OAAO,EAAE,WAAW,EAAE,MAAM,WAAW,CAAC;AAGxC,KAAK,KAAK,GAAG,WAAW,GAAG;IACzB,GAAG,CAAC,EAAE,SAAS,EAAE,CAAC;IAClB,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC;IACpB;;OAEG;IACH,CAAC,eAAe,CAAC,CAAC,EAAE,MAAM,CAAC;IAC3B;;OAEG;IACH,CAAC,iBAAiB,CAAC,CAAC,EAAE,MAAM,CAAC;CAC9B,CAAC;AAEF,QAAA,MAAM,gBAAgB,oFAKnB,KAAK,gCAyBP,CAAC;AAEF,eAAe,gBAAgB,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@transferwise/components",
-  "version": "0.0.0-experimental-991400c",
+  "version": "0.0.0-experimental-fb447f5",
   "description": "Neptune React components",
   "license": "Apache-2.0",
   "repository": {

package/src/alert/Alert.js

@@ -62,13 +62,6 @@ const Alert = (props) => {
     }
   }
 
-  function calculateAriaLive() {
-    if ([Sentiment.NEGATIVE, Sentiment.POSITIVE, Sentiment.WARNING].includes(mappedType)) {
-      return 'assertive';
-    }
-    return 'polite';
-  }
-
   const handleTouchStart = () => setShouldFire(true);
   const handleTouchMove = () => setShouldFire(false);
   const handleTouchEnd = (event) => {
@@ -87,7 +80,6 @@ const Alert = (props) => {
   return (
     <div
       role="alert"
-      aria-live={calculateAriaLive()}
       className={classNames('alert d-flex', `alert-${mappedType}`, className)}
       onTouchStart={handleTouchStart}
       onTouchEnd={handleTouchEnd}

package/src/alert/Alert.spec.js

@@ -277,15 +277,6 @@ describe('Alert', () => {
       expect(component).toHaveClass(classForType(Sentiment.WARNING));
       expect(screen.getByTestId('warning-icon')).toBeInTheDocument();
     });
-
-    it('renders warning alerts with aria-live assertive', () => {
-      component = getComponentWithType(Sentiment.WARNING);
-      expect(component).toHaveAttribute('aria-live', 'assertive');
-    });
-    it('renders neutral alerts with aria-live polite', () => {
-      component = getComponentWithType(Sentiment.NEUTRAL);
-      expect(component).toHaveAttribute('aria-live', 'polite');
-    });
   });
 
   describe('on touch devices', () => {

package/src/instructionsList/InstructionList.story.js

@@ -1,4 +1,9 @@
+import { CrossCircleFill as DontIcon, CheckCircleFill as DoIcon } from '@transferwise/icons';
+
+import Body from '../body';
+import { Typography } from '../common';
 import Link from '../link';
+import Title from '../title';
 
 import InstructionsList from './InstructionsList';
 
@@ -25,3 +30,29 @@ export const Basic = () => {
     />
   );
 };
+
+export const IconsProvideDescription = () => {
+  return (
+    <>
+      <Body as="p">
+        In following example icons have visual meaning. <DontIcon className="d-inline-flex" /> means
+        "doesn't support" while <DoIcon className="d-inline-flex" /> means "supports". So we have to
+        make sure that this is works same for visually impaired users which use screen readers.
+      </Body>
+      <Body as="p">
+        We can do this by adding meaning to each icon via <code>do-aria-label="Supports"</code> and{' '}
+        <code>dont-aria-label="Doesn't support"</code> props. So screen reader will read "Supports
+        Multiple currencies" / "Doesn't support Create recipients".
+      </Body>
+      <Title type={Typography.TITLE_SUBSECTION} className="m-t-3">
+        List of Supported Features
+      </Title>
+      <InstructionsList
+        do-aria-label="Supports"
+        dos={['Multiple currencies', 'Existing recipients']}
+        dont-aria-label="Doesn't support"
+        donts={['Create recipients', 'Edit recipients']}
+      />
+    </>
+  );
+};

package/src/instructionsList/InstructionsList.css

@@ -1 +1 @@
-.tw-instructions{display:flex;flex-direction:column}.tw-instructions .instruction{display:flex;margin-top:8px;margin-top:var(--padding-x-small)}.tw-instructions .instruction .do,.tw-instructions .instruction .dont{flex-shrink:0;margin-bottom:0;margin-right:16px;margin-right:var(--padding-small)}.np-theme-personal .tw-instructions .instruction .do,.np-theme-personal .tw-instructions .instruction .dont{margin-right:8px;margin-right:var(--padding-x-small)}.tw-instructions .instruction .do{color:#008026;color:var(--color-content-positive)}.np-theme-personal .tw-instructions .instruction .do{color:var(--color-sentiment-positive)}.tw-instructions .instruction .dont{color:#cf2929;color:var(--color-content-negative)}.np-theme-personal .tw-instructions .instruction .dont{color:var(--color-sentiment-negative)}
+.tw-instructions{display:flex;flex-direction:column}.tw-instructions .instruction{display:flex;margin-top:8px;margin-top:var(--padding-x-small)}.tw-instructions .instruction .do,.tw-instructions .instruction .dont{flex-shrink:0;margin-bottom:0;margin-right:8px;margin-right:var(--padding-x-small)}.tw-instructions .instruction .do{color:var(--color-sentiment-positive)}.tw-instructions .instruction .dont{color:var(--color-sentiment-negative)}

package/src/instructionsList/InstructionsList.less

@@ -9,28 +9,16 @@
     .do,
     .dont {
       flex-shrink: 0;
-      margin-right: var(--padding-small);
+      margin-right: var(--padding-x-small);
       margin-bottom: 0;
-
-      .np-theme-personal & {
-        margin-right: var(--padding-x-small);
-      }
     }
 
     .do {
-      color: var(--color-content-positive);
-
-      .np-theme-personal & {
-        color: var(--color-sentiment-positive);
-      }
+      color: var(--color-sentiment-positive);
     }
 
     .dont {
-      color: var(--color-content-negative);
-
-      .np-theme-personal & {
-        color: var(--color-sentiment-negative);
-      }
+      color: var(--color-sentiment-negative);
     }
   }
 }

package/src/instructionsList/InstructionsList.spec.tsx

@@ -0,0 +1,50 @@
+import { render, screen } from '../test-utils';
+
+import InstructionsList from '.';
+
+describe('InstructionsList', () => {
+  it('should render dos list only', () => {
+    const dos = ['Test this component', 'With multiple dos'];
+    render(<InstructionsList dos={dos} />);
+
+    expect(screen.getByText(dos[0])).toBeInTheDocument();
+    expect(screen.getByText(dos[1])).toBeInTheDocument();
+  });
+
+  it('should render do items with description for icons', () => {
+    const dos = ['Card validation', 'ID verification'];
+    render(<InstructionsList dos={dos} do-aria-label="Do" />);
+
+    expect(screen.getByText(dos[0])).toBeInTheDocument();
+    expect(screen.getByText(dos[1])).toBeInTheDocument();
+    expect(screen.getAllByText('Do')).toHaveLength(2);
+  });
+
+  it('should render donts list only', () => {
+    const donts = ['Card validation', 'ID verification'];
+
+    render(<InstructionsList donts={donts} />);
+    expect(screen.getByText(donts[0])).toBeInTheDocument();
+    expect(screen.getByText(donts[1])).toBeInTheDocument();
+  });
+
+  it('should render do/dont lists with description for icons', () => {
+    const dos = ['Card validation'];
+    const donts = ['ID verification'];
+    const doIconDescription = 'Do';
+    const dontIconDescription = 'No';
+
+    render(
+      <InstructionsList
+        dos={dos}
+        do-aria-label={doIconDescription}
+        donts={donts}
+        dont-aria-label={dontIconDescription}
+      />,
+    );
+    expect(screen.getByText(dos[0])).toBeInTheDocument();
+    expect(screen.getByText(donts[0])).toBeInTheDocument();
+    expect(screen.getByText('Do')).toBeInTheDocument();
+    expect(screen.getByText('No')).toBeInTheDocument();
+  });
+});

package/src/instructionsList/InstructionsList.tsx

@@ -1,5 +1,4 @@
-import { CrossCircle, CrossCircleFill, CheckCircle, CheckCircleFill } from '@transferwise/icons';
-import { useTheme } from '@wise/components-theming';
+import { CrossCircleFill as DontIcon, CheckCircleFill as DoIcon } from '@transferwise/icons';
 import { ReactNode } from 'react';
 
 import Body from '../body/Body';
@@ -9,21 +8,29 @@ import { Typography } from '../common/propsValues/typography';
 type Props = CommonProps & {
   dos?: ReactNode[];
   donts?: ReactNode[];
+  /**
+   * Add meaning to "do" icon of "do" items
+   */
+  ['do-aria-label']?: string;
+  /**
+   * Add meaning to "don't" icon of "don't" items
+   */
+  ['dont-aria-label']?: string;
 };
 
-const InstructionsList = (props: Props) => {
-  const { isModern } = useTheme();
-  const { dos, donts } = props;
-  const DontIcon = isModern ? CrossCircleFill : CrossCircle;
-  const DoIcon = isModern ? CheckCircleFill : CheckCircle;
-
+const InstructionsList = ({
+  dos,
+  donts,
+  'do-aria-label': doAriaLabel = undefined,
+  'dont-aria-label': dontAriaLabel = undefined,
+}: Props) => {
   return (
     <div className="tw-instructions">
       {dos &&
         dos.map((doThis, index) => (
           // eslint-disable-next-line react/no-array-index-key
           <div key={index} className="instruction">
-            <DoIcon size={24} className="do" />
+            <DoIcon size={24} className="do" title={doAriaLabel} />
             <Body className="text-primary" type={Typography.BODY_LARGE}>
               {doThis}
             </Body>
@@ -33,7 +40,7 @@ const InstructionsList = (props: Props) => {
         donts.map((dont, index) => (
           // eslint-disable-next-line react/no-array-index-key
           <div key={index} className="instruction">
-            <DontIcon size={24} className="dont" />
+            <DontIcon size={24} className="dont" title={dontAriaLabel} />
             <Body className="text-primary" type={Typography.BODY_LARGE}>
               {dont}
             </Body>