@transferwise/components 0.0.0-experimental-438bbba → 0.0.0-experimental-cf33ac7

package/src/uploadInput/UploadInput.less

@@ -3,90 +3,28 @@
 @import (reference) './uploadItem/UploadItem.less';
 
 .np-upload-input {
-  &.form-control {
-    height: auto;
-    padding: initial;
-  }
-
-  & > div {
-    &:first-child,
-    &:first-child .np-upload-item--single-file,
-    &:first-child .np-upload-item--link {
-      border-top-left-radius: var(--radius-small);
-      border-top-right-radius: var(--radius-small);
-    }
-
-    &:last-child {
-      border-bottom-left-radius: var(--radius-small);
-      border-bottom-right-radius: var(--radius-small);
-    }
-  }
-}
+  --outerBorder: 1px solid var(--color-interactive-secondary);
+  border-radius: var(--radius-small);
 
-.np-theme-personal {
-  .np-upload-input {
-    &.disabled .btn {
-      cursor: inherit;
-    }
-
-    .np-upload-icon {
-      color: var(--color-interactive-primary);
-    }
-
-    .media-body {
-      padding-right: var(--size-32);
-      color: var(--color-content-link);
-      white-space: break-spaces;
-
-      @media (--screen-400-zoom) {
-        padding-right: var(--size-64);
-      }
+  .np-upload-input__section {
+    margin: 0;
 
-      .np-text-body-large-bold {
-        text-decoration: underline;
-        .link-underline();
-      }
-
-      .np-text-body-default,
-      .np-upload-description,
-      .text-positive {
-        color: var(--color-content-secondary) !important;
-      }
-
-      .text-negative {
-        color: var(--color-sentiment-negative) !important;
-      }
-    }
-
-    &-errors {
-      list-style: none;
-      padding-left: 0;
-
-      li {
-        position: relative;
-        padding-left: var(--size-16);
-
-        @media (--screen-400-zoom) {
-          padding-left: var(--size-32);
-        }
-
-        &:before {
-          content: '•';
-          position: absolute;
-          display: block;
-          left: 0;
-        }
+    // only 1 file allowed and already uploaded (no UploadButton shown)
+    &:only-child {
+      .np-upload-input__item {
+        border-radius: var(--radius-small);
+        border-bottom: var(--outerBorder);
       }
     }
 
-    .status-circle {
-      width: var(--size-x-small);
-      height: var(--size-x-small);
-
-      @media (--screen-400-zoom) {
-        width: var(--size-large);
-        height: var(--size-large);
-      }
+    // if the last item in the file list is interactive (not an error)
+    // and the user is hovering over it, then we need to adjust the
+    // bottom separator, which happens to be in .np-upload-input__section--uploader
+    &:has(.np-upload-input__item:last-child.is-interactive:hover)
+    + .np-upload-input__section--uploader .np-upload-input__upload-button::before {
+      left: 0;
+      width: 100%;
+      top: 0;
     }
   }
 }

package/src/uploadInput/UploadInput.tests.story.tsx

@@ -26,18 +26,23 @@ const files = [
     url: 'https://wise.com/public-resources/assets/logos/wise/brand_logo_inverse.svg',
   },
   {
-    id: 2,
+    id: 3,
+    filename: 'purchase-receipt-2.pdf',
+    url: 'https://wise.com/public-resources/assets/logos/wise/brand_logo_inverse.svg',
+  },
+  {
+    id: 4,
     filename: 'receipt failed.png',
     status: Status.FAILED,
   },
   {
-    id: 3,
+    id: 5,
     filename: 'receipt failed With error string.png',
     status: Status.FAILED,
     error: 'Something went wrong',
   },
   {
-    id: 4,
+    id: 6,
     filename: 'receipt failed With error object.png',
     status: Status.FAILED,
     error: { message: 'Something went wrong' },

package/src/uploadInput/UploadInput.tsx

@@ -1,5 +1,5 @@
 import { clsx } from 'clsx';
-import { useEffect, useRef, useState, useCallback } from 'react';
+import { useEffect, useRef, useState } from 'react';
 import { useIntl } from 'react-intl';
 
 import Button from '../button';
@@ -101,10 +101,6 @@ export type UploadInputProps = {
   Pick<UploadItemProps, 'onDownload'> &
   CommonProps;
 
-interface UploadItemRef extends HTMLDivElement {
-  focus: () => void;
-}
-
 function generateFileId(file: File) {
   const { name, size } = file;
   const uploadTimeStamp = new Date().getTime();
@@ -137,8 +133,6 @@ const UploadInput = ({
   const [markedFileForDelete, setMarkedFileForDelete] = useState<UploadedFile | null>(null);
   const [mounted, setMounted] = useState(false);
   const { formatMessage } = useIntl();
-  const itemRefs = useRef<(HTMLDivElement | null)[]>([]);
-  const uploadInputRef = useRef<HTMLInputElement | null>(null);
 
   const PROGRESS_STATUSES = new Set([Status.PENDING, Status.PROCESSING]);
 
@@ -146,9 +140,7 @@ const UploadInput = ({
     multiple || files.length === 0 ? files : [files[0]],
   );
 
-  const uploadedFilesListReference = useRef([
-    ...(multiple || files.length === 0 ? files : [files[0]]),
-  ]);
+  const uploadedFilesListReference = useRef(multiple || files.length === 0 ? files : [files[0]]);
 
   function addFileToList(recentUploadedFile: UploadedFile) {
     function addToList(listToAddTo: readonly UploadedFile[]) {
@@ -182,46 +174,21 @@ const UploadInput = ({
     uploadedFilesListReference.current = updateListItem(uploadedFilesListReference.current);
   };
 
-  const manageFocusAfterRemoval = useCallback(
-    (file: UploadedFile) => {
-      const index = uploadedFiles.findIndex((f) => f.id === file.id);
-      const nextFocusIndex =
-        uploadedFiles.length > 1
-          ? index === uploadedFiles.length - 1
-            ? index - 1
-            : index + 1
-          : -1;
-
-      if (nextFocusIndex >= 0 && itemRefs.current[nextFocusIndex]) {
-        itemRefs.current[nextFocusIndex].focus();
-      } else if (uploadInputRef.current) {
-        uploadInputRef.current.focus();
-      }
-    },
-    [uploadedFiles, itemRefs, uploadInputRef],
-  );
-
   const removeFile = (file: UploadedFile) => {
     const { id, status } = file;
 
     if (status === Status.FAILED) {
       // If removing a failed upload, we're just updating the view
       removeFileFromList(file);
-      manageFocusAfterRemoval(file);
     } else if (onDeleteFile && id) {
       // Set status to PROCESSING
       modifyFileInList(file, { status: Status.PROCESSING, error: undefined });
 
       // Notify host app about deletion
       onDeleteFile(id)
-        .then(() => {
-          removeFileFromList(file);
-        })
+        .then(() => removeFileFromList(file))
         .catch((error) => {
           modifyFileInList(file, { error: error as UploadError });
-        })
-        .finally(() => {
-          manageFocusAfterRemoval(file);
         });
     }
   };
@@ -340,39 +307,45 @@ const UploadInput = ({
         className={clsx('np-upload-input', className, { disabled })}
         {...inputAttributes}
       >
-        {uploadedFiles.map((file, index) => (
-          <UploadItem
-            key={file.id}
-            ref={(el: UploadItemRef | null) => {
-              itemRefs.current[index] = el;
-            }}
-            file={file}
-            singleFileUpload={!multiple}
-            canDelete={
-              (!!onDeleteFile || file.status === Status.FAILED) &&
-              (!file.status || !PROGRESS_STATUSES.has(file.status))
-            }
-            onDelete={
-              file.status === Status.FAILED
-                ? () => removeFile(file)
-                : () => setMarkedFileForDelete(file)
-            }
-            onDownload={onDownload}
-          />
-        ))}
+        <div
+          className="np-upload-input__section"
+          aria-live="polite"
+          aria-relevant="all"
+          role="region"
+        >
+          {uploadedFiles.map((file) => (
+            <UploadItem
+              key={file.id}
+              file={file}
+              singleFileUpload={!multiple}
+              canDelete={
+                (!!onDeleteFile || file.status === Status.FAILED) &&
+                (!file.status || !PROGRESS_STATUSES.has(file.status))
+              }
+              onDelete={
+                file.status === Status.FAILED
+                  ? () => removeFile(file)
+                  : () => setMarkedFileForDelete(file)
+              }
+              onDownload={onDownload}
+            />
+          ))}
+        </div>
         {(multiple || (!multiple && !uploadedFiles.length)) && (
-          <UploadButton
-            ref={uploadInputRef}
-            id={id}
-            uploadButtonTitle={uploadButtonTitle}
-            disabled={areMaximumFilesUploadedAlready() || disabled}
-            multiple={multiple}
-            fileTypes={fileTypes}
-            sizeLimit={sizeLimit}
-            description={description}
-            maxFiles={maxFiles}
-            onChange={addFiles}
-          />
+          <div className="np-upload-input__section np-upload-input__section--uploader">
+            <UploadButton
+              id={id}
+              uploadButtonTitle={uploadButtonTitle}
+              disabled={areMaximumFilesUploadedAlready() || disabled}
+              multiple={multiple}
+              fileTypes={fileTypes}
+              sizeLimit={sizeLimit}
+              description={description}
+              maxFiles={maxFiles}
+              withEntries={Boolean(uploadedFiles.length)}
+              onChange={addFiles}
+            />
+          </div>
         )}
       </div>
       <Modal

package/src/uploadInput/uploadButton/UploadButton.css

@@ -1,44 +1,91 @@
-.np-upload-button-container {
-  border-style: solid;
-}
-.np-upload-button-container .droppable-card-content {
+.np-upload-input__upload-button {
+  position: relative;
+  padding: 16px;
+  padding: var(--size-16);
   display: flex;
+  align-items: center;
+  margin: 0;
+  border-bottom-left-radius: 10px;
+  border-bottom-left-radius: var(--radius-small);
+  border-bottom-right-radius: 10px;
+  border-bottom-right-radius: var(--radius-small);
+  border: var(--outerBorder);
+  cursor: pointer;
+}
+.np-upload-input__upload-button .np-upload-input__title {
+  color: var(--color-content-link);
+  -webkit-text-decoration: underline;
+  text-decoration: underline;
+  text-underline-offset: 0.3em;
+}
+.np-upload-input__upload-button .np-upload-input__title + .np-upload-input__text {
+  margin-top: 4px;
+  margin-top: var(--size-4);
+  line-height: 22px;
 }
-.np-upload-button-container.droppable-dropping {
-  border-color: #c9cbce !important;
-  border-color: var(--color-interactive-secondary) !important;
+.np-upload-input__upload-button .np-upload-input__icon {
+  padding-right: 16px;
+  padding-right: var(--size-16);
+  color: var(--color-interactive-primary);
 }
-.np-upload-button-container.droppable-dropping:before {
-  z-index: 2;
+.np-upload-input__upload-button.is-dropping .np-upload-input__icon,
+.np-upload-input__upload-button.is-dropping .np-upload-input__item-content {
+  display: none;
 }
-.np-upload-button-container input[type="file"] {
+.np-upload-input__upload-button:focus-within,
+.np-upload-input__upload-button:focus-visible {
+  outline: var(--ring-outline-color) solid 3px;
+  outline-offset: -3px;
+}
+.np-upload-input__upload-button-input {
+  position: absolute;
   opacity: 0;
   z-index: -1;
-  position: absolute;
 }
-.np-upload-button-container .np-upload-button {
-  border: none;
+.np-upload-input__upload-button-input:focus {
+  outline: none;
 }
-.np-upload-button {
-  width: 100%;
-  border-top: 1px solid transparent;
-  padding: 16px;
-  padding: var(--padding-small);
-  border-radius: 0;
+.np-upload-input__upload-button .np-upload-input__drop-file-overlay {
+  display: flex;
+  flex: 1;
+  padding: 13px 0 !important;
+  background-color: transparent;
+  transition: transform 0.3s ease;
+  position: relative;
 }
-label.np-upload-button:not(.disabled):hover,
-label.np-upload-button:not(.disabled):active {
-  background-color: var(--color-background-screen-hover);
+.np-upload-input__upload-button--with-entries {
+  border-top-width: 0;
 }
-.disabled label.np-upload-button:not(.disabled):hover,
-.disabled label.np-upload-button:not(.disabled):active {
-  background-color: transparent;
+.np-upload-input__upload-button--with-entries:before {
+  display: block;
+  position: absolute;
+  height: 1px;
+  background-color: rgba(0,0,0,0.10196);
+  background-color: var(--color-border-neutral);
+  content: " ";
+  left: 16px;
+  left: var(--size-16);
+  width: calc(100% - 2 * 16px);
+  width: calc(100% - 2 * var(--size-16));
+  top: 0;
+}
+.np-upload-input__upload-button--without-entries {
+  border-top: var(--outerBorder);
+  border-radius: 10px;
+  border-radius: var(--radius-small);
 }
-.np-upload-button .media {
-  align-items: flex-start;
+.np-upload-input__upload-button--enabled.is-dropping,
+.np-upload-input__upload-button--enabled:hover,
+.np-upload-input__upload-button--enabled:active {
+  background: rgba(134,167,189,0.10196);
+  background: var(--color-background-neutral);
+}
+.np-upload-input__upload-button--enabled.is-dropping:before,
+.np-upload-input__upload-button--enabled:hover:before,
+.np-upload-input__upload-button--enabled:active:before {
+  width: 100%;
+  left: 0;
 }
-@media (max-width: 320px) {
-  .np-upload-icon {
-    padding-left: 0;
-  }
+.np-upload-input__upload-button--disabled {
+  cursor: inherit;
 }

package/src/uploadInput/uploadButton/UploadButton.less

@@ -1,55 +1,98 @@
-.np-upload-button-container {
-  border-style: solid;
+.np-upload-input__upload-button {
+  position: relative;
+  padding: var(--size-16);
+  display: flex;
+  align-items: center;
+  margin: 0;
+  border-bottom-left-radius: var(--radius-small);
+  border-bottom-right-radius: var(--radius-small);
+  border: var(--outerBorder);
+  cursor: pointer;
 
-  .droppable-card-content {
-    display: flex;
+  .np-upload-input__title {
+    color: var(--color-content-link);
+    text-decoration: underline;
+    text-underline-offset: 0.3em;
+
+    & + .np-upload-input__text {
+      margin-top: var(--size-4);
+      line-height: 22px;
+    }
   }
 
-  &.droppable-dropping {
-    border-color: var(--color-interactive-secondary) !important;
+  .np-upload-input__icon {
+    padding-right: var(--size-16);
+    color: var(--color-interactive-primary);
+  }
 
-    &:before {
-      z-index: 2;
+  &.is-dropping {
+    .np-upload-input__icon,
+    .np-upload-input__item-content {
+      display: none;
     }
   }
 
-  input[type="file"] {
+  &:focus-within,
+  &:focus-visible {
+    outline: var(--ring-outline-color) solid 3px;
+    outline-offset: -3px;
+  }
+
+  &-input {
+    position: absolute;
     opacity: 0;
     z-index: -1;
-    position: absolute;
+
+    &:focus {
+      outline: none;
+    }
   }
 
-  .np-upload-button {
-    border: none;
+  .np-upload-input__drop-file-overlay {
+    display: flex;
+    flex: 1;
+    padding: 13px 0 !important;
+    background-color: transparent;
+    transition: transform 0.3s ease;
+    position: relative;
   }
 }
 
-.np-upload-button {
-  width: 100%;
-  border-top: 1px solid transparent;
-  padding: var(--padding-small);
-  border-radius: 0;
-
-  label& {
-    &:not(.disabled) {
-      &:hover,
-      &:active {
-        background-color: var(--color-background-screen-hover);
-
-        .disabled & {
-          background-color: transparent;
-        }
-      }
-    }
-  }
+// at least 1 file uploaded or 1 error visible
+.np-upload-input__upload-button--with-entries {
+  border-top-width: 0;
 
-  .media {
-    align-items: flex-start;
+  &:before {
+    display: block;
+    position: absolute;
+    height: 1px;
+    background-color: var(--color-border-neutral);
+    content: " ";
+    left: var(--size-16);
+    width: calc(100% - 2 * var(--size-16));
+    top: 0;
   }
 }
 
-.np-upload-icon{
-  @media (max-width: 320px) {
-    padding-left: 0;
+// no files uploaded (only button shown)
+.np-upload-input__upload-button--without-entries {
+  border-top: var(--outerBorder);
+  border-radius: var(--radius-small);
+}
+
+.np-upload-input__upload-button--enabled {
+  &.is-dropping,
+  &:hover,
+  &:active {
+    background: var(--color-background-neutral);
+
+    &:before {
+      width: 100%;
+      left: 0;
+    }
   }
 }
+
+.np-upload-input__upload-button--disabled {
+  cursor: inherit;
+}