@transferwise/comparison-components 20.0.2 → 20.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@transferwise/comparison-components",
-  "version": "20.0.2",
+  "version": "20.0.3",
   "description": "Display a comparison table of providers given a route and amount.",
   "homepage": "https://wise.com/gb/compare/",
   "main": "dist/umd/comparison-components.js",

package/src/domain/QuoteApi.ts

@@ -15,7 +15,7 @@ export interface PaymentOption {
 interface QuoteApi {
   sourceCurrency: string;
   targetCurrency: string;
-  preferredPayIn: string;
+  preferredPayIn?: string;
   paymentOptions: PaymentOption[];
   rate: number;
 }

package/src/resources/clients/quotes/__test__/transformQuotesResponseV2.spec.ts

@@ -1,6 +1,7 @@
 import { FeeType } from '../../../../transfer-fee-comparison/domain/Quote';
 import transformQuotesResponseV2 from '../transformQuotesResponseV2';
 
+import wiseQuoteApiIdrToEurResponse from './wiseQuoteApiIdrToEurResponse.json';
 import wiseQuoteApiResponse from './wiseQuoteApiResponse.json';
 
 describe('quotes v3 response transformations to the canonical model V2', () => {
@@ -366,7 +367,7 @@ describe('quotes v3 response transformations to the canonical model V2', () => {
     expect(transformQuotesResponseV2(providers, wiseProvider)).toStrictEqual(expected);
   });
 
-  it('given a route with a small conversion rate, and provider does have hidden fee, show the hidden fee', () => {
+  it('given a route with a small conversion rate, and provider doesnt have a hidden fee more than a cent, dont show the hidden fee', () => {
     const wiseProvider = {
       ...wiseQuoteApiAdjusted,
       rate: 0.00769645,
@@ -413,12 +414,8 @@ describe('quotes v3 response transformations to the canonical model V2', () => {
                 type: FeeType.MARKETED,
                 amount: { value: 40, currency: 'JPY' },
               },
-              {
-                type: FeeType.HIDDEN,
-                amount: { value: 0.23, currency: 'JPY' },
-              },
             ],
-            total: { value: 40.23, currency: 'JPY' },
+            total: { value: 40, currency: 'JPY' },
           },
           receiveAmount: { value: 0.46, currency: 'EUR' },
           sendAmount: { value: 100, currency: 'JPY' },
@@ -428,4 +425,62 @@ describe('quotes v3 response transformations to the canonical model V2', () => {
 
     expect(transformQuotesResponseV2(providers, wiseProvider)).toStrictEqual(expected);
   });
+
+  it('given Wise as provider, with a very small convert rate, dont show the hidden fee', () => {
+    const wiseProvider = {
+      ...wiseQuoteApiIdrToEurResponse,
+    };
+    const providers = {
+      providers: [
+        {
+          name: 'Wise',
+          alias: 'transferwise',
+          logo: 'https://dq8dwmysp7hk1.cloudfront.net/logos/western-union.svg',
+          partner: true,
+          quotes: [
+            {
+              rate: 10,
+              fee: 10,
+              dateCollected: new Date('2018-10-23T12:03:27'),
+              receivedAmount: 10,
+            },
+          ],
+        },
+      ],
+      sendAmount: 20000,
+      sourceCurrency: 'IDR',
+      targetCurrency: 'EUR',
+    };
+
+    const expected = {
+      quotes: [
+        {
+          provider: {
+            name: 'Wise',
+            alias: 'transferwise',
+            logoUrl: 'https://dq8dwmysp7hk1.cloudfront.net/logos/western-union.svg',
+            partner: true,
+          },
+          route: {
+            sourceCurrency: 'IDR',
+            targetCurrency: 'EUR',
+          },
+          rate: 0.0000619427,
+          fees: {
+            breakdown: [
+              {
+                type: FeeType.MARKETED,
+                amount: { value: 12219, currency: 'IDR' },
+              },
+            ],
+            total: { value: 12219, currency: 'IDR' },
+          },
+          receiveAmount: { value: 0.48, currency: 'EUR' },
+          sendAmount: { value: 20000, currency: 'IDR' },
+        },
+      ],
+    };
+
+    expect(transformQuotesResponseV2(providers, wiseProvider)).toStrictEqual(expected);
+  });
 });

package/src/resources/clients/quotes/__test__/wiseQuoteApiIdrToEurResponse.json

@@ -0,0 +1,85 @@
+{
+  "sourceAmount": 20000,
+  "guaranteedTargetAmountAllowed": true,
+  "targetAmountAllowed": true,
+  "paymentOptions": [
+    {
+      "formattedEstimatedDelivery": "in 4 hours",
+      "estimatedDeliveryDelays": [],
+      "allowedProfileTypes": [
+        "PERSONAL"
+      ],
+      "feePercentage": 0.6110,
+      "estimatedDelivery": "2021-11-26T15:15:00Z",
+      "sourceCurrency": "IDR",
+      "targetCurrency": "EUR",
+      "sourceAmount": 20000,
+      "targetAmount": 0.48,
+      "payOut": "BANK_TRANSFER",
+      "fee": {
+        "transferwise": 12219.0,
+        "payIn": 0.0,
+        "discount": 0,
+        "total": 12219.0,
+        "priceSetId": 266,
+        "partner": 0.0
+      },
+      "payIn": "BANK_TRANSFER",
+      "disabled": false
+    },
+    {
+      "formattedEstimatedDelivery": "in 4 hours",
+      "estimatedDeliveryDelays": [],
+      "allowedProfileTypes": [
+        "PERSONAL",
+        "BUSINESS"
+      ],
+      "feePercentage": 0.2343,
+      "estimatedDelivery": "2021-11-26T15:15:00Z",
+      "disabledReason": {
+        "code": "error.payInmethod.disabled",
+        "message": "Open a multi currency account and add funds to instantly pay for your transfers.",
+        "arguments": []
+      },
+      "sourceCurrency": "IDR",
+      "targetCurrency": "EUR",
+      "sourceAmount": 20000,
+      "targetAmount": 0.95,
+      "payOut": "BANK_TRANSFER",
+      "fee": {
+        "transferwise": 4686.0,
+        "payIn": 0.0,
+        "discount": 0,
+        "total": 4686.0,
+        "priceSetId": 267,
+        "partner": 0.0
+      },
+      "payIn": "BALANCE",
+      "disabled": true
+    }
+  ],
+  "notices": [],
+  "transferFlowConfig": {
+    "highAmount": {
+      "showFeePercentage": false,
+      "trackAsHighAmountSender": false,
+      "showEducationStep": false,
+      "offerPrefundingOption": false
+    }
+  },
+  "rateTimestamp": "2021-11-26T11:51:01Z",
+  "clientId": "unknown",
+  "type": "REGULAR",
+  "sourceCurrency": "IDR",
+  "targetCurrency": "EUR",
+  "status": "PENDING",
+  "rate": 0.0000619427,
+  "createdTime": "2021-11-26T11:52:00Z",
+  "rateType": "FIXED",
+  "rateExpirationTime": "2021-11-29T11:52:00Z",
+  "payOut": "BANK_TRANSFER",
+  "guaranteedTargetAmount": false,
+  "providedAmountType": "SOURCE",
+  "expirationTime": "2021-11-26T12:22:00Z",
+  "funding": "POST"
+}

package/src/resources/clients/quotes/transformQuotesResponseV2.ts

@@ -23,7 +23,7 @@ function extractHiddenFeeInSourceCurrency(
   marketedFee: number,
   midmarketRate: number,
 ) {
-  const toleranceAmountInPercentage = 0.001;
+  const toleranceAmountInPercentage = 0.01;
   const expectedReceivedAmount = midmarketRate * (sendAmount - marketedFee);
 
   const receivedTheExpectedAmount = numberEqualsWithRelativeTolerance(
@@ -34,7 +34,10 @@ function extractHiddenFeeInSourceCurrency(
   const receivedHigherThanExpected =
     !receivedTheExpectedAmount && receivedAmount > expectedReceivedAmount;
 
-  const hasHiddenFee = !receivedTheExpectedAmount && !receivedHigherThanExpected;
+  const expectedHasMoreThanACentMissing = expectedReceivedAmount - receivedAmount >= 0.01;
+
+  const hasHiddenFee =
+    !receivedTheExpectedAmount && !receivedHigherThanExpected && expectedHasMoreThanACentMissing;
   const hiddenFeePaidOnTargetCurrency = hasHiddenFee ? expectedReceivedAmount - receivedAmount : 0;
 
   return parseFloat((hiddenFeePaidOnTargetCurrency * (1 / midmarketRate)).toFixed(2));