@tramvai/module-child-app 2.64.0 → 2.66.0

package/README.md

@@ -421,6 +421,14 @@ You may specify a full config to debug to a specific child-app:
    ```
 2. Run root-app with `CHILD_APP_DEBUG` environment variable with value of child-app names needed to debug
 
+## Limitations
+
+### Usage of envs
+
+Child-app cannot control the environment variables and therefore should not use token `ENV_USED_TOKEN` at all. If you try to specify `ENV_USED_TOKEN` provider you will get error in development mode and in prod mode it will just be ignored.
+
+Controlling of the envs content should be fully delegated to the root-app itself. Child-app can only use final values through `ENV_MANAGER_TOKEN` or any other options that passes data from root-app to child-app.
+
 ## Known issues
 
 ### This Suspense boundary received an update before it finished hydrating

package/lib/server.browser.js

@@ -3,7 +3,7 @@ import { provide, COMMAND_LINE_RUNNER_TOKEN, walkOfModules, getModuleParameters,
 import { Container, ChildContainer, Scope, DI_TOKEN } from '@tinkoff/dippy';
 import { commandLineListTokens, CHILD_APP_INTERNAL_ROOT_STATE_SUBSCRIPTION_TOKEN, CHILD_APP_INTERNAL_ACTION_TOKEN, CHILD_APP_INTERNAL_CONFIG_TOKEN, IS_CHILD_APP_DI_TOKEN, CHILD_APP_INTERNAL_ROOT_DI_BORROW_TOKEN, CHILD_APP_INTERNAL_ROOT_STATE_ALLOWED_STORE_TOKEN, CHILD_APP_RESOLUTION_CONFIG_MANAGER_TOKEN, CHILD_APP_RESOLUTION_CONFIGS_TOKEN, CHILD_APP_RESOLVE_CONFIG_TOKEN, CHILD_APP_RESOLVE_BASE_URL_TOKEN, CHILD_APP_SINGLETON_DI_MANAGER_TOKEN, CHILD_APP_LOADER_TOKEN, CHILD_APP_DI_MANAGER_TOKEN, CHILD_APP_COMMAND_LINE_RUNNER_TOKEN, CHILD_APP_PRELOAD_MANAGER_TOKEN, CHILD_APP_RENDER_MANAGER_TOKEN, CHILD_APP_COMMON_INITIAL_STATE_TOKEN, CHILD_APP_INTERNAL_RENDER_TOKEN } from '@tramvai/tokens-child-app';
 export * from '@tramvai/tokens-child-app';
-import { CONTEXT_TOKEN, ACTION_PAGE_RUNNER_TOKEN, LOGGER_TOKEN, DISPATCHER_TOKEN, STORE_TOKEN, DISPATCHER_CONTEXT_TOKEN, STORE_MIDDLEWARE, INITIAL_APP_STATE_TOKEN, COMBINE_REDUCERS, ENV_MANAGER_TOKEN, REGISTER_CLEAR_CACHE_TOKEN, CLEAR_CACHE_TOKEN, ENV_USED_TOKEN } from '@tramvai/tokens-common';
+import { CONTEXT_TOKEN, ACTION_PAGE_RUNNER_TOKEN, LOGGER_TOKEN, DISPATCHER_TOKEN, STORE_TOKEN, ENV_USED_TOKEN, DISPATCHER_CONTEXT_TOKEN, STORE_MIDDLEWARE, INITIAL_APP_STATE_TOKEN, COMBINE_REDUCERS, ENV_MANAGER_TOKEN, REGISTER_CLEAR_CACHE_TOKEN, CLEAR_CACHE_TOKEN } from '@tramvai/tokens-common';
 import { RENDER_SLOTS, EXTEND_RENDER } from '@tramvai/tokens-render';
 import { ROUTER_SPA_ACTIONS_RUN_MODE_TOKEN, PAGE_SERVICE_TOKEN, ROUTER_TOKEN } from '@tramvai/tokens-router';
 import { resolveLazyComponent, UniversalErrorBoundary, useDi } from '@tramvai/react';
@@ -130,6 +130,14 @@ const commonModuleStubs = [
     };
 });
 
+const validateChildAppProvider = (provider) => {
+    if (provider.provide.name === ENV_USED_TOKEN.name) {
+        throw new Error(`child-app Cannot use 'ENV_USED_TOKEN' as envs should be controlled by the root-app.
+Consider passing configs from the root-app to child-app explicitly and remove defining 'ENV_USED_TOKEN' in the child-app itself.
+You can still use 'ENV_MANAGER_TOKEN' in child-app to get env values`);
+    }
+};
+
 class SingletonDiManager {
     constructor({ logger, appDi, loader, }) {
         this.cache = new Map();
@@ -191,6 +199,9 @@ class SingletonDiManager {
             });
         });
         providers.forEach((provider) => {
+            if (process.env.NODE_ENV === 'development') {
+                validateChildAppProvider(provider);
+            }
             di.register(provider);
         });
         di.register({

package/lib/server.es.js

@@ -3,7 +3,7 @@ import { provide, COMMAND_LINE_RUNNER_TOKEN, walkOfModules, getModuleParameters,
 import { Container, ChildContainer, Scope, DI_TOKEN } from '@tinkoff/dippy';
 import { commandLineListTokens, CHILD_APP_INTERNAL_ACTION_TOKEN, CHILD_APP_INTERNAL_CONFIG_TOKEN, IS_CHILD_APP_DI_TOKEN, CHILD_APP_INTERNAL_ROOT_DI_BORROW_TOKEN, CHILD_APP_INTERNAL_ROOT_STATE_ALLOWED_STORE_TOKEN, CHILD_APP_RESOLUTION_CONFIG_MANAGER_TOKEN, CHILD_APP_RESOLUTION_CONFIGS_TOKEN, CHILD_APP_RESOLVE_CONFIG_TOKEN, CHILD_APP_RESOLVE_BASE_URL_TOKEN, CHILD_APP_SINGLETON_DI_MANAGER_TOKEN, CHILD_APP_LOADER_TOKEN, CHILD_APP_DI_MANAGER_TOKEN, CHILD_APP_COMMAND_LINE_RUNNER_TOKEN, CHILD_APP_PRELOAD_MANAGER_TOKEN, CHILD_APP_RENDER_MANAGER_TOKEN, CHILD_APP_INTERNAL_ROOT_STATE_SUBSCRIPTION_TOKEN, CHILD_APP_STATE_MANAGER_TOKEN, CHILD_APP_INTERNAL_RENDER_TOKEN } from '@tramvai/tokens-child-app';
 export * from '@tramvai/tokens-child-app';
-import { ACTION_PAGE_RUNNER_TOKEN, LOGGER_TOKEN, DISPATCHER_TOKEN, STORE_TOKEN, CONTEXT_TOKEN, DISPATCHER_CONTEXT_TOKEN, STORE_MIDDLEWARE, INITIAL_APP_STATE_TOKEN, COMBINE_REDUCERS, ENV_MANAGER_TOKEN, REGISTER_CLEAR_CACHE_TOKEN, CLEAR_CACHE_TOKEN, ENV_USED_TOKEN, CREATE_CACHE_TOKEN } from '@tramvai/tokens-common';
+import { ACTION_PAGE_RUNNER_TOKEN, LOGGER_TOKEN, DISPATCHER_TOKEN, STORE_TOKEN, CONTEXT_TOKEN, ENV_USED_TOKEN, DISPATCHER_CONTEXT_TOKEN, STORE_MIDDLEWARE, INITIAL_APP_STATE_TOKEN, COMBINE_REDUCERS, ENV_MANAGER_TOKEN, REGISTER_CLEAR_CACHE_TOKEN, CLEAR_CACHE_TOKEN, CREATE_CACHE_TOKEN } from '@tramvai/tokens-common';
 import { RENDER_SLOTS, EXTEND_RENDER, ResourceType, ResourceSlot, RESOURCES_REGISTRY } from '@tramvai/tokens-render';
 import { PAGE_SERVICE_TOKEN } from '@tramvai/tokens-router';
 import { resolveLazyComponent, UniversalErrorBoundary, useDi } from '@tramvai/react';
@@ -68,6 +68,14 @@ const commonModuleStubs = [
     };
 });
 
+const validateChildAppProvider = (provider) => {
+    if (provider.provide.name === ENV_USED_TOKEN.name) {
+        throw new Error(`child-app Cannot use 'ENV_USED_TOKEN' as envs should be controlled by the root-app.
+Consider passing configs from the root-app to child-app explicitly and remove defining 'ENV_USED_TOKEN' in the child-app itself.
+You can still use 'ENV_MANAGER_TOKEN' in child-app to get env values`);
+    }
+};
+
 class SingletonDiManager {
     constructor({ logger, appDi, loader, }) {
         this.cache = new Map();
@@ -129,6 +137,9 @@ class SingletonDiManager {
             });
         });
         providers.forEach((provider) => {
+            if (process.env.NODE_ENV === 'development') {
+                validateChildAppProvider(provider);
+            }
             di.register(provider);
         });
         di.register({

package/lib/server.js

@@ -77,6 +77,14 @@ const commonModuleStubs = [
     };
 });
 
+const validateChildAppProvider = (provider) => {
+    if (provider.provide.name === tokensCommon.ENV_USED_TOKEN.name) {
+        throw new Error(`child-app Cannot use 'ENV_USED_TOKEN' as envs should be controlled by the root-app.
+Consider passing configs from the root-app to child-app explicitly and remove defining 'ENV_USED_TOKEN' in the child-app itself.
+You can still use 'ENV_MANAGER_TOKEN' in child-app to get env values`);
+    }
+};
+
 class SingletonDiManager {
     constructor({ logger, appDi, loader, }) {
         this.cache = new Map();
@@ -138,6 +146,9 @@ class SingletonDiManager {
             });
         });
         providers.forEach((provider) => {
+            if (process.env.NODE_ENV === 'development') {
+                validateChildAppProvider(provider);
+            }
             di.register(provider);
         });
         di.register({

package/lib/shared/child/validate.d.ts

@@ -0,0 +1,2 @@
+import type { Provider } from '@tinkoff/dippy';
+export declare const validateChildAppProvider: (provider: Provider) => void;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tramvai/module-child-app",
-  "version": "2.64.0",
+  "version": "2.66.0",
   "description": "Module for child apps",
   "browser": {
     "./lib/server.js": "./lib/browser.js",
@@ -31,21 +31,21 @@
     "@tinkoff/env-validators": "0.1.4",
     "@tinkoff/module-loader-client": "0.4.4",
     "@tinkoff/module-loader-server": "0.5.6",
-    "@tramvai/child-app-core": "2.64.0",
-    "@tramvai/module-router": "2.64.0",
+    "@tramvai/child-app-core": "2.66.0",
+    "@tramvai/module-router": "2.66.0",
     "@tramvai/safe-strings": "0.5.6",
-    "@tramvai/tokens-child-app": "2.64.0"
+    "@tramvai/tokens-child-app": "2.66.0"
   },
   "devDependencies": {},
   "peerDependencies": {
-    "@tinkoff/dippy": "0.8.11",
+    "@tinkoff/dippy": "0.8.12",
     "@tinkoff/utils": "^2.1.2",
-    "@tramvai/core": "2.64.0",
-    "@tramvai/state": "2.64.0",
-    "@tramvai/react": "2.64.0",
-    "@tramvai/tokens-common": "2.64.0",
-    "@tramvai/tokens-render": "2.64.0",
-    "@tramvai/tokens-router": "2.64.0",
+    "@tramvai/core": "2.66.0",
+    "@tramvai/state": "2.66.0",
+    "@tramvai/react": "2.66.0",
+    "@tramvai/tokens-common": "2.66.0",
+    "@tramvai/tokens-render": "2.66.0",
+    "@tramvai/tokens-router": "2.66.0",
     "react": ">=16.14.0",
     "react-dom": ">=16.14.0",
     "object-assign": "^4.1.1",