@trackunit/iris-app 2.3.3 → 2.3.5

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## 2.3.5 (2026-08-04)
+
+### 🧱 Updated Dependencies
+
+- Updated iris-app-build-utilities to 2.2.4
+- Updated iris-app-api to 2.2.4
+- Updated react-vite-test-setup to 0.0.90
+- Updated react-graphql-tools to 1.14.91
+- Updated shared-utils to 1.15.92
+
+## 2.3.4 (2026-08-04)
+
+This was a version bump only for iris-app to align it with other projects, there were no code changes.
+
 ## 2.3.3 (2026-08-04)
 
 ### 🧱 Updated Dependencies

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@trackunit/iris-app",
-  "version": "2.3.3",
+  "version": "2.3.5",
   "license": "SEE LICENSE IN LICENSE.txt",
   "main": "src/index.js",
   "generators": "./generators.json",
@@ -23,10 +23,10 @@
     "@nx/react": "23.1.0",
     "@npmcli/arborist": "^9.1.9",
     "win-ca": "^3.5.1",
-    "@trackunit/iris-app-build-utilities": "2.2.3",
-    "@trackunit/react-graphql-tools": "1.14.90",
-    "@trackunit/shared-utils": "1.15.91",
-    "@trackunit/iris-app-api": "2.2.3",
+    "@trackunit/iris-app-build-utilities": "2.2.4",
+    "@trackunit/react-graphql-tools": "1.14.91",
+    "@trackunit/shared-utils": "1.15.92",
+    "@trackunit/iris-app-api": "2.2.4",
     "tslib": "^2.6.2",
     "@clack/prompts": "^1.0.0",
     "@npm/types": "^1.0.2",

package/src/executors/submit/executor.js

@@ -15,12 +15,81 @@ const irisAppServerSettings_1 = require("../utils/irisAppServerSettings");
 class NpmConflictError extends Error {
 }
 class NpmGeneralError extends Error {
+    constructor(message, statusCode, code, type) {
+        super(message);
+        this.statusCode = statusCode;
+        this.code = code;
+        this.type = type;
+    }
 }
 class ApproveError extends Error {
+    constructor(message, statusCode, code) {
+        super(message);
+        this.statusCode = statusCode;
+        this.code = code;
+    }
 }
 function sleep(time) {
     return new Promise(resolve => setTimeout(resolve, time));
 }
+// Errno-style codes that indicate the request never reached the registry at all
+// (DNS/connection/timeout failures at the transport layer), as opposed to local
+// validation errors (e.g. libnpmpublish's EPRIVATE/EBADSEMVER/EUSAGE) which carry
+// a code but are permanent and can never succeed on retry. Kept aligned with
+// make-fetch-happen's own RETRY_ERRORS list (used by the submit path) plus the
+// undici error codes doApproveApp's native fetch can raise.
+//
+// ENOTFOUND (DNS failure) is deliberately included even though make-fetch-happen
+// itself excludes it as "bad hostname, or offline" - a DNS blip during a VPN/
+// network transition is common enough in practice that failing fast here would
+// trade one wasted-wait problem for developers hitting spurious permanent
+// failures on flaky networks. This is a judgment call, not a clear-cut default.
+const RETRYABLE_TRANSPORT_CODES = new Set([
+    "ENOTFOUND",
+    "ECONNRESET",
+    "ECONNREFUSED",
+    "ETIMEDOUT",
+    "EAI_AGAIN",
+    "ERR_SOCKET_TIMEOUT",
+    "EADDRINUSE",
+    // from @npmcli/agent, surfaced through make-fetch-happen
+    "ECONNECTIONTIMEOUT",
+    "EIDLETIMEOUT",
+    "ERESPONSETIMEOUT",
+    "ETRANSFERTIMEOUT",
+    // doApproveApp uses Node's native fetch (undici), which raises its own
+    // codes distinct from the classic Node errno codes above.
+    "UND_ERR_CONNECT_TIMEOUT",
+    "UND_ERR_HEADERS_TIMEOUT",
+    "UND_ERR_BODY_TIMEOUT",
+    "UND_ERR_SOCKET", // e.g. "other side closed" on a reused keep-alive connection
+]);
+/**
+ * Decide whether a failed submit/approve attempt is worth retrying.
+ *
+ * This is an allowlist, not a denylist: only failures with a real chance of
+ * succeeding on a later attempt are retried - 5xx responses, 408/429 (timeout/
+ * rate-limited), a transport-level failure that never reached the registry at
+ * all (identified by a known transient errno code), or a minipass-fetch request
+ * timeout (which surfaces with the generic code FETCH_ERROR, distinguishable
+ * only via its `type: "request-timeout"`). Everything else - permanent 4xx
+ * errors, local validation errors with an unrelated code (e.g. EBADSEMVER), or
+ * any other unrecognized error shape - is treated as non-retryable by default.
+ *
+ * @param {number} [statusCode] The HTTP status code of the failed attempt, if any.
+ * @param {string} [code] The error's errno-style code, if any (no statusCode implies no HTTP response was received).
+ * @param {string} [type] The error's `type` field, if any. Only consulted when `code === "FETCH_ERROR"`, since that's the one code minipass-fetch's FetchError uses generically for several failure kinds - `type` is what distinguishes a timeout from the others.
+ * @returns {boolean} Whether the attempt should be retried.
+ */
+function isRetryableError(statusCode, code, type) {
+    if (statusCode !== undefined) {
+        return statusCode >= 500 || statusCode === 408 || statusCode === 429;
+    }
+    if (code === undefined) {
+        return false;
+    }
+    return RETRYABLE_TRANSPORT_CODES.has(code) || (code === "FETCH_ERROR" && type === "request-timeout");
+}
 /**
  * Submit the package to the npm registry.
  *
@@ -72,16 +141,24 @@ async function doUploadAppWithRetry(accessToken, manifest, tarData, settings, re
             console.error("❌ Unable to ship app package. Cannot submit over existing version.");
             return { success: false };
         }
+        if (!(e instanceof NpmGeneralError)) {
+            // An error shape we don't recognize (e.g. a bug elsewhere in this function) -
+            // log the full error/stack rather than a bare message so it stays debuggable.
+            console.error("❌ Unable to ship app package. Got error from Iris App SDK repository.", e);
+            return { success: false };
+        }
+        if (!isRetryableError(e.statusCode, e.code, e.type)) {
+            console.error("❌ Unable to ship app package.", e.message);
+            return { success: false };
+        }
+        if (retryCount > 1) {
+            console.error("⚠️ Unable to ship app package. Got error from Iris App SDK repository. Retrying submit...", e.message);
+            await sleep(30000);
+            return await doUploadAppWithRetry(accessToken, manifest, tarData, settings, retryCount - 1);
+        }
         else {
-            if (retryCount > 1) {
-                console.error("⚠️ Unable to ship app package. Got error from Iris App SDK repository. Retrying submit...", e);
-                await sleep(30000);
-                return await doUploadAppWithRetry(accessToken, manifest, tarData, settings, retryCount - 1);
-            }
-            else {
-                console.error("❌ Unable to ship app package. Got error from Iris App SDK repository.", e);
-                return { success: false };
-            }
+            console.error("❌ Unable to ship app package. Got error from Iris App SDK repository.", e.message);
+            return { success: false };
         }
     }
 }
@@ -102,6 +179,9 @@ async function doUploadApp(accessToken, manifest, tarData, settings) {
         else {
             return {
                 ok: false,
+                statusCode: err.statusCode,
+                code: err.code,
+                type: err.type,
                 headers: new Headers(err.headers),
                 statusText: `Error`,
                 text: () => Promise.resolve(`${err.name} ${err.message}`),
@@ -130,7 +210,7 @@ async function doUploadApp(accessToken, manifest, tarData, settings) {
             " " +
             (await submitResult.text()) +
             ". Trace ID: " +
-            submitResult.headers.get("trace-id"));
+            submitResult.headers.get("trace-id"), "statusCode" in submitResult ? submitResult.statusCode : undefined, "code" in submitResult ? submitResult.code : undefined, "type" in submitResult ? submitResult.type : undefined);
     }
 }
 async function promptUserForInput(query) {
@@ -150,19 +230,21 @@ async function doApproveAppWithRetry(token, manifest, settings, retryCount) {
         return await doApproveApp(token, manifest, settings);
     }
     catch (e) {
-        if (e instanceof ApproveError) {
-            if (retryCount > 1) {
-                console.error("⚠️ Unable to approve app package. Got approve error from Iris App SDK repository. Retrying approve...", e);
-                await sleep(30000);
-                return await doApproveAppWithRetry(token, manifest, settings, retryCount - 1);
-            }
-            else {
-                console.error("❌ Unable to approve app package. Got approve error from Iris App SDK repository.", e);
-                return { success: false };
-            }
+        if (!(e instanceof ApproveError)) {
+            console.error("❌ Unable to approve app package. Got error from Iris App SDK repository.", e);
+            return { success: false };
+        }
+        if (!isRetryableError(e.statusCode, e.code)) {
+            console.error("❌ Unable to approve app package.", e.message);
+            return { success: false };
+        }
+        if (retryCount > 1) {
+            console.error("⚠️ Unable to approve app package. Got approve error from Iris App SDK repository. Retrying approve...", e.message);
+            await sleep(30000);
+            return await doApproveAppWithRetry(token, manifest, settings, retryCount - 1);
         }
         else {
-            console.error("❌ Unable to approve app package. Got error from Iris App SDK repository.", e);
+            console.error("❌ Unable to approve app package. Got approve error from Iris App SDK repository.", e.message);
             return { success: false };
         }
     }
@@ -170,18 +252,29 @@ async function doApproveAppWithRetry(token, manifest, settings, retryCount) {
 async function doApproveApp(token, manifest, settings) {
     if (process.env.TU_APPROVE === "true") {
         console.log(`🖋️ Approving the app...`);
+        // A rejection here (e.g. DNS/connection/timeout failure) never produced an HTTP
+        // response, so it's re-thrown as an ApproveError with no statusCode - carrying
+        // the underlying cause's errno code (if any) so isRetryableError can recognize
+        // genuine transport failures, and the cause's message so the log doesn't just
+        // say "fetch failed" with no indication of what actually broke.
         const approveResult = await fetch(new URL(`${manifest.name}@${manifest.version}`, settings.approvalUrl), {
             method: "PUT",
             headers: {
                 Authorization: `Bearer ${token}`,
             },
+        }).catch((err) => {
+            const cause = err.cause instanceof Error ? err.cause : undefined;
+            const causeCode = cause && "code" in cause ? cause.code : undefined;
+            const code = typeof causeCode === "string" ? causeCode : undefined;
+            const reason = cause ? `${err.message}: ${cause.message}` : err.message;
+            throw new ApproveError(reason, undefined, code);
         });
         if (approveResult.ok) {
             console.log(`✅ Approved version ${manifest.version} of ${manifest.name}.`);
             return { success: true };
         }
         else {
-            throw new ApproveError(`${approveResult.statusText}, ${await approveResult.text()}, Trace ID: ${approveResult.headers.get("trace-id")}`);
+            throw new ApproveError(`${approveResult.statusText}, ${await approveResult.text()}, Trace ID: ${approveResult.headers.get("trace-id")}`, approveResult.status);
         }
     }
     else {