@tplnet/homebridge-denon-heos-audio 1.2.0 → 1.2.1

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes of this fork. The fork is based on [hov3rcraft/homebridge-denon-heos-audio](https://github.com/hov3rcraft/homebridge-denon-heos-audio) 1.0.0-beta.1.
 
+## 1.2.1
+
+### Fixed
+
+- When switching on took a few seconds (e.g. while the power on favorite was being started), the tile briefly showed "off" before it switched to "on". The requested state is now reported from the moment of the tap, and intermediate states of the device are ignored until switching has finished.
+- The player list was requested twice per device at startup.
+
 ## 1.2.0
 
 ### New

package/dist/denonClientHeosCli.d.ts

@@ -204,7 +204,10 @@ export declare class DenonClientHeosCli extends DenonClient {
     private infoLog;
     private player_name;
     constructor(serialNumber: string, name: string, host: string, connect_timeout: number, response_timeout: number, debugLogCallback?: (message: string, ...parameters: any[]) => void, powerUpdateCallback?: (power: boolean) => void, muteUpdateCallback?: (mute: boolean) => void, volumeUpdateCallback?: (volume: number) => void, inputUpdateCallback?: (input: string) => void);
+    private playerIdLookup;
+    /** Looks up the player id; concurrent calls share one request. */
     private findPlayerId;
+    private findPlayerIdUncached;
     protected subscribeToChangeEvents(): Promise<void>;
     protected sendCommand(command: ProtocolCommand, commandMode: CommandMode, { value, passPayload }: {
         value?: string;

package/dist/denonClientHeosCli.js

@@ -275,7 +275,15 @@ export class DenonClientHeosCli extends DenonClient {
             }
         });
     }
-    async findPlayerId() {
+    playerIdLookup;
+    /** Looks up the player id; concurrent calls share one request. */
+    findPlayerId() {
+        this.playerIdLookup ??= this.findPlayerIdUncached().finally(() => {
+            this.playerIdLookup = undefined;
+        });
+        return this.playerIdLookup;
+    }
+    async findPlayerIdUncached() {
         const payload_str = await super.sendCommand(DenonClientHeosCli.PROTOCOL.PLAYERS, CommandMode.GET, { passPayload: true });
         const payload = JSON.parse(payload_str);
         if (!Array.isArray(payload)) {

package/dist/platformAccessory.d.ts

@@ -38,6 +38,7 @@ export declare class DenonAudioAccessory {
     private targetMediaState;
     private volumeChangeOngoing;
     private pendingActive;
+    private powerChangeInProgress;
     private playingChangeOngoing;
     constructor(platform: DenonAudioPlatform, accessory: PlatformAccessory, config: DeviceConfig, log: Logger);
     /**

package/dist/platformAccessory.js

@@ -44,6 +44,7 @@ export class DenonAudioAccessory {
     targetMediaState;
     volumeChangeOngoing = false;
     pendingActive;
+    powerChangeInProgress = false;
     playingChangeOngoing = false;
     constructor(platform, accessory, config, log) {
         log.debug("Initializing DenonAudioAccessory...");
@@ -312,6 +313,10 @@ export class DenonAudioAccessory {
     async setActive(newValue) {
         this.log.debug(`setActive for ${this.name} set to ${newValue}`);
         const active = newValue === this.platform.Characteristic.Active.ACTIVE;
+        // Report the requested state right away: switching on can take a few seconds (e.g. when the power on favorite is
+        // started), and the device reports intermediate states during that time.
+        this.pendingActive = { value: active, until: Number.POSITIVE_INFINITY };
+        this.powerChangeInProgress = true;
         try {
             await this.denonClient.setPower(active);
             this.pendingActive = { value: active, until: Date.now() + DenonAudioAccessory.POWER_STATE_SETTLE_TIME };
@@ -321,6 +326,9 @@ export class DenonAudioAccessory {
             this.log.error(`An error occured while setting power status for ${this.name}.`, error);
             throw new this.platform.api.hap.HapStatusError(this.platform.api.hap.HAPStatus.SERVICE_COMMUNICATION_FAILURE);
         }
+        finally {
+            this.powerChangeInProgress = false;
+        }
     }
     async setActiveIdentifier(newValue) {
         this.log.debug(`setActiveIdentifier for ${this.name} set to ${newValue}`);
@@ -542,6 +550,10 @@ export class DenonAudioAccessory {
      * Handles characteristic updates from the API
      */
     callbackActive(active) {
+        if (this.powerChangeInProgress && this.pendingActive && this.pendingActive.value !== active) {
+            this.log.debug(`Ignoring intermediate power state ${active} of ${this.name} while switching.`);
+            return;
+        }
         if (this.pendingActive && this.pendingActive.value !== active) {
             // changed on the device (e.g. in the HEOS app) - the device state wins
             this.pendingActive = undefined;

package/package.json

@@ -2,7 +2,7 @@
   "name": "@tplnet/homebridge-denon-heos-audio",
   "displayName": "Homebridge Denon Heos Audio (tplnet)",
   "type": "module",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "Control your Denon and Marantz HEOS speakers, amplifiers and AVRs via AVR Control and/or HEOS CLI",
   "author": "tplnet",
   "contributors": [