@toruslabs/ethereum-controllers 6.0.2 → 6.0.4

package/dist/ethereumControllers.cjs.js

@@ -2679,7 +2679,11 @@ class KeyringController extends base_controllers_namespaceObject.BaseKeyringCont
   async signPersonalMessage(data, address) {
     const wallet = this._getWalletForAccount(address);
     const privKey = new external_ethers_namespaceObject.SigningKey((0,util_namespaceObject.addHexPrefix)(wallet.privateKey));
-    const signature = privKey.sign((0,external_ethers_namespaceObject.hashMessage)(data)).serialized;
+    // we need to check if the data is hex or not
+    // For historical reasons, you must submit the message to sign in hex-encoded UTF-8.
+    // https://docs.metamask.io/wallet/how-to/sign-data/#use-personal_sign
+    const message = (0,util_namespaceObject.isHexString)(data) ? Buffer.from((0,util_namespaceObject.stripHexPrefix)(data), "hex") : Buffer.from(data);
+    const signature = privKey.sign((0,external_ethers_namespaceObject.hashMessage)(message)).serialized;
     return signature;
   }
 

package/dist/ethereumControllers.esm.js

@@ -2326,7 +2326,11 @@ class KeyringController extends BaseKeyringController {
   async signPersonalMessage(data, address) {
     const wallet = this._getWalletForAccount(address);
     const privKey = new SigningKey(addHexPrefix(wallet.privateKey));
-    const signature = privKey.sign(hashMessage(data)).serialized;
+    // we need to check if the data is hex or not
+    // For historical reasons, you must submit the message to sign in hex-encoded UTF-8.
+    // https://docs.metamask.io/wallet/how-to/sign-data/#use-personal_sign
+    const message = isHexString(data) ? Buffer.from(stripHexPrefix(data), "hex") : Buffer.from(data);
+    const signature = privKey.sign(hashMessage(message)).serialized;
     return signature;
   }