@torus-engineering/tas-kit 1.9.0 → 1.11.1

package/.claude/commands/tas-dev.md

@@ -1,128 +1,128 @@
-# /tas-dev $ARGUMENTS
-
-Vai trò: SE - Software Engineer
-Implement một User Story theo Technical Plan đã được duyệt.
-
-## Always / Ask / Never
-
-| | Hành động |
-|---|---|
-| **Always** | Kiểm tra `plan_status` trước khi implement |
-| **Always** | Follow tasks trong `## Technical Plan` của Story |
-| **Always** | Launch review agent độc lập sau khi implement — không review trong cùng session |
-| **Ask** | Khi phát hiện plan cần thay đổi đáng kể trong lúc code |
-| **Ask** | Khi cần đọc thêm file ngoài scope của plan |
-| **Never** | Implement ngoài scope Story |
-| **Never** | Skip bước review sau khi implement |
-
-## QUAN TRỌNG - Quy tắc đọc file
-- CHỈ đọc Story file — Technical Plan đã có đủ context kỹ thuật.
-- Không tự đọc PRD, SAD, ADR, Design-Spec trừ khi user xác nhận.
-- Không list thư mục, không quét project structure.
-- Không đọc `.tas/checklists/story-done.md` ở bước đầu (chỉ đọc ở bước cuối).
-
-## Stack Detection
-Đọc `.claude/rules/common/stack-detection.md`.
-
-## Hành động
-
-### Bước 1 — Xác định Story
-
-`$ARGUMENTS` là Story ID hoặc file path.
-Nếu không có: đọc `project-status.yaml`, tìm stories có `status: Committed` hoặc `status: In Progress`. Nếu nhiều hơn một, liệt kê để user chọn.
-Đọc Story file.
-
-### Bước 1.5 — Gate: Kiểm tra plan_status
-
-Đọc `plan_status` từ frontmatter của Story.
-
-**Nếu `plan_status: pending`:**
-Đọc `require_plan` từ root/`tas.yaml`:
-- `require_plan: true` (hoặc field không tồn tại) → **DỪNG LẠI**:
-  > "Story này chưa có Technical Plan. Chạy `/tas-plan {Story-ID}` trước khi implement."
-- `require_plan: false` → tiếp tục, hiển thị warning và chờ xác nhận:
-  > "⚠️ Quick mode: Story chưa có Technical Plan. Tiếp tục implement không?"
-
-**Nếu `plan_status: completed`:** tiếp tục bình thường.
-
-### Bước 2 — Đọc Technical Plan
-
-Từ Story file, đọc section `## Technical Plan`:
-- Approach đã chọn
-- Files to Change / Files to Create
-- Database Changes, Config Changes
-- Tasks list (checklist thực hiện theo thứ tự)
-
-Nếu không có Technical Plan (quick mode) → phân tích AC và implement trực tiếp theo AC.
-
-### Bước 3 — Implement
-
-**Nếu stack là Node.js/Express/Next.js** → invoke skill `js-backend-patterns` để tham khảo
-repository pattern, service layer, N+1 prevention, caching, error handling trước khi code.
-
-#### Nếu `use_tdd = true` trong `tas.yaml`:
-a. **Red phase** — Viết test cases TRƯỚC theo AC trong Story. Chạy tests, xác nhận FAIL.
-
-   Platform-specific (từ stack detection):
-   - **Mobile (React Native)**: Jest + React Testing Library — Components (`render`, `fireEvent`, `screen`), Hooks (`renderHook`), Services/API (Jest mocks + MSW), Utils, Zustand stores. File: `src/**/*.test.ts(x)`
-   - **Web (React + Node)**: Vitest/Jest + React Testing Library — Components, Hooks, Services (MSW/Nock), Backend services (Jest). File: `src/**/*.test.ts(x)`
-   - **Backend (.NET)**: xUnit — Unit (services, repositories), Integration (TestServer), API (WebApplicationFactory). File: `tests/Unit/`, `tests/Integration/`, `tests/Api/`
-
-b. **Green phase** — Viết code tối thiểu để pass tests.
-c. **Refactor** — Clean up, đảm bảo tests vẫn pass.
-
-#### Nếu `use_tdd = false`:
-a. Implement code theo AC + Tasks trong Technical Plan
-b. Viết unit tests cover các cases trong `## Unit Test Cases`
-c. Chạy tests, fix nếu fail
-→ Nếu tests vẫn fail sau 1 lần tự fix: launch `build-resolver` agent với error output để diagnose.
-
-Trong quá trình implement, tick từng task hoàn thành trong Story file: `- [x] Task 1: ...`
-
-Nếu phát hiện plan cần thay đổi đáng kể → thông báo user trước khi thay đổi hướng.
-
-### Bước 4 — Post-Implementation Review (Isolated Agent)
-
-Thực hiện theo `.claude/rules/common/post-review-agent.md`.
-Truyền vào: Story file path, danh sách changed files, stack (từ CLAUDE.md), lang_agent.
-
-### Bước 5 — Definition of Done
-
-Đọc `.tas/checklists/story-done.md`, verify từng mục, tick vào Story:
-- `- [x] Technical plan completed` — nếu plan_status: completed (hoặc quick mode xác nhận)
-- `- [x] Code implemented` — nếu implement xong
-- `- [x] Unit tests pass` — nếu tests đã pass
-- `- [x] No regression` — nếu toàn bộ test suite pass
-- `- [x] Documentation updated (if needed)` — nếu đã cập nhật
-- `- [x] Code review passed` — nếu review gate pass (không có Critical/High)
-- `- [ ] Acceptance criteria verified` — KHÔNG tick, để PE verify
-
-**Optional — nếu Story thay đổi API public, database schema, hoặc setup:**
-Launch `doc-updater` agent: cập nhật docs liên quan (README, SAD section, API docs).
-> Scope: [danh sách changed files]. Story: [Story ID + title].
-> Chỉ cập nhật phần docs đã lỗi thời — không viết lại từ đầu.
-
-### Bước 6 — Wrap up
-
-Cập nhật Story status → `In Progress` (nếu chưa).
-Tạo commit message theo conventions trong `CLAUDE.md`.
-Hỏi: "Tests OK và review passed rồi — bạn đã test thủ công chưa? Muốn chuyển sang Deploy Test không?"
-
-Nếu Yes:
-- Cập nhật Story status → `Deploy Test`
-- Thêm Changelog entry
-- Cập nhật `project-status.yaml`
-- Gợi ý: `/ado-update story {ado-id} --status "Deploy Test"` nếu dùng ADO
-
-## Nguyên tắc
-- KHÔNG implement ngoài scope của Story
-- Mỗi public method PHẢI có XML doc comment (C#) hoặc JSDoc (TypeScript) hoặc docstring (Python)
-- Review phải chạy qua Agent độc lập — không inline trong session hiện tại
-- **Khi nào cần tạo ADR** (nếu Technical Plan chưa đề cập):
-  - Thay đổi kiến trúc ảnh hưởng nhiều components
-  - Thêm mới design pattern hoặc framework
-  - Quyết định trade-off kỹ thuật quan trọng
-
-## Bước cuối — Token Log
-
-Invoke skill `token-logger`: ghi AI Usage Log vào file Story đang làm việc.
+# /tas-dev $ARGUMENTS
+
+Role: SE - Software Engineer
+Implement a User Story per approved Technical Plan.
+
+## Always / Ask / Never
+
+| | Action |
+|---|---|
+| **Always** | Check `plan_status` before implementing |
+| **Always** | Follow tasks in Story's `## Technical Plan` |
+| **Always** | Launch independent review agent after implement — no review in same session |
+| **Ask** | When discover plan needs significant changes during coding |
+| **Ask** | When need to read files outside plan scope |
+| **Never** | Implement outside Story scope |
+| **Never** | Skip review step after implement |
+
+## IMPORTANT - File Reading Rules
+- ONLY read Story file — Technical Plan has enough technical context.
+- Don't auto-read PRD, SAD, ADR, Design-Spec unless user confirms.
+- Don't list directories, don't scan project structure.
+- Don't read `.tas/checklists/story-done.md` at first step (only at final step).
+
+## Stack Detection
+Read `.claude/rules/common/stack-detection.md`.
+
+## Actions
+
+### Step 1 — Identify Story
+
+`$ARGUMENTS` is Story ID or file path.
+If none: read `project-status.yaml`, find stories with `status: Committed` or `status: In Progress`. If more than one, list for user to choose.
+Read Story file.
+
+### Step 1.5 — Gate: Check plan_status
+
+Read `plan_status` from Story frontmatter.
+
+**If `plan_status: pending`:**
+Read `require_plan` from root/`tas.yaml`:
+- `require_plan: true` (or field doesn't exist) → **STOP**:
+  > "This Story has no Technical Plan. Run `/tas-plan {Story-ID}` before implementing."
+- `require_plan: false` → continue, show warning and wait for confirmation:
+  > "⚠️ Quick mode: Story has no Technical Plan. Continue implementing?"
+
+**If `plan_status: completed`:** continue normally.
+
+### Step 2 — Read Technical Plan
+
+From Story file, read `## Technical Plan` section:
+- Chosen approach
+- Files to Change / Files to Create
+- Database Changes, Config Changes
+- Tasks list (checklist to follow in order)
+
+If no Technical Plan (quick mode) → analyze AC and implement directly per AC.
+
+### Step 3 — Implement
+
+**If stack is Node.js/Express/Next.js** → invoke skill `js-backend-patterns` to reference
+repository pattern, service layer, N+1 prevention, caching, error handling before coding.
+
+#### If `use_tdd = true` in `tas.yaml`:
+a. **Red phase** — Write test cases FIRST per AC in Story. Run tests, confirm FAIL.
+
+   Platform-specific (from stack detection):
+   - **Mobile (React Native)**: Jest + React Testing Library — Components (`render`, `fireEvent`, `screen`), Hooks (`renderHook`), Services/API (Jest mocks + MSW), Utils, Zustand stores. File: `src/**/*.test.ts(x)`
+   - **Web (React + Node)**: Vitest/Jest + React Testing Library — Components, Hooks, Services (MSW/Nock), Backend services (Jest). File: `src/**/*.test.ts(x)`
+   - **Backend (.NET)**: xUnit — Unit (services, repositories), Integration (TestServer), API (WebApplicationFactory). File: `tests/Unit/`, `tests/Integration/`, `tests/Api/`
+
+b. **Green phase** — Write minimal code to pass tests.
+c. **Refactor** — Clean up, ensure tests still pass.
+
+#### If `use_tdd = false`:
+a. Implement code per AC + Tasks in Technical Plan
+b. Write unit tests covering cases in `## Unit Test Cases`
+c. Run tests, fix if fail
+→ If tests still fail after 1 self-fix: launch `build-resolver` agent with error output to diagnose.
+
+During implementation, tick each completed task in Story file: `- [x] Task 1: ...`
+
+If discover plan needs significant changes → notify user before changing direction.
+
+### Step 4 — Post-Implementation Review (Isolated Agent)
+
+Follow `.claude/rules/common/post-review-agent.md`.
+Pass in: Story file path, changed files list, stack (from CLAUDE.md), lang_agent.
+
+### Step 5 — Definition of Done
+
+Read `.tas/checklists/story-done.md`, verify each item, tick in Story:
+- `- [x] Technical plan completed` — if plan_status: completed (or quick mode confirmed)
+- `- [x] Code implemented` — if implementation done
+- `- [x] Unit tests pass` — if tests passed
+- `- [x] No regression` — if full test suite passed
+- `- [x] Documentation updated (if needed)` — if updated
+- `- [x] Code review passed` — if review gate passed (no Critical/High)
+- `- [ ] Acceptance criteria verified` — DO NOT tick, let PE verify
+
+**Optional — if Story changes public API, database schema, or setup:**
+Launch `doc-updater` agent: update related docs (README, SAD section, API docs).
+> Scope: [changed files list]. Story: [Story ID + title].
+> Only update outdated docs — don't rewrite from scratch.
+
+### Step 6 — Wrap up
+
+Update Story status → `In Progress` (if not already).
+Create commit message per conventions in `CLAUDE.md`.
+Ask: "Tests OK and review passed — have you tested manually? Want to move to Deploy Test?"
+
+If Yes:
+- Update Story status → `Deploy Test`
+- Add Changelog entry
+- Update `project-status.yaml`
+- Suggest: `/ado-update story {ado-id} --status "Deploy Test"` if using ADO
+
+## Principles
+- DO NOT implement outside Story scope
+- Each public method MUST have XML doc comment (C#) or JSDoc (TypeScript) or docstring (Python)
+- Review must run through independent Agent — not inline in current session
+- **When to create ADR** (if Technical Plan didn't mention):
+  - Architecture changes affecting multiple components
+  - New design pattern or framework
+  - Important technical trade-off decisions
+
+## Final Step — Token Log
+
+Invoke skill `token-logger`: write AI Usage Log to working Story file.

package/.claude/commands/tas-e2e-mobile.md

@@ -1,155 +1,155 @@
-# /tas-e2e-mobile $ARGUMENTS
-
-Vai tro: SE / QA
-Generate Detox E2E test scripts tu mot E2E Scenario markdown file.
-
-## QUAN TRONG - Layer 3: Mobile E2E Scripts
-- Tao Detox test scripts tu E2E-Scenario (markdown)
-- Scripts nam trong `apps/mobile/e2e/flows/`
-- REUSE helpers tu Layer 2 functional tests (features/)
-- Chain functional test steps thanh end-to-end flows
-
-## Hanh dong
-
-### Buoc 1: Xac dinh Scenario
-1. $ARGUMENTS la path den E2E-Scenario-*.md file
-2. Neu khong co: scan `docs/epics/**/E2E-Scenario-*.md` va `docs/e2e-scenarios/E2E-Scenario-*.md`
-3. List scenarios va hoi user chon
-
-### Buoc 2: Kiem tra Prerequisites
-1. Kiem tra `apps/mobile/` ton tai. Neu khong → bao loi graceful
-2. Doc scenario file de lay:
-   - Scenario steps va flow
-   - FT ID references (cot "Builds on FT IDs")
-   - FT Reuse Map (section cuoi)
-   - Test data per environment
-   - Scenario type (single-epic / cross-epic)
-
-### Buoc 3: Tim Functional Test Helpers
-Tu FT Reuse Map trong scenario:
-1. Tim tung source file trong `apps/mobile/e2e/features/`
-2. Verify helper functions ton tai
-3. Neu helper khong ton tai → tao stub va ghi note "TODO: implement helper"
-4. Import map: FT ID → file path → function name
-
-### Buoc 4: Generate E2E Script
-
-**File output**: `apps/mobile/e2e/flows/{scenario-slug}.e2e.ts`
-
-**Structure**:
-```typescript
-/**
- * E2E Flow: {Scenario Name}
- * Scenario: {Scenario_ID}
- * Epic(s): {Epic_ID(s)}
- * Type: {single-epic | cross-epic}
- * 
- * Generated by /tas-e2e-mobile
- * Spec: {path to E2E-Scenario-*.md}
- */
-
-import { device, element, expect, by, waitFor } from 'detox';
-import { TEST_IDS } from '../test-ids';
-import { loadTestData, getCredentials } from '../helpers/data-loader';
-import { login, logout, navigateToTab } from '../helpers/test-utils';
-
-// Layer 2 helpers (reuse from functional tests)
-import { fillLoginForm, verifyLoginSuccess } from '../features/{epic}/{feature}/helpers';
-import { viewAllergenList } from '../features/{epic2}/{feature2}/helpers';
-
-const testData = loadTestData();
-
-describe('E2E Flow: {Scenario Name}', () => {
-  beforeAll(async () => {
-    await device.launchApp({ newInstance: true });
-  });
-
-  // Main Flow
-  describe('{PROJECT}_E{EPIC}_E2E_001_H: {Flow Title}', () => {
-    it('Step 1: {Action}', async () => {
-      // Reuses: AL_E002_F002_S001_FT_001_H
-      const creds = getCredentials();
-      await fillLoginForm(creds.email, creds.password);
-      await verifyLoginSuccess();
-    });
-
-    it('Step 2: {Action}', async () => {
-      // Reuses: AL_E003_F001_S001_FT_001_H
-      await viewAllergenList();
-    });
-
-    it('Step 3: {New logic - no FT reference}', async () => {
-      // New step: no functional test helper exists
-      await element(by.id(TEST_IDS.SCAN.SCREEN.CAMERA)).tap();
-      // ...
-    });
-  });
-
-  // Alternate Flow (if defined in scenario)
-  describe('{PROJECT}_E{EPIC}_E2E_002_N: {Alternate Flow}', () => {
-    it('should handle {error condition}', async () => {
-      // ...
-    });
-  });
-});
-```
-
-### Buoc 5: Update package.json Script
-Them hoac update script trong `apps/mobile/package.json`:
-```json
-"e2e:flow:{scenario-slug}": "detox test --configuration ios.sim.debug --testPathPattern='e2e/flows/{scenario-slug}'"
-```
-
-### Buoc 6: Generate Execution Report (Optional)
-Sau khi chay tests, generate report tu `.tas/templates/E2E-Execution-Report.md`:
-- Summary metrics (passed/failed/skipped)
-- Results by test ID
-- Failed test details
-- Performance metrics
-- AC coverage analysis
-
-## File Structure Output
-```
-apps/mobile/e2e/flows/
-├── {scenario-1-slug}.e2e.ts
-├── {scenario-2-slug}.e2e.ts
-└── ...
-```
-
-## Reuse Strategy
-```
-Layer 2 (features/)          Layer 3 (flows/)
-┌───────────────────┐       ┌──────────────────────┐
-│ helpers.ts        │──────>│ {scenario}.e2e.ts     │
-│  - fillLoginForm()│       │  import { fillLogin } │
-│  - verifyLogin()  │       │  import { viewList }  │
-└───────────────────┘       │                      │
-┌───────────────────┐       │  Step 1: fillLogin() │
-│ helpers.ts        │──────>│  Step 2: viewList()  │
-│  - viewList()     │       │  Step 3: new logic   │
-└───────────────────┘       └──────────────────────┘
-```
-
-## Chay Tests
-```bash
-# Chay E2E flow cu the
-yarn e2e:flow:{scenario-slug}
-
-# Chay tat ca E2E flows
-npx detox test --configuration ios.sim.debug --testPathPattern='e2e/flows/'
-
-# Chay voi Android
-npx detox test --configuration android.emu.debug --testPathPattern='e2e/flows/{scenario}'
-
-# Chay va generate report
-npx detox test --configuration ios.sim.debug --testPathPattern='e2e/flows/{scenario}' --reporters=jest-junit
-```
-
-## Nguyen tac
-- PHAI reuse helpers tu Layer 2 khi co the, KHONG viet lai logic da co
-- Moi step trong E2E flow nen tuong ung voi 1 functional test helper
-- Steps khong co FT reference → viet logic moi trong flow file
-- Scripts PHAI chay duoc tu CLI, KHONG can cua so Claude
-- Neu apps/mobile/ khong ton tai → bao loi graceful
-- describe block dung full E2E ID de grep duoc
-- import paths: relative tu flows/ len features/
+# /tas-e2e-mobile $ARGUMENTS
+
+Role: SE / QA
+Generate Detox E2E test scripts from an E2E Scenario markdown file.
+
+## IMPORTANT - Layer 3: Mobile E2E Scripts
+- Create Detox test scripts from E2E-Scenario (markdown)
+- Scripts located in `apps/mobile/e2e/flows/`
+- REUSE helpers from Layer 2 functional tests (features/)
+- Chain functional test steps into end-to-end flows
+
+## Actions
+
+### Step 1: Identify Scenario
+1. $ARGUMENTS is path to E2E-Scenario-*.md file
+2. If not provided: scan `docs/epics/**/E2E-Scenario-*.md` and `docs/e2e-scenarios/E2E-Scenario-*.md`
+3. List scenarios and ask user to choose
+
+### Step 2: Check Prerequisites
+1. Check `apps/mobile/` exists. If not → graceful error
+2. Read scenario file to get:
+   - Scenario steps and flow
+   - FT ID references ("Builds on FT IDs" column)
+   - FT Reuse Map (section at end)
+   - Test data per environment
+   - Scenario type (single-epic / cross-epic)
+
+### Step 3: Find Functional Test Helpers
+From FT Reuse Map in scenario:
+1. Find each source file in `apps/mobile/e2e/features/`
+2. Verify helper functions exist
+3. If helper doesn't exist → create stub and note "TODO: implement helper"
+4. Import map: FT ID → file path → function name
+
+### Step 4: Generate E2E Script
+
+**File output**: `apps/mobile/e2e/flows/{scenario-slug}.e2e.ts`
+
+**Structure**:
+```typescript
+/**
+ * E2E Flow: {Scenario Name}
+ * Scenario: {Scenario_ID}
+ * Epic(s): {Epic_ID(s)}
+ * Type: {single-epic | cross-epic}
+ * 
+ * Generated by /tas-e2e-mobile
+ * Spec: {path to E2E-Scenario-*.md}
+ */
+
+import { device, element, expect, by, waitFor } from 'detox';
+import { TEST_IDS } from '../test-ids';
+import { loadTestData, getCredentials } from '../helpers/data-loader';
+import { login, logout, navigateToTab } from '../helpers/test-utils';
+
+// Layer 2 helpers (reuse from functional tests)
+import { fillLoginForm, verifyLoginSuccess } from '../features/{epic}/{feature}/helpers';
+import { viewAllergenList } from '../features/{epic2}/{feature2}/helpers';
+
+const testData = loadTestData();
+
+describe('E2E Flow: {Scenario Name}', () => {
+  beforeAll(async () => {
+    await device.launchApp({ newInstance: true });
+  });
+
+  // Main Flow
+  describe('{PROJECT}_E{EPIC}_E2E_001_H: {Flow Title}', () => {
+    it('Step 1: {Action}', async () => {
+      // Reuses: AL_E002_F002_S001_FT_001_H
+      const creds = getCredentials();
+      await fillLoginForm(creds.email, creds.password);
+      await verifyLoginSuccess();
+    });
+
+    it('Step 2: {Action}', async () => {
+      // Reuses: AL_E003_F001_S001_FT_001_H
+      await viewAllergenList();
+    });
+
+    it('Step 3: {New logic - no FT reference}', async () => {
+      // New step: no functional test helper exists
+      await element(by.id(TEST_IDS.SCAN.SCREEN.CAMERA)).tap();
+      // ...
+    });
+  });
+
+  // Alternate Flow (if defined in scenario)
+  describe('{PROJECT}_E{EPIC}_E2E_002_N: {Alternate Flow}', () => {
+    it('should handle {error condition}', async () => {
+      // ...
+    });
+  });
+});
+```
+
+### Step 5: Update package.json Script
+Add or update script in `apps/mobile/package.json`:
+```json
+"e2e:flow:{scenario-slug}": "detox test --configuration ios.sim.debug --testPathPattern='e2e/flows/{scenario-slug}'"
+```
+
+### Step 6: Generate Execution Report (Optional)
+After running tests, generate report from `.tas/templates/E2E-Execution-Report.md`:
+- Summary metrics (passed/failed/skipped)
+- Results by test ID
+- Failed test details
+- Performance metrics
+- AC coverage analysis
+
+## File Structure Output
+```
+apps/mobile/e2e/flows/
+├── {scenario-1-slug}.e2e.ts
+├── {scenario-2-slug}.e2e.ts
+└── ...
+```
+
+## Reuse Strategy
+```
+Layer 2 (features/)          Layer 3 (flows/)
+┌───────────────────┐       ┌──────────────────────┐
+│ helpers.ts        │──────>│ {scenario}.e2e.ts     │
+│  - fillLoginForm()│       │  import { fillLogin } │
+│  - verifyLogin()  │       │  import { viewList }  │
+└───────────────────┘       │                      │
+┌───────────────────┐       │  Step 1: fillLogin() │
+│ helpers.ts        │──────>│  Step 2: viewList()  │
+│  - viewList()     │       │  Step 3: new logic   │
+└───────────────────┘       └──────────────────────┘
+```
+
+## Run Tests
+```bash
+# Run specific E2E flow
+yarn e2e:flow:{scenario-slug}
+
+# Run all E2E flows
+npx detox test --configuration ios.sim.debug --testPathPattern='e2e/flows/'
+
+# Run with Android
+npx detox test --configuration android.emu.debug --testPathPattern='e2e/flows/{scenario}'
+
+# Run and generate report
+npx detox test --configuration ios.sim.debug --testPathPattern='e2e/flows/{scenario}' --reporters=jest-junit
+```
+
+## Principles
+- MUST reuse helpers from Layer 2 when possible, DO NOT rewrite existing logic
+- Each step in E2E flow should correspond to 1 functional test helper
+- Steps without FT reference → write new logic in flow file
+- Scripts MUST be runnable from CLI, WITHOUT Claude window
+- If apps/mobile/ doesn't exist → graceful error
+- describe block uses full E2E ID for grep-ability
+- import paths: relative from flows/ up to features/