@torus-engineering/tas-kit 1.13.0 → 2.1.0

package/.tas/commands/tas-fix.md

@@ -1,51 +1,72 @@
-# /tas-fix $ARGUMENTS
-
-Role: SE - Software Engineer
-Quick fix for small bugs or obvious errors — no ticket needed, no full lifecycle.
-Use when: solo dev, quick hotfix, bug found during development.
-Differs from /tas-bug: no Bug file created, no status tracking, no deploy flow.
-
-## Stack Detection
-Read `.tas/rules/common/stack-detection.md`.
-
-## Actions
-
-### 1. Understand bug
-$ARGUMENTS is error description, error message, or file:line_number.
-- If error message/stack trace provided: parse immediately, identify error file and line
-- If only description: ask exactly 1 clarifying question (reproduce steps or expected vs actual)
-- DO NOT ask more than 1 question
-
-### 2. Diagnose (max 3 files read)
-- Read error file and directly related files
-- Identify root cause in 1-2 short sentences
-- DO NOT read entire project, DO NOT scan folder structure
-- If need to read more files beyond first 3: ask user confirmation
-
-### 3. Fix with regression test
-
-Before fixing, read relevant rules:
-- `.tas/rules/common/security.md` — check if fix creates security risks
-- `.tas/rules/common/testing.md` — regression test writing patterns
-- `.tas/rules/[lang_rules]/coding-style.md` — current stack conventions (if identifiable)
-
-Then:
-a. Write 1 minimal test case reproducing bug (if project has test framework)
-b. Confirm test FAILS
-c. Fix code at root cause
-d. Confirm test PASSES
-e. Quick run of test suite if available (to check regression)
-
-### 4. Wrap up
-- Output commit message: `fix: <short description>`
-- Remind: "If this bug may recur or affects production, consider using /tas-bug for full tracking."
-
-## Principles
-- Total files read ≤ 3 unless permitted
-- Fix at root cause, DO NOT patch symptom
-- If fix leads to architecture change → stop, suggest using /tas-bug + /tas-adr
-- If bug is in production with high severity → stop, suggest using /tas-bug with severity Critical/High
-
-## Final Step — Token Log
-
-Follow `.tas/rules/common/token-logging.md`: write AI Usage Log to related Story or Bug file (if any).
+---
+model: sonnet
+---
+
+# /tas-fix $ARGUMENTS
+
+Role: SE - Software Engineer
+Quick fix for small bugs or obvious errors — no ticket needed, no full lifecycle.
+Use when: solo dev, quick hotfix, bug found during development.
+Differs from /tas-bug: no Bug file created, no status tracking, no deploy flow.
+
+## Stack Detection
+Read `.tas/rules/common/stack-detection.md`.
+
+## Actions
+
+### 1. Understand bug
+$ARGUMENTS is error description, error message, or file:line_number.
+- If error message/stack trace provided: parse immediately, identify error file and line
+- If only description: ask exactly 1 clarifying question (reproduce steps or expected vs actual)
+- DO NOT ask more than 1 question
+
+### 2. Diagnose (max 3 files read)
+- Read error file and directly related files
+- Identify root cause in 1-2 short sentences
+- DO NOT read entire project, DO NOT scan folder structure
+- If need to read more files beyond first 3: ask user confirmation
+
+### 3. Fix with regression test
+
+Before fixing, read relevant rules:
+- `.tas/rules/common/security.md` — check if fix creates security risks
+- `.tas/rules/common/testing.md` — regression test writing patterns
+- `.tas/rules/[lang_rules]/coding-style.md` — current stack conventions (if identifiable)
+
+Then:
+a. Write 1 minimal test case reproducing bug (if project has test framework)
+b. Confirm test FAILS
+c. Fix code at root cause
+d. Confirm test PASSES
+e. Quick run of test suite if available (to check regression)
+
+### 3.5 SAD Impact Heuristic (pre-commit)
+
+Read `.tas/rules/common/sad-impact.md` "Quick Heuristic" section. Grep staged / changed files for trigger patterns:
+
+- `package.json` / `*.csproj` / `requirements.txt` / `go.mod` / `Cargo.toml` — deps section `+` lines
+- `.env*` / `appsettings*.json` — new key
+- `Dockerfile*` / `docker-compose*.yml` — `EXPOSE` / `ENV` / new service
+- `migrations/**` / `*.sql` — schema change
+- `terraform/**` / `cdk/**` / `k8s/**` / `helm/**` — infra change
+- `.github/workflows/**` / `azure-pipelines*.yml` — CI gate change
+- New top-level dir under `apps/` / `services/`
+
+**Any hit → STOP.** Output:
+> "Fix touches SAD trigger ({matched signal}). `/tas-fix` cannot update SAD properly. Re-run as `/tas-bug` with severity ≥ Medium for proper SAD impact tracking and Changelog audit."
+
+Do NOT commit. Do NOT continue to step 4.
+
+### 4. Wrap up
+- Output commit message: `fix: <short description>`
+- Remind: "If this bug may recur or affects production, consider using /tas-bug for full tracking."
+
+## Principles
+- Total files read ≤ 3 unless permitted
+- Fix at root cause, DO NOT patch symptom
+- If fix leads to architecture change OR matches SAD Impact Heuristic → stop, suggest `/tas-bug` (which handles SAD update + Changelog) + `/tas-adr` if cross-cutting
+- If bug is in production with high severity → stop, suggest using /tas-bug with severity Critical/High
+
+## Final Step — Token Log
+
+Follow `.tas/rules/common/token-logging.md`: write AI Usage Log to related Feature or Bug file (if any).

package/.tas/commands/tas-functest-mobile.md

@@ -1,144 +1,138 @@
-# /tas-functest-mobile $ARGUMENTS
-
-Role: SE / QA
-Generate all Detox automation test scripts for a mobile Feature.
-
-## IMPORTANT - Layer 2: Mobile Functional Test Scripts
-- Create Detox test scripts from Func-Test-Spec (markdown)
-- Scripts located in `apps/mobile/e2e/features/`
-- Reusable helpers exported for Layer 3 (E2E) reuse
-- Hardcoded data in tests, credentials from .env
-
-## Actions
-
-### Step 1: Identify Feature
-1. $ARGUMENTS is Feature ID or file path
-2. If not provided: scan `docs/epics/**/Feature-*.md` for features with status In Progress
-3. Read Feature file to get Epic/Feature numbers and list of Stories
-
-### Step 2: Check Prerequisites
-1. Check `apps/mobile/` exists. If not → error:
-   > "Mobile app doesn't exist in this project. Please create apps/mobile/ first."
-2. Find all `Func-Test-*.md` files in Feature directory:
-   ```
-   docs/epics/{epic-dir}/{feature-dir}/Func-Test-*.md
-   ```
-3. If no Func-Test-Spec exists → error:
-   > "No Func-Test-Spec for this Feature yet. Run /tas-functest {story-ID} first."
-4. Read `apps/mobile/e2e/test-ids.ts` to know existing testIDs
-5. Read `apps/mobile/e2e/helpers/data-loader.ts` and `test-utils.ts` to understand patterns
-
-### Step 3: Aggregate FT Test Cases
-- From all Func-Test-Spec files, aggregate list of FT test cases
-- Group by Story
-- Get test data requirements from each spec
-
-### Step 4: Generate Test Scripts
-For EACH Story with Func-Test-Spec:
-
-**File output**: `apps/mobile/e2e/features/{epic-slug}/{feature-slug}/{story-slug}.func.e2e.ts`
-
-**Structure**:
-```typescript
-/**
- * Functional Tests: {Story Name}
- * Story: {Story_ID}
- * Feature: {Feature_ID}  
- * Epic: {Epic_ID}
- * 
- * Generated by /tas-functest-mobile
- * Spec: docs/epics/{epic-dir}/{feature-dir}/Func-Test-{story-slug}.md
- */
-
-import { device, element, expect, by, waitFor } from 'detox';
-import { TEST_IDS } from '../../../test-ids';
-import { loadTestData, getCredentials } from '../../../helpers/data-loader';
-import { login, navigateTo } from '../../../helpers/test-utils';
-
-const testData = loadTestData();
-
-describe('{Feature Name} - {Story Name}', () => {
-  beforeAll(async () => {
-    await device.launchApp({ newInstance: true });
-  });
-
-  beforeEach(async () => {
-    await device.reloadReactNative();
-  });
-
-  // AC Reference: AC-1
-  describe('{PROJECT}_E{EPIC}_F{FEATURE}_S{STORY}_FT_001_H', () => {
-    it('should {description from spec}', async () => {
-      // Given: {precondition}
-      // When: {action}
-      // Then: {expected}
-    });
-  });
-});
-```
-
-### Step 5: Update test-ids.ts (if needed)
-- If test cases need testID not in test-ids.ts
-- Add new testID per current naming convention
-- Keep structure: nested object with dot notation
-
-### Step 6: Generate Feature Helpers
-Create file `apps/mobile/e2e/features/{epic-slug}/{feature-slug}/helpers.ts`:
-```typescript
-/**
- * Reusable helpers for {Feature Name}
- * Exported for Layer 3 E2E scripts reuse
- */
-
-export async function {featureSpecificHelper}() {
-  // Helper logic extracted from functional tests
-}
-```
-
-### Step 7: Update package.json Script
-Add or update script in `apps/mobile/package.json`:
-```json
-"functest:mobile:{feature-slug}": "detox test --configuration ios.sim.debug --testPathPattern='e2e/features/{epic-slug}/{feature-slug}'"
-```
-
-### Step 8: Generate Index
-Create `apps/mobile/e2e/features/{epic-slug}/{feature-slug}/index.ts`:
-```typescript
-export * from './helpers';
-```
-
-## File Structure Output
-```
-apps/mobile/e2e/features/
-└── {epic-slug}/
-    └── {feature-slug}/
-        ├── {story-1-slug}.func.e2e.ts
-        ├── {story-2-slug}.func.e2e.ts
-        ├── helpers.ts
-        └── index.ts
-```
-
-## Test Data Convention
-- **Hardcoded values**: Directly in test (e.g., "invalid@email", "short")
-- **Credentials**: `const creds = getCredentials();` → password from process.env
-- **Environment data**: `const testData = loadTestData();` → read from test-data.{env}.json
-- **NEVER** hardcode passwords/tokens in test files
-
-## Run Tests
-```bash
-# Run all func tests for feature
-yarn functest:mobile:{feature-slug}
-
-# Run only one story
-npx detox test --configuration ios.sim.debug --testPathPattern='e2e/features/{epic}/{feature}/{story}'
-
-# Run with Android
-npx detox test --configuration android.emu.debug --testPathPattern='e2e/features/{epic}/{feature}'
-```
-
-## Principles
-- Script MUST be runnable directly from CLI, WITHOUT Claude window
-- Each describe block uses full FT ID for grep-ability
-- Helpers MUST export for Layer 3 reuse
-- DO NOT import from Layer 3 (flows/), only export UP to Layer 3
-- If apps/mobile/ doesn't exist → graceful error, DO NOT create
+---
+model: sonnet
+---
+
+# /tas-functest-mobile $ARGUMENTS
+
+Role: SE / QA
+Generate all Detox automation test scripts for a mobile Feature.
+
+## IMPORTANT — Layer 2: Mobile Functional Test Scripts
+- Create Detox test scripts from Func-Test-Spec (markdown)
+- Scripts located in `apps/mobile/e2e/features/`
+- Reusable helpers exported for Layer 3 (E2E) reuse
+- Hardcoded data in tests, credentials from `.env`
+
+## Actions
+
+### Step 1: Identify Feature
+1. `$ARGUMENTS` is Feature ID or file path
+2. If not provided: scan `docs/features/{CODE}-Feature-*/{CODE}-Feature-*.md` for Features with status `In Development`
+3. Read Feature file to get Feature ID + slug
+
+### Step 2: Check Prerequisites
+1. Check `apps/mobile/` exists. If not → error:
+   > "Mobile app doesn't exist. Create `apps/mobile/` first."
+2. Find `Func-Test-Spec.md` in Feature directory:
+   ```
+   docs/features/{CODE}-Feature-{NNN}-{slug}/Func-Test-Spec.md
+   ```
+3. If missing → error:
+   > "No Func-Test-Spec for this Feature. Run `/tas-functest {Feature-ID}` first."
+4. Read `apps/mobile/e2e/test-ids.ts` to know existing testIDs
+5. Read `apps/mobile/e2e/helpers/data-loader.ts` and `test-utils.ts` for patterns
+
+### Step 3: Aggregate FT Test Cases
+- From Func-Test-Spec, list all FT test cases grouped by AC
+- Pull test data requirements from spec
+
+### Step 4: Generate Test Scripts
+
+**File output**: `apps/mobile/e2e/features/{feature-slug}/{feature-slug}.func.e2e.ts`
+
+(One test file per Feature — Stories no longer exist.)
+
+**Structure**:
+```typescript
+/**
+ * Functional Tests: {Feature Name}
+ * Feature: {Feature_ID}
+ * Stack: app
+ *
+ * Generated by /tas-functest-mobile
+ * Spec: docs/features/{feature-dir}/Func-Test-Spec.md
+ */
+
+import { device, element, expect, by, waitFor } from 'detox';
+import { TEST_IDS } from '../../test-ids';
+import { loadTestData, getCredentials } from '../../helpers/data-loader';
+import { login, navigateTo } from '../../helpers/test-utils';
+
+const testData = loadTestData();
+
+describe('{Feature Name}', () => {
+  beforeAll(async () => {
+    await device.launchApp({ newInstance: true });
+  });
+
+  beforeEach(async () => {
+    await device.reloadReactNative();
+  });
+
+  // AC Reference: AC-1
+  describe('{PROJECT}_F{FEATURE}_AC1_FT_001_H', () => {
+    it('should {description from spec}', async () => {
+      // Given: {precondition}
+      // When: {action}
+      // Then: {expected}
+    });
+  });
+});
+```
+
+### Step 5: Update test-ids.ts (if needed)
+- Add new testIDs per current naming convention
+- Keep nested-object structure with dot notation
+
+### Step 6: Generate Feature Helpers
+Create `apps/mobile/e2e/features/{feature-slug}/helpers.ts`:
+```typescript
+/**
+ * Reusable helpers for {Feature Name}
+ * Exported for Layer 3 E2E scripts reuse.
+ */
+
+export async function {featureSpecificHelper}() {
+  // Helper logic extracted from functional tests
+}
+```
+
+### Step 7: Update package.json Script
+```json
+"functest:mobile:{feature-slug}": "detox test --configuration ios.sim.debug --testPathPattern='e2e/features/{feature-slug}'"
+```
+
+### Step 8: Generate Index
+`apps/mobile/e2e/features/{feature-slug}/index.ts`:
+```typescript
+export * from './helpers';
+```
+
+## File Structure Output
+```
+apps/mobile/e2e/features/
+└── {feature-slug}/
+    ├── {feature-slug}.func.e2e.ts
+    ├── helpers.ts
+    └── index.ts
+```
+
+## Test Data Convention
+- **Hardcoded values**: Directly in test
+- **Credentials**: `getCredentials()` → password from process.env
+- **Environment data**: `loadTestData()` → from test-data.{env}.json
+- **NEVER** hardcode passwords/tokens
+
+## Run Tests
+```bash
+yarn functest:mobile:{feature-slug}
+npx detox test --configuration ios.sim.debug --testPathPattern='e2e/features/{feature-slug}'
+npx detox test --configuration android.emu.debug --testPathPattern='e2e/features/{feature-slug}'
+```
+
+## Principles
+- Script MUST be runnable directly from CLI
+- Each describe block uses full FT ID for grep-ability
+- Helpers MUST export for Layer 3 reuse
+- DO NOT import from Layer 3 (`flows/`)
+- If `apps/mobile/` doesn't exist → graceful error