@torrent-tv/proxy 2.89.5 → 2.89.6

package/test/format-keyed-outputs.test.js

@@ -1,78 +1,78 @@
-/**
- * @file An output is named by the format it produces, and nothing may put
- * pieces of another format under that name.
- *
- * Two ways that could still happen once the name became the format: a
- * directory left by an earlier version, whose key named the box a viewer asked
- * for and so cannot say what format is inside; and a hardware encoder failing,
- * after which the proxy encodes with software while outputs named by the failed
- * encoder are still being watched.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { existsSync, writeFileSync } from "node:fs";
-import path from "node:path";
-import { managerWithOwnStore } from "./helpers/manager.js";
-import { outputSpec } from "./helpers/output-spec.js";
-import { ENCODE_EXIT } from "../services/encode/encode-exit.js";
-import { SourceFile } from "../services/media/SourceFile.js";
-
-test("a directory whose key names an asked-for box is not adopted, and one naming a format is", (t) => {
-  const { store, root, manager, cleanup } = managerWithOwnStore();
-  t.after(cleanup);
-  const oldKey = "torrent:abc:fmt=fmp4:grid=even@0:video-only:v=0/enc:1280x720:budget";
-  const newKey = outputSpec({ sourceKey: "torrent:abc", transcodeVideo: true, width: 1280, height: 720, audioSeparate: true }).toKey();
-  const oldDir = store.directoryFor(oldKey);
-  const newDir = store.directoryFor(newKey);
-  writeFileSync(path.join(oldDir, "segment-00000.mp4"), Buffer.alloc(10));
-  writeFileSync(path.join(newDir, "segment-00000.mp4"), Buffer.alloc(10));
-
-  const result = manager.lifecycle.adoptSegmentsLeftBehind();
-
-  assert.equal(result.adopted, 1);
-  assert.equal(result.dropped, 1);
-  assert.equal(existsSync(oldDir), false, "the old directory goes");
-  assert.equal(existsSync(newDir), true, "the named format stays");
-  assert.ok(root);
-});
-
-test("when a hardware encoder fails, the outputs it named are closed rather than continued by software", async (t) => {
-  const { manager, cleanup } = managerWithOwnStore({
-    videoEncoder: { kind: "vaapi", name: "h264_vaapi", inputArgs: [] }
-  });
-  t.after(async () => {
-    await manager.lifecycle.disposeAll();
-    cleanup();
-  });
-  manager.encodeRuns.planEncodersNow = () => {};
-  manager.encodeRuns.planEncodersSoon = () => {};
-  const file = new SourceFile({ sourceKey: "torrent:abc", fileIndex: 0, name: "film.mkv" });
-  const record = (id, encoder) => {
-    const spec = outputSpec({ sourceKey: "torrent:abc", transcodeVideo: true, width: 1280, height: 720, encoder });
-    const output = { id, spec, get outputKey() { return this.spec.toKey(); }, file };
-    manager.outputs.set(id, output);
-    return output;
-  };
-  const failing = record("aaaaaaaa00000001", "h264_vaapi");
-  const software = record("aaaaaaaa00000002", "libx264");
-  const run = { from: 0, to: -1, argsDescribed: "ffmpeg …" };
-  manager.encodeOrchestrator.adopt(failing.outputKey, run);
-
-  manager.encodeRuns.noteRunEnded(failing, run, {
-    address: failing.outputKey,
-    run,
-    ending: ENCODE_EXIT.FAILED,
-    from: 0,
-    to: -1,
-    livedMs: 30_000,
-    because: "vaapi failed",
-    lastError: "vaapi failed",
-    producedCount: 3
-  });
-  await new Promise((resolve) => setImmediate(resolve));
-
-  assert.equal(manager.videoEncoder.kind, "software");
-  assert.equal(manager.outputs.has(failing.id), false, "an output of the failed encoder is closed");
-  assert.equal(manager.outputs.has(software.id), true, "an output of another encoder is untouched");
-});
+/**
+ * @file An output is named by the format it produces, and nothing may put
+ * pieces of another format under that name.
+ *
+ * Two ways that could still happen once the name became the format: a
+ * directory left by an earlier version, whose key named the box a viewer asked
+ * for and so cannot say what format is inside; and a hardware encoder failing,
+ * after which the proxy encodes with software while outputs named by the failed
+ * encoder are still being watched.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { existsSync, writeFileSync } from "node:fs";
+import path from "node:path";
+import { managerWithOwnStore } from "./helpers/manager.js";
+import { outputSpec } from "./helpers/output-spec.js";
+import { ENCODE_EXIT } from "../services/encode/encode-exit.js";
+import { SourceFile } from "../services/media/SourceFile.js";
+
+test("a directory whose key names an asked-for box is not adopted, and one naming a format is", (t) => {
+  const { store, root, manager, cleanup } = managerWithOwnStore();
+  t.after(cleanup);
+  const oldKey = "torrent:abc:fmt=fmp4:grid=even@0:video-only:v=0/enc:1280x720:budget";
+  const newKey = outputSpec({ sourceKey: "torrent:abc", transcodeVideo: true, width: 1280, height: 720, audioSeparate: true }).toKey();
+  const oldDir = store.directoryFor(oldKey);
+  const newDir = store.directoryFor(newKey);
+  writeFileSync(path.join(oldDir, "segment-00000.mp4"), Buffer.alloc(10));
+  writeFileSync(path.join(newDir, "segment-00000.mp4"), Buffer.alloc(10));
+
+  const result = manager.lifecycle.adoptSegmentsLeftBehind();
+
+  assert.equal(result.adopted, 1);
+  assert.equal(result.dropped, 1);
+  assert.equal(existsSync(oldDir), false, "the old directory goes");
+  assert.equal(existsSync(newDir), true, "the named format stays");
+  assert.ok(root);
+});
+
+test("when a hardware encoder fails, the outputs it named are closed rather than continued by software", async (t) => {
+  const { manager, cleanup } = managerWithOwnStore({
+    videoEncoder: { kind: "vaapi", name: "h264_vaapi", inputArgs: [] }
+  });
+  t.after(async () => {
+    await manager.lifecycle.disposeAll();
+    cleanup();
+  });
+  manager.encodeRuns.planEncodersNow = () => {};
+  manager.encodeRuns.planEncodersSoon = () => {};
+  const file = new SourceFile({ sourceKey: "torrent:abc", fileIndex: 0, name: "film.mkv" });
+  const record = (id, encoder) => {
+    const spec = outputSpec({ sourceKey: "torrent:abc", transcodeVideo: true, width: 1280, height: 720, encoder });
+    const output = { id, spec, get outputKey() { return this.spec.toKey(); }, file };
+    manager.outputs.set(id, output);
+    return output;
+  };
+  const failing = record("aaaaaaaa00000001", "h264_vaapi");
+  const software = record("aaaaaaaa00000002", "libx264");
+  const run = { from: 0, to: -1, argsDescribed: "ffmpeg …" };
+  manager.encodeOrchestrator.adopt(failing.outputKey, run);
+
+  manager.encodeRuns.noteRunEnded(failing, run, {
+    address: failing.outputKey,
+    run,
+    ending: ENCODE_EXIT.FAILED,
+    from: 0,
+    to: -1,
+    livedMs: 30_000,
+    because: "vaapi failed",
+    lastError: "vaapi failed",
+    producedCount: 3
+  });
+  await new Promise((resolve) => setImmediate(resolve));
+
+  assert.equal(manager.encoders.current.kind, "software");
+  assert.equal(manager.outputs.has(failing.id), false, "an output of the failed encoder is closed");
+  assert.equal(manager.outputs.has(software.id), true, "an output of another encoder is untouched");
+});

package/test/helpers/manager.js

@@ -1,57 +1,62 @@
-/**
- * @file A session manager for a test, with a store of its own.
- *
- * ONE MANAGER, ONE ROOT. In production that is true by construction: one
- * process holds one manager, and the store's root is a fixed path so that a
- * restart can find what the process before it finished (`SegmentStore.sweep`).
- * Under `node --test` it is false — the runner starts one PROCESS PER FILE and
- * runs them in parallel, so every manager built without a store of its own
- * shared the one default root with every other file running at that moment.
- *
- * What that cost, measured 2026-09-14: `disposeAll` removes the store's whole
- * root, and four files call it between them 40 times. Running the twenty-one
- * files that build a manager gave 2, 3 and 4 failures on consecutive runs and
- * zero with `--test-concurrency=1`; the victim was always
- * `segment-serve-wiring.test.js`, reporting a segment missing that it had
- * written itself a moment earlier, because another process had deleted the
- * directory under it. `npm test` is `node --test`, so this was the project's
- * own test command, and it is why a red result had become something to read
- * past rather than to act on.
- *
- * A test that fails by luck is worse than one that does not exist: it costs a
- * run every time, and it trains everyone to ignore red.
- */
-
-import { mkdtempSync, rmSync } from "node:fs";
-import os from "node:os";
-import path from "node:path";
-import { wireOutputs } from "../../services/server/wire-outputs.js";
-import { SegmentStore } from "../../services/storage/segment-store/SegmentStore.js";
-
-/**
- * A manager whose produced segments live where nothing else can reach them.
- *
- * @param {object} [options] - Passed to the manager, over the defaults below.
- *   A `segmentStore` given here wins, for a test that wants to watch the store
- *   itself.
- * @returns {{ manager: object, store: SegmentStore, root: string,
- *   cleanup: () => void }} `cleanup` removes the root; call it from `t.after`.
- */
-export function managerWithOwnStore(options = {}) {
-  const root = mkdtempSync(path.join(os.tmpdir(), "ttv-store-"));
-  const store = options.segmentStore ?? new SegmentStore({ root });
-  const manager = wireOutputs({
-    enabled: true,
-    ffmpegBin: "ffmpeg",
-    localBindHost: "127.0.0.1",
-    localPort: 9090,
-    ...options,
-    segmentStore: store
-  });
-  return {
-    manager,
-    store,
-    root,
-    cleanup: () => rmSync(root, { recursive: true, force: true })
-  };
-}
+/**
+ * @file A session manager for a test, with a store of its own.
+ *
+ * ONE MANAGER, ONE ROOT. In production that is true by construction: one
+ * process holds one manager, and the store's root is a fixed path so that a
+ * restart can find what the process before it finished (`SegmentStore.sweep`).
+ * Under `node --test` it is false — the runner starts one PROCESS PER FILE and
+ * runs them in parallel, so every manager built without a store of its own
+ * shared the one default root with every other file running at that moment.
+ *
+ * What that cost, measured 2026-09-14: `disposeAll` removes the store's whole
+ * root, and four files call it between them 40 times. Running the twenty-one
+ * files that build a manager gave 2, 3 and 4 failures on consecutive runs and
+ * zero with `--test-concurrency=1`; the victim was always
+ * `segment-serve-wiring.test.js`, reporting a segment missing that it had
+ * written itself a moment earlier, because another process had deleted the
+ * directory under it. `npm test` is `node --test`, so this was the project's
+ * own test command, and it is why a red result had become something to read
+ * past rather than to act on.
+ *
+ * A test that fails by luck is worse than one that does not exist: it costs a
+ * run every time, and it trains everyone to ignore red.
+ */
+
+import { mkdtempSync, rmSync } from "node:fs";
+import os from "node:os";
+import path from "node:path";
+import { wireOutputs } from "../../services/server/wire-outputs.js";
+import { SegmentStore } from "../../services/storage/segment-store/SegmentStore.js";
+
+/**
+ * A manager whose produced segments live where nothing else can reach them.
+ *
+ * @param {object} [options] - Passed to the manager, over the defaults below.
+ *   A `segmentStore` given here wins, for a test that wants to watch the store
+ *   itself.
+ * @returns {{ manager: object, store: SegmentStore, root: string,
+ *   cleanup: () => void }} `cleanup` removes the root; call it from `t.after`.
+ */
+export function managerWithOwnStore(options = {}) {
+  const root = mkdtempSync(path.join(os.tmpdir(), "ttv-store-"));
+  const store = options.segmentStore ?? new SegmentStore({ root });
+  const manager = wireOutputs({
+    enabled: true,
+    ffmpegBin: "ffmpeg",
+    localBindHost: "127.0.0.1",
+    localPort: 9090,
+    // What this host has measured about itself is kept beside the store, not
+    // beside the installed proxy: read from there, one run's figures became
+    // the next run's premises, and a check passed only on a machine that had
+    // run the suite before.
+    stateDir: root,
+    ...options,
+    segmentStore: store
+  });
+  return {
+    manager,
+    store,
+    root,
+    cleanup: () => rmSync(root, { recursive: true, force: true })
+  };
+}