@torrent-tv/proxy 2.89.3 → 2.89.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (49) hide show
  1. package/AGENTS.md +338 -336
  2. package/CHANGELOG.md +12 -0
  3. package/docs/encode-architecture.md +55 -19
  4. package/docs/playback-start-forecast.md +13 -5
  5. package/docs/storage-architecture.md +6 -0
  6. package/package.json +1 -1
  7. package/routes/stream/get.js +38 -2
  8. package/server.js +748 -745
  9. package/services/encode/EncodeOrchestrator.js +24 -49
  10. package/services/encode/EncodePlan.js +5 -3
  11. package/services/encode/EncodeRun.js +80 -17
  12. package/services/encode/EncodeRuns.js +1339 -1239
  13. package/services/encode/Renditions.js +2 -1
  14. package/services/encode/RunClock.js +87 -0
  15. package/services/encode/RunProgress.js +1 -6
  16. package/services/encode/encoder-readings.js +26 -28
  17. package/services/encode/piece-completeness.js +46 -0
  18. package/services/encode/quality/EncodeCost.js +1043 -1167
  19. package/services/encode/quality/OutputQualityState.js +1 -5
  20. package/services/encode/quality/QualityController.js +213 -390
  21. package/services/encode/quality/link-budget.js +5 -17
  22. package/services/encode/run-inputs.js +13 -2
  23. package/services/server/SegmentServing.js +3 -1
  24. package/services/server/ViewerRequests.js +2 -7
  25. package/services/server/wire-outputs.js +12 -7
  26. package/services/storage/segment-store/SegmentStore.js +46 -29
  27. package/services/torrent/supply-margin.js +7 -5
  28. package/test/auto-quality-step.test.js +75 -29
  29. package/test/decode-cost.test.js +1 -1
  30. package/test/encode-cost.test.js +31 -39
  31. package/test/encode-orchestrator.test.js +15 -8
  32. package/test/encode-plan-viewers.test.js +34 -27
  33. package/test/encode-run.test.js +34 -6
  34. package/test/encoder-readings.test.js +48 -26
  35. package/test/helpers/encode-run.js +113 -9
  36. package/test/link-budget.test.js +4 -5
  37. package/test/manager-surface.test.js +1 -2
  38. package/test/orchestrator-wired.test.js +5 -4
  39. package/test/output-speed.test.js +0 -1
  40. package/test/piece-completeness.test.js +42 -0
  41. package/test/quality-offer.test.js +1 -3
  42. package/test/quality-variants.test.js +1 -1
  43. package/test/run-progress.test.js +2 -3
  44. package/test/same-height-switch.test.js +1 -2
  45. package/test/segment-store.test.js +15 -15
  46. package/test/stream-route.test.js +28 -0
  47. package/test/supply-margin.test.js +13 -0
  48. package/test/two-viewers-one-picture.test.js +1 -1
  49. package/test/viewer-outputs.test.js +1 -1
package/AGENTS.md CHANGED
@@ -1,336 +1,338 @@
1
- # proxy — @torrent-tv/proxy (WebTorrent + ffmpeg)
2
-
3
- Downloads a torrent and streams the chosen file to the browser, transcoding to
4
- HLS only when needed. See the parent `../CLAUDE.md` for the overall architecture
5
- and release process.
6
-
7
- ## Deployment-agnostic — important
8
-
9
- The HA addon is only ONE way to run this; bare npm and Docker are planned. Keep
10
- all code free of Home-Assistant assumptions. Anything host-specific (GPU
11
- devices, ffmpeg build, CLI flags) belongs in the `ha-addon` layer. Hardware
12
- detection must probe at runtime and fall back gracefully; do not assume a
13
- Linux-only host (e.g. POSIX-only signals must degrade elsewhere).
14
-
15
- ## Layout
16
-
17
- Browser request and response fields, compatibility defaults, and status meanings
18
- are recorded in `docs/browser-proxy-contract.md`.
19
-
20
- - `bin/cli.js` — CLI entry; resolves `ffmpegBin` (uses `--ffmpeg-bin` if given,
21
- else bundled ffmpeg-static, else PATH `ffmpeg`).
22
- - `server.js` — the composition root: creates Fastify, initializes process-wide
23
- resources, calls `services/server/wire-outputs.js` for the output and encode
24
- service graph, registers each route explicitly, and passes its dependencies.
25
- `wire-outputs.js` is a subordinate assembler for that graph; it does not
26
- create the HTTP server or register routes.
27
- - `routes/<path>/<method>.js` — same convention as the server repo.
28
- - `routes/stream/get.js` — byte-range torrent file streaming (HTTP 206).
29
- - `routes/api/playback-plan/post.js` — codec/container/duration probe result.
30
- - `routes/transcode/session-file/get.js` — serves HLS playlist/segments;
31
- long-polls while a segment is being produced, returns retryable 503 (never
32
- 202 — hls.js can't consume it).
33
- - `services/`:
34
- - `torrent/demand/` — what anybody wants, in BYTES: `Window` (claimant, file, byte
35
- range, urgency), `Urgency` (BLOCKED / NEAR / AHEAD / TAIL / BEHIND),
36
- `DemandRegister` (live windows by claimant), `pieces.js` (the one place
37
- bytes become piece numbers). No WebTorrent, no piece store, no pieces.
38
- - `torrent/download/` — `SwarmSelection`, the ONLY thing that calls `select`,
39
- `deselect` or `critical`, and `registry.js`, which holds one per torrent and
40
- owns the cross-torrent rule that withholds the speculative levels while
41
- anything urgent is missing anywhere. See `docs/download-architecture.md`.
42
- - `encode/output/` — domain layer: `OutputSpec`, `VideoOutput`, `AudioOutput`,
43
- `CutGrid`. What a session PRODUCES — which tracks, in what form, cut how,
44
- packaged how — and therefore its identity: two outputs whose parameters
45
- agree ARE the same output, and the encoded result is reused by definition.
46
- Nothing about a VIEWER appears in it (not the consumer id, not where they
47
- started, not their viewport), and nothing about the request that does not
48
- change a byte of the result. `server/ViewerRequests.js` builds one and keys
49
- the output on it.
50
- - **`media/` — THE MEDIA LAYER, one directory, and it answers ONE question:
51
- what does a FILE say about itself.** Its containers, its tracks, where its
52
- keyframes are, how long it runs, and the plan for playing it. Every fact in
53
- it is born when a header is read, dies when the file is forgotten, and is
54
- addressed by the file — which is the test that put them together. It used to
55
- be four places at two levels (`container/`, `tracks/`, half of
56
- `orchestrators/`, and `playback-planner.js` loose in `services/`), so the
57
- layer could not be put under an import rule and the rule was written per
58
- directory instead.
59
- Inside it, the DOMAIN is `media/container/` and `media/tracks/`: they import
60
- nothing but each other, this proxy's own logger included. The application
61
- files sit flat beside them — `ContainerOrchestrator`, `KeyframeTables`,
62
- `SubtitleOrchestrator`, `playback-planner.js`, `keyframe-probe.js`,
63
- `ffmpeg-banner.js`, `audio-inventory.js` — and may reach their own domain and
64
- the logger and nothing else. What a torrent CONTAINS, which clusters may be
65
- read, where a viewer stands, what an encoder costs: all handed in. Both
66
- reaches that existed are gone — `torrent-worker/subtitle-cues.js` is given to
67
- `SubtitleOrchestrator` by `server.js`, and `torrent/Contents.js` to the
68
- planner — so this layer can be exercised with plain values, no torrent, no
69
- thread and no disk. Checked by breaking it in every direction.
70
- - **The parse happens on the MAIN thread, and the torrent thread serves
71
- bytes.** It used to parse containers too — tracks, media info, keyframe
72
- index — and carry each answer back over the channel, on the stated ground
73
- that "the main thread cannot open a read stream on one of its files". True
74
- of WebTorrent's API, not of the bytes: a container is built from one
75
- function, `readRange(start, end)`, the pieces live in shared memory, and
76
- `WorkerTorrentPool.readRangeOf` is the read that serves every segment — it
77
- waits for what has not arrived and steers the swarm toward it. That split
78
- is what made "where is this fact kept" a question at all; with one thread it
79
- does not arise. NOTHING in that thread reaches into the media layer now —
80
- the subtitle cue walk was the last, and it is handed which byte ranges of a
81
- file are downloaded WHOLE (one list per pass, not a question per cluster)
82
- plus a store read that never fetches, both in
83
- `torrent/worker/held-bytes.js`. A piece arriving is ANNOUNCED
84
- (`PIECES_ARRIVED`) rather than acted on there. Pinned by
85
- `test/the-torrent-thread-serves-bytes.test.js`.
86
- - `media/container/` — domain: `Container` (abstract, RFC 9559 / ISO 14496-12),
87
- `MatroskaContainer` / `Mp4Container` / `AviContainer`, `ContainerFactory`
88
- (sniff 16 bytes → precise subclass), `KeyframeTable`. See
89
- `docs/container-architecture.md`.
90
- - `media/tracks/` — domain: `ContainerTrack` (base: TrackNumber, declaredIndex,
91
- language/BCP47, isEnabled/isDefault) → `VideoTrack` / `AudioTrack` /
92
- `SubtitleTrack` → `TextSubtitleTrack` / `ImageSubtitleTrack`,
93
- `ExternalSubtitleFile`. Spec-accurate flags (FlagForced only on subtitles per
94
- RFC 9559 §5.1.4.1, FlagOriginal/Commentary only on audio, tkhd
95
- track_enabled / alternate_group, elng BCP47).
96
- - `media/` application files: `ContainerOrchestrator` (detect + the ONE
97
- container per file, `containerFor`/`getTracks`/`getMediaInfo`/`getKeyframeIndex`;
98
- the container keeps its own reading of each element it states — the Segment
99
- layout, Tracks, Cues, MP4's `moov` — once it has been read), `KeyframeTables`,
100
- `SubtitleOrchestrator` (the track list and the cues behind
101
- `Container` tracks, warm/push — it is handed the walk, and `server.js` is
102
- what puts the two together), `SubtitleCues` (the plan, the found-order
103
- cursor, one walk of a file at a time, taking back withdrawn cues). It uses
104
- the file's one container — it no longer builds its own. The walk itself is
105
- `MatroskaContainer.readHeldCues` over `container/matroska-clusters.js` (which
106
- also finds clusters the Cues table does not name) and
107
- `Mp4Container.readHeldSamples`; what the torrent supplies is `held-bytes.js`
108
- — which ranges are downloaded whole, and a read of one that never fetches
109
- and answers at once with nothing where the range is not whole.
110
- - **A read whose bytes have not arrived is not an answer about the file.**
111
- Every container read is strict (`container/unavailable.js`): every byte, or
112
- `BytesUnavailable`. A value, a proven absence, or a refusal of ours with its
113
- reason may be kept; "not here yet" never is — not by a container, not by
114
- `ContainerOrchestrator`, not by `KeyframeTables`, not by `SubtitleCues`.
115
- **`KeyframeTables` is where a file's keyframe table lives and the only thing
116
- that reads one.** The table is `container/KeyframeTable.js`, ONE object per
117
- file, handed out rather than copied — so a read that lands after a session
118
- was made still reaches it, which a value could not. It answers two questions
119
- that a bag of probe fields could not tell apart: `answered` (a reader came
120
- back) and `readable` (it came back with times). The first distinguishes a
121
- file that must be re-encoded for ever from a passing shortage of bytes off
122
- the swarm. One read per file whoever asks, the second asker joins the first,
123
- each caller's wait is bounded by the measured `KEYFRAME_TABLE_BUDGET_MS`
124
- while the READ is not, and a read that threw — `BytesUnavailable` included —
125
- is never recorded as an answer; it is read again when pieces of the file
126
- arrive (`readAgainIfUnanswered`). It is the ONLY store of the keyframe
127
- answer; the container keeps the Cues reading the times are taken from. The second reader is the packet probe in
128
- `media/keyframe-probe.js`, which decodes rather than parsing; the fuller of the
129
- two answers is the one that stands (`media/keyframe-probe.js`).
130
- - `server/controllers/` — interface layer: `PlaybackController` / `SubtitleController`
131
- (thin adapters over orchestrators; routes depend on controllers, not services).
132
- `routes/*` are now thin HTTP translators. A controller reaches every layer
133
- below it THROUGH its orchestrator and never around it, which biome checks —
134
- so what an orchestrator needs from another layer is composed in `server.js`
135
- and passed in.
136
- - Everything a container states about ITSELF lives in its own class: the
137
- track table, the Cues, the keyframe times they name, the cluster positions,
138
- the blocks inside a cluster, the MP4 sample table, and the walk of what is
139
- downloaded. `services/container-index/` is gone; `container/ebml-reader.js`
140
- is the format's byte-level grammar, not its statements, and is the only
141
- piece kept apart. `ContainerFactory` is the ONE place that decides what a
142
- file is — by sniffing the header, since that is what the muxer wrote — and
143
- that is it. `ContainerFactory.readKeyframeIndex` is gone: it existed only for
144
- the session manager's own HTTP read of a container, which is deleted.
145
- - `docs/download-architecture.md` — the two axes of downloading: what is
146
- wanted (`demand/`) against what the swarm is told (`download/`), why urgency
147
- is not a number given to the library, and why the speculative levels are
148
- withdrawn rather than lowered.
149
- - **The storage layer — ONE layer, FOUR directories.** Bytes on a medium with
150
- a limit is the property they share; what holds them are three different
151
- things with different lifetimes, different addresses and different THREADS,
152
- so they are not flattened into one:
153
- - `storage/piece-store/` — the torrent's pieces: memory tier, spill tier, and the
154
- order they leave in (`shared-piece-store.js`, `piece-lru.js`,
155
- `piece-disk-store.js`). Lives in the torrent WORKER thread.
156
- - `storage/segment-store/` — the segments an encoder has produced
157
- (`SegmentStore.js`), addressed by the output's own key. Main thread.
158
- - `storage/files/` — files downloaded whole and kept as files
159
- (`CompletedFiles.js`, `piece-from-whole-file.js`). Worker thread.
160
- - `storage/` — THE ONE BUDGET: how much of this machine the proxy may
161
- take, and how that is divided between everything that holds bytes.
162
- `MachineBudget.js` is the single owner; `allowance.js` the rule;
163
- `machine-memory.js` and `free.js` read the machine; `wire.js` says who
164
- the claimants are and which RESOURCE each takes; `keep.js` and
165
- `returns.js` say how long material nobody is using is kept. It holds no
166
- bytes itself.
167
- **One budget does not mean one number.** Memory cannot be paid for with
168
- disk, so what is divided is divided per resource — and "disk" is one
169
- resource per DEVICE, read with `statSync(dir).dev`, because two
170
- filesystems cannot pay for each other either (`/tmp` and `/data` on the
171
- addon host are two). What there is ONE of is the owner, the policy and
172
- the place that reads the machine. One owner because the claimants TRADE
173
- across resources: pieces that do not fit in memory are spilled to disk,
174
- so what memory is given decides how much disk is needed — 14 400 MB
175
- spilled in fifty minutes while the store held 312-424 MB.
176
- The policy is the operator's, stated once at startup — `--budget
177
- adaptive|share|fixed`, `--budget-share`, `--budget-bytes`,
178
- `--min-memory-bytes`, `--min-disk-bytes` — and those are the only
179
- chosen numbers in the proxy, because they are chosen by the person whose
180
- machine it is. The default is the measured one.
181
- They may import each other and nothing above, which `biome` checks as an
182
- EXCEPTION to `../**` rather than as a list of forbidden layers — a layer is
183
- not a directory, the blanket form cannot say "my siblings", and a list of
184
- names misses whatever it forgets.
185
- - `docs/storage-architecture.md` — the three things that write to one disk, the
186
- two rules that remove material (nobody needs it, or there is no room), the
187
- order the viewers give that removal, why a spilled piece is a file of its
188
- own, and what is still not solved.
189
- - `docs/encode-architecture.md` — who decides where encoders go, and the
190
- answer is one authority: `EncodePlan`, from what is made, what is being
191
- made, what is wanted and what the host can hold. Why no viewer reaches it,
192
- why the priority map is read at two scopes (per FILE for the swarm, per
193
- OUTPUT for the encoders), and what each of the eight other places that used
194
- to place or kill an encoder now states instead.
195
- - `docs/logs.md` — where to find logs, and the fact that the BROWSER's own log
196
- is in TWO places split by phase: on the droplet while a transport is being
197
- acquired and at unload, on THIS proxy for the whole of a viewing
198
- (`/data/client-<start>-<session>-<torrent>.log`, one file per session).
199
- Read both before concluding anything from a half-session.
200
- - `media/playback-planner.js` — single ffmpeg probe returns audioCodec,
201
- videoCodec, container, durationSeconds. `mode` is advisory; the browser
202
- decides. `media/keyframe-probe.js` beside it is the OTHER reading of the same
203
- file, by decoding rather than by parsing, for containers that state no index.
204
- - `server/` — what a request does, one operation at a time, and nothing
205
- that lives longer than the operation: `ViewerRequests` (open an output of a
206
- file and be placed on it, state a position, report progress),
207
- `SegmentServing` (answer a playlist, init or segment request from the store,
208
- or hold it until the piece is whole), `OutputLifecycle` (dispose an output
209
- nobody is on, all of them at shutdown, adopt what an earlier process left),
210
- and `wire-outputs.js`, which builds the components and hands each the narrow
211
- host it reads. `hls-session-manager.js` is gone (2.87.0): each of its members
212
- is a method of the component that owns it. The operations own no long-lived
213
- fact: the init served for an output is kept by `SegmentStore`, the bytes read
214
- for an output by `EncodeRuns`, the cold-start measurement by `HostTimings`.
215
- They import no component's implementation — only the name of an output and
216
- of its playlist (`encode/output/index.js`) and the keeping period
217
- (`storage/keep.js`); biome checks it. A held request waits for the store's
218
- publication event, as long as the requester states (`X-Hold-Ms`) and no
219
- longer than it stays.
220
- - `encode/` beside the orchestrator: `OutputOpening` (which output answers a
221
- request for a file, made if it is not here yet — without knowing who asked),
222
- `EncodeRuns` (build a run where the plan places it, follow it, account for
223
- its end, and what its input has received), `EncoderSelection` (the encoder
224
- in use and the move to software), `Renditions` (the steps of a picture and
225
- its soundtracks, the master playlist, and which rung a viewer's page says it
226
- plays), `OutputTimes` (where each segment begins and how the cut table is
227
- corrected), `CushionReport` (how much film is ready in front of the
228
- viewers), `output-key-format.js` (which container a key names).
229
- - `viewer/`: every viewer has a name (`Viewers.of` refuses an empty one); the
230
- relation to outputs is stored only in `Viewer.outputs` and read the other way
231
- by `Viewers.forOutput`. A quality request belongs to one viewer and exists
232
- only in AUTO (`Viewer.askQuality`). The playback start forecast
233
- (`playback-readiness.js`) is the viewer's, because it predicts how the
234
- viewer's browser will play; `ViewerRequests` is handed it by
235
- `wire-outputs.js`. `media-time.js` is exact media time and the rule by which
236
- every Media Source engine joins buffered ranges — see
237
- `docs/playback-start-forecast.md`.
238
- - `torrent/` reaches the piece store by what it does (`piece-store-of.js`) and
239
- is handed the store's class by `torrent/worker/worker.js`, where that thread
240
- is assembled. `transport/` imports nothing of another component; `bin/cli.js`
241
- hands it the memory reading and the rule for which captures are kept.
242
- - `encode/hwaccel.js` — detect best H.264 encoder (NVENC/QSV/VAAPI/V4L2M2M) with a
243
- STRICT startup test: encode `testsrc2` through the real HLS pipeline, then
244
- verify each segment decodes independently (catches non-IDR/corrupted hw
245
- output). Falls back to software libx264. Runtime fallback to software if a
246
- hw encode later fails. v4l2m2m is gated by this test (fails on HA Yellow).
247
- - `transport/data-channel-handler.js` — forwards WebRTC data-channel requests to the
248
- local HTTP server (loopback), so the same routes serve both transports.
249
-
250
- ## Gotchas
251
-
252
- - Do NOT use `-hls_playlist_type event` — it breaks duration/seek. VOD only.
253
- - A transitive dep (`ip-set`, via webtorrent) ships a hostile
254
- `preinstall: npx only-allow pnpm` that breaks `npm install`. The addon works
255
- around it with `--ignore-scripts` + a targeted rebuild of `node-datachannel`;
256
- if you ever change install flow, keep that in mind.
257
-
258
- ## Planned: public reachability (remote access)
259
-
260
- Decided direction — full plan in the parent `../CLAUDE.md`. Proxy-side pieces:
261
-
262
- - **Auto port mapping** — IMPLEMENTED (`services/transport/port-mapper.js`, changelog
263
- 2.9.16). UPnP IGD / NAT-PMP via `@silentbot1/nat-api` (now a direct dep; the
264
- same lib WebTorrent uses for the torrent port). Maps TCP 9090 with a 2 h
265
- auto-renewed lease, removed on shutdown (lease expiry covers hard kills).
266
- Best-effort + start/stop timeouts; `--no-port-mapping` opts out;
267
- `getMappedEndpoint()` exposes the external endpoint. NOT yet done: mapping the
268
- **UDP** port WebRTC actually uses (it binds ephemeral UDP ports, so this TCP
269
- mapping does not yet help WebRTC — roadmap step 3 in the parent CLAUDE.md).
270
- Also pending (next iteration): a success log line in `transport/port-mapper.js` `stop()`
271
- (`removed mapping for TCP <port>`) — today stop() only logs on failure, so a
272
- clean unmap on shutdown is silent.
273
- - **Report endpoint to server** — ✅ DONE (proxy 2.9.17). The mapped endpoint
274
- is sent over the tunnel (`tunnel-client.sendEndpoint` → `proxy-endpoint`) on
275
- mapping success and on every tunnel (re)connect; the server dial-back-verifies
276
- reachability (server 0.8.22, roadmap step 2).
277
- - **HTTPS listener**: serve the existing routes over TLS with a per-proxy
278
- certificate delivered by the server through the tunnel (persist cert+key
279
- locally; ~90-day renewals are pushed the same way). Add CORS headers for the
280
- web-app origin so hls.js / `<video>` can fetch cross-origin.
281
- - Plain HTTPS becomes the preferred video transport; WebRTC data channel stays
282
- as fallback for hosts where no port could be opened.
283
- - **Later roadmap steps** (single staged roadmap in parent `../CLAUDE.md`,
284
- WebRTC-first ordering): step 3 map the WebRTC UDP port (fixed
285
- `portRangeBegin`/`End` + UPnP-map UDP); step 4 birthday-paradox port
286
- prediction (open ~256 UDP sockets, inject predicted-port ICE candidates) for
287
- symmetric NAT; step 5 IPv6-first (audit the candidate filter — do not drop
288
- *global* v6) + STUN NAT pre-classification reported to the registry; then
289
- the DNS+TLS path (steps 6–7); step 8 relay-then-upgrade (deferred).
290
- - Future: ed25519 proxy identity (sign announcements), BEP 44 endpoint
291
- announcements via the `bittorrent-dht` already bundled with WebTorrent.
292
-
293
- All of this must stay deployment-agnostic (HA addon, bare npm, Docker).
294
-
295
- ## Disk hygiene (open item — torrent data is NOT cleaned up today)
296
-
297
- HLS segments are handled (`server/OutputLifecycle.js`: idle TTL, `disposeSession`,
298
- `disposeAll`). Torrent data is **partially** handled: shutdown cleanup is done
299
- (`TorrentPool.destroyAll()` with `destroyStore: true`, wired into the `onClose`
300
- hook — proxy 2.9.15), but `deselect()` only stops further download and nothing
301
- removes a torrent's data **while the proxy keeps running**, nor sweeps orphans
302
- left by a previous hard kill at startup.
303
-
304
- Level 1 — remaining: `client.remove(torrent, { destroyStore: true })` on last-
305
- file refcount 0 + idle TTL (mirror the HLS session model); startup sweep of
306
- orphaned store dirs under `os.tmpdir()`; global disk cap with LRU eviction of
307
- whole torrents. (Shutdown teardown ✅ done.)
308
- Level 2 (research): sliding-window chunk store. Full rationale in the parent
309
- `../CLAUDE.md` "Disk hygiene" section.
310
-
311
- ## Cloud proxy
312
-
313
- The same proxy code also runs as the company-hosted fallback when the user
314
- pool can't serve a viewer. Keep the proxy host-agnostic so it runs unchanged on
315
- rented infra (flat-rate/unmetered bandwidth — Hetzner dedicated / OVH; NOT
316
- metered-egress clouds). Provider/economics analysis in the parent
317
- `../CLAUDE.md` "Cloud proxy" section.
318
-
319
- ## Changelog
320
-
321
- Every behavioural change must be recorded in `CHANGELOG.md` — add an entry under
322
- a new `## <version>` heading at the top, following the existing
323
- `- **New**/**Fix**/**Chore**:` format.
324
-
325
- **Do NOT edit `package.json` version.** `npm run patch`/`minor` runs `npm
326
- version …` which bumps it. Write the CHANGELOG entry at the version that bump
327
- will produce: **current `package.json` version + 1 patch** (or + 1 minor).
328
- Accumulate bullets into that single pending entry until it's published. See the
329
- parent `../CLAUDE.md`.
330
-
331
- ## Release
332
-
333
- `npm run patch` (publishes to npm + pushes tags). The HA addon then needs its
334
- own version bump to pull the new package. Publish proxy BEFORE bumping the addon.
335
-
336
- **Any proxy change requires bumping the ha-addon version** (`ha-addon/torrent_tv_proxy/config.yaml`). The addon installs the proxy from npm at build time and the build is cached; without a version bump the plugin will NOT update and keeps running the old proxy. So after `npm run patch`, always bump the addon `config.yaml` version, push, and update the addon.
1
+ # proxy — @torrent-tv/proxy (WebTorrent + ffmpeg)
2
+
3
+ Downloads a torrent and streams the chosen file to the browser, transcoding to
4
+ HLS only when needed. See the parent `../CLAUDE.md` for the overall architecture
5
+ and release process.
6
+
7
+ ## Deployment-agnostic — important
8
+
9
+ The HA addon is only ONE way to run this; bare npm and Docker are planned. Keep
10
+ all code free of Home-Assistant assumptions. Anything host-specific (GPU
11
+ devices, ffmpeg build, CLI flags) belongs in the `ha-addon` layer. Hardware
12
+ detection must probe at runtime and fall back gracefully; do not assume a
13
+ Linux-only host (e.g. POSIX-only signals must degrade elsewhere).
14
+
15
+ ## Layout
16
+
17
+ Browser request and response fields, compatibility defaults, and status meanings
18
+ are recorded in `docs/browser-proxy-contract.md`.
19
+
20
+ - `bin/cli.js` — CLI entry; resolves `ffmpegBin` (uses `--ffmpeg-bin` if given,
21
+ else bundled ffmpeg-static, else PATH `ffmpeg`).
22
+ - `server.js` — the composition root: creates Fastify, initializes process-wide
23
+ resources, calls `services/server/wire-outputs.js` for the output and encode
24
+ service graph, registers each route explicitly, and passes its dependencies.
25
+ `wire-outputs.js` is a subordinate assembler for that graph; it does not
26
+ create the HTTP server or register routes.
27
+ - `routes/<path>/<method>.js` — same convention as the server repo.
28
+ - `routes/stream/get.js` — byte-range torrent file streaming (HTTP 206).
29
+ - `routes/api/playback-plan/post.js` — codec/container/duration probe result.
30
+ - `routes/transcode/session-file/get.js` — serves HLS playlist/segments;
31
+ long-polls while a segment is being produced, returns retryable 503 (never
32
+ 202 — hls.js can't consume it).
33
+ - `services/`:
34
+ - `torrent/demand/` — what anybody wants, in BYTES: `Window` (claimant, file, byte
35
+ range, urgency), `Urgency` (BLOCKED / NEAR / AHEAD / TAIL / BEHIND),
36
+ `DemandRegister` (live windows by claimant), `pieces.js` (the one place
37
+ bytes become piece numbers). No WebTorrent, no piece store, no pieces.
38
+ - `torrent/download/` — `SwarmSelection`, the ONLY thing that calls `select`,
39
+ `deselect` or `critical`, and `registry.js`, which holds one per torrent and
40
+ owns the cross-torrent rule that withholds the speculative levels while
41
+ anything urgent is missing anywhere. See `docs/download-architecture.md`.
42
+ - `encode/output/` — domain layer: `OutputSpec`, `VideoOutput`, `AudioOutput`,
43
+ `CutGrid`. What a session PRODUCES — which tracks, in what form, cut how,
44
+ packaged how — and therefore its identity: two outputs whose parameters
45
+ agree ARE the same output, and the encoded result is reused by definition.
46
+ Nothing about a VIEWER appears in it (not the consumer id, not where they
47
+ started, not their viewport), and nothing about the request that does not
48
+ change a byte of the result. `server/ViewerRequests.js` builds one and keys
49
+ the output on it.
50
+ - **`media/` — THE MEDIA LAYER, one directory, and it answers ONE question:
51
+ what does a FILE say about itself.** Its containers, its tracks, where its
52
+ keyframes are, how long it runs, and the plan for playing it. Every fact in
53
+ it is born when a header is read, dies when the file is forgotten, and is
54
+ addressed by the file — which is the test that put them together. It used to
55
+ be four places at two levels (`container/`, `tracks/`, half of
56
+ `orchestrators/`, and `playback-planner.js` loose in `services/`), so the
57
+ layer could not be put under an import rule and the rule was written per
58
+ directory instead.
59
+ Inside it, the DOMAIN is `media/container/` and `media/tracks/`: they import
60
+ nothing but each other, this proxy's own logger included. The application
61
+ files sit flat beside them — `ContainerOrchestrator`, `KeyframeTables`,
62
+ `SubtitleOrchestrator`, `playback-planner.js`, `keyframe-probe.js`,
63
+ `ffmpeg-banner.js`, `audio-inventory.js` — and may reach their own domain and
64
+ the logger and nothing else. What a torrent CONTAINS, which clusters may be
65
+ read, where a viewer stands, what an encoder costs: all handed in. Both
66
+ reaches that existed are gone — `torrent-worker/subtitle-cues.js` is given to
67
+ `SubtitleOrchestrator` by `server.js`, and `torrent/Contents.js` to the
68
+ planner — so this layer can be exercised with plain values, no torrent, no
69
+ thread and no disk. Checked by breaking it in every direction.
70
+ - **The parse happens on the MAIN thread, and the torrent thread serves
71
+ bytes.** It used to parse containers too — tracks, media info, keyframe
72
+ index — and carry each answer back over the channel, on the stated ground
73
+ that "the main thread cannot open a read stream on one of its files". True
74
+ of WebTorrent's API, not of the bytes: a container is built from one
75
+ function, `readRange(start, end)`, the pieces live in shared memory, and
76
+ `WorkerTorrentPool.readRangeOf` is the read that serves every segment — it
77
+ waits for what has not arrived and steers the swarm toward it. That split
78
+ is what made "where is this fact kept" a question at all; with one thread it
79
+ does not arise. NOTHING in that thread reaches into the media layer now —
80
+ the subtitle cue walk was the last, and it is handed which byte ranges of a
81
+ file are downloaded WHOLE (one list per pass, not a question per cluster)
82
+ plus a store read that never fetches, both in
83
+ `torrent/worker/held-bytes.js`. A piece arriving is ANNOUNCED
84
+ (`PIECES_ARRIVED`) rather than acted on there. Pinned by
85
+ `test/the-torrent-thread-serves-bytes.test.js`.
86
+ - `media/container/` — domain: `Container` (abstract, RFC 9559 / ISO 14496-12),
87
+ `MatroskaContainer` / `Mp4Container` / `AviContainer`, `ContainerFactory`
88
+ (sniff 16 bytes → precise subclass), `KeyframeTable`. See
89
+ `docs/container-architecture.md`.
90
+ - `media/tracks/` — domain: `ContainerTrack` (base: TrackNumber, declaredIndex,
91
+ language/BCP47, isEnabled/isDefault) → `VideoTrack` / `AudioTrack` /
92
+ `SubtitleTrack` → `TextSubtitleTrack` / `ImageSubtitleTrack`,
93
+ `ExternalSubtitleFile`. Spec-accurate flags (FlagForced only on subtitles per
94
+ RFC 9559 §5.1.4.1, FlagOriginal/Commentary only on audio, tkhd
95
+ track_enabled / alternate_group, elng BCP47).
96
+ - `media/` application files: `ContainerOrchestrator` (detect + the ONE
97
+ container per file, `containerFor`/`getTracks`/`getMediaInfo`/`getKeyframeIndex`;
98
+ the container keeps its own reading of each element it states — the Segment
99
+ layout, Tracks, Cues, MP4's `moov` — once it has been read), `KeyframeTables`,
100
+ `SubtitleOrchestrator` (the track list and the cues behind
101
+ `Container` tracks, warm/push — it is handed the walk, and `server.js` is
102
+ what puts the two together), `SubtitleCues` (the plan, the found-order
103
+ cursor, one walk of a file at a time, taking back withdrawn cues). It uses
104
+ the file's one container — it no longer builds its own. The walk itself is
105
+ `MatroskaContainer.readHeldCues` over `container/matroska-clusters.js` (which
106
+ also finds clusters the Cues table does not name) and
107
+ `Mp4Container.readHeldSamples`; what the torrent supplies is `held-bytes.js`
108
+ — which ranges are downloaded whole, and a read of one that never fetches
109
+ and answers at once with nothing where the range is not whole.
110
+ - **A read whose bytes have not arrived is not an answer about the file.**
111
+ Every container read is strict (`container/unavailable.js`): every byte, or
112
+ `BytesUnavailable`. A value, a proven absence, or a refusal of ours with its
113
+ reason may be kept; "not here yet" never is — not by a container, not by
114
+ `ContainerOrchestrator`, not by `KeyframeTables`, not by `SubtitleCues`.
115
+ **`KeyframeTables` is where a file's keyframe table lives and the only thing
116
+ that reads one.** The table is `container/KeyframeTable.js`, ONE object per
117
+ file, handed out rather than copied — so a read that lands after a session
118
+ was made still reaches it, which a value could not. It answers two questions
119
+ that a bag of probe fields could not tell apart: `answered` (a reader came
120
+ back) and `readable` (it came back with times). The first distinguishes a
121
+ file that must be re-encoded for ever from a passing shortage of bytes off
122
+ the swarm. One read per file whoever asks, the second asker joins the first,
123
+ each caller's wait is bounded by the measured `KEYFRAME_TABLE_BUDGET_MS`
124
+ while the READ is not, and a read that threw — `BytesUnavailable` included —
125
+ is never recorded as an answer; it is read again when pieces of the file
126
+ arrive (`readAgainIfUnanswered`). It is the ONLY store of the keyframe
127
+ answer; the container keeps the Cues reading the times are taken from. The second reader is the packet probe in
128
+ `media/keyframe-probe.js`, which decodes rather than parsing; the fuller of the
129
+ two answers is the one that stands (`media/keyframe-probe.js`).
130
+ - `server/controllers/` — interface layer: `PlaybackController` / `SubtitleController`
131
+ (thin adapters over orchestrators; routes depend on controllers, not services).
132
+ `routes/*` are now thin HTTP translators. A controller reaches every layer
133
+ below it THROUGH its orchestrator and never around it, which biome checks —
134
+ so what an orchestrator needs from another layer is composed in `server.js`
135
+ and passed in.
136
+ - Everything a container states about ITSELF lives in its own class: the
137
+ track table, the Cues, the keyframe times they name, the cluster positions,
138
+ the blocks inside a cluster, the MP4 sample table, and the walk of what is
139
+ downloaded. `services/container-index/` is gone; `container/ebml-reader.js`
140
+ is the format's byte-level grammar, not its statements, and is the only
141
+ piece kept apart. `ContainerFactory` is the ONE place that decides what a
142
+ file is — by sniffing the header, since that is what the muxer wrote — and
143
+ that is it. `ContainerFactory.readKeyframeIndex` is gone: it existed only for
144
+ the session manager's own HTTP read of a container, which is deleted.
145
+ - `docs/download-architecture.md` — the two axes of downloading: what is
146
+ wanted (`demand/`) against what the swarm is told (`download/`), why urgency
147
+ is not a number given to the library, and why the speculative levels are
148
+ withdrawn rather than lowered.
149
+ - **The storage layer — ONE layer, FOUR directories.** Bytes on a medium with
150
+ a limit is the property they share; what holds them are three different
151
+ things with different lifetimes, different addresses and different THREADS,
152
+ so they are not flattened into one:
153
+ - `storage/piece-store/` — the torrent's pieces: memory tier, spill tier, and the
154
+ order they leave in (`shared-piece-store.js`, `piece-lru.js`,
155
+ `piece-disk-store.js`). Lives in the torrent WORKER thread.
156
+ - `storage/segment-store/` — the segments an encoder has produced
157
+ (`SegmentStore.js`), addressed by the output's own key. Main thread.
158
+ It keeps bytes and what is read from them; whether a piece is whole is
159
+ decided by the encoding (`encode/piece-completeness.js`).
160
+ - `storage/files/` — files downloaded whole and kept as files
161
+ (`CompletedFiles.js`, `piece-from-whole-file.js`). Worker thread.
162
+ - `storage/` — THE ONE BUDGET: how much of this machine the proxy may
163
+ take, and how that is divided between everything that holds bytes.
164
+ `MachineBudget.js` is the single owner; `allowance.js` the rule;
165
+ `machine-memory.js` and `free.js` read the machine; `wire.js` says who
166
+ the claimants are and which RESOURCE each takes; `keep.js` and
167
+ `returns.js` say how long material nobody is using is kept. It holds no
168
+ bytes itself.
169
+ **One budget does not mean one number.** Memory cannot be paid for with
170
+ disk, so what is divided is divided per resource — and "disk" is one
171
+ resource per DEVICE, read with `statSync(dir).dev`, because two
172
+ filesystems cannot pay for each other either (`/tmp` and `/data` on the
173
+ addon host are two). What there is ONE of is the owner, the policy and
174
+ the place that reads the machine. One owner because the claimants TRADE
175
+ across resources: pieces that do not fit in memory are spilled to disk,
176
+ so what memory is given decides how much disk is needed — 14 400 MB
177
+ spilled in fifty minutes while the store held 312-424 MB.
178
+ The policy is the operator's, stated once at startup — `--budget
179
+ adaptive|share|fixed`, `--budget-share`, `--budget-bytes`,
180
+ `--min-memory-bytes`, `--min-disk-bytes` — and those are the only
181
+ chosen numbers in the proxy, because they are chosen by the person whose
182
+ machine it is. The default is the measured one.
183
+ They may import each other and nothing above, which `biome` checks as an
184
+ EXCEPTION to `../**` rather than as a list of forbidden layers — a layer is
185
+ not a directory, the blanket form cannot say "my siblings", and a list of
186
+ names misses whatever it forgets.
187
+ - `docs/storage-architecture.md` — the three things that write to one disk, the
188
+ two rules that remove material (nobody needs it, or there is no room), the
189
+ order the viewers give that removal, why a spilled piece is a file of its
190
+ own, and what is still not solved.
191
+ - `docs/encode-architecture.md` — who decides where encoders go, and the
192
+ answer is one authority: `EncodePlan`, from what is made, what is being
193
+ made, what is wanted and what the host can hold. Why no viewer reaches it,
194
+ why the priority map is read at two scopes (per FILE for the swarm, per
195
+ OUTPUT for the encoders), and what each of the eight other places that used
196
+ to place or kill an encoder now states instead.
197
+ - `docs/logs.md` — where to find logs, and the fact that the BROWSER's own log
198
+ is in TWO places split by phase: on the droplet while a transport is being
199
+ acquired and at unload, on THIS proxy for the whole of a viewing
200
+ (`/data/client-<start>-<session>-<torrent>.log`, one file per session).
201
+ Read both before concluding anything from a half-session.
202
+ - `media/playback-planner.js` — single ffmpeg probe returns audioCodec,
203
+ videoCodec, container, durationSeconds. `mode` is advisory; the browser
204
+ decides. `media/keyframe-probe.js` beside it is the OTHER reading of the same
205
+ file, by decoding rather than by parsing, for containers that state no index.
206
+ - `server/` — what a request does, one operation at a time, and nothing
207
+ that lives longer than the operation: `ViewerRequests` (open an output of a
208
+ file and be placed on it, state a position, report progress),
209
+ `SegmentServing` (answer a playlist, init or segment request from the store,
210
+ or hold it until the piece is whole), `OutputLifecycle` (dispose an output
211
+ nobody is on, all of them at shutdown, adopt what an earlier process left),
212
+ and `wire-outputs.js`, which builds the components and hands each the narrow
213
+ host it reads. `hls-session-manager.js` is gone (2.87.0): each of its members
214
+ is a method of the component that owns it. The operations own no long-lived
215
+ fact: the init served for an output is kept by `SegmentStore`, the bytes read
216
+ for an output by `EncodeRuns`, the cold-start measurement by `HostTimings`.
217
+ They import no component's implementation — only the name of an output and
218
+ of its playlist (`encode/output/index.js`) and the keeping period
219
+ (`storage/keep.js`); biome checks it. A held request waits for the store's
220
+ publication event, as long as the requester states (`X-Hold-Ms`) and no
221
+ longer than it stays.
222
+ - `encode/` beside the orchestrator: `OutputOpening` (which output answers a
223
+ request for a file, made if it is not here yet — without knowing who asked),
224
+ `EncodeRuns` (build a run where the plan places it, follow it, account for
225
+ its end, and what its input has received), `EncoderSelection` (the encoder
226
+ in use and the move to software), `Renditions` (the steps of a picture and
227
+ its soundtracks, the master playlist, and which rung a viewer's page says it
228
+ plays), `OutputTimes` (where each segment begins and how the cut table is
229
+ corrected), `CushionReport` (how much film is ready in front of the
230
+ viewers), `output-key-format.js` (which container a key names).
231
+ - `viewer/`: every viewer has a name (`Viewers.of` refuses an empty one); the
232
+ relation to outputs is stored only in `Viewer.outputs` and read the other way
233
+ by `Viewers.forOutput`. A quality request belongs to one viewer and exists
234
+ only in AUTO (`Viewer.askQuality`). The playback start forecast
235
+ (`playback-readiness.js`) is the viewer's, because it predicts how the
236
+ viewer's browser will play; `ViewerRequests` is handed it by
237
+ `wire-outputs.js`. `media-time.js` is exact media time and the rule by which
238
+ every Media Source engine joins buffered ranges — see
239
+ `docs/playback-start-forecast.md`.
240
+ - `torrent/` reaches the piece store by what it does (`piece-store-of.js`) and
241
+ is handed the store's class by `torrent/worker/worker.js`, where that thread
242
+ is assembled. `transport/` imports nothing of another component; `bin/cli.js`
243
+ hands it the memory reading and the rule for which captures are kept.
244
+ - `encode/hwaccel.js` — detect best H.264 encoder (NVENC/QSV/VAAPI/V4L2M2M) with a
245
+ STRICT startup test: encode `testsrc2` through the real HLS pipeline, then
246
+ verify each segment decodes independently (catches non-IDR/corrupted hw
247
+ output). Falls back to software libx264. Runtime fallback to software if a
248
+ hw encode later fails. v4l2m2m is gated by this test (fails on HA Yellow).
249
+ - `transport/data-channel-handler.js` — forwards WebRTC data-channel requests to the
250
+ local HTTP server (loopback), so the same routes serve both transports.
251
+
252
+ ## Gotchas
253
+
254
+ - Do NOT use `-hls_playlist_type event` — it breaks duration/seek. VOD only.
255
+ - A transitive dep (`ip-set`, via webtorrent) ships a hostile
256
+ `preinstall: npx only-allow pnpm` that breaks `npm install`. The addon works
257
+ around it with `--ignore-scripts` + a targeted rebuild of `node-datachannel`;
258
+ if you ever change install flow, keep that in mind.
259
+
260
+ ## Planned: public reachability (remote access)
261
+
262
+ Decided direction — full plan in the parent `../CLAUDE.md`. Proxy-side pieces:
263
+
264
+ - **Auto port mapping** — IMPLEMENTED (`services/transport/port-mapper.js`, changelog
265
+ 2.9.16). UPnP IGD / NAT-PMP via `@silentbot1/nat-api` (now a direct dep; the
266
+ same lib WebTorrent uses for the torrent port). Maps TCP 9090 with a 2 h
267
+ auto-renewed lease, removed on shutdown (lease expiry covers hard kills).
268
+ Best-effort + start/stop timeouts; `--no-port-mapping` opts out;
269
+ `getMappedEndpoint()` exposes the external endpoint. NOT yet done: mapping the
270
+ **UDP** port WebRTC actually uses (it binds ephemeral UDP ports, so this TCP
271
+ mapping does not yet help WebRTC — roadmap step 3 in the parent CLAUDE.md).
272
+ Also pending (next iteration): a success log line in `transport/port-mapper.js` `stop()`
273
+ (`removed mapping for TCP <port>`) — today stop() only logs on failure, so a
274
+ clean unmap on shutdown is silent.
275
+ - **Report endpoint to server** — ✅ DONE (proxy 2.9.17). The mapped endpoint
276
+ is sent over the tunnel (`tunnel-client.sendEndpoint` → `proxy-endpoint`) on
277
+ mapping success and on every tunnel (re)connect; the server dial-back-verifies
278
+ reachability (server 0.8.22, roadmap step 2).
279
+ - **HTTPS listener**: serve the existing routes over TLS with a per-proxy
280
+ certificate delivered by the server through the tunnel (persist cert+key
281
+ locally; ~90-day renewals are pushed the same way). Add CORS headers for the
282
+ web-app origin so hls.js / `<video>` can fetch cross-origin.
283
+ - Plain HTTPS becomes the preferred video transport; WebRTC data channel stays
284
+ as fallback for hosts where no port could be opened.
285
+ - **Later roadmap steps** (single staged roadmap in parent `../CLAUDE.md`,
286
+ WebRTC-first ordering): step 3 map the WebRTC UDP port (fixed
287
+ `portRangeBegin`/`End` + UPnP-map UDP); step 4 birthday-paradox port
288
+ prediction (open ~256 UDP sockets, inject predicted-port ICE candidates) for
289
+ symmetric NAT; step 5 IPv6-first (audit the candidate filter — do not drop
290
+ *global* v6) + STUN NAT pre-classification reported to the registry; then
291
+ the DNS+TLS path (steps 6–7); step 8 relay-then-upgrade (deferred).
292
+ - Future: ed25519 proxy identity (sign announcements), BEP 44 endpoint
293
+ announcements via the `bittorrent-dht` already bundled with WebTorrent.
294
+
295
+ All of this must stay deployment-agnostic (HA addon, bare npm, Docker).
296
+
297
+ ## Disk hygiene (open item — torrent data is NOT cleaned up today)
298
+
299
+ HLS segments are handled (`server/OutputLifecycle.js`: idle TTL, `disposeSession`,
300
+ `disposeAll`). Torrent data is **partially** handled: shutdown cleanup is done
301
+ (`TorrentPool.destroyAll()` with `destroyStore: true`, wired into the `onClose`
302
+ hook — proxy 2.9.15), but `deselect()` only stops further download and nothing
303
+ removes a torrent's data **while the proxy keeps running**, nor sweeps orphans
304
+ left by a previous hard kill at startup.
305
+
306
+ Level 1 — remaining: `client.remove(torrent, { destroyStore: true })` on last-
307
+ file refcount 0 + idle TTL (mirror the HLS session model); startup sweep of
308
+ orphaned store dirs under `os.tmpdir()`; global disk cap with LRU eviction of
309
+ whole torrents. (Shutdown teardown ✅ done.)
310
+ Level 2 (research): sliding-window chunk store. Full rationale in the parent
311
+ `../CLAUDE.md` "Disk hygiene" section.
312
+
313
+ ## Cloud proxy
314
+
315
+ The same proxy code also runs as the company-hosted fallback when the user
316
+ pool can't serve a viewer. Keep the proxy host-agnostic so it runs unchanged on
317
+ rented infra (flat-rate/unmetered bandwidth — Hetzner dedicated / OVH; NOT
318
+ metered-egress clouds). Provider/economics analysis in the parent
319
+ `../CLAUDE.md` "Cloud proxy" section.
320
+
321
+ ## Changelog
322
+
323
+ Every behavioural change must be recorded in `CHANGELOG.md` — add an entry under
324
+ a new `## <version>` heading at the top, following the existing
325
+ `- **New**/**Fix**/**Chore**:` format.
326
+
327
+ **Do NOT edit `package.json` version.** `npm run patch`/`minor` runs `npm
328
+ version …` which bumps it. Write the CHANGELOG entry at the version that bump
329
+ will produce: **current `package.json` version + 1 patch** (or + 1 minor).
330
+ Accumulate bullets into that single pending entry until it's published. See the
331
+ parent `../CLAUDE.md`.
332
+
333
+ ## Release
334
+
335
+ `npm run patch` (publishes to npm + pushes tags). The HA addon then needs its
336
+ own version bump to pull the new package. Publish proxy BEFORE bumping the addon.
337
+
338
+ **Any proxy change requires bumping the ha-addon version** (`ha-addon/torrent_tv_proxy/config.yaml`). The addon installs the proxy from npm at build time and the build is cached; without a version bump the plugin will NOT update and keeps running the old proxy. So after `npm run patch`, always bump the addon `config.yaml` version, push, and update the addon.