@torrent-tv/proxy 2.86.0 → 2.87.1

package/test/manager-surface.test.js

@@ -0,0 +1,294 @@
+/**
+ * @file What the HTTP layer asks of the components, checked from the HTTP layer.
+ *
+ * Written as the net under the dismantling of `hls-session-manager.js`, which
+ * was 9608 lines and 142 methods and is now gone: its members are methods of
+ * the components that own them, wired by `services/server/wire-outputs.js`.
+ * Most tests that build those components name something INSIDE them — a field,
+ * a fake output shaped the way one happens to be shaped — so they move when the
+ * code moves, and a test that moves with the code cannot say the code still
+ * works.
+ *
+ * This one is derived from the other side: from what the HTTP layer asks of
+ * the components. That contract does not move. A route calling a member that no longer exists
+ * is the exact failure a nine-step move risks, and it is silent — Fastify
+ * answers 500 at runtime, months later, on a path no unit test walks.
+ *
+ * So the first check READS `routes/` and `server.js` rather than listing what
+ * the manager has. It cannot go stale: adding a call to a route adds it to the
+ * requirement, and removing the member it names breaks this test the same
+ * minute.
+ *
+ * The second is a characteristic record rather than a judgement: what the
+ * progress report carries today. Eighteen figures reach the page from it and
+ * nothing on this side of the wire knows which of them the page needs, so the
+ * honest statement is "these are the ones there were" — the point being that a
+ * move must not change them, not that they are the right ones.
+ *
+ * Every manager here has a store root of its own, for the reason
+ * `helpers/manager.js` records.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { readFileSync, readdirSync } from "node:fs";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import { SourceFile } from "../services/media/SourceFile.js";
+import { Timeline } from "../services/encode/output/Timeline.js";
+import { managerWithOwnStore } from "./helpers/manager.js";
+import { fmp4Format } from "../services/encode/segment-formats/fmp4.js";
+import { Output } from "../services/encode/output/Output.js";
+import { outputSpec } from "./helpers/output-spec.js";
+
+const HERE = path.dirname(fileURLToPath(import.meta.url));
+const PROXY = path.join(HERE, "..");
+const SESSION_ID = "aaaaaaaabbbbcccc";
+/** The components the HTTP layer is handed. */
+const COMPONENTS = ["serving", "viewerRequests", "renditions", "lifecycle", "quality", "outputs", "hostTimings", "viewers", "encodeRuns"];
+
+/**
+ * Every `.js` file under a directory, at any depth.
+ *
+ * @param {string} dir
+ * @returns {string[]}
+ */
+function jsFilesUnder(dir) {
+  /** @type {string[]} */
+  const found = [];
+  for (const entry of readdirSync(dir, { withFileTypes: true })) {
+    const full = path.join(dir, entry.name);
+    if (entry.isDirectory()) {
+      found.push(...jsFilesUnder(full));
+      continue;
+    }
+    if (entry.name.endsWith(".js")) {
+      found.push(full);
+    }
+  }
+  return found;
+}
+
+/**
+ * What the HTTP layer asks of each component, read from the HTTP layer.
+ *
+ * Deliberately not a list kept here: a list is a second statement of the same
+ * fact, and the two drift. The callers are the statement. A route names the
+ * component it was handed (`serving.getFileStream`); `server.js` names it
+ * through what the wiring returned (`outputParts.serving.getFileStream`).
+ *
+ * @returns {Map<string, string[]>} `component.member` to the files that ask for it.
+ */
+function membersTheHttpLayerCalls() {
+  /** @type {Map<string, string[]>} */
+  const asked = new Map();
+  const sources = [path.join(PROXY, "server.js"), ...jsFilesUnder(path.join(PROXY, "routes"))];
+  const pattern = new RegExp(String.raw`\b(${COMPONENTS.join("|")})\.([A-Za-z][A-Za-z0-9]*)\(`, "g");
+  for (const file of sources) {
+    const text = readFileSync(file, "utf8");
+    for (const match of text.matchAll(pattern)) {
+      const asking = `${match[1]}.${match[2]}`;
+      const where = asked.get(asking) ?? [];
+      where.push(path.relative(PROXY, file));
+      asked.set(asking, where);
+    }
+  }
+  return asked;
+}
+
+/**
+ * A manager with nothing running behind it, over a store of its own.
+ *
+ * Its two timers are unref'd, so nothing here keeps the process alive.
+ *
+ * @returns {object}
+ */
+function bareManager() {
+  return managerWithOwnStore().manager;
+}
+
+/**
+ * A session shaped like a live one, with no encoder behind it.
+ *
+ * @param {{ id?: string }} [params]
+ * @returns {object}
+ */
+function fakeSession({ id = SESSION_ID } = {}) {
+  return {
+    id,
+    spec: outputSpec({ cutGrid: "keyframe", audioSeparate: true }),
+    outputKey: "surface:fmt=fmp4:grid=kf@0:video-only:v=0/copy",
+    dirPath: path.join(PROXY, "test", "does-not-exist"),
+    file: new SourceFile({ sourceKey: "torrent:abc", fileIndex: 0, name: "video.mkv" })
+      .learn({ width: 1920, height: 1080 }),
+    get inputFile() { return this.file; },
+    get audioFile() { return this.file; },
+    timeline: new Timeline({
+      boundaries: Array.from({ length: 11 }, (_, index) => index * 4),
+      cutGrid: "keyframe"
+    }),
+    segmentFormat: fmp4Format,
+    output: new Output({
+      encodeWidth: 0,
+      encodeHeight: 0,
+      outputFps: 24,
+      softwarePreset: null,
+      applyTonemap: false
+    }),
+    transcodeVideo: false,
+    transcodeAudio: true,
+    audioTrackIndex: 0,
+    audioSourceTrackIndex: 0,
+    useSyntheticPlaylist: true,
+    playlistText: "#EXTM3U\n",
+    segmentCount: 10,
+    progress: { state: "running", processedSeconds: 0, startPositionSeconds: 0, speed: "1.0x" }
+  };
+}
+
+test("every call the HTTP layer makes is answered", () => {
+  const parts = bareManager();
+  const asked = membersTheHttpLayerCalls();
+  // If this ever reads zero the extraction has broken, and the test would then
+  // pass by asking nothing at all.
+  assert.ok(asked.size >= 15, `expected the HTTP layer to ask for members, found ${asked.size}`);
+
+  const missing = [];
+  for (const [asking, callers] of asked) {
+    const [component, member] = asking.split(".");
+    if (!(parts[component] && member in parts[component])) {
+      missing.push(`${asking} (asked by ${[...new Set(callers)].join(", ")})`);
+    }
+  }
+  assert.deepEqual(missing, [], `the HTTP layer calls members no component has:\n${missing.join("\n")}`);
+});
+
+test("the progress report keeps every figure it carries today", async () => {
+  const manager = bareManager();
+  manager.outputs.set(SESSION_ID, fakeSession());
+  const progress = await manager.viewerRequests.getSessionProgress(SESSION_ID, "viewer-one");
+  assert.ok(progress, "a live session has a progress report");
+
+  // A characteristic record: what the page is given now. The claim is "a move
+  // did not change this", never "this is the right set".
+  const carried = [
+    "sessionId",
+    "state",
+    "minimumBufferSeconds",
+    "processedSeconds",
+    "inputBytes",
+    "startPositionSeconds",
+    "totalSeconds",
+    "percent",
+    "remainingSeconds",
+    "segmentDurationSec",
+    "speed",
+    "currentHeight",
+    "offeredHeights",
+    "requestedHeight",
+    "expectedSessionCreateMs",
+    "expectedFirstSegmentMs",
+    "updatedAt",
+    "error"
+  ];
+  const absent = carried.filter((key) => !(key in progress));
+  assert.deepEqual(absent, [], `the progress report lost ${absent.join(", ")}`);
+  assert.equal(progress.sessionId, SESSION_ID);
+});
+
+test("a session that is not there is answered, not invented", async () => {
+  const manager = bareManager();
+  const absent = "ffffffffffffffff";
+
+  assert.equal(await manager.viewerRequests.getSessionProgress(absent), null);
+  assert.equal((await manager.serving.getFileStream(absent, "segment-00000.mp4")).kind, "not-found");
+  // A name no session could have must be refused before anything touches the
+  // disk with it.
+  assert.equal((await manager.serving.getFileStream("../../etc", "segment-00000.mp4")).kind, "not-found");
+});
+
+test("what a viewer states about themselves is kept and answered", () => {
+  const manager = bareManager();
+  manager.outputs.set(SESSION_ID, fakeSession());
+
+  // Nine public members had no test of any kind before the dismantling began,
+  // and six of them are the viewer's own facts — the ones that move into
+  // `viewer/`. They are cheap to state and were simply never stated.
+
+  // A SEEK DOES ONE THING: it puts the viewer where they now are. Recorded
+  // here because it used to do eleven, and because the one remaining effect is
+  // what every reading of a viewer's position now rests on.
+  assert.equal(manager.viewerRequests.requestSeek(SESSION_ID, 120, "viewer-one"), true);
+  assert.equal(manager.viewerRequests.viewerPositionOf(SESSION_ID, "viewer-one"), 120);
+  assert.equal(manager.viewerRequests.requestSeek("no-such-session", 120, "viewer-one"), false);
+
+  // `seekEpoch` is NOT moved by a seek, whatever its name says: its two writers
+  // are the variant switch and the soundtrack switch, and they move it on the
+  // output the viewer has LEFT. Recorded as it is, so the dismantling can give
+  // the fact its real name instead of discovering this by breaking it.
+  assert.equal(manager.serving.seekEpoch(SESSION_ID), 0, "a seek leaves the wait epoch alone");
+  assert.equal(manager.serving.seekEpoch("no-such-session"), 0);
+
+  manager.encodeRuns.noteInputBytes(SESSION_ID, 4096);
+  manager.encodeRuns.noteInputBytes(SESSION_ID, 1024);
+  assert.equal(
+    manager.encodeRuns.inputBytesOf(manager.outputs.get(SESSION_ID)),
+    5120,
+    "input bytes accumulate at their owner"
+  );
+
+  // A far fragment is a reading and must never throw, whatever the player says.
+  manager.serving.recordFragmentFar(SESSION_ID, {
+    sn: 40, track: "video", fragStartSec: 200, bufferEndSec: 130, currentTimeSec: 128
+  });
+  manager.serving.recordFragmentFar("no-such-session", { sn: 1, track: "video" });
+});
+
+test("a session nobody has touched is disposed, one that is being watched is not", async () => {
+  const manager = bareManager();
+  const stale = fakeSession({ id: "1111111111111111" });
+  const fresh = fakeSession({ id: "2222222222222222" });
+  // Older than any TTL this manager could carry, without naming one here: the
+  // period is the manager's business and this test is about the rule.
+  manager.outputs.set(stale.id, stale);
+  manager.outputs.set(fresh.id, fresh);
+  manager.outputs.touch(stale, Date.now() - (2 * 60 * 60 * 1000));
+
+  await manager.lifecycle.cleanupExpired();
+
+  assert.equal(manager.outputs.has(stale.id), false, "an untouched session goes");
+  assert.equal("state" in stale, false, "removal from the registry is the only lifetime fact");
+  assert.equal(manager.outputs.has(fresh.id), true, "a session just read stays");
+});
+
+test("what a file declares and what this host could offer are answered without a session", () => {
+  const manager = bareManager();
+  const session = fakeSession();
+  manager.outputs.set(SESSION_ID, session);
+
+  // `declaredTracks` reads the session's own record and must answer even when
+  // nothing has probed the file yet.
+  assert.doesNotThrow(() => manager.renditions.declaredTracks(session));
+
+  // The offer is predicted before any session exists — that is its whole point,
+  // the menu being complete from the moment a file is opened.
+  assert.equal(manager.quality.predictOfferedHeights({ height: 0, width: 0 }), null, "an unknown picture offers nothing");
+  const offered = manager.quality.predictOfferedHeights({
+    height: 1080, width: 1920, fps: 24, sourceKey: "torrent:abc", fileIndex: 0
+  });
+  // TWO ANSWERS, not one: what this host can hold when the picture is copied,
+  // and what it can hold when it is re-encoded. The browser decides which of
+  // the two applies, because whether it can play the source is its own fact.
+  assert.ok(Array.isArray(offered?.copy), "the copied branch gets a list");
+  assert.ok(Array.isArray(offered?.transcode), "the re-encoded branch gets a list");
+});
+
+test("a segment name that is not one is refused", async () => {
+  const manager = bareManager();
+  manager.outputs.set(SESSION_ID, fakeSession());
+
+  for (const name of ["../key.txt", "segment-00000.mp4/../../x", "making-0-00000.mp4"]) {
+    const answer = await manager.serving.getFileStream(SESSION_ID, name);
+    assert.equal(answer.kind, "not-found", `${name} must not be servable`);
+  }
+});

package/test/matroska-cues-track.test.js

@@ -16,7 +16,7 @@
 
 import test from "node:test";
 import assert from "node:assert/strict";
-import { MatroskaContainer } from "../services/container/MatroskaContainer.js";
+import { MatroskaContainer } from "../services/media/container/MatroskaContainer.js";
 
 const ID_EBML = 0x1a45dfa3;
 const ID_SEGMENT = 0x18538067;

package/test/memory-budget.test.js

@@ -6,7 +6,7 @@ import {
   readingIsWorthWriting,
   summariseMappings,
   watchedFigures
-} from "../services/memory-report.js";
+} from "../services/storage/memory-report.js";
 import {
   divideAllowance,
   forgetMachineMemory,
@@ -14,7 +14,7 @@ import {
   machineReserveBytes,
   noteMachineMemory,
   SharedPieceStore
-} from "../services/piece-store/shared-piece-store.js";
+} from "../services/storage/piece-store/shared-piece-store.js";
 import { mkdtemp, rm } from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";

package/test/mp4-subtitles.test.js

@@ -8,7 +8,7 @@
 
 import test from "node:test";
 import assert from "node:assert/strict";
-import { Mp4Container } from "../services/container/Mp4Container.js";
+import { Mp4Container } from "../services/media/container/Mp4Container.js";
 
 function box(type, payload) {
   const header = Buffer.alloc(8);

package/test/one-authority.test.js

@@ -14,7 +14,7 @@
 
 import test from "node:test";
 import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
+import { readFileSync, readdirSync } from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 import { EventEmitter } from "node:events";
@@ -30,6 +30,21 @@ function source(relative) {
   return readFileSync(path.join(HERE, "..", relative), "utf8");
 }
 
+/**
+ * Every source file of the proxy's services, read together.
+ *
+ * A rule that something must not come back is asked of all of them: asked of
+ * one file, it passes as soon as the code moves to another.
+ *
+ * @returns {string}
+ */
+function everything() {
+  return readdirSync(path.join(HERE, "..", "services"), { recursive: true })
+    .filter((name) => String(name).endsWith(".js"))
+    .map((name) => source(path.join("services", String(name))))
+    .join("\n");
+}
+
 /**
  * Lines of code, without comments or blanks: a rule about what the code does
  * must not be answered by what a comment says about it.
@@ -48,26 +63,30 @@ test("an encoder is stopped for scheduling reasons in exactly one place", () =>
   // The orchestrator decides; nobody else may. What is left in the session
   // manager is teardown — the session is going away and its encoders with it —
   // which is not a decision about which encoders should exist.
-  const orchestrator = statements(source("services/orchestrators/EncodeOrchestrator.js"));
+  const orchestrator = statements(source("services/encode/EncodeOrchestrator.js"));
   const stopsInOrchestrator = orchestrator.filter((line) => line.includes("run.stop("));
   assert.equal(stopsInOrchestrator.length, 1, "the orchestrator stops runs in one place");
 
-  const manager = statements(source("services/hls-session-manager.js"));
-  const stopsInManager = manager.filter((line) => line.includes(".stop("));
+  const wiring = statements(source("services/server/wire-outputs.js"));
+  assert.deepEqual(wiring.filter((line) => line.includes(".stop(")), [], "the wiring stops nothing");
+  const lifecycle = statements(source("services/server/OutputLifecycle.js"));
+  const stopsAtTeardown = lifecycle.filter((line) => line.includes(".stop("));
   assert.equal(
-    stopsInManager.length,
-    2,
-    "the session manager stops runs only when a session is torn down: " +
-      stopsInManager.join(" / ")
+    stopsAtTeardown.length,
+    1,
+    "an output's end stops its runs, and nothing else there does: " + stopsAtTeardown.join(" / ")
   );
+  // And the runs themselves stop one for a stated reason in one place, which is
+  // what a corrected cut table asks through.
+  const runs = statements(source("services/encode/EncodeRuns.js"));
+  assert.equal(runs.filter((line) => line.includes(".stop(")).length, 1);
 });
 
 test("nothing outside the encoding layer starts an encoder", () => {
   // A run is built in one place. Two places building them is how a start came
   // to kill what the plan had decided to keep — the killing lived in the
   // building.
-  const manager = statements(source("services/hls-session-manager.js"));
-  const builds = manager.filter((line) => line.includes("new EncodeRun("));
+  const builds = statements(everything()).filter((line) => line.includes("new EncodeRun("));
   assert.equal(builds.length, 1, "one place builds an encoder");
 });
 
@@ -86,8 +105,9 @@ test("a run exists means its process is running, so nothing can start one twice"
   // there is no second act for a second owner to perform.
   const files = [
     "services/encode/EncodeRun.js",
-    "services/orchestrators/EncodeOrchestrator.js",
-    "services/hls-session-manager.js"
+    "services/encode/EncodeOrchestrator.js",
+    "services/encode/EncodeRuns.js",
+    "services/server/wire-outputs.js"
   ];
   for (const file of files) {
     const starts = statements(source(file)).filter(
@@ -103,7 +123,7 @@ test("starting an encoder stops nothing", () => {
   // The rule that broke it: the start path looked for a live run whose own
   // start was not below the new one's and killed it. It is not enough that the
   // line is gone — the words it was written with must not come back.
-  const manager = source("services/hls-session-manager.js");
+  const manager = everything();
   assert.equal(
     manager.includes("previousRun"),
     false,
@@ -116,11 +136,10 @@ test("a seek moves the viewer and nothing else", () => {
   // It used to do eleven things and write the position into five places. What
   // follows from a viewer moving is the map's business, and the orchestrators
   // read the map.
-  const manager = source("services/hls-session-manager.js");
-  const seek = manager.slice(
-    manager.indexOf("requestSeek(sessionId, positionSeconds"),
-    manager.indexOf("requestSeek(sessionId, positionSeconds") + 2000
-  );
+  const manager = source("services/server/ViewerRequests.js");
+  const at = manager.indexOf("requestSeek(sessionId, positionSeconds");
+  assert.notEqual(at, -1, "the seek is where this reads it");
+  const seek = manager.slice(at, at + 2000);
   const body = seek.slice(0, seek.indexOf("\n  }\n"));
   assert.equal(body.includes("#startEncodeRun"), false, "a seek starts no encoder");
   assert.equal(body.includes("setTimeout"), false, "and waits for nothing");
@@ -130,7 +149,7 @@ test("how far an encoder may work is answered once", () => {
   // The plan computes the stretch and it reaches ffmpeg. A second computation
   // somewhere else is what made the first one pointless: it was passed and then
   // dropped by a parameter list that did not name it.
-  const orchestrator = source("services/orchestrators/EncodeOrchestrator.js");
+  const orchestrator = source("services/encode/EncodeOrchestrator.js");
   assert.match(
     orchestrator,
     /makeRun\(\{ address, from, to, because \}\)/,
@@ -146,12 +165,12 @@ test("only the plan places an encoder", () => {
   // a settled seek. Each of them chose a position by a rule of its own, and the
   // plan — which is arithmetic over what is made, what is being made and what is
   // wanted — was left to compare its answer against theirs.
-  const manager = source("services/hls-session-manager.js");
+  const manager = source("services/encode/EncodeRuns.js");
   const starts = [...manager.matchAll(/this\.#startEncodeRun\(/g)].length;
   assert.equal(starts, 1, "one caller, and it is the one the plan asks through");
   assert.match(
     manager,
-    /#makeRunAt\(address, from, to, because\)[\s\S]{0,3000}this\.#startEncodeRun\(base, from, because, \{ to \}\)/,
+    /makeRunAt\(address, from, to, because\)[\s\S]{0,3000}this\.#startEncodeRun\(base, from, because, \{ to \}\)/,
     "and that caller is what the plan is given to build runs with"
   );
 });
@@ -162,7 +181,7 @@ test("nobody stops an encoder for being unwatched", () => {
   // with nothing in it. Answered here as well, it was answered twice by two
   // rules — and since a viewer moving between steps announces itself, the plan
   // started again what this class had just killed, several times a second.
-  const manager = source("services/hls-session-manager.js");
+  const manager = everything();
   assert.equal(
     manager.includes("no viewer is watching"),
     false,
@@ -182,7 +201,7 @@ test("the seek settle machinery is gone, whole", () => {
   // second debounce on a signal the browser had already debounced, and every
   // millisecond of it was dead time in front of the viewer; the cooldown behind
   // it existed because segment REQUESTS once steered the encoder.
-  const manager = source("services/hls-session-manager.js");
+  const manager = everything();
   for (const gone of [
     "seekSettleTimer",
     "seekTarget",
@@ -203,10 +222,10 @@ test("where a soundtrack begins is read off the table, not handed in", () => {
   // the live table every session of the file shares. Passed as an argument by
   // the one caller that had measured it, only a run started by that caller ever
   // had it, and a run the plan placed at the same number landed apart again.
-  const manager = source("services/hls-session-manager.js");
+  const manager = source("services/encode/EncodeRuns.js");
   assert.match(
     manager,
-    /const positionSecondsOverride = session\.audioOnly === true\s*\n?\s*\? trueStartOf\(session\.timeline, startIndex\)/,
+    /const positionSecondsOverride = session\.spec\.carries === "audio-only"\s*\n?\s*\? trueStartOf\(session\.timeline, startIndex\)/,
     "derived where the run is built"
   );
   assert.equal(
@@ -216,27 +235,12 @@ test("where a soundtrack begins is read off the table, not handed in", () => {
   );
 });
 
-test("a changed bitrate cap stops the encoder carrying the old one and nothing more", () => {
-  // An argument list is fixed when a process starts, so a run carrying the
-  // previous cap cannot be told about the new one — that is what is known here.
-  // Where the replacement stands is a different question, and the old answer to
-  // it was neither where a viewer is nor a gap in the material: it was the
-  // segment the process being replaced happened to have reached.
-  const manager = source("services/hls-session-manager.js");
-  assert.equal(manager.includes("#restartAtViewer"), false, "the second answer is gone");
-  assert.match(
-    manager,
-    /#reencodeAtNewRate\(session\) \{\s*\n\s*this\.#stopEncodeRun\(session, "its bitrate cap changed"\);\s*\n\s*this\.planEncodersSoon\(\);\s*\n\s*\}/,
-    "stopped, and then decided again"
-  );
-});
-
 test("each output is handed its own priority map, and the plan is what reads it", () => {
   // The map is one fact asked at two scopes, and both are right for what asks
   // them: the swarm is asked for bytes of a FILE, which every output of it
   // reads, and encoders are placed per OUTPUT, which a person watching 480p
   // wants nothing of at 1080p.
-  const manager = source("services/hls-session-manager.js");
+  const manager = source("services/encode/EncodeRuns.js");
   assert.match(
     manager,
     /notePriorityMap\([\s\S]{0,200}mapForOutput\(address\)/,