@torrent-tv/proxy 2.86.0 → 2.87.0

package/test/helpers/encode-run.js

@@ -1,136 +1,136 @@
-/**
- * @file A real `EncodeRun` over a process that is not real.
- *
- * Tests used to set a session's process fields by hand — `session.ffmpeg`,
- * `session.runState`, `session.encodeStartIndex` — which is how a test can pass
- * over code that no longer works: the fields were the thing under test as much
- * as the behaviour was. A run is an object now, so a test builds the object the
- * product builds and injects only the one thing a test may not have, which is a
- * child process.
- *
- * The pid is deliberately absent unless a test asks for one. `pause` and
- * `resume` send signals by pid, and a made-up number is somebody else's process
- * on the machine running the tests.
- */
-
-import { EncodeRun } from "../../services/encode/EncodeRun.js";
-
-/**
- * A child process that records what was done to it.
- *
- * @param {object} [options]
- * @param {number | null} [options.pid] - Only where a test genuinely exercises
- *   suspend or resume, and then it must be this process's own.
- * @returns {object}
- */
-export function fakeProcess({ pid = null, exitsWhenKilled = true } = {}) {
-  /** @type {Map<string, (...args: unknown[]) => void>} */
-  const listeners = new Map();
-  return {
-    pid,
-    killed: false,
-    exitCode: null,
-    signalCode: null,
-    /** Every signal it was sent, in order. */
-    signals: [],
-    stdout: { on() {} },
-    stderr: { on() {} },
-    on(event, handler) {
-      const kept = listeners.get(event) ?? [];
-      kept.push(handler);
-      listeners.set(event, kept);
-      return this;
-    },
-    once(event, handler) {
-      return this.on(event, handler);
-    },
-    kill(signal = "SIGTERM") {
-      this.signals.push(signal);
-      this.killed = true;
-      // A real process answers a signal by exiting, and it does so on a later
-      // turn. A fake that never exits makes every disposal wait out the grace
-      // period, which is two seconds a test spends proving nothing.
-      if (exitsWhenKilled && this.exitCode === null && this.signalCode === null) {
-        queueMicrotask(() => this.exit(null, signal));
-      }
-      return true;
-    },
-    /**
-     * Report an exit, as the real thing would.
-     *
-     * @param {number | null} code
-     * @param {string | null} [signal]
-     */
-    exit(code, signal = null) {
-      this.exitCode = code;
-      this.signalCode = signal;
-      for (const handler of listeners.get("exit") ?? []) {
-        handler(code, signal);
-      }
-    }
-  };
-}
-
-/** A logger that says nothing, for tests that are not about the log. */
-export const silentLogger = { info() {}, warn() {}, error() {} };
-
-/**
- * Add a run to a session, started, over a fake process.
- *
- * A session holds a SET of runs — as many as the machine affords — so a test
- * that wants two heads on one output calls this twice.
- *
- * @param {object} session - The session under test.
- * @param {object} [options]
- * @param {number} [options.from] - First segment number it is making.
- * @param {number} [options.to] - Last, inclusive; below `from` means no end.
- * @param {object} [options.process] - The process it should own.
- * @param {boolean} [options.producing] - Whether it has already made its first
- *   segment, which is what moves it out of starting.
- * @param {number | null} [options.lastSegmentIndex] - The film's last number,
- *   for telling a finished file from an input that dried up.
- * @param {boolean} [options.usesExplicitCuts]
- * @returns {import("../../services/encode/EncodeRun.js").EncodeRun}
- */
-export function startRunOn(session, options = {}) {
-  const {
-    from = 0,
-    to = -1,
-    process: child = fakeProcess(),
-    producing = true,
-    lastSegmentIndex = null,
-    usesExplicitCuts = false,
-    // WHAT FFMPEG HAS REPORTED IT IS RUNNING AT. It says so on its progress
-    // channel from the first seconds, before any piece closes — so a run can be
-    // starting and already have a speed, and every real one does. Left at zero,
-    // the plan has no speed to compute an arrival from, every arrangement of
-    // encoders is equally hopeless, they all tie, and the encoder is taken away
-    // for changing nothing.
-    speedX = 0
-  } = options;
-  const run = new EncodeRun({
-    address: session.outputKey ?? session.id ?? "output",
-    encoder: { name: "libx264", kind: "software" },
-    from,
-    to,
-    buildArgs: () => [],
-    spawn: () => child,
-    logger: silentLogger,
-    lastSegmentIndex: () => lastSegmentIndex,
-    usesExplicitCuts,
-    because: "a test asked for it"
-  });
-  run.noteSpeed(speedX);
-  if (producing) {
-    // What moves a run out of starting is its first segment, in the product as
-    // here — so a run that is producing has made one, and its head stands one
-    // past where it began. `from` is still where it started, which is what a
-    // test asserting a run's position asks for.
-    run.noteProduced(from);
-  }
-  if (!(session.runs instanceof Set)) {
-    session.runs = new Set();
-  }
-  session.runs.add(run);
-  return run;
-}
+/**
+ * @file A real `EncodeRun` over a process that is not real.
+ *
+ * Tests used to set a session's process fields by hand — `session.ffmpeg`,
+ * `session.runState`, `session.encodeStartIndex` — which is how a test can pass
+ * over code that no longer works: the fields were the thing under test as much
+ * as the behaviour was. A run is an object now, so a test builds the object the
+ * product builds and injects only the one thing a test may not have, which is a
+ * child process.
+ *
+ * The pid is deliberately absent unless a test asks for one. `pause` and
+ * `resume` send signals by pid, and a made-up number is somebody else's process
+ * on the machine running the tests.
+ */
+
+import { EncodeRun } from "../../services/encode/EncodeRun.js";
+
+/**
+ * A child process that records what was done to it.
+ *
+ * @param {object} [options]
+ * @param {number | null} [options.pid] - Only where a test genuinely exercises
+ *   suspend or resume, and then it must be this process's own.
+ * @returns {object}
+ */
+export function fakeProcess({ pid = null, exitsWhenKilled = true } = {}) {
+  /** @type {Map<string, (...args: unknown[]) => void>} */
+  const listeners = new Map();
+  return {
+    pid,
+    killed: false,
+    exitCode: null,
+    signalCode: null,
+    /** Every signal it was sent, in order. */
+    signals: [],
+    stdout: { on() {} },
+    stderr: { on() {} },
+    on(event, handler) {
+      const kept = listeners.get(event) ?? [];
+      kept.push(handler);
+      listeners.set(event, kept);
+      return this;
+    },
+    once(event, handler) {
+      return this.on(event, handler);
+    },
+    kill(signal = "SIGTERM") {
+      this.signals.push(signal);
+      this.killed = true;
+      // A real process answers a signal by exiting, and it does so on a later
+      // turn. A fake that never exits makes every disposal wait out the grace
+      // period, which is two seconds a test spends proving nothing.
+      if (exitsWhenKilled && this.exitCode === null && this.signalCode === null) {
+        queueMicrotask(() => this.exit(null, signal));
+      }
+      return true;
+    },
+    /**
+     * Report an exit, as the real thing would.
+     *
+     * @param {number | null} code
+     * @param {string | null} [signal]
+     */
+    exit(code, signal = null) {
+      this.exitCode = code;
+      this.signalCode = signal;
+      for (const handler of listeners.get("exit") ?? []) {
+        handler(code, signal);
+      }
+    }
+  };
+}
+
+/** A logger that says nothing, for tests that are not about the log. */
+export const silentLogger = { info() {}, warn() {}, error() {} };
+
+/**
+ * Add a run to a session, started, over a fake process.
+ *
+ * A session holds a SET of runs — as many as the machine affords — so a test
+ * that wants two heads on one output calls this twice.
+ *
+ * @param {object} session - The session under test.
+ * @param {object} [options]
+ * @param {number} [options.from] - First segment number it is making.
+ * @param {number} [options.to] - Last, inclusive; below `from` means no end.
+ * @param {object} [options.process] - The process it should own.
+ * @param {boolean} [options.producing] - Whether it has already made its first
+ *   segment, which is what moves it out of starting.
+ * @param {number | null} [options.lastSegmentIndex] - The film's last number,
+ *   for telling a finished file from an input that dried up.
+ * @param {boolean} [options.usesExplicitCuts]
+ * @returns {import("../../services/encode/EncodeRun.js").EncodeRun}
+ */
+export function startRunOn(session, options = {}) {
+  const {
+    from = 0,
+    to = -1,
+    process: child = fakeProcess(),
+    producing = true,
+    lastSegmentIndex = null,
+    usesExplicitCuts = false,
+    // WHAT FFMPEG HAS REPORTED IT IS RUNNING AT. It says so on its progress
+    // channel from the first seconds, before any piece closes — so a run can be
+    // starting and already have a speed, and every real one does. Left at zero,
+    // the plan has no speed to compute an arrival from, every arrangement of
+    // encoders is equally hopeless, they all tie, and the encoder is taken away
+    // for changing nothing.
+    speedX = 0
+  } = options;
+  const run = new EncodeRun({
+    address: session.outputKey ?? session.id ?? "output",
+    encoder: { name: "libx264", kind: "software" },
+    from,
+    to,
+    buildArgs: () => [],
+    spawn: () => child,
+    logger: silentLogger,
+    lastSegmentIndex: () => lastSegmentIndex,
+    usesExplicitCuts,
+    because: "a test asked for it"
+  });
+  run.noteSpeed(speedX);
+  if (producing) {
+    // What moves a run out of starting is its first segment, in the product as
+    // here — so a run that is producing has made one, and its head stands one
+    // past where it began. `from` is still where it started, which is what a
+    // test asserting a run's position asks for.
+    run.noteProduced(from);
+  }
+  if (!(session.runs instanceof Set)) {
+    session.runs = new Set();
+  }
+  session.runs.add(run);
+  return run;
+}

package/test/helpers/held-file.js

@@ -0,0 +1,29 @@
+/**
+ * @file A torrent reduced to what the subtitle walk may know about one file.
+ *
+ * Built from the REAL two functions the torrent thread answers with
+ * (`torrent/worker/held-bytes.js`), so a check that walks cues exercises both
+ * sides of the seam rather than a stand-in for one of them: the bitfield
+ * becoming a list of ranges, and a range read that never fetches.
+ */
+
+import { heldRangesOf, readHeldBytes } from "../../services/torrent/worker/held-bytes.js";
+
+/**
+ * @param {object} torrent - The fake a check builds: `pieceLength`, `bitfield`,
+ *   `files[]` with `offset`, `length`, `name`, `createReadStream`.
+ * @param {number} fileIndex
+ * @param {string} sourceKey
+ * @returns {import("../../services/media/SubtitleCues.js").HeldFile}
+ */
+export function heldFileOver(torrent, fileIndex, sourceKey) {
+  const file = torrent?.files?.[fileIndex] ?? {};
+  return {
+    sourceKey,
+    fileIndex,
+    name: String(file.name ?? ""),
+    length: Number(file.length) || 0,
+    heldRanges: async () => heldRangesOf(torrent, fileIndex),
+    readHeld: (start, end) => readHeldBytes(torrent, fileIndex, start, end)
+  };
+}

package/test/helpers/manager.js

@@ -0,0 +1,57 @@
+/**
+ * @file A session manager for a test, with a store of its own.
+ *
+ * ONE MANAGER, ONE ROOT. In production that is true by construction: one
+ * process holds one manager, and the store's root is a fixed path so that a
+ * restart can find what the process before it finished (`SegmentStore.sweep`).
+ * Under `node --test` it is false — the runner starts one PROCESS PER FILE and
+ * runs them in parallel, so every manager built without a store of its own
+ * shared the one default root with every other file running at that moment.
+ *
+ * What that cost, measured 2026-09-14: `disposeAll` removes the store's whole
+ * root, and four files call it between them 40 times. Running the twenty-one
+ * files that build a manager gave 2, 3 and 4 failures on consecutive runs and
+ * zero with `--test-concurrency=1`; the victim was always
+ * `segment-serve-wiring.test.js`, reporting a segment missing that it had
+ * written itself a moment earlier, because another process had deleted the
+ * directory under it. `npm test` is `node --test`, so this was the project's
+ * own test command, and it is why a red result had become something to read
+ * past rather than to act on.
+ *
+ * A test that fails by luck is worse than one that does not exist: it costs a
+ * run every time, and it trains everyone to ignore red.
+ */
+
+import { mkdtempSync, rmSync } from "node:fs";
+import os from "node:os";
+import path from "node:path";
+import { wireOutputs } from "../../services/server/wire-outputs.js";
+import { SegmentStore } from "../../services/storage/segment-store/SegmentStore.js";
+
+/**
+ * A manager whose produced segments live where nothing else can reach them.
+ *
+ * @param {object} [options] - Passed to the manager, over the defaults below.
+ *   A `segmentStore` given here wins, for a test that wants to watch the store
+ *   itself.
+ * @returns {{ manager: object, store: SegmentStore, root: string,
+ *   cleanup: () => void }} `cleanup` removes the root; call it from `t.after`.
+ */
+export function managerWithOwnStore(options = {}) {
+  const root = mkdtempSync(path.join(os.tmpdir(), "ttv-store-"));
+  const store = options.segmentStore ?? new SegmentStore({ root });
+  const manager = wireOutputs({
+    enabled: true,
+    ffmpegBin: "ffmpeg",
+    localBindHost: "127.0.0.1",
+    localPort: 9090,
+    ...options,
+    segmentStore: store
+  });
+  return {
+    manager,
+    store,
+    root,
+    cleanup: () => rmSync(root, { recursive: true, force: true })
+  };
+}

package/test/helpers/output-spec.js

@@ -0,0 +1,63 @@
+import { AudioOutput, CutGrid, OutputSpec, VideoOutput } from "../../services/encode/output/OutputSpec.js";
+
+/**
+ * Build the output identity used by production objects in focused tests.
+ *
+ * @param {object} [params]
+ * @param {string} [params.sourceKey]
+ * @param {number} [params.fileIndex]
+ * @param {boolean} [params.transcodeVideo]
+ * @param {boolean} [params.transcodeAudio]
+ * @param {boolean} [params.audioOnly]
+ * @param {boolean} [params.audioSeparate]
+ * @param {number} [params.audioFileIndex]
+ * @param {number} [params.audioSourceTrackIndex]
+ * @param {number} [params.width]
+ * @param {number} [params.height]
+ * @param {string} [params.encoder]
+ * @param {number} [params.fps]
+ * @param {string | null} [params.preset]
+ * @param {boolean} [params.tonemap]
+ * @param {{ maxrateKbps: number, bufsizeKbps: number, level: string | null } | null} [params.rateControl]
+ * @param {"keyframe" | "uniform"} [params.cutGrid]
+ * @param {string} [params.segmentFormatId]
+ * @returns {OutputSpec}
+ */
+export function outputSpec({
+  sourceKey = "source-1",
+  fileIndex = 0,
+  transcodeVideo = false,
+  transcodeAudio = true,
+  audioOnly = false,
+  audioSeparate = false,
+  audioFileIndex = fileIndex,
+  audioSourceTrackIndex = 0,
+  width = 0,
+  height = 0,
+  encoder = "libx264",
+  fps = 24,
+  preset = null,
+  tonemap = false,
+  rateControl = null,
+  cutGrid = "uniform",
+  segmentFormatId = "fmp4"
+} = {}) {
+  return new OutputSpec({
+    sourceKey,
+    segmentFormatId,
+    grid: new CutGrid({ kind: cutGrid, fileIndex }),
+    video: audioOnly
+      ? null
+      : new VideoOutput({
+          fileIndex,
+          encode: transcodeVideo ? { encoder, width, height, fps, preset, tonemap, rateControl } : null
+        }),
+    audio: audioSeparate
+      ? null
+      : new AudioOutput({
+          fileIndex: audioFileIndex,
+          trackIndex: audioSourceTrackIndex,
+          transcode: transcodeAudio
+        })
+  });
+}

package/test/host-load.test.js

@@ -9,7 +9,7 @@
 import assert from "node:assert/strict";
 import test from "node:test";
 
-import { readProcessCpuSeconds, readSystemCpu, sampleHost, shareOfMachine } from "../services/host-load.js";
+import { readProcessCpuSeconds, readSystemCpu, sampleHost, shareOfMachine } from "../services/encode/host-load.js";
 
 test("a process using one core of four for a second reports a quarter of the machine", () => {
   const before = { takenAt: 1_000, processCpuSeconds: 10, system: null };

package/test/index-accuracy-is-about-the-file.test.js

@@ -0,0 +1,128 @@
+/**
+ * @file What a produced piece reveals, and WHOSE fact it is.
+ *
+ * One reading is taken — how far a produced piece began from where its grid
+ * said it would — and three different facts are drawn from it, which the code
+ * that draws them already stated in its own three branches:
+ *
+ * 1. a COPIED picture can only be cut where a keyframe already is, so a
+ *    disagreement says the container's keyframe TABLE describes times the file
+ *    does not have. A fact of the FILE;
+ * 2. a RE-ENCODED rung was told to put a keyframe at that instant and did not,
+ *    so its pieces no longer stand where the stream it accompanies would have
+ *    put them. A fact of that OUTPUT;
+ * 3. a SOUNDTRACK is cut exactly where it is asked to be, to within an audio
+ *    frame, so it says nothing about any keyframe at all — only that the
+ *    picture's grid has moved under a run already going. A fact of that OUTPUT.
+ *
+ * Until 2026-09-15 all three went into ONE tally, and the tally was on the cut
+ * table — which is held per (file, grid), so a picture and the soundtrack muxed
+ * into the same file shared it. Three consequences, and these checks are about
+ * all of them: the file's finding died with a grid it does not belong to, one
+ * output's reading of a piece number silenced another's reading of its own, and
+ * the summary could not say which of the three facts it was summarising.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { Timeline, Timelines } from "../services/encode/output/Timeline.js";
+import { Output } from "../services/encode/output/Output.js";
+import { KeyframeTable } from "../services/media/container/KeyframeTable.js";
+
+const KEYFRAMES = [0, 4.004, 8.008, 12.012, 16.016];
+const TOLERANCE = 0.25;
+
+/**
+ * @param {number[]} boundaries
+ * @returns {Timeline}
+ */
+function timelineOver(boundaries) {
+  return new Timeline({ boundaries: [...boundaries], cutGrid: "keyframe" });
+}
+
+/**
+ * @returns {Output}
+ */
+function anOutput() {
+  return new Output({
+    encodeWidth: 0,
+    encodeHeight: 0,
+    outputFps: 25,
+    softwarePreset: null,
+    applyTonemap: false
+  });
+}
+
+test("a picture and the soundtrack inside the same file share one cut table, and no longer one tally", () => {
+  // Sharing the table is right — it is what makes them cut at the same instants
+  // and is the whole reason it is held per file and grid. What must not be
+  // shared is what each of them LEARNS, since the two learn different things.
+  const tables = new Timelines();
+  const key = Timelines.keyFor("torrent:abc", 3, "keyframe");
+
+  const picture = tables.get(key, () => timelineOver(KEYFRAMES));
+  const sound = tables.get(key, () => timelineOver(KEYFRAMES));
+
+  assert.equal(sound, picture, "one table, so the cuts cannot drift apart");
+  assert.equal(
+    Object.keys(picture).some((field) => /check|tally|deviation|landing/i.test(field)),
+    false,
+    "and nothing on it counts what anybody found, which two outputs would have shared"
+  );
+});
+
+test("two outputs each keep their own reading of the same piece number", () => {
+  // `seen` exists so that a piece asked for twice is not counted twice — right
+  // for one producer, and wrong across two. Shared, it dropped whichever of the
+  // two finished second, so which reading survived was decided by a race.
+  const picture = anOutput();
+  const sound = anOutput();
+
+  picture.noteLanding({ index: 7, deviationSec: 0.9, toleranceSec: TOLERANCE });
+  sound.noteLanding({ index: 7, deviationSec: 0, toleranceSec: TOLERANCE });
+
+  assert.equal(picture.landing.checked, 1);
+  assert.equal(picture.landing.disagreed, 1, "the picture's piece did begin away from its grid");
+  assert.equal(sound.landing.checked, 1, "and the sound's reading of its own #7 is not a repeat");
+  assert.equal(sound.landing.disagreed, 0, "the sound was cut exactly where it was asked");
+
+  // What `seen` is FOR, which the split must not lose: within one output a
+  // piece is produced and served over and over while a viewer is refused it,
+  // and the same piece is one reading however many times it is read.
+  picture.noteLanding({ index: 7, deviationSec: 0.9, toleranceSec: TOLERANCE });
+  picture.noteLanding({ index: 7, deviationSec: 0.9, toleranceSec: TOLERANCE });
+
+  assert.equal(picture.landing.checked, 1, "its own repeat is still the same piece, counted once");
+  assert.equal(picture.landing.disagreed, 1);
+});
+
+test("only a copy's reading reaches the file's table, and it outlives any one grid", () => {
+  // The whole point of moving it: the table is one per FILE, so what a copy
+  // showed about it is there for every step and every later session of those
+  // bytes — while a tally on a cut table died with the grid, and a grid is not
+  // what the reading is about.
+  const table = new KeyframeTable().learn({ times: KEYFRAMES, format: "matroska" });
+
+  table.witness({ index: 2, trueStart: 12.012, deviationSec: 4.004, toleranceSec: TOLERANCE });
+
+  assert.equal(table.evidence.checked, 1);
+  assert.equal(table.evidence.disagreed, 1);
+  assert.equal(
+    table.evidence.landedOnAnotherKeyframe,
+    1,
+    "and the table itself says the piece began at another time it names — the grid was built over a gap"
+  );
+});
+
+test("each tally answers one question, so a summary of it cannot be a mixture", () => {
+  // The distinction the three branches make when they WARN is now kept in what
+  // they count, so the summary can restate it — and the summary is what is read
+  // when nobody was watching the log live.
+  const sound = anOutput();
+  const table = new KeyframeTable().learn({ times: KEYFRAMES, format: "matroska" });
+
+  sound.noteLanding({ index: 1, deviationSec: 0.8, toleranceSec: TOLERANCE });
+
+  assert.equal(sound.landing.disagreed, 1, "the sound's grid moved under its run, and that is all it says");
+  assert.equal(table.evidence, null, "nothing a soundtrack produced is evidence about the file's keyframes");
+});