@torrent-tv/proxy 2.83.4 → 2.83.6

package/test/input-lost-quiets-the-plan.test.js

@@ -0,0 +1,261 @@
+/**
+ * @file An output whose input is away gets no encoders until it may.
+ *
+ * A run whose input has gone is not alive, so the plan reads the stretch it held
+ * as free and places another run there at once — which dies the same way,
+ * because nothing about the state has changed. A delay existed for exactly this,
+ * doubling from 2 s to 15 s, and it was timed against the DEAD RUN, which the
+ * plan never consults. Field 2026-09-12: 2432 ffmpeg starts in 23 minutes, one
+ * every 0.57 s, for 61 minutes, against a delay that had reached its ceiling
+ * long before; the flood also turned the log over twice and destroyed the
+ * record of how the failure began.
+ *
+ * The delay lives beside the decision it governs now, and these check that it
+ * binds.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { EventEmitter } from "node:events";
+import { EncodeRun } from "../services/encode/EncodeRun.js";
+import { ENCODE_EXIT } from "../services/encode/encode-exit.js";
+import { SoftwareEncoder } from "../services/encode/SoftwareEncoder.js";
+import { EncodeOrchestrator } from "../services/orchestrators/EncodeOrchestrator.js";
+
+const PICTURE = "torrent:abc:fmt=fmp4:grid=kf@0:video-only:v=0/copy";
+
+class FakeProcess extends EventEmitter {
+  constructor() {
+    super();
+    this.pid = 1;
+  }
+
+  kill(signal) {
+    this.emit("exit", null, signal);
+  }
+}
+
+/** An orchestrator whose clock the test moves, and a count of what it started. */
+function orchestrator() {
+  const lines = [];
+  let clock = 1_000;
+  let started = 0;
+  let asked = 0;
+  /** @type {EncodeOrchestrator} */
+  let made;
+  /** @type {{ run: EncodeRun, process: FakeProcess }[]} */
+  const runs = [];
+  made = new EncodeOrchestrator({
+    maxRunsFor: () => 1,
+    segmentSeconds: 4,
+    startingSpeedFor: () => 2,
+    refetchSecPerFilmSecond: () => 0.25,
+    now: () => clock,
+    planSoon: () => { asked += 1; },
+    logger: { info: (line) => lines.push(line), warn: (line) => lines.push(line) },
+    makeRun: ({ address, from, to }) => {
+      started += 1;
+      const process_ = new FakeProcess();
+      const run = new EncodeRun({
+        address,
+        encoder: new SoftwareEncoder(),
+        from,
+        to,
+        buildArgs: () => ["-i", "in", "out"],
+        spawn: () => process_,
+        logger: { info: (line) => lines.push(line), warn: (line) => lines.push(line) },
+        now: () => clock,
+        onEnded: (ended) => made.noteEnded(ended)
+      });
+      runs.push({ run, process: process_ });
+      return run;
+    }
+  });
+  made.setSegmentCount(PICTURE, 1000);
+  made.noteStartupCosts({ killCostSec: 0, firstByteWaitSec: 0.12 });
+
+  const wants = () => made.notePriorityMap(PICTURE, [
+    { from: 0, to: 20, priority: 1, withinSeconds: 0 }
+  ]);
+
+  return {
+    made,
+    lines,
+    wants,
+    runs,
+    startedCount: () => started,
+    askedToPlanAgain: () => asked,
+    advance: (ms) => { clock += ms; },
+    /** End the newest run the way a torrent going away ends one. */
+    loseTheInput: () => {
+      const newest = runs[runs.length - 1];
+      made.noteEnded({
+        address: PICTURE,
+        run: newest.run,
+        from: newest.run.from,
+        to: newest.run.to,
+        ending: ENCODE_EXIT.INPUT_LOST,
+        because: "the torrent went away"
+      });
+    }
+  };
+}
+
+test("nothing is placed on an output whose input has just gone", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 1, "one encoder for the one thing wanted");
+
+  stand.loseTheInput();
+  // The plan is asked again by every event there is — a request, a report, a
+  // piece — and in the field that was about twice a second.
+  for (let attempt = 0; attempt < 20; attempt += 1) {
+    stand.made.reconcile();
+  }
+  assert.equal(
+    stand.startedCount(),
+    1,
+    "twenty decisions while the input is away must not be twenty processes"
+  );
+});
+
+test("once the wait is over the plan places again", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  stand.loseTheInput();
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 1);
+
+  // The first wait is the base delay; anything past it lets the plan act.
+  stand.advance(2_001);
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 2, "the data may be back, and that is worth one attempt");
+});
+
+test("the wait doubles while the input stays away, and is capped", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+
+  const waits = [];
+  for (let attempt = 0; attempt < 8; attempt += 1) {
+    stand.loseTheInput();
+    // Find the shortest advance that lets the plan act again, by stepping to
+    // just before and just after the boundary rather than reading a private.
+    let waited = 0;
+    const step = 250;
+    for (;;) {
+      const before = stand.startedCount();
+      stand.made.reconcile();
+      if (stand.startedCount() > before) {
+        break;
+      }
+      stand.advance(step);
+      waited += step;
+      assert.ok(waited < 60_000, "a wait must not be unbounded");
+    }
+    waits.push(waited);
+  }
+
+  for (let at = 1; at < waits.length; at += 1) {
+    assert.ok(
+      waits[at] >= waits[at - 1],
+      `the wait must not shrink while the input stays away: ${JSON.stringify(waits)}`
+    );
+  }
+  assert.ok(
+    waits[waits.length - 1] <= 15_000,
+    `and it must stop growing: ${JSON.stringify(waits)}`
+  );
+  assert.ok(
+    waits[waits.length - 1] > waits[0],
+    `and it must actually have grown: ${JSON.stringify(waits)}`
+  );
+});
+
+test("a wake-up is asked for, because no event arrives while the data is away", async () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  stand.loseTheInput();
+  // The wake-up runs on the real clock — the orchestrator's injected `now` is
+  // what the DECISION reads, and a timer is not a decision. So this waits for
+  // the condition, with a deadline only as a backstop; a fixed pause here would
+  // measure the machine.
+  const deadline = Date.now() + 10_000;
+  while (stand.askedToPlanAgain() === 0) {
+    if (Date.now() > deadline) {
+      assert.fail("nothing about the state changes while the input is missing, so the plan must be recalled");
+    }
+    await new Promise((resolve) => setTimeout(resolve, 25));
+  }
+  assert.ok(stand.askedToPlanAgain() >= 1);
+});
+
+test("an ending that is not about the input clears the wait", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  stand.loseTheInput();
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 1, "held back, as it should be");
+
+  stand.advance(2_001);
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 2);
+
+  // This one PRODUCED and was then stopped: a segment came out of the input, so
+  // the input was plainly there and the next attempt starts from no delay.
+  const newest = stand.runs[stand.runs.length - 1];
+  stand.made.noteEnded({
+    address: PICTURE,
+    run: newest.run,
+    from: newest.run.from,
+    to: newest.run.to,
+    reached: newest.run.from,
+    firstOutputMs: 120,
+    ending: ENCODE_EXIT.STOPPED,
+    because: "we asked it to"
+  });
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 3, "a file that has just produced is not suspect");
+});
+
+test("an ending that produced NOTHING does not lift the wait", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  stand.loseTheInput();
+
+  // At the moment of failure several runs end at once. One of them ending
+  // without having made anything proves nothing about the input, and lifting
+  // the wait on it is the storm again with an extra step.
+  const newest = stand.runs[stand.runs.length - 1];
+  stand.made.noteEnded({
+    address: PICTURE,
+    run: newest.run,
+    from: newest.run.from,
+    to: newest.run.to,
+    reached: newest.run.from - 1,
+    firstOutputMs: null,
+    ending: ENCODE_EXIT.GONE,
+    because: "it is no longer running, and it did not say so"
+  });
+  for (let attempt = 0; attempt < 10; attempt += 1) {
+    stand.made.reconcile();
+  }
+  assert.equal(stand.startedCount(), 1, "an ending with nothing produced is no evidence");
+});
+
+test("the wait is said out loud, with the attempt and how long", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  stand.loseTheInput();
+  assert.ok(
+    stand.lines.some((line) => /its input was not there \(attempt 1\)/.test(line)),
+    `the reason nothing is being placed must be readable: ${JSON.stringify(stand.lines.slice(-4))}`
+  );
+});

package/test/logger-repeats.test.js

@@ -0,0 +1,134 @@
+/**
+ * @file An established fact is said once, then with decreasing frequency.
+ *
+ * Field 2026-09-12: one absent piece produced 235 000 lines in 92 minutes —
+ * about 55 a second, 68.8 % of them byte-identical repeats — and it turned the
+ * log file over twice, so the beginning of the failure was gone before anybody
+ * read it. A log is not spoilt by its size; it is spoilt by uniformity.
+ *
+ * Matched verbatim, the whole line: that catches nearly all of the flood and
+ * cannot merge two different statements. Normalising numbers would catch a
+ * little more and would also merge the memory series, which exists precisely to
+ * catch a runaway.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { logger, writeAlreadyDecided } from "../utils/logger.js";
+
+/** What reached the console while `body` ran. */
+function captured(body) {
+  const lines = [];
+  const real = { log: console.log, warn: console.warn, error: console.error };
+  console.log = (line) => lines.push(String(line));
+  console.warn = (line) => lines.push(String(line));
+  console.error = (line) => lines.push(String(line));
+  try {
+    body();
+  } finally {
+    console.log = real.log;
+    console.warn = real.warn;
+    console.error = real.error;
+  }
+  return lines;
+}
+
+/** A line no other test in this process will have said. */
+function unique(what) {
+  return `logger-repeats ${what} ${Math.random().toString(36).slice(2)}`;
+}
+
+test("the first time is said, and the repeats right behind it are not", () => {
+  const message = unique("flood");
+  const lines = captured(() => {
+    for (let at = 0; at < 500; at += 1) {
+      logger.info(message);
+    }
+  });
+  assert.equal(lines.length, 1, "five hundred identical lines are one fact");
+  assert.ok(lines[0].includes(message));
+});
+
+test("two different lines are both said — repeats are matched whole", () => {
+  const one = unique("one");
+  const other = unique("other");
+  const lines = captured(() => {
+    logger.info(one);
+    logger.info(other);
+    logger.info(one);
+    logger.info(other);
+  });
+  assert.equal(lines.length, 2, "different statements never merge");
+  assert.ok(lines[0].includes(one));
+  assert.ok(lines[1].includes(other));
+});
+
+test("a line whose numbers differ is a different line", () => {
+  const stem = unique("rss");
+  const lines = captured(() => {
+    logger.info(`${stem} rss=327MB`);
+    logger.info(`${stem} rss=726MB`);
+    logger.info(`${stem} rss=4616MB`);
+  });
+  assert.equal(
+    lines.length,
+    3,
+    "the memory series exists to catch a runaway; suppressing it would be worse than the flood"
+  );
+});
+
+test("when it is said again, it says how many were held back", async () => {
+  const message = unique("counted");
+  const first = captured(() => {
+    logger.info(message);
+    for (let at = 0; at < 9; at += 1) {
+      logger.info(message);
+    }
+  });
+  assert.equal(first.length, 1);
+
+  // The first interval is a second. Waited for rather than assumed: this asks
+  // the logger itself when it is ready to speak again, with a deadline as a
+  // backstop.
+  const deadline = Date.now() + 10_000;
+  let later = [];
+  while (later.length === 0) {
+    if (Date.now() > deadline) {
+      assert.fail("the line should be said again once its interval has passed");
+    }
+    await new Promise((resolve) => setTimeout(resolve, 100));
+    later = captured(() => logger.info(message));
+  }
+  const said = later[0].match(/\[said (\d+) more time\(s\) in the last ([0-9.]+)s\]/);
+  assert.ok(said, `the rate is the fact here, and must be stated: ${later[0]}`);
+  // At least the nine held back above. Each poll that found nothing said the
+  // line again and was itself held back, so the exact figure belongs to how
+  // often this test asked — the property being pinned is that the held-back
+  // count is reported at all, and that it counts every one of them.
+  assert.ok(Number(said[1]) >= 9, `held-back count too low: ${later[0]}`);
+  assert.ok(Number(said[2]) > 0, `the span it covers must be stated: ${later[0]}`);
+});
+
+test("a line already decided on another thread is written as it is", () => {
+  const message = unique("forwarded");
+  const lines = captured(() => {
+    writeAlreadyDecided("info", message);
+    writeAlreadyDecided("info", message);
+    writeAlreadyDecided("warn", message);
+  });
+  // The worker holds the same rule and applies it before forwarding. Deciding
+  // again here would be one decision taken twice on two different histories,
+  // and the file's own promise is that a line cannot reach the console and miss
+  // the file.
+  assert.equal(lines.length, 3, "a forwarded line is not judged a second time");
+});
+
+test("every level goes through the same rule", () => {
+  const message = unique("levels");
+  const lines = captured(() => {
+    logger.warn(message);
+    logger.warn(message);
+    logger.error(message);
+  });
+  assert.equal(lines.length, 1, "a flood of errors is still a flood");
+});

package/test/read-survives-withdrawal.test.js

@@ -0,0 +1,164 @@
+/**
+ * @file A read whose piece is withdrawn under it waits, rather than failing.
+ *
+ * The store drops a piece once every reader is past it, and the claim is
+ * withdrawn with it, so the piece is fetched again. A read that meets the gap in
+ * between must therefore WAIT — until 2026-09-12 it threw, ffmpeg read the empty
+ * body as the end of the file, the encoder died, and the plan restarted it into
+ * the same emptiness: 2432 starts in 23 minutes and a viewer looking at a still
+ * picture for 92 minutes.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { EventEmitter } from "node:events";
+import os from "node:os";
+import path from "node:path";
+import fs from "node:fs/promises";
+import { readFragments } from "../services/torrent-worker/piece-reader.js";
+import { SharedPieceStore } from "../services/piece-store/shared-piece-store.js";
+
+const PIECE = 1024;
+const TOTAL = 4 * PIECE;
+
+/**
+ * A torrent of four pieces over a real store, whose `reside` can be made to
+ * answer "gone" for a chosen piece a chosen number of times — which is what the
+ * store does between dropping a piece and the swarm bringing it back.
+ *
+ * @param {{ emptyFor: number, times: number }} gap
+ */
+async function torrentWithAGap({ emptyFor, times }) {
+  const directory = await fs.mkdtemp(path.join(os.tmpdir(), "withdrawal-read-"));
+  const store = new SharedPieceStore(PIECE, {
+    length: TOTAL,
+    memoryBytes: 64 * PIECE,
+    path: directory,
+    name: "test",
+    files: [{ offset: 0, length: TOTAL, name: "file.bin" }]
+  });
+  for (let index = 0; index < 4; index += 1) {
+    const piece = Buffer.alloc(PIECE);
+    for (let at = 0; at < PIECE; at += 1) {
+      piece[at] = (index * PIECE + at) % 251;
+    }
+    await new Promise((resolve, reject) => {
+      store.put(index, piece, (error) => (error ? reject(error) : resolve()));
+    });
+  }
+
+  const held = new Set([0, 1, 2, 3]);
+  let left = times;
+  /** How many times the piece was asked of the store at all. */
+  let asked = 0;
+  // The gap is injected at the one method that answers "can you produce this
+  // piece" — subclassed rather than wrapped, because `findSharedStore` walks
+  // the chain looking for the real class and would find the real one behind a
+  // facade.
+  store.reside = async function resideWithAGap(index) {
+    if (index !== emptyFor) {
+      return SharedPieceStore.prototype.reside.call(this, index);
+    }
+    asked += 1;
+    if (left > 0) {
+      left -= 1;
+      // THE CLAIM GOES WITH THE BYTES. That is what makes the wait a wait for a
+      // download and not a wait for nothing, and it is what the withdrawal now
+      // does in production.
+      held.delete(index);
+      // Back a moment later, as the swarm brings it: the reader's own wait ends
+      // on the torrent's `verified` event.
+      setImmediate(() => {
+        held.add(index);
+        torrent.emit("verified", index);
+      });
+      return null;
+    }
+    return SharedPieceStore.prototype.reside.call(this, index);
+  };
+
+  const torrent = Object.assign(new EventEmitter(), {
+    pieceLength: PIECE,
+    store,
+    bitfield: { get: (index) => held.has(index) },
+    files: [{ offset: 0, length: TOTAL, name: "file.bin" }],
+    select() {},
+    critical() {}
+  });
+
+  return {
+    torrent,
+    clean: async () => {
+      store.destroy(() => undefined);
+      await fs.rm(directory, { recursive: true, force: true, maxRetries: 10, retryDelay: 20 });
+    },
+    asksFor: () => asked
+  };
+}
+
+/** Read a range as the worker does. */
+async function readRange(torrent, start, end) {
+  const collected = [];
+  for await (const fragment of readFragments({
+    torrent,
+    fileIndex: 0,
+    start,
+    end,
+    cancellation: { isCancelled: () => false }
+  })) {
+    const source = fragment.buffer
+      ? Buffer.from(fragment.buffer, fragment.offset, fragment.length)
+      : Buffer.alloc(0);
+    collected.push(Buffer.from(source));
+    fragment.release();
+  }
+  return Buffer.concat(collected);
+}
+
+function expectedBytes(absoluteStart, length) {
+  const expected = Buffer.alloc(length);
+  for (let at = 0; at < length; at += 1) {
+    expected[at] = (absoluteStart + at) % 251;
+  }
+  return expected;
+}
+
+test("a piece withdrawn once is asked for again and the read completes", async () => {
+  // Piece 0 is the case the field met: an encoder restart re-opens its input at
+  // byte 0, and byte 0 is behind every read head by then.
+  const { torrent, clean, asksFor } = await torrentWithAGap({ emptyFor: 0, times: 1 });
+  try {
+    const bytes = await readRange(torrent, 0, 2 * PIECE - 1);
+    assert.deepEqual(bytes, expectedBytes(0, 2 * PIECE), "the read returns the film, not an empty body");
+    assert.equal(asksFor(), 2, "the piece is asked for a second time, not given up on");
+  } finally {
+    await clean();
+  }
+});
+
+test("a piece that does not come back ends the read with a named error", async () => {
+  const { torrent, clean } = await torrentWithAGap({ emptyFor: 0, times: 5 });
+  try {
+    await assert.rejects(
+      () => readRange(torrent, 0, PIECE - 1),
+      // NOT "verified but absent": the claim has been withdrawn, so the honest
+      // statement is that the bytes did not come back.
+      /piece 0 was withdrawn from the store and did not come back/i,
+      "a second emptiness is a failure the caller must hear about"
+    );
+  } finally {
+    await clean();
+  }
+});
+
+test("every piece of a long read gets its own second chance", async () => {
+  // The allowance is per piece: a read of many pieces may legitimately meet the
+  // gap more than once, and one exhausted allowance must not condemn the rest.
+  const { torrent, clean } = await torrentWithAGap({ emptyFor: 2, times: 1 });
+  try {
+    const bytes = await readRange(torrent, 0, 4 * PIECE - 1);
+    assert.deepEqual(bytes, expectedBytes(0, 4 * PIECE));
+  } finally {
+    await clean();
+  }
+});