@torrent-tv/proxy 2.83.3 → 2.83.5

package/test/input-lost-quiets-the-plan.test.js

@@ -0,0 +1,261 @@
+/**
+ * @file An output whose input is away gets no encoders until it may.
+ *
+ * A run whose input has gone is not alive, so the plan reads the stretch it held
+ * as free and places another run there at once — which dies the same way,
+ * because nothing about the state has changed. A delay existed for exactly this,
+ * doubling from 2 s to 15 s, and it was timed against the DEAD RUN, which the
+ * plan never consults. Field 2026-09-12: 2432 ffmpeg starts in 23 minutes, one
+ * every 0.57 s, for 61 minutes, against a delay that had reached its ceiling
+ * long before; the flood also turned the log over twice and destroyed the
+ * record of how the failure began.
+ *
+ * The delay lives beside the decision it governs now, and these check that it
+ * binds.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { EventEmitter } from "node:events";
+import { EncodeRun } from "../services/encode/EncodeRun.js";
+import { ENCODE_EXIT } from "../services/encode/encode-exit.js";
+import { SoftwareEncoder } from "../services/encode/SoftwareEncoder.js";
+import { EncodeOrchestrator } from "../services/orchestrators/EncodeOrchestrator.js";
+
+const PICTURE = "torrent:abc:fmt=fmp4:grid=kf@0:video-only:v=0/copy";
+
+class FakeProcess extends EventEmitter {
+  constructor() {
+    super();
+    this.pid = 1;
+  }
+
+  kill(signal) {
+    this.emit("exit", null, signal);
+  }
+}
+
+/** An orchestrator whose clock the test moves, and a count of what it started. */
+function orchestrator() {
+  const lines = [];
+  let clock = 1_000;
+  let started = 0;
+  let asked = 0;
+  /** @type {EncodeOrchestrator} */
+  let made;
+  /** @type {{ run: EncodeRun, process: FakeProcess }[]} */
+  const runs = [];
+  made = new EncodeOrchestrator({
+    maxRunsFor: () => 1,
+    segmentSeconds: 4,
+    startingSpeedFor: () => 2,
+    refetchSecPerFilmSecond: () => 0.25,
+    now: () => clock,
+    planSoon: () => { asked += 1; },
+    logger: { info: (line) => lines.push(line), warn: (line) => lines.push(line) },
+    makeRun: ({ address, from, to }) => {
+      started += 1;
+      const process_ = new FakeProcess();
+      const run = new EncodeRun({
+        address,
+        encoder: new SoftwareEncoder(),
+        from,
+        to,
+        buildArgs: () => ["-i", "in", "out"],
+        spawn: () => process_,
+        logger: { info: (line) => lines.push(line), warn: (line) => lines.push(line) },
+        now: () => clock,
+        onEnded: (ended) => made.noteEnded(ended)
+      });
+      runs.push({ run, process: process_ });
+      return run;
+    }
+  });
+  made.setSegmentCount(PICTURE, 1000);
+  made.noteStartupCosts({ killCostSec: 0, firstByteWaitSec: 0.12 });
+
+  const wants = () => made.notePriorityMap(PICTURE, [
+    { from: 0, to: 20, priority: 1, withinSeconds: 0 }
+  ]);
+
+  return {
+    made,
+    lines,
+    wants,
+    runs,
+    startedCount: () => started,
+    askedToPlanAgain: () => asked,
+    advance: (ms) => { clock += ms; },
+    /** End the newest run the way a torrent going away ends one. */
+    loseTheInput: () => {
+      const newest = runs[runs.length - 1];
+      made.noteEnded({
+        address: PICTURE,
+        run: newest.run,
+        from: newest.run.from,
+        to: newest.run.to,
+        ending: ENCODE_EXIT.INPUT_LOST,
+        because: "the torrent went away"
+      });
+    }
+  };
+}
+
+test("nothing is placed on an output whose input has just gone", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 1, "one encoder for the one thing wanted");
+
+  stand.loseTheInput();
+  // The plan is asked again by every event there is — a request, a report, a
+  // piece — and in the field that was about twice a second.
+  for (let attempt = 0; attempt < 20; attempt += 1) {
+    stand.made.reconcile();
+  }
+  assert.equal(
+    stand.startedCount(),
+    1,
+    "twenty decisions while the input is away must not be twenty processes"
+  );
+});
+
+test("once the wait is over the plan places again", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  stand.loseTheInput();
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 1);
+
+  // The first wait is the base delay; anything past it lets the plan act.
+  stand.advance(2_001);
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 2, "the data may be back, and that is worth one attempt");
+});
+
+test("the wait doubles while the input stays away, and is capped", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+
+  const waits = [];
+  for (let attempt = 0; attempt < 8; attempt += 1) {
+    stand.loseTheInput();
+    // Find the shortest advance that lets the plan act again, by stepping to
+    // just before and just after the boundary rather than reading a private.
+    let waited = 0;
+    const step = 250;
+    for (;;) {
+      const before = stand.startedCount();
+      stand.made.reconcile();
+      if (stand.startedCount() > before) {
+        break;
+      }
+      stand.advance(step);
+      waited += step;
+      assert.ok(waited < 60_000, "a wait must not be unbounded");
+    }
+    waits.push(waited);
+  }
+
+  for (let at = 1; at < waits.length; at += 1) {
+    assert.ok(
+      waits[at] >= waits[at - 1],
+      `the wait must not shrink while the input stays away: ${JSON.stringify(waits)}`
+    );
+  }
+  assert.ok(
+    waits[waits.length - 1] <= 15_000,
+    `and it must stop growing: ${JSON.stringify(waits)}`
+  );
+  assert.ok(
+    waits[waits.length - 1] > waits[0],
+    `and it must actually have grown: ${JSON.stringify(waits)}`
+  );
+});
+
+test("a wake-up is asked for, because no event arrives while the data is away", async () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  stand.loseTheInput();
+  // The wake-up runs on the real clock — the orchestrator's injected `now` is
+  // what the DECISION reads, and a timer is not a decision. So this waits for
+  // the condition, with a deadline only as a backstop; a fixed pause here would
+  // measure the machine.
+  const deadline = Date.now() + 10_000;
+  while (stand.askedToPlanAgain() === 0) {
+    if (Date.now() > deadline) {
+      assert.fail("nothing about the state changes while the input is missing, so the plan must be recalled");
+    }
+    await new Promise((resolve) => setTimeout(resolve, 25));
+  }
+  assert.ok(stand.askedToPlanAgain() >= 1);
+});
+
+test("an ending that is not about the input clears the wait", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  stand.loseTheInput();
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 1, "held back, as it should be");
+
+  stand.advance(2_001);
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 2);
+
+  // This one PRODUCED and was then stopped: a segment came out of the input, so
+  // the input was plainly there and the next attempt starts from no delay.
+  const newest = stand.runs[stand.runs.length - 1];
+  stand.made.noteEnded({
+    address: PICTURE,
+    run: newest.run,
+    from: newest.run.from,
+    to: newest.run.to,
+    reached: newest.run.from,
+    firstOutputMs: 120,
+    ending: ENCODE_EXIT.STOPPED,
+    because: "we asked it to"
+  });
+  stand.made.reconcile();
+  assert.equal(stand.startedCount(), 3, "a file that has just produced is not suspect");
+});
+
+test("an ending that produced NOTHING does not lift the wait", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  stand.loseTheInput();
+
+  // At the moment of failure several runs end at once. One of them ending
+  // without having made anything proves nothing about the input, and lifting
+  // the wait on it is the storm again with an extra step.
+  const newest = stand.runs[stand.runs.length - 1];
+  stand.made.noteEnded({
+    address: PICTURE,
+    run: newest.run,
+    from: newest.run.from,
+    to: newest.run.to,
+    reached: newest.run.from - 1,
+    firstOutputMs: null,
+    ending: ENCODE_EXIT.GONE,
+    because: "it is no longer running, and it did not say so"
+  });
+  for (let attempt = 0; attempt < 10; attempt += 1) {
+    stand.made.reconcile();
+  }
+  assert.equal(stand.startedCount(), 1, "an ending with nothing produced is no evidence");
+});
+
+test("the wait is said out loud, with the attempt and how long", () => {
+  const stand = orchestrator();
+  stand.wants();
+  stand.made.reconcile();
+  stand.loseTheInput();
+  assert.ok(
+    stand.lines.some((line) => /its input was not there \(attempt 1\)/.test(line)),
+    `the reason nothing is being placed must be readable: ${JSON.stringify(stand.lines.slice(-4))}`
+  );
+});

package/test/logger-repeats.test.js

@@ -0,0 +1,120 @@
+/**
+ * @file An established fact is said once, then with decreasing frequency.
+ *
+ * Field 2026-09-12: one absent piece produced 235 000 lines in 92 minutes —
+ * about 55 a second, 68.8 % of them byte-identical repeats — and it turned the
+ * log file over twice, so the beginning of the failure was gone before anybody
+ * read it. A log is not spoilt by its size; it is spoilt by uniformity.
+ *
+ * Matched verbatim, the whole line: that catches nearly all of the flood and
+ * cannot merge two different statements. Normalising numbers would catch a
+ * little more and would also merge the memory series, which exists precisely to
+ * catch a runaway.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { logger } from "../utils/logger.js";
+
+/** What reached the console while `body` ran. */
+function captured(body) {
+  const lines = [];
+  const real = { log: console.log, warn: console.warn, error: console.error };
+  console.log = (line) => lines.push(String(line));
+  console.warn = (line) => lines.push(String(line));
+  console.error = (line) => lines.push(String(line));
+  try {
+    body();
+  } finally {
+    console.log = real.log;
+    console.warn = real.warn;
+    console.error = real.error;
+  }
+  return lines;
+}
+
+/** A line no other test in this process will have said. */
+function unique(what) {
+  return `logger-repeats ${what} ${Math.random().toString(36).slice(2)}`;
+}
+
+test("the first time is said, and the repeats right behind it are not", () => {
+  const message = unique("flood");
+  const lines = captured(() => {
+    for (let at = 0; at < 500; at += 1) {
+      logger.info(message);
+    }
+  });
+  assert.equal(lines.length, 1, "five hundred identical lines are one fact");
+  assert.ok(lines[0].includes(message));
+});
+
+test("two different lines are both said — repeats are matched whole", () => {
+  const one = unique("one");
+  const other = unique("other");
+  const lines = captured(() => {
+    logger.info(one);
+    logger.info(other);
+    logger.info(one);
+    logger.info(other);
+  });
+  assert.equal(lines.length, 2, "different statements never merge");
+  assert.ok(lines[0].includes(one));
+  assert.ok(lines[1].includes(other));
+});
+
+test("a line whose numbers differ is a different line", () => {
+  const stem = unique("rss");
+  const lines = captured(() => {
+    logger.info(`${stem} rss=327MB`);
+    logger.info(`${stem} rss=726MB`);
+    logger.info(`${stem} rss=4616MB`);
+  });
+  assert.equal(
+    lines.length,
+    3,
+    "the memory series exists to catch a runaway; suppressing it would be worse than the flood"
+  );
+});
+
+test("when it is said again, it says how many were held back", async () => {
+  const message = unique("counted");
+  const first = captured(() => {
+    logger.info(message);
+    for (let at = 0; at < 9; at += 1) {
+      logger.info(message);
+    }
+  });
+  assert.equal(first.length, 1);
+
+  // The first interval is a second. Waited for rather than assumed: this asks
+  // the logger itself when it is ready to speak again, with a deadline as a
+  // backstop.
+  const deadline = Date.now() + 10_000;
+  let later = [];
+  while (later.length === 0) {
+    if (Date.now() > deadline) {
+      assert.fail("the line should be said again once its interval has passed");
+    }
+    await new Promise((resolve) => setTimeout(resolve, 100));
+    later = captured(() => logger.info(message));
+  }
+  const said = later[0].match(/\[said (\d+) more time\(s\) in the last ([0-9.]+)s\]/);
+  assert.ok(said, `the rate is the fact here, and must be stated: ${later[0]}`);
+  // At least the nine held back above. Each poll that found nothing said the
+  // line again and was itself held back, so the exact figure belongs to how
+  // often this test asked — the property being pinned is that the held-back
+  // count is reported at all, and that it counts every one of them.
+  assert.ok(Number(said[1]) >= 9, `held-back count too low: ${later[0]}`);
+  assert.ok(Number(said[2]) > 0, `the span it covers must be stated: ${later[0]}`);
+});
+
+test("every level goes through the same rule", () => {
+  const message = unique("levels");
+  const lines = captured(() => {
+    logger.warn(message);
+    logger.warn(message);
+    logger.error(message);
+  });
+  assert.equal(lines.length, 1, "a flood of errors is still a flood");
+});

package/test/priority-map-emptied.test.js

@@ -0,0 +1,207 @@
+/**
+ * @file WHEN NOBODY WANTS A FILE ANY MORE, THE MAP SAYS SO.
+ *
+ * The map is the only statement of what is wanted, and until 2.83.4 it could
+ * make only one of the two statements it exists for. A file whose viewers had
+ * gone was deleted from the orchestrator's own memory and published nowhere, so
+ * the bands it had stated on the swarm's behalf stood until the torrent itself
+ * was removed — read from the demand register, a film nobody had watched for an
+ * hour was indistinguishable from one being watched now.
+ *
+ * Two halves, and both are here: the side that builds the map has to say it,
+ * and the side that receives it has to act on it without needing the file's
+ * length, the torrent's list, or the torrent to exist at all.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { PriorityOrchestrator } from "../services/priority/PriorityOrchestrator.js";
+import { Viewers } from "../services/viewer/Viewers.js";
+import { viewersOf } from "../services/viewer/Viewer.js";
+import { TorrentPool } from "../services/torrent-pool.js";
+import { demandFor, forgetTorrent } from "../services/download/registry.js";
+import { Urgency } from "../services/demand/index.js";
+
+const STALE_AFTER_MS = 60_000;
+
+/**
+ * A session, as much of one as the orchestrator reads.
+ *
+ * @param {{ id: string, fileIndex?: number }} params
+ * @returns {object}
+ */
+function outputOf({ id, fileIndex = 0 }) {
+  return {
+    id,
+    outputKey: `out:${id}`,
+    sourceKey: "source-1",
+    fileIndex,
+    file: { key: `film-${fileIndex}`, durationSeconds: 600 }
+  };
+}
+
+/**
+ * The real orchestrator, with everything it publishes kept.
+ *
+ * @param {object[]} sessions
+ * @returns {{ priority: PriorityOrchestrator, viewers: Viewers, published: object[], publish: (sessions?: object[]) => void }}
+ */
+function over(sessions) {
+  const published = [];
+  const viewers = new Viewers();
+  const priority = new PriorityOrchestrator({
+    publish: (one) => published.push(one),
+    viewersOf: (session) => viewersOf(session),
+    allowanceFor: () => 10
+  });
+  return {
+    priority,
+    viewers,
+    published,
+    publish: (live = sessions) =>
+      priority.publishFor({ sessionGroups: [live], staleAfterMs: STALE_AFTER_MS })
+  };
+}
+
+test("a file whose viewers have all gone is published as wanting nothing", () => {
+  const picture = outputOf({ id: "pic" });
+  const { viewers, published, publish } = over([picture]);
+  const person = viewers.of(picture, "p");
+  person.moveTo(300);
+  publish();
+  assert.ok(published.at(-1).zones.length > 0, "somebody is watching, so something is wanted");
+
+  // They stop answering. The session is still there — it outlives them by half
+  // an hour — so this is the case that used to say nothing at all.
+  person.seen(Date.now() - STALE_AFTER_MS * 2);
+  publish();
+
+  const last = published.at(-1);
+  assert.deepEqual(last.zones, []);
+  assert.equal(last.sourceKey, "source-1");
+  assert.equal(last.fileIndex, 0);
+});
+
+test("a file whose session has gone is published as wanting nothing, once", () => {
+  const picture = outputOf({ id: "pic" });
+  const { viewers, published, publish } = over([picture]);
+  viewers.of(picture, "p").moveTo(300);
+  publish();
+  const said = published.length;
+
+  // The session is disposed: it is not among the live ones any more.
+  publish([]);
+  assert.deepEqual(published.at(-1).zones, []);
+  assert.equal(published.length, said + 1);
+
+  // And it is not repeated on every pass afterwards — the file is gone from
+  // this class's memory, and a departure is said once.
+  publish([]);
+  publish([]);
+  assert.equal(published.length, said + 1);
+});
+
+test("an unchanged map is still not republished", () => {
+  const picture = outputOf({ id: "pic" });
+  const { viewers, published, publish } = over([picture]);
+  viewers.of(picture, "p").moveTo(300);
+  publish();
+  const said = published.length;
+  publish();
+  publish();
+  assert.equal(published.length, said, "the downloading rebuilds its requests on every one");
+});
+
+/** A torrent that is nothing but one file of a known length. */
+function torrentOf({ length = 1_000_000 } = {}) {
+  return {
+    infoHash: `hash-${Math.random().toString(36).slice(2)}`,
+    pieceLength: 1024,
+    files: [{ offset: 0, length, name: "film.mkv" }],
+    _selections: { _items: [] },
+    _select() {},
+    _deselect() {},
+    critical() {}
+  };
+}
+
+const applyPriorityMap = TorrentPool.prototype.applyPriorityMap;
+
+/**
+ * @param {object} torrent
+ * @returns {object[]}
+ */
+function stated(torrent) {
+  return demandFor(torrent)
+    .register.windows()
+    .filter((one) => String(one.claimant).startsWith("priority-map:"));
+}
+
+test("a map with nothing in it withdraws everything that file had stated", () => {
+  const torrent = torrentOf();
+  try {
+    applyPriorityMap.call(null, torrent, 0, [
+      { from: 0, to: 100, priority: 100 },
+      { from: 100, to: 600, priority: 50 }
+    ], 600);
+    assert.equal(stated(torrent).length, 2);
+
+    applyPriorityMap.call(null, torrent, 0, [], 600);
+    assert.equal(stated(torrent).length, 0);
+  } finally {
+    forgetTorrent(torrent);
+  }
+});
+
+test("it withdraws that file's bands and nobody else's", () => {
+  const torrent = torrentOf();
+  try {
+    const { register } = demandFor(torrent);
+    applyPriorityMap.call(null, torrent, 0, [{ from: 0, to: 600, priority: 100 }], 600);
+    // A read stopped on a piece right now, which only a read can say, and the
+    // background fill, which the pool states for itself. Neither is the map's
+    // to withdraw.
+    register.state({
+      claimant: "read-7:blocked",
+      fileIndex: 0,
+      byteStart: 0,
+      byteEnd: 999,
+      urgency: Urgency.BLOCKED
+    });
+    register.state({
+      claimant: "background-fill:0",
+      fileIndex: 0,
+      byteStart: 1000,
+      byteEnd: 9999,
+      urgency: Urgency.TAIL
+    });
+
+    applyPriorityMap.call(null, torrent, 0, [], 600);
+
+    assert.equal(stated(torrent).length, 0);
+    assert.deepEqual(
+      register.windows().map((one) => one.claimant).sort(),
+      ["background-fill:0", "read-7:blocked"]
+    );
+  } finally {
+    forgetTorrent(torrent);
+  }
+});
+
+test("a departure is answered even when nothing else about the file is known", () => {
+  // The length, the duration and the torrent's own list are what the ordinary
+  // path needs to turn seconds into bytes. A departure needs none of them, and
+  // it arrives exactly when they are going away: the map that says it is
+  // published as the last viewer leaves.
+  const torrent = torrentOf();
+  try {
+    applyPriorityMap.call(null, torrent, 0, [{ from: 0, to: 600, priority: 100 }], 600);
+    assert.equal(stated(torrent).length, 1);
+
+    torrent.files = [];
+    applyPriorityMap.call(null, torrent, 0, [], 0);
+    assert.equal(stated(torrent).length, 0);
+  } finally {
+    forgetTorrent(torrent);
+  }
+});