@torrent-tv/proxy 2.83.0 → 2.83.1

package/test/piece-store-never-refuses.test.js

@@ -0,0 +1,153 @@
+/**
+ * @file A store that is short of memory must inconvenience a read, never end a
+ * torrent.
+ *
+ * The field failure of 2026-09-11, in one sentence: the store could not hand
+ * out a block, threw, the throw travelled out through the torrent client's own
+ * write callback, and the client destroyed the torrent. For the rest of the
+ * process every read of that film answered `File 1 not found in
+ * torrent:d4022ff4…`, `/stats` reported `peers=0 connected of 1186 known`, and
+ * the viewer could not open anything until the addon was restarted.
+ *
+ * Three properties hold it shut, and each is checked here on its own:
+ *
+ *  1. an arriving piece is never refused — it has the disk;
+ *  2. a read on the torrent client's own path takes no block at all, so an
+ *     upload can neither wait for memory nor be refused it;
+ *  3. a store between readers keeps room for one window, because that is what
+ *     the next read asks for and the allowance is otherwise re-derived a
+ *     minute later — twelve times slower than a claim gives up.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import fs from "node:fs/promises";
+import os from "node:os";
+import path from "node:path";
+import { SharedPieceStore } from "../services/piece-store/shared-piece-store.js";
+
+const PIECE = 1024;
+
+/**
+ * @param {SharedPieceStore} store
+ * @param {number} index
+ * @returns {Promise<void>}
+ */
+const put = (store, index) =>
+  new Promise((resolve, reject) => {
+    store.put(index, Buffer.alloc(PIECE, index % 251), (error) => (error ? reject(error) : resolve()));
+  });
+
+/**
+ * @param {SharedPieceStore} store
+ * @param {number} index
+ * @param {{ offset: number, length: number }} range
+ * @returns {Promise<Buffer>}
+ */
+const get = (store, index, range) =>
+  new Promise((resolve, reject) => {
+    store.get(index, range, (error, bytes) => (error ? reject(error) : resolve(bytes)));
+  });
+
+/**
+ * @returns {Promise<string>}
+ */
+const directory = () => fs.mkdtemp(path.join(os.tmpdir(), "never-refuses-"));
+
+test("a piece is never refused for want of memory", async () => {
+  const root = await directory();
+  // Every block held by a piece that may not leave. The ceiling never falls
+  // below two, so this is how a store with nothing to give is reached: what
+  // held the blocks in the field was two writes on their way to disk, and a pin
+  // reaches the same state deterministically.
+  //
+  // This one takes the store's own patience to run — it must be seen to give
+  // up and keep the piece anyway.
+  const store = new SharedPieceStore(PIECE, {
+    length: PIECE * 8,
+    memoryBytes: PIECE * 2,
+    path: root,
+    name: "no-block-to-be-had"
+  });
+  try {
+    await put(store, 0);
+    await put(store, 1);
+    store.pin(0);
+    store.pin(1);
+
+    await put(store, 3);
+    const stats = store.stats();
+    assert.equal(stats.spilled, 1, "the piece is on disk");
+    assert.equal(store.locate(3), null, "and not in memory, since no block could be had for it");
+    assert.equal(stats.resident, 2, "the pinned pieces were not taken from under their reader");
+    assert.ok(
+      stats.admittedWithoutSlot >= 1,
+      "and the store says so, rather than the torrent client saying it with a destroyed torrent"
+    );
+    const bytes = await get(store, 3, { offset: 0, length: PIECE });
+    assert.equal(bytes.length, PIECE, "and it reads back");
+    assert.equal(bytes[0], 3 % 251, "with its own contents");
+  } finally {
+    await new Promise((resolve) => store.destroy(resolve));
+    await fs.rm(root, { recursive: true, force: true });
+  }
+});
+
+test("a read for the torrent client takes no block and only its own range", async () => {
+  const root = await directory();
+  const store = new SharedPieceStore(PIECE, {
+    length: PIECE * 8,
+    memoryBytes: PIECE,
+    path: root,
+    name: "ranged-read"
+  });
+  try {
+    // Two fit; the third displaces the oldest, which goes to disk.
+    await put(store, 0);
+    await put(store, 1);
+    await put(store, 2);
+    const before = store.stats();
+    assert.equal(before.spilled, 1, "the first piece is on disk");
+
+    const wanted = 16;
+    const bytes = await get(store, 0, { offset: PIECE - wanted, length: wanted });
+    assert.equal(bytes.length, wanted, "only what was asked for comes back");
+    assert.equal(bytes[0], 0, "and it is that piece's own bytes");
+
+    const after = store.stats();
+    assert.equal(
+      after.blocksAllocated,
+      before.blocksAllocated,
+      "and answering it took no block: a peer asks for kilobytes and a piece here is megabytes"
+    );
+    assert.equal(after.resident, before.resident, "nothing was revived for it");
+    assert.equal(after.fromDisk, before.fromDisk + 1, "and the read is counted as coming from disk");
+  } finally {
+    await new Promise((resolve) => store.destroy(resolve));
+    await fs.rm(root, { recursive: true, force: true });
+  }
+});
+
+test("a store between readers keeps room for one window", async () => {
+  const root = await directory();
+  const store = new SharedPieceStore(PIECE, {
+    length: PIECE * 200,
+    memoryBytes: PIECE * 64,
+    path: root,
+    name: "between-readers"
+  });
+  try {
+    store.protectRange("read-1", 10, 21, 100);
+    const asked = store.wantedBytes;
+    assert.ok(asked >= PIECE * 12, "with a reader, the window it declared is asked for");
+
+    store.releaseProtection("read-1");
+    assert.ok(
+      store.wantedBytes >= PIECE * 12,
+      "and with the reader gone the floor is still one window — the next read asks for the same again"
+    );
+  } finally {
+    await new Promise((resolve) => store.destroy(resolve));
+    await fs.rm(root, { recursive: true, force: true });
+  }
+});

package/test/piece-store-reservations.test.js

@@ -129,10 +129,12 @@ const get = (store, index) =>
  *
  * @param {() => boolean} holds
  * @param {string} what
+ * @param {number} [limit] - A backstop, never the measurement: one of the
+ *   conditions here is the store's own patience, which is itself five seconds.
  * @returns {Promise<void>}
  */
-async function until(holds, what) {
-  const deadline = Date.now() + 5_000;
+async function until(holds, what, limit = 5_000) {
+  const deadline = Date.now() + limit;
   while (!holds()) {
     if (Date.now() > deadline) {
       throw new Error(`timed out waiting until ${what}`);
@@ -196,10 +198,21 @@ test("a claim that cannot be met ends in an error, not in waiting for ever", { t
     // other is pinned. The old rule waited while anything was nominally in
     // flight, which here is for ever.
     store.pin(1);
-    await assert.rejects(() => put(store, 3), /nothing moved/);
+    // The claim gives up within its own patience — that is the property. What
+    // the caller does with the refusal is its own business, and since
+    // 2026-09-11 an arriving piece answers it by taking the disk instead of
+    // failing the torrent client's write.
+    const arriving = put(store, 3);
+    await until(
+      () => store.stats().blockedByPins > 0,
+      "the claim gave up rather than waiting for ever",
+      20_000
+    );
 
     store.unpin(1);
     disk.releaseWrites();
+    await arriving;
+    disk.releaseWrites();
     await spilling;
   } finally {
     disk.releaseWrites();

package/test/probe-wedge-certainty.test.js

@@ -12,7 +12,7 @@ test("a seen-counter bounded lag is not a wedge, however long it lasts", () => {
     stuckForMs: 3400,
     longestHealthySeenGapMs: 3500
   });
-  assert.equal(verdict.certain, false);
+  assert.equal(verdict.isCertain, false);
 });
 
 test("a seen-counter frozen past this connection's own worst legitimate gap is a wedge", () => {
@@ -23,7 +23,7 @@ test("a seen-counter frozen past this connection's own worst legitimate gap is a
     stuckForMs: 90_000,
     longestHealthySeenGapMs: 3500
   });
-  assert.equal(verdict.certain, true);
+  assert.equal(verdict.isCertain, true);
 });
 
 test("with no healthy history yet, one probe interval is still required", () => {
@@ -31,7 +31,7 @@ test("with no healthy history yet, one probe interval is still required", () =>
     stuckForMs: PROBE_INTERVAL_MS - 1,
     longestHealthySeenGapMs: 0
   });
-  assert.equal(verdict.certain, false);
+  assert.equal(verdict.isCertain, false);
   assert.equal(verdict.needMs, PROBE_INTERVAL_MS);
 });
 

package/test/shared-piece-store.test.js

@@ -151,11 +151,16 @@ test("refuses to make room when every resident piece is being read", async () =>
     store.pin(0);
     store.pin(1);
 
-    await assert.rejects(
-      () => put(store, 2, piece(2)),
-      /pinned/,
-      "the store took memory from under a reader instead of refusing"
-    );
+    // The pinned pieces stay where they are, and the arrival is kept anyway —
+    // on the disk, which is what it has. Refusing it was how a store short of
+    // memory ended a torrent: the refusal travelled out through the torrent
+    // client's own write callback and the client destroyed the torrent
+    // (field 2026-09-11).
+    await put(store, 2, piece(2));
+    assert.ok(store.locate(0), "the pinned piece was taken from under its reader");
+    assert.ok(store.locate(1), "the pinned piece was taken from under its reader");
+    assert.equal(store.locate(2), null, "and the arrival did not displace either of them");
+    assert.ok((await get(store, 2)).equals(piece(2)), "the arrival is kept, and reads back");
   } finally {
     store.unpin(0);
     store.unpin(1);
@@ -172,7 +177,7 @@ test("a piece revived from disk is readable by offset again", async () => {
     await put(store, 2, piece(2)); // pushes piece 0 out to disk
     assert.equal(store.locate(0), null, "piece 0 should have left memory");
 
-    await get(store, 0); // brings it back
+    await store.reside(0); // brings it back, which is what a playback read does
     const located = store.locate(0);
     assert.ok(located, "piece 0 was not brought back into memory");
     const view = Buffer.from(located.buffer, located.offset, located.length);
@@ -248,11 +253,18 @@ test("counts where reads were served from, so the budget can be judged", async (
     const stats = store.stats();
     assert.equal(stats.fromMemory, 2, "memory reads miscounted");
     assert.equal(stats.fromDisk, 1, "disk reads miscounted");
-    // Two: piece 0 goes out to make room for piece 2, then piece 1 goes out to
-    // make room for piece 0 coming back. Reviving costs a spill of its own, and
-    // that is worth seeing in the figures rather than hiding.
-    assert.equal(stats.spills, 2, "spills miscounted");
-    assert.equal(stats.revivals, 1, "revivals miscounted");
+    // One: piece 0 goes out to make room for piece 2. The read that follows is
+    // the torrent client's, and since 2026-09-11 it is answered from the disk
+    // copy without taking a block — so nothing has to be written out for it and
+    // nothing is revived. A read for PLAYBACK still populates memory, and pays
+    // for it with a spill; that is the next assertion.
+    assert.equal(stats.spills, 1, "spills miscounted");
+    assert.equal(stats.revivals, 0, "the client's own read does not revive");
+
+    await store.reside(0);
+    const afterPlayback = store.stats();
+    assert.equal(afterPlayback.revivals, 1, "a read for playback revives");
+    assert.equal(afterPlayback.spills, 2, "and pays for its block with a spill");
     assert.equal(stats.blockedByPins, 0);
     assert.equal(stats.capacity, 2);
   } finally {
@@ -268,9 +280,11 @@ test("counts a refusal caused by pinned pieces", async () => {
     await put(store, 1, piece(1));
     store.pin(0);
     store.pin(1);
-    await assert.rejects(() => put(store, 2, piece(2)));
+    await put(store, 2, piece(2));
 
-    assert.equal(store.stats().blockedByPins, 1, "a refusal went unrecorded");
+    const stats = store.stats();
+    assert.equal(stats.blockedByPins, 1, "the store not being able to give a block went unrecorded");
+    assert.equal(stats.admittedWithoutSlot, 1, "and what it did instead went unrecorded");
   } finally {
     store.unpin(0);
     store.unpin(1);

package/test/stream-route.test.js

@@ -10,6 +10,9 @@
 
 import test from "node:test";
 import assert from "node:assert/strict";
+import fs from "node:fs/promises";
+import os from "node:os";
+import path from "node:path";
 import { handleStreamGet } from "../routes/stream/get.js";
 
 /**
@@ -143,3 +146,41 @@ test("a ranged GET is reported as a real read position", async () => {
 
   assert.deepEqual(state.prioritized, [{ byteStart: 4_390_000_000, wholeFileRead: false }]);
 });
+
+test("a file downloaded whole is served from disk without touching the torrent", async () => {
+  const root = await fs.mkdtemp(path.join(os.tmpdir(), "stream-whole-"));
+  const where = path.join(root, "0");
+  const bytes = Buffer.from("a film that is a file now", "utf8");
+  await fs.writeFile(where, bytes);
+  try {
+    const { req, reply, sent, deps } = harness({ method: "GET", range: "bytes=2-6" });
+    let asked = false;
+    deps.torrentPool.getTorrent = async () => {
+      asked = true;
+      throw new Error("the torrent was asked for, which is what this avoids");
+    };
+    deps.torrentPool.wholeFiles = new Map([
+      ["abc/0", { path: where, length: bytes.length, name: "film.mkv" }]
+    ]);
+    // The source key IS the identity — `torrent:<infohash>` — and it is all the
+    // route needs to find the file.
+    deps.sourceRegistry = { get: () => ({ sourceType: "torrent", source: "magnet:?xt=urn:btih:abc" }) };
+    req.query = { sourceKey: "torrent:abc", fileIndex: "0" };
+
+    await handleStreamGet(req, reply, deps);
+
+    assert.equal(asked, false, "the torrent was asked for");
+    assert.equal(sent.code, 206);
+    assert.equal(sent.headers["content-range"], `bytes 2-6/${bytes.length}`);
+    assert.equal(sent.headers["content-length"], "5");
+  } finally {
+    await fs.rm(root, { recursive: true, force: true, maxRetries: 10, retryDelay: 20 });
+  }
+});
+
+test("a file this proxy does not have whole still goes to the torrent", async () => {
+  const { req, reply, state, deps } = harness({ method: "GET", range: "bytes=0-99" });
+  deps.torrentPool.wholeFiles = new Map([["other/7", { path: "/nowhere", length: 1, name: "x" }]]);
+  await handleStreamGet(req, reply, deps);
+  assert.equal(state.claims, 1, "the ordinary path was not taken");
+});

package/test/swarm-follows-readers.test.js

@@ -0,0 +1,126 @@
+/**
+ * @file A proxy that needs nothing from a swarm is not in that swarm.
+ *
+ * WebTorrent enforces `maxConns` only on peers it dials (`_drain`), while
+ * `_addIncomingPeer` checks that the torrent is neither destroyed nor paused
+ * and registers the peer. A proxy with its port mapped is reachable, so
+ * connections arrive and are never turned away — field 2026-09-11: 249
+ * connected at the start of one viewing, 596 at the end, 15 862 more queued, on
+ * a file that had been complete for three quarters of an hour, each connection
+ * served by reading a 4 MB piece off the disk for every 16 KB sent.
+ *
+ * The rule is not a limit on connections. While anybody is reading, every
+ * connection is worth keeping: the one that has delivered nothing yet may
+ * deliver next. It is about a torrent nobody is reading at all.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { TorrentPool } from "../services/torrent-pool.js";
+import { demandFor, forgetTorrent } from "../services/download/registry.js";
+
+/**
+ * A torrent that records what was done to it. Only the surface the rule
+ * touches: `paused` is the library's own flag, and the peers are what the pause
+ * does not close by itself.
+ *
+ * @param {number} peerCount
+ * @returns {object}
+ */
+function torrentWith(peerCount) {
+  const peers = new Map();
+  for (let index = 0; index < peerCount; index += 1) {
+    peers.set(String(index), {
+      wire: { downloaded: 0 },
+      destroy() {
+        peers.delete(String(index));
+      }
+    });
+  }
+  return {
+    infoHash: "f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0",
+    files: [{ length: 1024 }],
+    paused: false,
+    wires: [...peers.values()].map((peer) => peer.wire),
+    _peers: peers,
+    pause() {
+      this.paused = true;
+    },
+    resume() {
+      this.paused = false;
+    }
+  };
+}
+
+/**
+ * @param {object} torrent
+ * @returns {TorrentPool}
+ */
+function poolWith(torrent) {
+  const pool = Object.create(TorrentPool.prototype);
+  pool.torrents = new Map([["source", torrent]]);
+  pool.fileUsageByTorrent = new WeakMap();
+  return pool;
+}
+
+test("a torrent nobody is reading is let go of, and its data is not", () => {
+  const torrent = torrentWith(6);
+  const pool = poolWith(torrent);
+  try {
+    pool.followTheReaders(torrent);
+
+    assert.equal(torrent.paused, true, "the swarm was not left");
+    assert.equal(torrent._peers.size, 0, "the connections the pause does not close were not let go");
+  } finally {
+    forgetTorrent(torrent);
+  }
+});
+
+test("a torrent somebody is reading keeps every connection it has", () => {
+  const torrent = torrentWith(6);
+  const pool = poolWith(torrent);
+  pool.fileUsageByTorrent.set(torrent, new Map([[0, 1]]));
+  try {
+    pool.followTheReaders(torrent);
+
+    assert.equal(torrent.paused, false, "a torrent being read was taken out of its swarm");
+    assert.equal(torrent._peers.size, 6, "connections were closed while somebody was reading");
+  } finally {
+    forgetTorrent(torrent);
+  }
+});
+
+test("a stated window keeps the swarm even with no file held", () => {
+  // The register is what the download layer states; a reader that has declared
+  // a window but not yet taken a file hold is still a reader.
+  const torrent = torrentWith(2);
+  const pool = poolWith(torrent);
+  demandFor(torrent).register.state({
+    claimant: "read-1",
+    fileIndex: 0,
+    byteStart: 0,
+    byteEnd: 1023,
+    urgency: 0
+  });
+  try {
+    pool.followTheReaders(torrent);
+    assert.equal(torrent.paused, false, "a declared window did not count as somebody reading");
+  } finally {
+    forgetTorrent(torrent);
+  }
+});
+
+test("the swarm is rejoined when a reader comes back", () => {
+  const torrent = torrentWith(3);
+  const pool = poolWith(torrent);
+  try {
+    pool.followTheReaders(torrent);
+    assert.equal(torrent.paused, true);
+
+    pool.fileUsageByTorrent.set(torrent, new Map([[0, 1]]));
+    pool.followTheReaders(torrent);
+    assert.equal(torrent.paused, false, "the next reader was left with a torrent that fetches nothing");
+  } finally {
+    forgetTorrent(torrent);
+  }
+});

package/test/swarm-reach.test.js

@@ -25,6 +25,7 @@ test("connected and known are separate numbers", () => {
   const torrent = { wires: [{}, {}], _peersLength: 7, _numQueued: 4 };
   assert.deepEqual(describeSwarmReach(torrent), {
     connectedPeers: 2,
+    deliveringPeers: 0,
     knownPeers: 7,
     queuedPeers: 4
   });
@@ -46,16 +47,19 @@ test("internals that are gone say nothing rather than breaking the poll", () =>
   // cost the field and not the answer.
   assert.deepEqual(describeSwarmReach({ wires: [{}] }), {
     connectedPeers: 1,
+    deliveringPeers: 0,
     knownPeers: null,
     queuedPeers: null
   });
   assert.deepEqual(describeSwarmReach({}), {
     connectedPeers: 0,
+    deliveringPeers: 0,
     knownPeers: null,
     queuedPeers: null
   });
   assert.deepEqual(describeSwarmReach(null), {
     connectedPeers: 0,
+    deliveringPeers: 0,
     knownPeers: null,
     queuedPeers: null
   });
@@ -67,6 +71,7 @@ test("internals that are gone say nothing rather than breaking the poll", () =>
   };
   assert.deepEqual(describeSwarmReach(throwing), {
     connectedPeers: 0,
+    deliveringPeers: 0,
     knownPeers: null,
     queuedPeers: null
   });

package/test/upload-hurry.test.js

@@ -119,3 +119,30 @@ test("a torrent nobody is reading is not treated as starving", () => {
     "a reader that IS waiting must still earn unchoke slots"
   );
 });
+
+test("a torrent short of nothing is not worth uploading for", () => {
+  // Field 2026-09-11: the file being watched was complete, its windows all
+  // present, and the proxy went on offering 512 KB/s to 596 peers for
+  // forty-eight minutes — reading a 4 MB piece off the disk for every 16 KB it
+  // sent. Upload is bought with reciprocity, and reciprocity is only worth
+  // buying while somebody is still short of bytes.
+  const complete = {
+    name: "watched to the end",
+    hasActiveReader: true,
+    hasUnmetDemand: false,
+    done: false,
+    downloadSpeed: 0,
+    wires: [
+      { amInterested: true, peerChoking: true },
+      { amInterested: true, peerChoking: true },
+      { amInterested: true, peerChoking: true }
+    ]
+  };
+  const decided = decideUploadLimit([complete]);
+  assert.equal(decided.bytesPerSec, 8 * 1024, "a complete torrent is given the idle floor");
+  assert.match(decided.reason, /buys nothing/);
+
+  // And a torrent that IS short of something still earns its unchoke.
+  const short = { ...complete, hasUnmetDemand: true };
+  assert.ok(decideUploadLimit([short]).bytesPerSec > 8 * 1024, "a starving torrent still buys reciprocity");
+});