@torrent-tv/proxy 2.80.10 → 2.80.12

package/test/one-authority.test.js

@@ -1,105 +1,220 @@
-/**
- * @file One place decides which encoders exist.
- *
- * Not a check of behaviour but of shape, and it is here because the shape is
- * what failed. Three separate places used to decide where an encoder should
- * work and whether it should go on living, and they disagreed on every pass:
- * measured in the field on 2026-09-05, 684 starts and 660 stops in 482 seconds,
- * of which 294 were one place killing what another had just decided to keep,
- * while the viewer's own segment went unmade for 32.3 seconds.
- *
- * Every rule below is one that was broken then. A reader who needs to add a
- * fourth place should read this file first and then not.
- */
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
-
-const HERE = path.dirname(fileURLToPath(import.meta.url));
-
-/**
- * @param {string} relative
- * @returns {string}
- */
-function source(relative) {
-  return readFileSync(path.join(HERE, "..", relative), "utf8");
-}
-
-/**
- * Lines of code, without comments or blanks: a rule about what the code does
- * must not be answered by what a comment says about it.
- *
- * @param {string} text
- * @returns {string[]}
- */
-function statements(text) {
-  return text
-    .split("\n")
-    .map((line) => line.trim())
-    .filter((line) => line.length > 0 && !line.startsWith("//") && !line.startsWith("*") && !line.startsWith("/*"));
-}
-
-test("an encoder is stopped for scheduling reasons in exactly one place", () => {
-  // The orchestrator decides; nobody else may. What is left in the session
-  // manager is teardown — the session is going away and its encoders with it —
-  // which is not a decision about which encoders should exist.
-  const orchestrator = statements(source("services/orchestrators/EncodeOrchestrator.js"));
-  const stopsInOrchestrator = orchestrator.filter((line) => line.includes("run.stop("));
-  assert.equal(stopsInOrchestrator.length, 1, "the orchestrator stops runs in one place");
-
-  const manager = statements(source("services/hls-session-manager.js"));
-  const stopsInManager = manager.filter((line) => line.includes(".stop("));
-  assert.equal(
-    stopsInManager.length,
-    2,
-    "the session manager stops runs only when a session is torn down: " +
-      stopsInManager.join(" / ")
-  );
-});
-
-test("nothing outside the encoding layer starts an encoder", () => {
-  // A run is built in one place. Two places building them is how a start came
-  // to kill what the plan had decided to keep — the killing lived in the
-  // building.
-  const manager = statements(source("services/hls-session-manager.js"));
-  const builds = manager.filter((line) => line.includes("new EncodeRun("));
-  assert.equal(builds.length, 1, "one place builds an encoder");
-});
-
-test("starting an encoder stops nothing", () => {
-  // The rule that broke it: the start path looked for a live run whose own
-  // start was not below the new one's and killed it. It is not enough that the
-  // line is gone — the words it was written with must not come back.
-  const manager = source("services/hls-session-manager.js");
-  assert.equal(
-    manager.includes("previousRun"),
-    false,
-    "there is no such thing as the previous run: a session holds several"
-  );
-  assert.equal(manager.includes("a new run is taking its place"), false);
-});
-
-test("a seek moves the viewer and nothing else", () => {
-  // It used to do eleven things and write the position into five places. What
-  // follows from a viewer moving is the map's business, and the orchestrators
-  // read the map.
-  const manager = source("services/hls-session-manager.js");
-  const seek = manager.slice(
-    manager.indexOf("requestSeek(sessionId, positionSeconds"),
-    manager.indexOf("requestSeek(sessionId, positionSeconds") + 2000
-  );
-  const body = seek.slice(0, seek.indexOf("\n  }\n"));
-  assert.equal(body.includes("#startEncodeRun"), false, "a seek starts no encoder");
-  assert.equal(body.includes("setTimeout"), false, "and waits for nothing");
-});
-
-test("how far an encoder may work is answered once", () => {
-  // The plan computes the stretch and it reaches ffmpeg. A second computation
-  // somewhere else is what made the first one pointless: it was passed and then
-  // dropped by a parameter list that did not name it.
-  const orchestrator = source("services/orchestrators/EncodeOrchestrator.js");
-  assert.ok(orchestrator.includes("makeRun({ address, from, to })"), "the stretch is handed over");
-});
+/**
+ * @file One place decides which encoders exist.
+ *
+ * Not a check of behaviour but of shape, and it is here because the shape is
+ * what failed. Three separate places used to decide where an encoder should
+ * work and whether it should go on living, and they disagreed on every pass:
+ * measured in the field on 2026-09-05, 684 starts and 660 stops in 482 seconds,
+ * of which 294 were one place killing what another had just decided to keep,
+ * while the viewer's own segment went unmade for 32.3 seconds.
+ *
+ * Every rule below is one that was broken then. A reader who needs to add a
+ * fourth place should read this file first and then not.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { readFileSync } from "node:fs";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+
+const HERE = path.dirname(fileURLToPath(import.meta.url));
+
+/**
+ * @param {string} relative
+ * @returns {string}
+ */
+function source(relative) {
+  return readFileSync(path.join(HERE, "..", relative), "utf8");
+}
+
+/**
+ * Lines of code, without comments or blanks: a rule about what the code does
+ * must not be answered by what a comment says about it.
+ *
+ * @param {string} text
+ * @returns {string[]}
+ */
+function statements(text) {
+  return text
+    .split("\n")
+    .map((line) => line.trim())
+    .filter((line) => line.length > 0 && !line.startsWith("//") && !line.startsWith("*") && !line.startsWith("/*"));
+}
+
+test("an encoder is stopped for scheduling reasons in exactly one place", () => {
+  // The orchestrator decides; nobody else may. What is left in the session
+  // manager is teardown — the session is going away and its encoders with it —
+  // which is not a decision about which encoders should exist.
+  const orchestrator = statements(source("services/orchestrators/EncodeOrchestrator.js"));
+  const stopsInOrchestrator = orchestrator.filter((line) => line.includes("run.stop("));
+  assert.equal(stopsInOrchestrator.length, 1, "the orchestrator stops runs in one place");
+
+  const manager = statements(source("services/hls-session-manager.js"));
+  const stopsInManager = manager.filter((line) => line.includes(".stop("));
+  assert.equal(
+    stopsInManager.length,
+    2,
+    "the session manager stops runs only when a session is torn down: " +
+      stopsInManager.join(" / ")
+  );
+});
+
+test("nothing outside the encoding layer starts an encoder", () => {
+  // A run is built in one place. Two places building them is how a start came
+  // to kill what the plan had decided to keep — the killing lived in the
+  // building.
+  const manager = statements(source("services/hls-session-manager.js"));
+  const builds = manager.filter((line) => line.includes("new EncodeRun("));
+  assert.equal(builds.length, 1, "one place builds an encoder");
+});
+
+test("starting an encoder stops nothing", () => {
+  // The rule that broke it: the start path looked for a live run whose own
+  // start was not below the new one's and killed it. It is not enough that the
+  // line is gone — the words it was written with must not come back.
+  const manager = source("services/hls-session-manager.js");
+  assert.equal(
+    manager.includes("previousRun"),
+    false,
+    "there is no such thing as the previous run: a session holds several"
+  );
+  assert.equal(manager.includes("a new run is taking its place"), false);
+});
+
+test("a seek moves the viewer and nothing else", () => {
+  // It used to do eleven things and write the position into five places. What
+  // follows from a viewer moving is the map's business, and the orchestrators
+  // read the map.
+  const manager = source("services/hls-session-manager.js");
+  const seek = manager.slice(
+    manager.indexOf("requestSeek(sessionId, positionSeconds"),
+    manager.indexOf("requestSeek(sessionId, positionSeconds") + 2000
+  );
+  const body = seek.slice(0, seek.indexOf("\n  }\n"));
+  assert.equal(body.includes("#startEncodeRun"), false, "a seek starts no encoder");
+  assert.equal(body.includes("setTimeout"), false, "and waits for nothing");
+});
+
+test("how far an encoder may work is answered once", () => {
+  // The plan computes the stretch and it reaches ffmpeg. A second computation
+  // somewhere else is what made the first one pointless: it was passed and then
+  // dropped by a parameter list that did not name it.
+  const orchestrator = source("services/orchestrators/EncodeOrchestrator.js");
+  assert.match(
+    orchestrator,
+    /makeRun\(\{ address, from, to, because \}\)/,
+    "the stretch is handed over, and so are the plan's own words for why"
+  );
+});
+
+test("only the plan places an encoder", () => {
+  // The count is the whole of this item. There were eight other places: the
+  // first run of a session, a viewer joining it further in, a rung or a
+  // soundtrack being warmed, one being switched to, a hardware encoder falling
+  // back to software, an input coming back, a cut table correcting itself, and
+  // a settled seek. Each of them chose a position by a rule of its own, and the
+  // plan — which is arithmetic over what is made, what is being made and what is
+  // wanted — was left to compare its answer against theirs.
+  const manager = source("services/hls-session-manager.js");
+  const starts = [...manager.matchAll(/this\.#startEncodeRun\(/g)].length;
+  assert.equal(starts, 1, "one caller, and it is the one the plan asks through");
+  assert.match(
+    manager,
+    /#makeRunAt\(address, from, to, because\)[\s\S]{0,3000}this\.#startEncodeRun\(base, from, because, \{ to \}\)/,
+    "and that caller is what the plan is given to build runs with"
+  );
+});
+
+test("nobody stops an encoder for being unwatched", () => {
+  // Whether an encoder is still wanted is the same question as where one should
+  // be, and the plan answers it: an output with nobody on it has a priority map
+  // with nothing in it. Answered here as well, it was answered twice by two
+  // rules — and since a viewer moving between steps announces itself, the plan
+  // started again what this class had just killed, several times a second.
+  const manager = source("services/hls-session-manager.js");
+  assert.equal(
+    manager.includes("no viewer is watching"),
+    false,
+    "a rung nobody is on is a fact, not an act"
+  );
+  assert.equal(manager.includes("no viewer is listening to audio track"), false);
+  assert.equal(
+    manager.includes("warmed for a switch the viewer did not make"),
+    false,
+    "an abandoned warm-up is a viewer leaving an output"
+  );
+  assert.equal(manager.includes("prepared for a track change the viewer did not make"), false);
+});
+
+test("the seek settle machinery is gone, whole", () => {
+  // A viewer's position is applied the moment they state it. The settle was a
+  // second debounce on a signal the browser had already debounced, and every
+  // millisecond of it was dead time in front of the viewer; the cooldown behind
+  // it existed because segment REQUESTS once steered the encoder.
+  const manager = source("services/hls-session-manager.js");
+  for (const gone of [
+    "seekSettleTimer",
+    "seekTarget",
+    "seekFirstFarAt",
+    "SEEK_SETTLE_MS",
+    "SEEK_SETTLE_MAX_MS",
+    "RESTART_COOLDOWN_MS",
+    "SEEK_BACKOFF_SEGMENTS",
+    "#fireSettledSeek",
+    "#seekSession"
+  ]) {
+    assert.equal(manager.includes(gone), false, `${gone} is gone`);
+  }
+});
+
+test("where a soundtrack begins is read off the table, not handed in", () => {
+  // The instant a number really begins is a fact of the FILE's cutting, held in
+  // the live table every session of the file shares. Passed as an argument by
+  // the one caller that had measured it, only a run started by that caller ever
+  // had it, and a run the plan placed at the same number landed apart again.
+  const manager = source("services/hls-session-manager.js");
+  assert.match(
+    manager,
+    /const positionSecondsOverride = session\.audioOnly === true\s*\n?\s*\? trueStartOf\(session\.timeline, startIndex\)/,
+    "derived where the run is built"
+  );
+  assert.equal(
+    manager.includes("this.#startEncodeRun(member, index, trueStart)"),
+    false,
+    "and not carried in from the correction that measured it"
+  );
+});
+
+test("a changed bitrate cap stops the encoder carrying the old one and nothing more", () => {
+  // An argument list is fixed when a process starts, so a run carrying the
+  // previous cap cannot be told about the new one — that is what is known here.
+  // Where the replacement stands is a different question, and the old answer to
+  // it was neither where a viewer is nor a gap in the material: it was the
+  // segment the process being replaced happened to have reached.
+  const manager = source("services/hls-session-manager.js");
+  assert.equal(manager.includes("#restartAtViewer"), false, "the second answer is gone");
+  assert.match(
+    manager,
+    /#reencodeAtNewRate\(session\) \{\s*\n\s*this\.#stopEncodeRun\(session, "its bitrate cap changed"\);\s*\n\s*this\.planEncodersSoon\(\);\s*\n\s*\}/,
+    "stopped, and then decided again"
+  );
+});
+
+test("each output is handed its own priority map, and the plan is what reads it", () => {
+  // The map is one fact asked at two scopes, and both are right for what asks
+  // them: the swarm is asked for bytes of a FILE, which every output of it
+  // reads, and encoders are placed per OUTPUT, which a person watching 480p
+  // wants nothing of at 1080p.
+  const manager = source("services/hls-session-manager.js");
+  assert.match(
+    manager,
+    /notePriorityMap\([\s\S]{0,200}mapForOutput\(address\)/,
+    "the encoding reads the output's own map"
+  );
+  assert.equal(
+    manager.includes("this.priority.mapFor("),
+    false,
+    "and never the whole film's, which wanted an encoder on every output of it"
+  );
+});

package/test/piece-store-slow-disk.test.js

@@ -23,6 +23,25 @@ import { SharedPieceStore } from "../services/piece-store/shared-piece-store.js"
 
 const PIECE = 1024;
 
+/**
+ * Wait for the thing being asserted, not for a length of time.
+ *
+ * @param {() => boolean} until
+ * @param {string} what - Named in the failure, since a timeout otherwise says
+ *   only that something did not happen.
+ * @param {number} [limit]
+ * @returns {Promise<void>}
+ */
+async function waitFor(until, what, limit = 10_000) {
+  const deadline = Date.now() + limit;
+  while (!until()) {
+    if (Date.now() > deadline) {
+      throw new Error(`${what} never happened`);
+    }
+    await new Promise((resolve) => { setTimeout(resolve, 5); });
+  }
+}
+
 /**
  * A disk that answers only when the test lets it, so writes can be made slower
  * than arrivals on purpose — which is the whole of the field condition.
@@ -85,8 +104,19 @@ test("memory in use never runs past the allowance while the disk is behind", asy
     for (let index = capacity; index < capacity + 40; index += 1) {
       arrivals.push(put(store, index).catch(() => undefined));
     }
-    // Let them get as far as they can with the disk answering nothing.
-    await new Promise((resolve) => setTimeout(resolve, 200));
+    // Until the state being asserted has been reached: a write is outstanding
+    // and admission has waited for the disk rather than evicting. Waited out as
+    // 200 ms instead, this asserted how far the arrivals had got in that time —
+    // and on a machine slow enough that none of them reached a disk write, both
+    // of those figures are zero and the test fails with nothing wrong.
+    //
+    // The bound below is what the wait must NOT decide, so it is checked after
+    // the state is reached rather than after an interval: the store may never
+    // hold more blocks than it is allowed, however many arrivals are in flight.
+    await waitFor(() => {
+      const now = store.stats();
+      return now.blocksInFlight > 0 && now.waitedForDisk > 0;
+    }, "a held write and an admission that waited for it");
 
     const held = store.stats();
     // The check the field failure would fail: a store allowed four pieces held

package/test/priority-map-per-output.test.js

@@ -0,0 +1,211 @@
+/**
+ * @file One fact asked at two scopes: what the swarm is asked for, and what the
+ * encoders are placed by.
+ *
+ * Both are right for what asks them. The swarm is asked for bytes of a FILE,
+ * and the picture, a quality step and a soundtrack of one film read the same
+ * bytes — so every viewer of any of them wants that file's bytes. Encoders are
+ * placed per OUTPUT, and a person watching 480p wants nothing of the 1080p
+ * output at all.
+ *
+ * One map for both was the second authority over encoders. Every output of a
+ * film was handed the whole film's map, so the plan wanted an encoder on every
+ * one of them; what actually stopped the ones nobody was watching was the
+ * session manager killing them by its own judgement — and since a viewer moving
+ * between steps also announces itself, the plan started them again on the next
+ * pass. Field 2026-09-08.
+ *
+ * Built out of the real classes throughout: the real viewer registry holds real
+ * viewers, the real `LiveOutputs` answers what a film's shape is, and the real
+ * `PriorityOrchestrator` builds the maps. A session is a plain object in this
+ * proxy — there is no class for one — so the literals below are the thing
+ * itself and not a stand-in for it.
+ */
+
+import test from "node:test";
+import assert from "node:assert/strict";
+import { PriorityOrchestrator } from "../services/priority/PriorityOrchestrator.js";
+import { LiveOutputs } from "../services/output/LiveOutputs.js";
+import { Viewers } from "../services/viewer/Viewers.js";
+import { viewersOf } from "../services/viewer/Viewer.js";
+import { runsOf } from "../services/priority/PriorityMap.js";
+
+const FILM = { sourceKey: "source-1", fileIndex: 0, durationSeconds: 600 };
+const STALE_AFTER_MS = 60_000;
+
+/**
+ * A session, as much of one as these classes read.
+ *
+ * @param {{ id: string, outputKey: string, isStep?: boolean, audioOnly?: boolean }} params
+ * @returns {object}
+ */
+function outputOf({ id, outputKey, isStep = false, audioOnly = false }) {
+  return {
+    id,
+    outputKey,
+    isStep,
+    audioOnly,
+    state: "ready",
+    sourceKey: FILM.sourceKey,
+    fileIndex: FILM.fileIndex,
+    file: { key: "film-1", durationSeconds: FILM.durationSeconds }
+  };
+}
+
+/**
+ * The real orchestrator over the real registry, wired the way the session
+ * manager wires it.
+ *
+ * @param {object[]} sessions
+ * @returns {{ priority: PriorityOrchestrator, viewers: Viewers, publish: () => void }}
+ */
+function over(sessions) {
+  const live = new LiveOutputs({ sessionsById: new Map(sessions.map((one) => [one.id, one])) });
+  const viewers = new Viewers();
+  const priority = new PriorityOrchestrator({
+    publish: () => {},
+    viewersOf: (session) => viewersOf(session),
+    allowanceFor: () => 10,
+    watchedBy: (session, viewer) => !live.supersededBy(session, viewer.activeVariantId ?? null)
+  });
+  return {
+    priority,
+    viewers,
+    live,
+    publish: () => priority.publishFor({ sessionGroups: [sessions], staleAfterMs: STALE_AFTER_MS })
+  };
+}
+
+test("a person on a step wants nothing of the picture they stepped off", () => {
+  const picture = outputOf({ id: "pic", outputKey: "out:1080" });
+  const step = outputOf({ id: "step", outputKey: "out:480", isStep: true });
+  const { priority, viewers, publish } = over([picture, step]);
+  // ONE viewer object per person, referenced from both outputs — which is why
+  // the step they are on is known when the picture is asked about.
+  viewers.of(picture, "p");
+  const person = viewers.of(step, "p");
+  person.moveTo(300);
+  person.activeVariantId = "step";
+  publish();
+
+  assert.ok(
+    runsOf(priority.mapForOutput("out:480")).length > 0,
+    "the step they are watching is wanted"
+  );
+  assert.deepEqual(
+    runsOf(priority.mapForOutput("out:1080")),
+    [],
+    "and the picture is producing for nobody, which is what makes its encoder unwanted"
+  );
+  // The bytes are another matter: both outputs read the same file, and the
+  // swarm is asked for the file.
+  assert.ok(
+    runsOf(priority.mapFor(FILM.sourceKey, FILM.fileIndex)).length > 0,
+    "the download still wants the film, because that is what is being watched"
+  );
+});
+
+test("a soundtrack is wanted by whoever is registered on it", () => {
+  const picture = outputOf({ id: "pic", outputKey: "out:1080" });
+  const sound = outputOf({ id: "rus", outputKey: "out:a1", audioOnly: true });
+  const { priority, viewers, publish } = over([picture, sound]);
+  // Standing on a STEP of the picture says nothing about the sound: the tracks
+  // nobody chose are let go of where a track is chosen, so being known to a
+  // soundtrack is listening to it.
+  const person = viewers.of(sound, "p");
+  person.moveTo(120);
+  person.activeVariantId = "step";
+  publish();
+
+  assert.ok(runsOf(priority.mapForOutput("out:a1")).length > 0);
+});
+
+test("a step being warmed is wanted, and so is the picture still on screen", () => {
+  // Both are genuinely being produced through a warm-up, which is the price of
+  // the switch not being visible. Whether the machine can afford two encoders
+  // is the budget's question and not this one's.
+  const picture = outputOf({ id: "pic", outputKey: "out:1080" });
+  const step = outputOf({ id: "step", outputKey: "out:480", isStep: true });
+  const { priority, viewers, publish } = over([picture, step]);
+  viewers.of(picture, "p");
+  const person = viewers.of(step, "p");
+  person.moveTo(300);
+  person.warmingVariantId = "step";
+  publish();
+
+  assert.ok(runsOf(priority.mapForOutput("out:1080")).length > 0, "still on screen");
+  assert.ok(runsOf(priority.mapForOutput("out:480")).length > 0, "being made ready");
+});
+
+test("an output everybody has left is stated as empty, not left as it was", () => {
+  // The difference matters: the plan stops the encoders of an output whose map
+  // is empty, and would keep the map it had when somebody was watching.
+  const picture = outputOf({ id: "pic", outputKey: "out:1080" });
+  const { priority, viewers, publish } = over([picture]);
+  viewers.of(picture, "p").moveTo(300);
+
+  publish();
+  assert.ok(runsOf(priority.mapForOutput("out:1080")).length > 0);
+
+  viewers.leaves(picture, "p");
+  publish();
+  assert.deepEqual(runsOf(priority.mapForOutput("out:1080")), []);
+});
+
+test("a viewer nothing has been heard from is not watching anything", () => {
+  // The backstop for a viewer who never said they were leaving: a browser whose
+  // tab is gone releases nothing, and their own silence is what expires.
+  const picture = outputOf({ id: "pic", outputKey: "out:1080" });
+  const live = new LiveOutputs({ sessionsById: new Map([["pic", picture]]) });
+  const viewers = new Viewers();
+  const priority = new PriorityOrchestrator({
+    publish: () => {},
+    viewersOf: (session) => viewersOf(session),
+    allowanceFor: () => 10,
+    watchedBy: (session, viewer) => !live.supersededBy(session, viewer.activeVariantId ?? null)
+  });
+  const person = viewers.of(picture, "p");
+  person.moveTo(300);
+
+  priority.publishFor({
+    sessionGroups: [[picture]],
+    staleAfterMs: STALE_AFTER_MS,
+    now: person.lastSeenAt + STALE_AFTER_MS + 1
+  });
+
+  assert.deepEqual(runsOf(priority.mapForOutput("out:1080")), []);
+});
+
+test("a file and an output that are gone are forgotten", () => {
+  // These are the projection of the live sessions, never a memory of them. Left
+  // to accumulate they were three maps that only grew, and `forget` was written
+  // for that and called from nowhere.
+  const picture = outputOf({ id: "pic", outputKey: "out:1080" });
+  const { priority, viewers, publish } = over([picture]);
+  viewers.of(picture, "p").moveTo(300);
+
+  publish();
+  assert.ok(runsOf(priority.mapForOutput("out:1080")).length > 0);
+
+  priority.publishFor({ sessionGroups: [[]], staleAfterMs: STALE_AFTER_MS });
+  assert.deepEqual(runsOf(priority.mapForOutput("out:1080")), [], "the output is gone");
+  assert.deepEqual(
+    runsOf(priority.mapFor(FILM.sourceKey, FILM.fileIndex)),
+    [],
+    "and so is the file"
+  );
+});
+
+test("the picture is watched by a person who never moved off it", () => {
+  const picture = outputOf({ id: "pic", outputKey: "out:1080" });
+  const { viewers, live } = over([picture]);
+  const person = viewers.of(picture, "p");
+
+  assert.equal(live.supersededBy(picture, null), false, "no step is active");
+  person.activeVariantId = "pic";
+  assert.equal(
+    live.supersededBy(picture, person.activeVariantId),
+    false,
+    "and naming the picture itself as the step is the same statement"
+  );
+});