@toptal/eslint-plugin-davinci 5.4.2-alpha-fix-execute-graphql-command-8169aa3b.95 → 5.4.2

package/lib/rules/consistent-data-testid.js

@@ -5,7 +5,7 @@ const looksLike = require('../utils/looks-like')
 // Examples: certification-item, talent-loader-${state.isLoading}
 const TEST_ID_REGEX = /^[a-z]+(-[a-z0-9]+)*(-\${[a-zA-Z_$][0-9a-zA-Z_$.]*})?$/g
 const NAMING_CONVETNION_DOC_LINK =
-  'https://toptal-core.atlassian.net/l/c/6xX7pSe6'
+  'https://toptal-core.atlassian.net/l/cp/C7cmiiX1'
 const VALID_TEST_ID_METHODS = [
   'getByTestId',
   'getAllByTestId',

package/lib/utils/is-import-path-starts-with-package-name.test.js

@@ -0,0 +1,95 @@
+const isImportPathStartsWithPackageName = require('./is-import-path-starts-with-package-name')
+
+describe('isImportPathStartsWithPackageName', () => {
+  describe('true cases', () => {
+    it.each([
+      {
+        packageName: '@toptal/picasso',
+        importFromPath: '@toptal/picasso',
+      },
+      {
+        packageName: '@toptal/picasso',
+        importFromPath: '@toptal/picasso/test-utils',
+      },
+      {
+        packageName: '@toptal/picasso',
+        importFromPath: '@toptal/picasso/utils',
+      },
+      {
+        packageName: '@toptal/picasso',
+        importFromPath: '@toptal/picasso/TagSelectorInput',
+      },
+      {
+        packageName: 'picasso-package',
+        importFromPath: 'picasso-package/test-utils',
+      },
+      {
+        packageName: 'picasso',
+        importFromPath: 'picasso/TagSelectorInput',
+      },
+      {
+        packageName: 'picasso',
+        importFromPath: 'picasso/TagSelectorInput/utils',
+      },
+      {
+        packageName: 'picasso/sub-package',
+        importFromPath: 'picasso/sub-package/utils',
+      },
+    ])(
+      `import '$importFromPath' comes from the '$packageName'`,
+      ({ packageName, importFromPath }) => {
+        expect(
+          isImportPathStartsWithPackageName(packageName, importFromPath)
+        ).toBe(true)
+      }
+    )
+  })
+
+  describe('false cases', () => {
+    it.each([
+      {
+        packageName: '@toptal/picasso-shared',
+        importFromPath: '@toptal/picasso-not-shared',
+      },
+      {
+        packageName: '@toptal/picasso',
+        importFromPath: '@toptal/picasso-shared',
+      },
+      {
+        packageName: '@toptal/picasso',
+        importFromPath: '@davinci/picasso/test-forms',
+      },
+      {
+        packageName: '@toptal/picasso',
+        importFromPath: '@davinci/picasso',
+      },
+      {
+        packageName: '@toptal/picasso',
+        importFromPath: '@davinci/picasso-shared',
+      },
+      {
+        packageName: 'picasso',
+        importFromPath: 'davinci',
+      },
+      {
+        packageName: 'picasso',
+        importFromPath: 'davinci/cli-shared',
+      },
+      {
+        packageName: 'picasso',
+        importFromPath: '@davinci',
+      },
+      {
+        packageName: 'picasso/sub-package',
+        importFromPath: 'another-package',
+      },
+    ])(
+      `imports '$importFromPath' comes from a package different from '$packageName'`,
+      ({ packageName, importFromPath }) => {
+        expect(
+          isImportPathStartsWithPackageName(packageName, importFromPath)
+        ).toBe(false)
+      }
+    )
+  })
+})

package/lib/utils/resolve-module-path.test.js

@@ -0,0 +1,69 @@
+jest.mock('./require-resolve.js', () => jest.fn())
+
+const resolveModulePath = require('./resolve-module-path')
+const requireResolve = require('./require-resolve')
+
+describe('resolve module path utility', () => {
+  beforeEach(() => {
+    requireResolve.mockReset()
+  })
+
+  it('resolves module path by using requre.resolve in provided path when no aliases provided', () => {
+    const module = 'module'
+    const cwd = 'cwd'
+    const modulePath = 'module-path'
+
+    requireResolve.mockReturnValueOnce(modulePath)
+
+    const result = resolveModulePath(module, cwd)
+
+    expect(result).toBe(modulePath)
+    expect(requireResolve).toHaveBeenCalledWith(module, cwd)
+  })
+
+  it('returns the module path resolved according to the alias map', () => {
+    const module = '@alias/module'
+    const cwd = 'cwd'
+    const aliasModulePath = 'alias-module-path'
+    const aliasMap = {
+      '@alias': aliasModulePath,
+    }
+
+    const result = resolveModulePath(module, cwd, aliasMap)
+
+    expect(result).toBe(`${aliasModulePath}/module`)
+    expect(requireResolve).not.toHaveBeenCalled()
+  })
+
+  it('resolves the module with the last matching alias', () => {
+    const module = '@alias/module'
+    const cwd = 'cwd'
+    const fristAliasModulePath = 'first-alias-module-path'
+    const secondAliasModulePath = 'second-alias-module-path'
+    const aliasMap = {
+      '@': fristAliasModulePath,
+      '@alias': secondAliasModulePath,
+    }
+
+    const result = resolveModulePath(module, cwd, aliasMap)
+
+    expect(result).toBe(`${secondAliasModulePath}/module`)
+    expect(requireResolve).not.toHaveBeenCalled()
+  })
+
+  it('resolves module path by using requre.resolve if no aliases matching the module', () => {
+    const module = 'module'
+    const cwd = 'cwd'
+    const aliasMap = {
+      'other-module': 'some-path',
+    }
+    const modulePath = 'module-path'
+
+    requireResolve.mockReturnValueOnce(modulePath)
+
+    const result = resolveModulePath(module, cwd, aliasMap)
+
+    expect(result).toBe(modulePath)
+    expect(requireResolve).toHaveBeenCalledWith(module, cwd)
+  })
+})

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/eslint-plugin-davinci",
-  "version": "5.4.2-alpha-fix-execute-graphql-command-8169aa3b.95+8169aa3b",
+  "version": "5.4.2",
   "description": "davinci eslint rules",
   "publishConfig": {
     "access": "public"
@@ -41,6 +41,5 @@
     "require-json5": "^1.1.0",
     "requireindex": "^1.2.0",
     "resolve-ts-aliases": "^1.0.1"
-  },
-  "gitHead": "8169aa3bf223d6c1348d45f5ce4706768a091104"
+  }
 }