@toptal/davinci-syntax 24.0.0 → 24.0.1-alpha-feature-typescript-5.5-f29e7d47.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/davinci-syntax",
-  "version": "24.0.0",
+  "version": "24.0.1-alpha-feature-typescript-5.5-f29e7d47.9+f29e7d47",
   "keywords": [
     "lint"
   ],
@@ -25,16 +25,25 @@
     "docs",
     "CHANGELOG.md"
   ],
+  "scripts": {
+    "lint": "pnpm run lint:path .",
+    "lint:path": "eslint --ext=.js,.jsx,.ts,.tsx --color --fix",
+    "test": "NODE_OPTIONS='--experimental-vm-modules --no-warnings' pnpm jest"
+  },
   "dependencies": {
     "@stylelint/postcss-css-in-js": "^0.38.0",
-    "@typescript-eslint/eslint-plugin": "^6.7.3",
-    "@typescript-eslint/parser": "^6.7.3",
-    "eslint": "^8.34.0",
+    "@toptal/davinci-cli-shared": "^3.0.1-alpha-feature-typescript-5.5-f29e7d47.9+f29e7d47",
+    "@toptal/davinci-dir-lint": "^2.0.1-alpha-feature-typescript-5.5-f29e7d47.9+f29e7d47",
+    "@toptal/eslint-plugin-davinci": "^6.0.1-alpha-feature-typescript-5.5-f29e7d47.9+f29e7d47",
+    "@toptal/stylelint-plugin-davinci": "^2.0.1-alpha-feature-typescript-5.5-f29e7d47.9+f29e7d47",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-config-prettier-standard": "^4.0.1",
     "eslint-plugin-cypress": "^2.13.3",
     "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-jest": "^27.6.2",
+    "eslint-plugin-jest": "^28.8.0",
     "eslint-plugin-jest-formatting": "^3.1.0",
     "eslint-plugin-no-inline-styles": "^1.0.5",
     "eslint-plugin-node": "^11.1.0",
@@ -43,7 +52,7 @@
     "eslint-plugin-react": "^7.30.1",
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-todo-plz": "^1.3.0",
-    "eslint-plugin-unused-imports": "3.0.0",
+    "eslint-plugin-unused-imports": "^4.1.0",
     "husky": "^8.0.2",
     "lint-staged": "^15.2.9",
     "postcss-syntax": "^0.36.2",
@@ -51,18 +60,14 @@
     "prettier-config-standard": "^5.0.0",
     "stylelint": "^15.11.0",
     "stylelint-config-standard": "^34.0.0",
-    "stylelint-config-styled-components": "^0.1.1",
-    "@toptal/davinci-cli-shared": "^3.0.0",
-    "@toptal/eslint-plugin-davinci": "^6.0.0",
-    "@toptal/davinci-dir-lint": "^2.0.0",
-    "@toptal/stylelint-plugin-davinci": "^2.0.0"
+    "stylelint-config-styled-components": "^0.1.1"
   },
   "devDependencies": {
     "@jest/globals": "^29.7.0",
     "json5": "^2.2.3"
   },
   "peerDependencies": {
-    "typescript": "^4.8.4"
+    "typescript": "^5.5.0"
   },
   "engines": {
     "node": ">=18.12.0"
@@ -70,9 +75,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "scripts": {
-    "lint": "pnpm run lint:path .",
-    "lint:path": "eslint --ext=.js,.jsx,.ts,.tsx --color --fix",
-    "test": "NODE_OPTIONS='--experimental-vm-modules --no-warnings' pnpm jest"
-  }
-}
+  "gitHead": "f29e7d47bc671263a434ee69d6ad9744636531d0"
+}

package/src/__tests__/__snapshots__/eslint.test.ts.snap

@@ -5,14 +5,6 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'space-before-function-paren': [
     'off',
   ],
-  '@typescript-eslint/space-before-function-paren': [
-    'error',
-    {
-      anonymous: 'always',
-      named: 'never',
-      asyncArrow: 'always',
-    },
-  ],
   'padding-line-between-statements': [
     'error',
     {
@@ -236,7 +228,7 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@typescript-eslint/explicit-member-accessibility': [
     'off',
   ],
-  '@typescript-eslint/no-var-requires': [
+  '@typescript-eslint/no-require-imports': [
     'off',
   ],
   'no-use-before-define': [
@@ -260,9 +252,6 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@typescript-eslint/no-empty-interface': [
     'off',
   ],
-  '@typescript-eslint/member-delimiter-style': [
-    'off',
-  ],
   'no-shadow': [
     'off',
   ],
@@ -284,9 +273,6 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'func-call-spacing': [
     'off',
   ],
-  '@typescript-eslint/func-call-spacing': [
-    'error',
-  ],
   'no-unused-expressions': [
     'off',
   ],
@@ -296,16 +282,11 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@typescript-eslint/no-empty-function': [
     'off',
   ],
-  '@typescript-eslint/ban-types': [
-    'error',
-    {
-      extendDefaults: true,
-      types: {
-        '{}': false,
-        Function: false,
-        object: false,
-      },
-    },
+  '@typescript-eslint/no-empty-object-type': [
+    'off',
+  ],
+  '@typescript-eslint/no-unsafe-function-type': [
+    'off',
   ],
   '@typescript-eslint/consistent-type-assertions': [
     'off',
@@ -416,19 +397,6 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'comma-dangle': [
     'off',
   ],
-  '@typescript-eslint/comma-dangle': [
-    'error',
-    {
-      arrays: 'always-multiline',
-      objects: 'always-multiline',
-      imports: 'always-multiline',
-      exports: 'always-multiline',
-      functions: 'never',
-      enums: 'always-multiline',
-      generics: 'ignore',
-      tuples: 'never',
-    },
-  ],
   '@typescript-eslint/consistent-type-imports': [
     'error',
     {
@@ -646,9 +614,15 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@typescript-eslint/brace-style': [
     'off',
   ],
+  '@typescript-eslint/comma-dangle': [
+    'off',
+  ],
   '@typescript-eslint/comma-spacing': [
     'off',
   ],
+  '@typescript-eslint/func-call-spacing': [
+    'off',
+  ],
   '@typescript-eslint/indent': [
     'off',
   ],
@@ -658,6 +632,9 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@typescript-eslint/keyword-spacing': [
     'off',
   ],
+  '@typescript-eslint/member-delimiter-style': [
+    'off',
+  ],
   '@typescript-eslint/no-extra-parens': [
     'off',
   ],
@@ -673,6 +650,9 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@typescript-eslint/space-before-blocks': [
     'off',
   ],
+  '@typescript-eslint/space-before-function-paren': [
+    'off',
+  ],
   '@typescript-eslint/space-infix-ops': [
     'off',
   ],
@@ -976,9 +956,6 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@typescript-eslint/prefer-function-type': [
     'error',
   ],
-  '@typescript-eslint/prefer-namespace-keyword': [
-    'error',
-  ],
   'no-array-constructor': [
     'off',
   ],
@@ -991,12 +968,6 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@typescript-eslint/no-extra-non-null-assertion': [
     'error',
   ],
-  'no-loss-of-precision': [
-    'off',
-  ],
-  '@typescript-eslint/no-loss-of-precision': [
-    'error',
-  ],
   '@typescript-eslint/no-misused-new': [
     'error',
   ],
@@ -1012,9 +983,15 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@typescript-eslint/no-unsafe-declaration-merging': [
     'error',
   ],
+  '@typescript-eslint/no-wrapper-object-types': [
+    'error',
+  ],
   '@typescript-eslint/prefer-as-const': [
     'error',
   ],
+  '@typescript-eslint/prefer-namespace-keyword': [
+    'error',
+  ],
   '@typescript-eslint/triple-slash-reference': [
     'error',
   ],
@@ -1108,6 +1085,9 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'no-irregular-whitespace': [
     'error',
   ],
+  'no-loss-of-precision': [
+    'error',
+  ],
   'no-misleading-character-class': [
     'error',
   ],

package/src/__tests__/eslint.test.ts

@@ -75,19 +75,6 @@ describe('eslint rules', () => {
     })
   }
 
-  testRule({
-    ruleId: '@typescript-eslint/space-before-function-paren',
-    invalidCases: [
-      'function withoutSpace (x) {}',
-      'var anonymousWithoutSpace = function() {};',
-    ],
-    validCases: [
-      'function withoutSpace(x) {}',
-      'var anonymousWithoutSpace = function () {};',
-      'var anonymousWithoutSpace = function <T>() {};',
-    ],
-  })
-
   testRule({
     ruleId: 'padding-line-between-statements',
     invalidCases: [
@@ -242,12 +229,6 @@ describe('eslint rules', () => {
     ],
   })
 
-  testRule({
-    ruleId: '@typescript-eslint/func-call-spacing',
-    invalidCases: ['foo ()', 'foo<T> ()'],
-    validCases: ['foo()', 'foo<T>()'],
-  })
-
   testRule({
     ruleId: '@typescript-eslint/no-unused-expressions',
     invalidCases: ['if (0) null'],
@@ -255,13 +236,18 @@ describe('eslint rules', () => {
   })
 
   testRule({
-    ruleId: '@typescript-eslint/ban-types',
+    ruleId: '@typescript-eslint/no-wrapper-object-types',
     invalidCases: [`const foo: String = 'foo'`, 'const foo: Number = 1'],
-    validCases: [
-      'const foo: Function = () => 1',
-      'const foo: object = {}',
-      'const foo: {} = {}',
-    ],
+  })
+
+  testRule({
+    ruleId: '@typescript-eslint/no-unsafe-function-type',
+    validCases: ['const foo: Function = () => 1'],
+  })
+
+  testRule({
+    ruleId: '@typescript-eslint/no-empty-object-type',
+    validCases: ['const foo: {} = {}'],
   })
 
   testRule({

package/src/configs/.eslintrc.cjs

@@ -64,16 +64,7 @@ module.exports = {
     },
   },
   rules: {
-    // override standard - allows function foo() {} instead of function foo () {}
     'space-before-function-paren': 'off',
-    '@typescript-eslint/space-before-function-paren': [
-      'error',
-      {
-        anonymous: 'always',
-        named: 'never',
-        asyncArrow: 'always',
-      },
-    ],
     // newlines between variable declarations, returns, if blocks
     'padding-line-between-statements': [
       'error',
@@ -233,7 +224,7 @@ module.exports = {
     // already covered by @typescript-eslint/no-non-null-assertion
     '@typescript-eslint/no-non-null-asserted-optional-chain': 'off',
     '@typescript-eslint/explicit-member-accessibility': 'off',
-    '@typescript-eslint/no-var-requires': 'off',
+    '@typescript-eslint/no-require-imports': 'off',
     // must be turned off in favor of typescript-eslint/no-use-before-define
     'no-use-before-define': 'off',
     '@typescript-eslint/no-use-before-define': [
@@ -248,7 +239,6 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'warn',
     '@typescript-eslint/ban-ts-comment': 'warn',
     '@typescript-eslint/no-empty-interface': 'off',
-    '@typescript-eslint/member-delimiter-style': 'off',
     // must be turned off in favor of typescript-eslint/no-shadow
     'no-shadow': 'off',
     '@typescript-eslint/no-shadow': ['warn'],
@@ -258,24 +248,13 @@ module.exports = {
     // must be turned off in favor of typescript-eslint/no-unused-vars
     'no-unused-vars': 'off',
     '@typescript-eslint/no-unused-vars': 'error',
-    // must be turned off in favor of typescript-eslint/func-call-spacing
     'func-call-spacing': 'off',
-    '@typescript-eslint/func-call-spacing': 'error',
     // must be turned off in favor of typescript-eslint/no-unused-expressions
     'no-unused-expressions': 'off',
     '@typescript-eslint/no-unused-expressions': ['error'],
     '@typescript-eslint/no-empty-function': 'off',
-    '@typescript-eslint/ban-types': [
-      'error',
-      {
-        extendDefaults: true,
-        types: {
-          '{}': false,
-          Function: false,
-          object: false,
-        },
-      },
-    ],
+    '@typescript-eslint/no-empty-object-type': 'off',
+    '@typescript-eslint/no-unsafe-function-type': 'off',
     '@typescript-eslint/consistent-type-assertions': 'off',
     '@typescript-eslint/consistent-type-definitions': 'off',
     '@typescript-eslint/consistent-indexed-object-style': 'off',
@@ -351,20 +330,7 @@ module.exports = {
           'Please add either a full URL to Jira issue or a short form: [ABC-1234] ',
       },
     ],
-    'comma-dangle': 'off', // Turned off in favor of the typescript-eslint alternative
-    '@typescript-eslint/comma-dangle': [
-      'error',
-      {
-        arrays: 'always-multiline',
-        objects: 'always-multiline',
-        imports: 'always-multiline',
-        exports: 'always-multiline',
-        functions: 'never',
-        enums: 'always-multiline',
-        generics: 'ignore',
-        tuples: 'never',
-      },
-    ],
+    'comma-dangle': 'off',
     '@typescript-eslint/consistent-type-imports': [
       'error',
       {
@@ -445,6 +411,7 @@ module.exports = {
       parser: 'eslint-plugin-markdownlint/parser',
       rules: {
         '@toptal/davinci/consistent-changesets': 'error',
+        '@typescript-eslint/consistent-type-imports': 'off',
       },
     },
   ],