@toptal/davinci-syntax 23.1.6 → 24.0.1-alpha-ff-79-27a22fcb.1

package/CHANGELOG.md

@@ -1,5 +1,30 @@
 # Change Log
 
+## 24.0.0
+
+### Major Changes
+
+- [#2643](https://github.com/toptal/davinci/pull/2643) [`ab9666f`](https://github.com/toptal/davinci/commit/ab9666f999e7a610f6068e0145200257d8511b46) Thanks [@rocodesign](https://github.com/rocodesign)!
+  Migrate package manager from Yarn to pnpm
+  **WHAT (breaking change):**
+  - switch package manager from Yarn to pnpm across the entire Davinci monorepo
+  - add `pnpm-workspace.yaml`, `.npmrc`, and `packageManager` field for corepack support
+  - convert Yarn `resolutions` to `pnpm.overrides` in root `package.json`
+  - update lerna `npmClient` from `yarn` to `pnpm`
+  - replace `yarn` with `pnpm` in root scripts (postinstall, test, test:unit:update)
+  **HOW to update:**
+  - install pnpm (`corepack enable` or `npm install -g pnpm@10.6.1`)
+  - replace `yarn install` with `pnpm install` in local workflows
+  - replace `yarn <script>` with `pnpm <script>` when running commands
+
+### Patch Changes
+
+- Updated dependencies [[`ab9666f`](https://github.com/toptal/davinci/commit/ab9666f999e7a610f6068e0145200257d8511b46)]:
+  - @toptal/davinci-cli-shared@3.0.0
+  - @toptal/davinci-dir-lint@2.0.0
+  - @toptal/eslint-plugin-davinci@6.0.0
+  - @toptal/stylelint-plugin-davinci@2.0.0
+
 ## 23.1.6
 
 ### Patch Changes

package/README.md

@@ -4,7 +4,7 @@ Helps to check the style of your code. Provides basic linting, prettier function
 
 ## Usage
 
-Use it by installing `yarn add @toptal/davinci-syntax` in your project.
+Use it by installing `pnpm add @toptal/davinci-syntax` in your project.
 
 #### Commands
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/davinci-syntax",
-  "version": "23.1.6",
+  "version": "24.0.1-alpha-ff-79-27a22fcb.1+27a22fcb",
   "keywords": [
     "lint"
   ],
@@ -26,16 +26,16 @@
     "CHANGELOG.md"
   ],
   "scripts": {
-    "lint": "yarn run lint:path .",
+    "lint": "pnpm run lint:path .",
     "lint:path": "eslint --ext=.js,.jsx,.ts,.tsx --color --fix",
-    "test": "NODE_OPTIONS='--experimental-vm-modules --no-warnings' yarn jest"
+    "test": "NODE_OPTIONS='--experimental-vm-modules --no-warnings' pnpm jest"
   },
   "dependencies": {
     "@stylelint/postcss-css-in-js": "^0.38.0",
-    "@toptal/davinci-cli-shared": "^2.6.1",
-    "@toptal/davinci-dir-lint": "^1.0.0",
-    "@toptal/eslint-plugin-davinci": "5.7.1",
-    "@toptal/stylelint-plugin-davinci": "1.0.0",
+    "@toptal/davinci-cli-shared": "^3.0.1-alpha-ff-79-27a22fcb.1+27a22fcb",
+    "@toptal/davinci-dir-lint": "^2.0.1-alpha-ff-79-27a22fcb.1+27a22fcb",
+    "@toptal/eslint-plugin-davinci": "^6.0.1-alpha-ff-79-27a22fcb.1+27a22fcb",
+    "@toptal/stylelint-plugin-davinci": "^2.0.1-alpha-ff-79-27a22fcb.1+27a22fcb",
     "@typescript-eslint/eslint-plugin": "^6.7.3",
     "@typescript-eslint/parser": "^6.7.3",
     "eslint": "^8.34.0",
@@ -74,5 +74,6 @@
   },
   "publishConfig": {
     "access": "public"
-  }
+  },
+  "gitHead": "27a22fcb012002a99ab87a4a996721e3ba8a92c4"
 }

package/src/__tests__/__snapshots__/eslint.test.ts.snap

@@ -177,6 +177,8 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
       ],
       'newlines-between': 'always',
       distinctGroup: true,
+      sortTypesGroup: false,
+      named: false,
       warnOnUnassignedImports: false,
     },
   ],
@@ -452,6 +454,9 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'no-unexpected-multiline': [
     0,
   ],
+  '@typescript-eslint/lines-around-comment': [
+    0,
+  ],
   '@typescript-eslint/quotes': [
     0,
   ],
@@ -506,9 +511,6 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'function-paren-newline': [
     'off',
   ],
-  'generator-star': [
-    'off',
-  ],
   'generator-star-spacing': [
     'off',
   ],
@@ -539,12 +541,6 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'new-parens': [
     'off',
   ],
-  'no-arrow-condition': [
-    'off',
-  ],
-  'no-comma-dangle': [
-    'off',
-  ],
   'no-extra-parens': [
     'off',
   ],
@@ -563,21 +559,12 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'no-multiple-empty-lines': [
     'off',
   ],
-  'no-reserved-keys': [
-    'off',
-  ],
-  'no-space-before-semi': [
-    'off',
-  ],
   'no-trailing-spaces': [
     'off',
   ],
   'no-whitespace-before-property': [
     'off',
   ],
-  'no-wrap-func': [
-    'off',
-  ],
   'nonblock-statement-body-position': [
     'off',
   ],
@@ -614,39 +601,18 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'semi-style': [
     'off',
   ],
-  'space-after-function-name': [
-    'off',
-  ],
-  'space-after-keywords': [
-    'off',
-  ],
   'space-before-blocks': [
     'off',
   ],
-  'space-before-function-parentheses': [
-    'off',
-  ],
-  'space-before-keywords': [
-    'off',
-  ],
-  'space-in-brackets': [
-    'off',
-  ],
   'space-in-parens': [
     'off',
   ],
   'space-infix-ops': [
     'off',
   ],
-  'space-return-throw-case': [
-    'off',
-  ],
   'space-unary-ops': [
     'off',
   ],
-  'space-unary-word-ops': [
-    'off',
-  ],
   'switch-colon-spacing': [
     'off',
   ],
@@ -674,6 +640,9 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@babel/semi': [
     'off',
   ],
+  '@typescript-eslint/block-spacing': [
+    'off',
+  ],
   '@typescript-eslint/brace-style': [
     'off',
   ],
@@ -683,6 +652,9 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   '@typescript-eslint/indent': [
     'off',
   ],
+  '@typescript-eslint/key-spacing': [
+    'off',
+  ],
   '@typescript-eslint/keyword-spacing': [
     'off',
   ],
@@ -812,6 +784,9 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'vue/array-bracket-spacing': [
     'off',
   ],
+  'vue/array-element-newline': [
+    'off',
+  ],
   'vue/arrow-spacing': [
     'off',
   ],
@@ -866,6 +841,9 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'vue/multiline-html-element-content-newline': [
     'off',
   ],
+  'vue/multiline-ternary': [
+    'off',
+  ],
   'vue/mustache-interpolation-spacing': [
     'off',
   ],
@@ -911,12 +889,51 @@ exports[`eslint config verifies eslint rules are not updated silently 1`] = `
   'vue/template-curly-spacing': [
     'off',
   ],
+  'generator-star': [
+    'off',
+  ],
   'indent-legacy': [
     'off',
   ],
+  'no-arrow-condition': [
+    'off',
+  ],
+  'no-comma-dangle': [
+    'off',
+  ],
+  'no-reserved-keys': [
+    'off',
+  ],
+  'no-space-before-semi': [
+    'off',
+  ],
   'no-spaced-func': [
     'off',
   ],
+  'no-wrap-func': [
+    'off',
+  ],
+  'space-after-function-name': [
+    'off',
+  ],
+  'space-after-keywords': [
+    'off',
+  ],
+  'space-before-function-parentheses': [
+    'off',
+  ],
+  'space-before-keywords': [
+    'off',
+  ],
+  'space-in-brackets': [
+    'off',
+  ],
+  'space-return-throw-case': [
+    'off',
+  ],
+  'space-unary-word-ops': [
+    'off',
+  ],
   'react/jsx-space-before-closing': [
     'off',
   ],

package/src/commands/lint-code.js

@@ -1,4 +1,6 @@
-import { runSync, print } from '@toptal/davinci-cli-shared'
+import { runSync, print, resolveBin } from '@toptal/davinci-cli-shared'
+
+const eslintBin = resolveBin('eslint', import.meta.url)
 
 const lintCodeCommand = (paths, options) => {
   print.header('Running code checks')
@@ -6,14 +8,10 @@ const lintCodeCommand = (paths, options) => {
   const { check, ext, color } = options
 
   runSync(
-    'yarn',
-    [
-      'eslint',
-      `--ext=${ext}`,
-      `--color=${color}`,
-      !check && '--fix',
-      ...paths,
-    ].filter(Boolean)
+    eslintBin,
+    [`--ext=${ext}`, `--color=${color}`, !check && '--fix', ...paths].filter(
+      Boolean
+    )
   )
 }
 

package/src/commands/lint-code.test.js

@@ -3,8 +3,11 @@ import { jest } from '@jest/globals'
 // eslint-disable-next-line import/no-extraneous-dependencies
 import { Command } from 'commander'
 
+const MOCK_ESLINT_BIN = '/resolved/eslint/bin/eslint.js'
+
 jest.unstable_mockModule('@toptal/davinci-cli-shared', () => ({
   runSync: jest.fn(),
+  resolveBin: jest.fn(() => MOCK_ESLINT_BIN),
   print: {
     header: jest.fn(),
   },
@@ -42,8 +45,7 @@ describe('createLintCodeCommand', () => {
 
     command.parse(argv)
 
-    expect(runSync).toHaveBeenCalledWith('yarn', [
-      'eslint',
+    expect(runSync).toHaveBeenCalledWith(MOCK_ESLINT_BIN, [
       '--ext=.js,.jsx,.ts,.tsx',
       '--color=true',
       'file1',
@@ -56,8 +58,8 @@ describe('createLintCodeCommand', () => {
       label: 'handles --check',
       input: ['node', 'code', '--check', 'file1', 'file2'],
       output: [
-        'yarn',
-        ['eslint', '--ext=.js,.jsx,.ts,.tsx', '--color=true', 'file1', 'file2'],
+        MOCK_ESLINT_BIN,
+        ['--ext=.js,.jsx,.ts,.tsx', '--color=true', 'file1', 'file2'],
       ],
     },
     {
@@ -71,9 +73,8 @@ describe('createLintCodeCommand', () => {
         'file2',
       ],
       output: [
-        'yarn',
+        MOCK_ESLINT_BIN,
         [
-          'eslint',
           '--ext=.js,.jsx,.ts,.tsx',
           '--color=true',
           '--fix',
@@ -88,9 +89,8 @@ describe('createLintCodeCommand', () => {
       label: 'handles external options',
       input: ['node', 'code', '-c', 'eslintrc_base', '.'],
       output: [
-        'yarn',
+        MOCK_ESLINT_BIN,
         [
-          'eslint',
           '--ext=.js,.jsx,.ts,.tsx',
           '--color=true',
           '--fix',
@@ -108,9 +108,8 @@ describe('createLintCodeCommand', () => {
         "'{hosts,libs,namespaces}/**/{src,cypress}/**/*.{js,jsx,ts,tsx,gql}'",
       ],
       output: [
-        'yarn',
+        MOCK_ESLINT_BIN,
         [
-          'eslint',
           '--ext=.js,.jsx,.ts,.tsx',
           '--color=true',
           '--fix',

package/src/commands/lint-styles.js

@@ -1,5 +1,7 @@
 import path from 'path'
-import { runSync, print } from '@toptal/davinci-cli-shared'
+import { runSync, print, resolveBin } from '@toptal/davinci-cli-shared'
+
+const stylelintBin = resolveBin('stylelint', import.meta.url)
 
 const lintStylesCommand = (dir, options) => {
   print.header('Running styles checks', dir)
@@ -9,9 +11,8 @@ const lintStylesCommand = (dir, options) => {
   const hasExtension = path.extname(dir)
 
   runSync(
-    'yarn',
+    stylelintBin,
     [
-      'stylelint',
       '--allow-empty-input',
       options.mw && ['--max-warnings', options.mw].join('='),
       hasExtension ? dir : `${dir}/**/styles.(js|jsx|ts|tsx)`,

package/src/configs/.eslintrc.cjs

@@ -1,8 +1,13 @@
 /* eslint-disable max-lines */
 
+const { createRequire } = require('module')
+const path = require('path')
+
+const projectRequire = createRequire(path.join(process.cwd(), 'package.json'))
+
 const projectHasPackage = pkg => {
   try {
-    require.resolve(pkg)
+    projectRequire.resolve(pkg)
 
     return true
   } catch {