@toptal/davinci-monorepo 7.0.5 → 7.1.0

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @toptal/davinci-monorepo
 
+## 7.1.0
+
+### Minor Changes
+
+- [#1876](https://github.com/toptal/davinci/pull/1876) [`0346b98e`](https://github.com/toptal/davinci/commit/0346b98ec60a105fed14dae179ac2dff0f7b99a0) Thanks [@OndrejTuma](https://github.com/OndrejTuma)! - ---
+
+  - add optional `--webpack-config` flag to `graph generate` command
+
 ## 7.0.5
 
 ### Patch Changes

package/bin/davinci-monorepo.js

@@ -3,12 +3,11 @@
 import cliEngine from '@toptal/davinci-cli-shared'
 
 import detectCircularityCommand from '../src/commands/detect-circularity.js'
-import graphGenerateCommand from '../src/commands/graph-generate.js'
+import { createGraphGenerateCommand } from '../src/commands/graph-generate.js'
 import metricsCommand from '../src/commands/metrics.js'
 
-cliEngine.loadCommands([
-  detectCircularityCommand,
-  graphGenerateCommand,
-  metricsCommand,
-], 'davinci-monorepo')
+cliEngine.loadCommands(
+  [detectCircularityCommand, createGraphGenerateCommand, metricsCommand],
+  'davinci-monorepo'
+)
 cliEngine.bootstrap()

package/docs/graph-generate.md

@@ -24,10 +24,11 @@ davinci-monorepo graph generate [options]
 ### Options
 
 | Option            | Default            | Description                                      |
-| ----------------- | ------------------ | ------------------------------------------------ |
+| ----------------- | ------------------ |--------------------------------------------------|
 | -o, --output-file | monorepo-graph.svg | Name of the output file (.svg)                   |
 | --ts-config       | tsconfig.json      | Name of the tsconfig file                        |
 | -d, --diff        |                    | Base branch to use for showing affected packages |
+| --webpack-config  |                    | Use a webpack configuration                      |
 
 ## FAQs
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/davinci-monorepo",
-  "version": "7.0.5",
+  "version": "7.1.0",
   "description": "Monorepo utility tools",
   "publishConfig": {
     "access": "public"
@@ -39,7 +39,6 @@
     "dependency-cruiser": "^12.5.0",
     "execa": "^5.1.1",
     "glob": "^8.0.3",
-    "ora": "^5.4.1",
     "ramda": "^0.28.0"
   },
   "devDependencies": {

package/src/commands/__snapshots__/graph-generate.test.js.snap

@@ -1,39 +1,116 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`graphGenerateCommandCreator has the correct command structure 1`] = `
-{
-  "action": [Function],
-  "args": [
-    Argument {
-      "_name": "command",
-      "argChoices": [
-        "generate",
-      ],
-      "defaultValue": undefined,
-      "defaultValueDescription": undefined,
-      "description": "Graph related command to execute",
-      "parseArg": [Function],
-      "required": true,
-      "variadic": false,
-    },
-  ],
-  "command": "graph",
-  "description": "Generate dependency graph in a monorepo",
+exports[`createGraphGenerateCommand has the correct command structure 1`] = `
+"{
+  "_events": {},
+  "_eventsCount": 4,
+  "commands": [],
   "options": [
     {
-      "default": "monorepo-graph.svg",
-      "label": "Output file name. Default is monorepo-graph.svg",
-      "name": "-o, --output-file [outputFile]",
+      "flags": "-o, --output-file [outputFile]",
+      "description": "Output file name. Default is monorepo-graph.svg",
+      "required": false,
+      "optional": true,
+      "variadic": false,
+      "mandatory": false,
+      "short": "-o",
+      "long": "--output-file",
+      "negate": false,
+      "defaultValue": "monorepo-graph.svg",
+      "hidden": false,
+      "conflictsWith": []
     },
     {
-      "default": "tsconfig.json",
-      "label": "Path to typescript configuration file. Default is tsconfig.json",
-      "name": "--ts-config [tsConfig]",
+      "flags": "--ts-config [tsConfig]",
+      "description": "Path to typescript configuration file. Default is tsconfig.json",
+      "required": false,
+      "optional": true,
+      "variadic": false,
+      "mandatory": false,
+      "long": "--ts-config",
+      "negate": false,
+      "defaultValue": "tsconfig.json",
+      "hidden": false,
+      "conflictsWith": []
     },
     {
-      "label": "Branch to use as a base for comparison and display of affected packages",
-      "name": "-d, --diff [diff]",
+      "flags": "-d, --diff <branch>",
+      "description": "Branch to use as a base for comparison and display of affected packages",
+      "required": true,
+      "optional": false,
+      "variadic": false,
+      "mandatory": false,
+      "short": "-d",
+      "long": "--diff",
+      "negate": false,
+      "hidden": false,
+      "conflictsWith": []
     },
+    {
+      "flags": "--webpack-config [webpackConfig]",
+      "description": "Path to webpack configuration file",
+      "required": false,
+      "optional": true,
+      "variadic": false,
+      "mandatory": false,
+      "long": "--webpack-config",
+      "negate": false,
+      "hidden": false,
+      "conflictsWith": []
+    }
+  ],
+  "parent": null,
+  "_allowUnknownOption": false,
+  "_allowExcessArguments": true,
+  "_args": [
+    {
+      "description": "Graph related command to execute",
+      "variadic": false,
+      "argChoices": [
+        "generate"
+      ],
+      "required": true,
+      "_name": "command"
+    }
   ],
-}
+  "args": [],
+  "rawArgs": [],
+  "processedArgs": [],
+  "_scriptPath": null,
+  "_name": "graph",
+  "_optionValues": {
+    "outputFile": "monorepo-graph.svg",
+    "tsConfig": "tsconfig.json"
+  },
+  "_optionValueSources": {
+    "outputFile": "default",
+    "tsConfig": "default"
+  },
+  "_storeOptionsAsProperties": false,
+  "_executableHandler": false,
+  "_executableFile": null,
+  "_executableDir": null,
+  "_defaultCommandName": null,
+  "_exitCallback": null,
+  "_aliases": [],
+  "_combineFlagAndOptionalValue": true,
+  "_description": "Generate dependency graph in a monorepo",
+  "_summary": "",
+  "_enablePositionalOptions": false,
+  "_passThroughOptions": false,
+  "_lifeCycleHooks": {},
+  "_showHelpAfterError": false,
+  "_showSuggestionAfterError": true,
+  "_outputConfiguration": {},
+  "_hidden": false,
+  "_hasHelpOption": true,
+  "_helpFlags": "-h, --help",
+  "_helpDescription": "display help for command",
+  "_helpShortFlag": "-h",
+  "_helpLongFlag": "--help",
+  "_helpCommandName": "help",
+  "_helpCommandnameAndArgs": "help [command]",
+  "_helpCommandDescription": "display help for command",
+  "_helpConfiguration": {}
+}"
 `;

package/src/commands/graph-generate.js

@@ -1,132 +1,77 @@
-import path from 'node:path'
 import execa from 'execa'
-import ora from 'ora'
 import { createArgument, print } from '@toptal/davinci-cli-shared'
-import { fileURLToPath } from 'node:url'
 
-import getPackages from '../utils/get-packages.js'
+import { getDepcruiseCommandOptions } from '../utils/graph/utils.js'
+import { getPackageLocations } from '../utils/graph/packages.js'
 
-/**
- * @return {Array<string>}
- */
-const getPackageLocations = () => {
-  const packages = getPackages(process.cwd())
+export const graphGenerateCommand = async ({
+  outputFile,
+  ...depcruiseOptions
+}) => {
+  console.log(print.davinciGradient('Dependency graph generator\n'))
 
-  if (packages.length === 0) {
-    print.red('Your project does not seem to be a monorepo. Exiting...')
-    process.exit(1)
-  }
-
-  return packages.map(({ location }) => location)
-}
+  const spinner = print.startSpinner('Getting Packages Locations...\n', {
+    prefixText: '[GRAPH GENERATOR]',
+  })
 
-/**
- * @param {string} baseBranch
- * @returns {Array<string>}
- */
-const getChangedFiles = baseBranch => {
   try {
-    const { stdout } = execa.sync('git', [
-      '--no-pager',
-      'diff',
-      '--name-only',
-      `origin/${baseBranch}`,
-    ])
-
-    return stdout.split('\n')
-  } catch (e) {
-    return []
-  }
-}
-
-/**
- * @param {Array<string>} changedPackages
- * @returns {string}
- */
-const evaluateChangedPackages = changedPackages =>
-  changedPackages.length === 0
-    ? 'undefined'
-    : `^(${changedPackages.join('|')})/`
-
-/**
- * @param {string} baseBranch
- * @param {Array<string>} packageLocations
- * @returns {Array<string>}
- */
-const getChangedPackages = (baseBranch, packageLocations) => {
-  const changedFiles = getChangedFiles(baseBranch)
+    const packageLocations = getPackageLocations()
 
-  return packageLocations.filter(packageLocation =>
-    changedFiles.find(filePath => filePath.startsWith(packageLocation + '/'))
-  )
-}
+    spinner.succeed('Packages Locations are fetched!')
 
-const graphGenerateCommand = async ({ outputFile, tsConfig, diff }) => {
-  const __dirname = path.dirname(fileURLToPath(import.meta.url))
-  const packageLocations = getPackageLocations()
+    spinner.start('Generating dependency graph...\n')
 
-  const spinner = ora('Generating dependency graph...\n').start()
+    const graphGenerationOutput = await execa(
+      'depcruise',
+      getDepcruiseCommandOptions({
+        ...depcruiseOptions,
+        packageLocations,
+      }),
+      { stdout: 'pipe' }
+    )
 
-  const graphDefinitionProcess = execa('depcruise', [
-    '--config',
-    path.join(__dirname, '..', 'configs', 'depcruise-config.cjs'),
-    '--ts-config',
-    tsConfig,
-    '--output-type',
-    'archi',
-    '--include-only',
-    `^(${packageLocations.join('|')})/`,
-    '--collapse',
-    `^(${packageLocations.join('|')})/`,
-    ...(diff
-      ? [
-          '--reaches',
-          evaluateChangedPackages(getChangedPackages(diff, packageLocations)),
-        ]
-      : []),
-    '.',
-  ])
-  const graphTransformProcess = execa('dot', ['-T', 'svg', '-o', outputFile])
+    spinner.succeed('Dependency graph has been generated!')
 
-  graphDefinitionProcess.stdout.pipe(graphTransformProcess.stdin)
+    spinner.start(`Creating SVG file to ${outputFile}...\n`)
 
-  try {
-    await graphDefinitionProcess
-    await graphTransformProcess
+    await execa('dot', ['-T', 'svg', '-o', outputFile], {
+      input: graphGenerationOutput.stdout,
+    })
 
-    spinner.succeed('Graph file is created!\n')
+    spinner.succeed('Graph SVG file is created!')
   } catch (error) {
-    spinner.fail(`Failed to generate dependency graph. ${error.message}\n`)
+    spinner.fail()
+    console.error(error)
     process.exit(1)
   }
 }
 
-const graphGenerateCommandCreator = {
-  action: (_, options) => graphGenerateCommand(options),
-  command: 'graph',
-  description: 'Generate dependency graph in a monorepo',
-  args: [
-    createArgument('<command>', 'Graph related command to execute').choices([
-      'generate',
-    ]),
-  ],
-  options: [
-    {
-      name: '-o, --output-file [outputFile]',
-      label: 'Output file name. Default is monorepo-graph.svg',
-      default: 'monorepo-graph.svg',
-    },
-    {
-      name: '--ts-config [tsConfig]',
-      label: 'Path to typescript configuration file. Default is tsconfig.json',
-      default: 'tsconfig.json',
-    },
-    {
-      name: '-d, --diff [diff]',
-      label:
-        'Branch to use as a base for comparison and display of affected packages',
-    },
-  ],
+export const createGraphGenerateCommand = program => {
+  return program
+    .createCommand('graph')
+    .description('Generate dependency graph in a monorepo')
+    .addArgument(
+      createArgument('<command>', 'Graph related command to execute').choices([
+        'generate',
+      ])
+    )
+    .option(
+      '-o, --output-file [outputFile]',
+      'Output file name. Default is monorepo-graph.svg',
+      'monorepo-graph.svg'
+    )
+    .option(
+      '--ts-config [tsConfig]',
+      'Path to typescript configuration file. Default is tsconfig.json',
+      'tsconfig.json'
+    )
+    .option(
+      '-d, --diff <branch>',
+      'Branch to use as a base for comparison and display of affected packages'
+    )
+    .option(
+      '--webpack-config [webpackConfig]',
+      'Path to webpack configuration file'
+    )
+    .action((_, options) => graphGenerateCommand(options))
 }
-
-export default graphGenerateCommandCreator

package/src/commands/graph-generate.test.js

@@ -1,7 +1,23 @@
-import graphGenerateCommandCreator from './graph-generate.js'
+import { jest } from '@jest/globals'
+// eslint-disable-next-line import/no-extraneous-dependencies
+import { Command } from 'commander'
+
+import { createGraphGenerateCommand } from './graph-generate.js'
+
+describe('createGraphGenerateCommand', () => {
+  let program
+
+  beforeEach(() => {
+    program = new Command()
+  })
+
+  afterEach(() => {
+    jest.clearAllMocks()
+  })
 
-describe('graphGenerateCommandCreator', () => {
   it('has the correct command structure', () => {
-    expect(graphGenerateCommandCreator).toMatchSnapshot()
+    const command = createGraphGenerateCommand(program)
+
+    expect(JSON.stringify(command, null, 2)).toMatchSnapshot()
   })
 })

package/src/index.js

@@ -1,6 +1,6 @@
 import detectCircularityCommandCreator from './commands/detect-circularity.js'
 import metricsCommandCreator from './commands/metrics.js'
-import graphGenerateCommandCreator from './commands/graph-generate.js'
+import { createGraphGenerateCommand } from './commands/graph-generate.js'
 import checkIfMonorepo from './utils/check-if-monorepo.js'
 import getPackages from './utils/get-packages.js'
 
@@ -12,7 +12,7 @@ export const utils = {
 export const commands = [
   detectCircularityCommandCreator,
   metricsCommandCreator,
-  graphGenerateCommandCreator,
+  createGraphGenerateCommand,
 ]
 
 export default {

package/src/utils/graph/packages.js

@@ -0,0 +1,83 @@
+import execa from 'execa'
+
+import getPackages from '../get-packages.js'
+
+/**
+ * Get Locations of packages in monorepo
+ * @return {Array<string>}
+ * @example
+ * getPackageLocations()
+ * // => ['packages/picasso', 'packages/picasso-lab']
+ */
+export const getPackageLocations = () => {
+  const packages = getPackages(process.cwd())
+
+  if (packages.length === 0) {
+    throw new Error('Your project does not seem to be a monorepo.')
+  }
+
+  return packages.map(({ location }) => location)
+}
+
+/**
+ * Transforms an array of package names to a regex string
+ * that can be used to match against a file path.
+ * Example:
+ * ['@toptal/picasso', '@toptal/picasso-lab'] => '^(@toptal\\/picasso|@toptal\\/picasso-lab)\\/'
+ * @param {Array<string>} packages
+ * @returns {string}
+ * @example
+ * transformPackagesToRegex(['@toptal/picasso', '@toptal/picasso-lab'])
+ * // => '^(@toptal\\/picasso|@toptal\\/picasso-lab)\\/'
+ * @example
+ * transformPackagesToRegex(['@toptal/picasso'])
+ * // => '^(@toptal\\/picasso)\\/'
+ * @example
+ * transformPackagesToRegex([])
+ * // => 'undefined'
+ * @example
+ */
+export const transformPackagesToRegex = packages => {
+  if (packages.length === 0) {
+    return 'undefined'
+  }
+
+  const regex = packages
+    .map(packageName => packageName.replace('/', '\\/'))
+    .join('|')
+
+  return `^(${regex})/`
+}
+
+/**
+ * Get changed packages in a monorepo
+ * @param {string} baseBranch
+ * @param {Array<string>} packageLocations
+ * @returns {Array<string>}
+ * @example
+ * getChangedPackages('master', ['packages/picasso', 'packages/picasso-lab'])
+ * // => ['packages/picasso']
+ * @example
+ * getChangedPackages('master', [])
+ * // => []
+ */
+export const getChangedPackages = (baseBranch, packageLocations) => {
+  const { stdout } = execa.sync('git', [
+    '--no-pager',
+    'diff',
+    '--name-only',
+    `origin/${baseBranch}`,
+  ])
+
+  const changedFiles = stdout.split('\n')
+
+  return packageLocations.filter(packageLocation =>
+    changedFiles.find(filePath => filePath.startsWith(packageLocation + '/'))
+  )
+}
+
+export default {
+  getPackageLocations,
+  getChangedPackages,
+  transformPackagesToRegex,
+}

package/src/utils/graph/packages.test.js

@@ -0,0 +1,109 @@
+import { describe, jest } from '@jest/globals'
+import execa from 'execa'
+
+const mockedGetPackages = jest.fn()
+
+jest.unstable_mockModule('../get-packages.js', () => ({
+  __esModule: true,
+  default: mockedGetPackages,
+}))
+
+const { getPackageLocations, transformPackagesToRegex, getChangedPackages } =
+  await import('./packages.js')
+
+describe('getPackageLocations', () => {
+  beforeEach(() => {
+    mockedGetPackages.mockImplementation(() => [
+      {
+        location: 'packages/picasso',
+        name: '@toptal/picasso',
+      },
+      {
+        location: 'packages/picasso-lab',
+        name: '@toptal/picasso-lab',
+      },
+      {
+        location: 'packages/picasso-charts',
+        name: '@toptal/picasso-charts',
+      },
+    ])
+  })
+
+  afterEach(() => {
+    jest.resetAllMocks()
+  })
+
+  it('returns package locations', () => {
+    expect(getPackageLocations()).toEqual([
+      'packages/picasso',
+      'packages/picasso-lab',
+      'packages/picasso-charts',
+    ])
+  })
+
+  describe('when there are no packages', () => {
+    it('throws an error', () => {
+      mockedGetPackages.mockImplementation(() => [])
+
+      expect(getPackageLocations).toThrow(
+        'Your project does not seem to be a monorepo.'
+      )
+    })
+  })
+})
+
+describe('transformPackagesToRegex', () => {
+  it('transforms an array of package names to a regex string', () => {
+    expect(
+      transformPackagesToRegex(['@toptal/picasso', '@toptal/picasso-lab'])
+    ).toBe('^(@toptal\\/picasso|@toptal\\/picasso-lab)/')
+  })
+
+  it('transforms an array with single package to a regex string', () => {
+    expect(transformPackagesToRegex(['@toptal/picasso'])).toBe(
+      '^(@toptal\\/picasso)/'
+    )
+  })
+
+  describe('when there are no packages', () => {
+    it('returns undefined', () => {
+      expect(transformPackagesToRegex([])).toBe('undefined')
+    })
+  })
+})
+
+describe('getChangedPackages', () => {
+  const baseBranch = 'master'
+  const packageLocations = ['packages/picasso', 'packages/picasso-lab']
+
+  it('returns changed packages', async () => {
+    jest.spyOn(execa, 'sync').mockImplementation(() => ({
+      stdout: 'packages/picasso/\npackages/picasso-lab/',
+    }))
+
+    expect(await getChangedPackages(baseBranch, packageLocations)).toEqual([
+      'packages/picasso',
+      'packages/picasso-lab',
+    ])
+  })
+
+  describe('when there are changed files that are not related to packages', () => {
+    it('returns an empty array', async () => {
+      jest.spyOn(execa, 'sync').mockImplementation(() => ({
+        stdout: 'packages/picasso2/\npackages/picasso-lab3/\nREADME.md',
+      }))
+
+      expect(await getChangedPackages(baseBranch, packageLocations)).toEqual([])
+    })
+  })
+
+  describe('when there are no changed packages', () => {
+    it('returns an empty array', async () => {
+      jest.spyOn(execa, 'sync').mockImplementation(() => ({
+        stdout: '',
+      }))
+
+      expect(await getChangedPackages(baseBranch, packageLocations)).toEqual([])
+    })
+  })
+})

package/src/utils/graph/utils.js

@@ -0,0 +1,65 @@
+import { fileURLToPath } from 'node:url'
+import path from 'node:path'
+
+import { getChangedPackages, transformPackagesToRegex } from './packages.js'
+
+/**
+ * Get depcruise command options
+ * @param {Object} options
+ * @param {string} options.tsConfig
+ * @param {string} options.webpackConfig
+ * @param {string} options.diff
+ * @param {Array<string>} options.packageLocations
+ * @returns {Array<string>}
+ * @example
+ * getDepcruiseCommandOptions({
+ *  tsConfig: 'tsconfig.json',
+ *  webpackConfig: 'webpack.config.js',
+ *  diff: 'master',
+ *  packageLocations: ['packages/picasso', 'packages/picasso-lab']
+ *  })
+ *  // => [
+ *  //   '--config',
+ *  //   'packages/monorepo/src/utils/graph/configs/depcruise-config.cjs',
+ *  //   '--ts-config',
+ *  //   'tsconfig.json',
+ *  //   '--output-type',
+ *  //   'archi',
+ *  //   '--include-only',
+ *  //   '^(@toptal\\/picasso|@toptal\\/picasso-lab)\\/',
+ *  //   '--collapse',
+ *  //   '^(@toptal\\/picasso|@toptal\\/picasso-lab)\\/',
+ *  //   '--reaches',
+ *  //   '^(@toptal\\/picasso)\\/',
+ *  //   '.',
+ *  // ]
+ */
+export const getDepcruiseCommandOptions = options => {
+  const { tsConfig, webpackConfig, diff, packageLocations } = options
+  const __dirname = path.dirname(fileURLToPath(import.meta.url))
+
+  return [
+    '--config',
+    path.join(__dirname, '../../', 'configs', 'depcruise-config.cjs'),
+    '--ts-config',
+    tsConfig,
+    '--output-type',
+    'archi',
+    '--include-only',
+    transformPackagesToRegex(packageLocations),
+    '--collapse',
+    transformPackagesToRegex(packageLocations),
+    ...(webpackConfig ? ['--webpack-config', webpackConfig] : []),
+    ...(diff
+      ? [
+          '--reaches',
+          transformPackagesToRegex(getChangedPackages(diff, packageLocations)),
+        ]
+      : []),
+    '.',
+  ]
+}
+
+export default {
+  getDepcruiseCommandOptions,
+}

package/src/utils/graph/utils.test.js

@@ -0,0 +1,102 @@
+import { jest } from '@jest/globals'
+import path from 'node:path'
+
+const mockedGetChangedPackages = jest.fn()
+const mockedTransformPackagesToRegex = jest.fn()
+
+jest.unstable_mockModule('./packages.js', () => ({
+  getChangedPackages: mockedGetChangedPackages,
+  transformPackagesToRegex: mockedTransformPackagesToRegex,
+}))
+
+const { getDepcruiseCommandOptions } = await import('./utils.js')
+
+describe('getDepcruiseCommandOptions', () => {
+  beforeEach(() => {
+    mockedGetChangedPackages.mockReturnValue(['packages/picasso-lab'])
+
+    mockedTransformPackagesToRegex.mockImplementation(packages =>
+      packages.join('|')
+    )
+
+    jest
+      .spyOn(path, 'join')
+      .mockReturnValue(
+        'packages/monorepo/src/utils/graph/configs/depcruise-config.cjs'
+      )
+  })
+
+  afterEach(() => {
+    jest.resetAllMocks()
+  })
+
+  const options = {
+    tsConfig: 'tsconfig.json',
+    webpackConfig: 'webpack.config.js',
+    diff: 'master',
+    packageLocations: ['packages/picasso', 'packages/picasso-lab'],
+  }
+
+  it('returns an array with all the required depcruise options', () => {
+    const result = getDepcruiseCommandOptions(options)
+
+    expect(result).toEqual([
+      '--config',
+      'packages/monorepo/src/utils/graph/configs/depcruise-config.cjs',
+      '--ts-config',
+      'tsconfig.json',
+      '--output-type',
+      'archi',
+      '--include-only',
+      'packages/picasso|packages/picasso-lab',
+      '--collapse',
+      'packages/picasso|packages/picasso-lab',
+      '--webpack-config',
+      'webpack.config.js',
+      '--reaches',
+      'packages/picasso-lab',
+      '.',
+    ])
+  })
+
+  describe('when webpackConfig is not provided', () => {
+    it('does not include webpackConfig in the result', () => {
+      const result = getDepcruiseCommandOptions({
+        ...options,
+        webpackConfig: undefined,
+      })
+
+      expect(result).not.toContain('--webpack-config')
+    })
+  })
+
+  describe('when diff is not provided', () => {
+    it('does not include diff in the result', () => {
+      const result = getDepcruiseCommandOptions({
+        ...options,
+        diff: undefined,
+      })
+
+      expect(result).not.toContain('--reaches')
+    })
+  })
+
+  describe('when diff is provided', () => {
+    it('calls getChangedPackages with the correct arguments', () => {
+      getDepcruiseCommandOptions(options)
+
+      expect(mockedGetChangedPackages).toHaveBeenCalledWith('master', [
+        'packages/picasso',
+        'packages/picasso-lab',
+      ])
+    })
+
+    it('calls transformPackagesToRegex with the correct arguments', () => {
+      getDepcruiseCommandOptions(options)
+
+      expect(mockedTransformPackagesToRegex).toHaveBeenCalledWith([
+        'packages/picasso-lab',
+      ])
+    })
+  })
+})