@toptal/davinci-graphql-codegen 0.2.25-alpha-fix-execute-graphql-command-f9d910f2.16 → 0.3.0

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @toptal/davinci-graphql-codegen
 
+## 0.3.0
+
+### Minor Changes
+
+- [#1799](https://github.com/toptal/davinci/pull/1799) [`103a3ec9`](https://github.com/toptal/davinci/commit/103a3ec94aa9ca9d9d83aab4cbcb510e26bf6071) Thanks [@separatio](https://github.com/separatio)! - ---
+
+  - upgrade required minimum Node version to 14 LTS
+
 ## 0.2.24
 
 ### Patch Changes

package/bin/davinci-graphql-codegen.js

@@ -9,4 +9,3 @@ cliEngine.loadCommands(
   [codegenGenerateSchemaCreator, codegenGenerateOperationsCreator],
   'davinci-graphql-codegen'
 )
-cliEngine.bootstrap()

package/dist-package/package.json

@@ -0,0 +1,37 @@
+{
+  "name": "@toptal/davinci-graphql-codegen",
+  "version": "0.3.0",
+  "description": "Codegen",
+  "author": "Toptal",
+  "license": "ISC",
+  "homepage": "https://github.com/toptal/davinci/tree/master/packages/graphql-codegen#readme",
+  "publishConfig": {
+    "access": "public"
+  },
+  "bin": {
+    "davinci-graphql-codegen": "./bin/davinci-graphql-codegen.js"
+  },
+  "main": "./src/index.js",
+  "scripts": {
+    "build:package": "../../bin/build-package.js",
+    "prepublishOnly": "../../bin/prepublish.js",
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "sideEffects": false,
+  "dependencies": {
+    "@google-cloud/storage": "^6.2.3",
+    "@graphql-codegen/add": "^3.1.0",
+    "@graphql-codegen/cli": "^2.11.3",
+    "@graphql-codegen/introspection": "^2.2.0",
+    "@graphql-codegen/near-operation-file-preset": "^2.4.4",
+    "@graphql-codegen/typed-document-node": "^2.3.2",
+    "@graphql-codegen/typescript": "^2.2.2",
+    "@graphql-codegen/typescript-operations": "^2.3.5",
+    "@graphql-codegen/typescript-resolvers": "^2.2.1",
+    "@graphql-typed-document-node/core": "^3.1.0",
+    "@toptal/davinci-cli-shared": "^1.10.0",
+    "@toptal/davinci-monorepo": "6.8.5",
+    "chalk": "^4.1.2",
+    "graphql": "^15.7.1"
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/davinci-graphql-codegen",
-  "version": "0.2.25-alpha-fix-execute-graphql-command-f9d910f2.16+f9d910f2",
+  "version": "0.3.0",
   "description": "Codegen",
   "author": "Toptal",
   "license": "ISC",
@@ -29,12 +29,9 @@
     "@graphql-codegen/typescript-operations": "^2.3.5",
     "@graphql-codegen/typescript-resolvers": "^2.2.1",
     "@graphql-typed-document-node/core": "^3.1.0",
-    "@toptal/davinci-cli-shared": "1.10.1-alpha-fix-execute-graphql-command-f9d910f2.16+f9d910f2",
-    "@toptal/davinci-monorepo": "6.8.6-alpha-fix-execute-graphql-command-f9d910f2.16+f9d910f2",
+    "@toptal/davinci-cli-shared": "^1.10.0",
+    "@toptal/davinci-monorepo": "6.8.5",
     "chalk": "^4.1.2",
-    "fs-extra": "^10.1.0",
-    "graphql": "^15.7.1",
-    "prettier": "^2.6.2"
-  },
-  "gitHead": "f9d910f255c0f3a91e4181beb4b1883fd158551e"
+    "graphql": "^15.7.1"
+  }
 }

package/src/generate/operations.js

@@ -1,7 +1,5 @@
 const chalk = require('chalk')
 const { generate } = require('@graphql-codegen/cli')
-const { readFileSync, writeFileSync } = require('fs-extra')
-const prettier = require('prettier')
 
 const {
   commonOperationTypesConfig,
@@ -44,21 +42,7 @@ const generateOperations = async ({ schema, documents, extension }) => {
         },
       },
       hooks: {
-        afterAllFileWrite: [
-          async (...filePaths) => {
-            for (const path of filePaths) {
-              const rawText = readFileSync(path, 'utf8')
-              const options = await prettier.resolveConfig(process.cwd())
-
-              const formattedText = prettier.format(rawText, {
-                parser: 'typescript',
-                ...options,
-              })
-
-              writeFileSync(path, formattedText)
-            }
-          },
-        ],
+        afterAllFileWrite: 'prettier --write',
       },
     },
     true

package/src/generate/schema.js

@@ -1,7 +1,5 @@
 const { generate } = require('@graphql-codegen/cli')
 const chalk = require('chalk')
-const { readFileSync, writeFileSync } = require('fs')
-const prettier = require('prettier')
 
 const {
   commonSchemaTypesConfig,
@@ -39,21 +37,7 @@ const generateSchema = async ({ schema, target, projectId }) => {
         },
       },
       hooks: {
-        afterAllFileWrite: [
-          async (...filePaths) => {
-            for (const path of filePaths) {
-              const rawText = readFileSync(path, 'utf8')
-              const options = await prettier.resolveConfig(process.cwd())
-
-              const formattedText = prettier.format(rawText, {
-                parser: 'typescript',
-                ...options,
-              })
-
-              writeFileSync(path, formattedText)
-            }
-          },
-        ],
+        afterAllFileWrite: 'prettier --write',
       },
       config: {
         ...commonSchemaTypesConfig,

package/src/services/get-schema-path.js

@@ -6,7 +6,7 @@ const getMonorepoSchemaPath = require('./get-monorepo-schema-path')
 const getMonolithSchemaPath = require('./get-monolith-schema-path')
 
 const getSchemaPath = schema => {
-  return checkIfMonorepo({ considerWorkspaces: true })
+  return checkIfMonorepo()
     ? getMonorepoSchemaPath(schema)
     : getMonolithSchemaPath(schema)
 }

package/src/services/get-schema-path.test.js

@@ -0,0 +1,59 @@
+jest.mock('@toptal/davinci-monorepo', () => ({
+  commands: [],
+  utils: { checkIfMonorepo: jest.fn() },
+}))
+
+jest.mock('./get-monorepo-schema-path', () =>
+  jest.fn(() => ({
+    target: 'talent',
+    schemaPath: '@toptal/modularity-template-graphql',
+    schemaPathResolution:
+      'home/users/alexvcasillas/toptal/libs/graphql/schema.graphql',
+  }))
+)
+
+jest.mock('./get-monolith-schema-path', () =>
+  jest.fn(() => ({
+    target: 'src/modules/graphql',
+    schemaPath: 'src/modules/graphql',
+    schemaPathResolution:
+      'home/users/alexvcasillas/toptal/screening-wizard/src/modules/graphql/schema.graphql',
+  }))
+)
+
+const {
+  utils: { checkIfMonorepo },
+} = require('@toptal/davinci-monorepo')
+
+const getSchemaPath = require('./get-schema-path')
+
+const monorepoSchema = '@toptal/modularity-template-graphql/talent'
+const monolithSchema = 'src/modules/graphql'
+
+describe('getSchemaPath', () => {
+  it('returns target, schemaPath and schemaPathResolution for monorepo', () => {
+    checkIfMonorepo.mockReturnValue(() => true)
+
+    const { target, schemaPath, schemaPathResolution } =
+      getSchemaPath(monorepoSchema)
+
+    expect(target).toBe('talent')
+    expect(schemaPath).toBe('@toptal/modularity-template-graphql')
+    expect(schemaPathResolution).toBe(
+      'home/users/alexvcasillas/toptal/libs/graphql/schema.graphql'
+    )
+  })
+
+  it('returns target, schemaPath and schemaPathResolution for monolith', () => {
+    checkIfMonorepo.mockReturnValue(false)
+
+    const { target, schemaPath, schemaPathResolution } =
+      getSchemaPath(monolithSchema)
+
+    expect(target).toBe('src/modules/graphql')
+    expect(schemaPath).toBe('src/modules/graphql')
+    expect(schemaPathResolution).toBe(
+      'home/users/alexvcasillas/toptal/screening-wizard/src/modules/graphql/schema.graphql'
+    )
+  })
+})

package/src/utils/detect-schema-source.test.js

@@ -0,0 +1,29 @@
+const {
+  isSchemaFromBucket,
+  isSchemaFromHttp,
+  isLocalSchema,
+} = require('./detect-schema-source')
+
+const gsBucketSchema = 'gs://toptal.net/gateway/graphql/talent'
+const httpSchema = 'https://toptal.net/gateway/graphql/talent'
+const localSchema = '../../graphql/talent'
+
+describe('Detect Schema Sources', () => {
+  it('detects that schema is from GS Bucket', () => {
+    expect(isSchemaFromBucket(gsBucketSchema)).toBe(true)
+    expect(isSchemaFromHttp(gsBucketSchema)).toBe(false)
+    expect(isLocalSchema(gsBucketSchema)).toBe(false)
+  })
+
+  it('detects that schema is from http', () => {
+    expect(isSchemaFromBucket(httpSchema)).toBe(false)
+    expect(isSchemaFromHttp(httpSchema)).toBe(true)
+    expect(isLocalSchema(httpSchema)).toBe(false)
+  })
+
+  it('detects that schema is from local folder', () => {
+    expect(isSchemaFromBucket(localSchema)).toBe(false)
+    expect(isSchemaFromHttp(localSchema)).toBe(false)
+    expect(isLocalSchema(localSchema)).toBe(true)
+  })
+})

package/src/utils/parse-gs-uri.test.js

@@ -0,0 +1,12 @@
+const parseGSURI = require('./parse-gs-uri')
+
+const bucketURI = 'gs://gqlgw-introspection/staging_talent_schema.graphql'
+
+describe('Parse Google Storage Bucket URI', () => {
+  it('parses a Google Storage Bucket URI correctly', () => {
+    const { bucketName, fileName } = parseGSURI(bucketURI)
+
+    expect(bucketName).toBe('gqlgw-introspection')
+    expect(fileName).toBe('staging_talent_schema.graphql')
+  })
+})

package/src/utils/process-args.test.js

@@ -0,0 +1,10 @@
+const processArgs = require('./process-args')
+
+describe('Argument processor', () => {
+  it('process arguments correctly', () => {
+    const args = processArgs(['generate-operations', '--projectId=toptal'])
+
+    expect(args.operation).toBe('generate-operations')
+    expect(args.projectId).toBe('toptal')
+  })
+})

package/src/utils/to-array.test.js

@@ -0,0 +1,15 @@
+const toArray = require('./to-array')
+
+describe('toArray', () => {
+  it("converts a value into an array if it's not one", () => {
+    const asArray = toArray('hello')
+
+    expect(Array.isArray(asArray)).toBe(true)
+  })
+
+  it("returns the array as is if it's an array", () => {
+    const asArray = toArray(['hello', 'there'])
+
+    expect(Array.isArray(asArray)).toBe(true)
+  })
+})