@toptal/davinci-graphql-codegen 0.1.2-alpha-feature-comm-745-monolith-support.39 → 0.2.0

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @toptal/davinci-graphql-codegen
 
+## 0.2.0
+
+### Minor Changes
+
+- [#1184](https://github.com/toptal/davinci/pull/1184) [`7dd8b681`](https://github.com/toptal/davinci/commit/7dd8b68177d595538dd8d5cff5c0654d92d68659) Thanks [@alexvcasillas](https://github.com/alexvcasillas)! - - Support for Monolith projects that don't rely on yarn workspaces and packages.
+  - Allow searching for codegen.json in a custom directory.
+  - Allow configuring the generated operations file extension and defaults to `.ts`.
+
+* [#1184](https://github.com/toptal/davinci/pull/1184) [`7dd8b681`](https://github.com/toptal/davinci/commit/7dd8b68177d595538dd8d5cff5c0654d92d68659) Thanks [@alexvcasillas](https://github.com/alexvcasillas)! - - Allow searching for custom codegen.json configuration file.
+  - Move `checkIfMonorepo` from engine to monorepo package.
+
+### Patch Changes
+
+- Updated dependencies [[`7dd8b681`](https://github.com/toptal/davinci/commit/7dd8b68177d595538dd8d5cff5c0654d92d68659)]:
+  - @toptal/davinci-cli-shared@1.5.1
+  - @toptal/davinci-monorepo@6.4.2
+
 ## 0.1.1
 
 ### Patch Changes

package/dist-package/package.json

@@ -0,0 +1,37 @@
+{
+  "name": "@toptal/davinci-graphql-codegen",
+  "version": "0.2.0",
+  "description": "Codegen",
+  "author": "Toptal",
+  "license": "ISC",
+  "homepage": "https://github.com/toptal/davinci/tree/master/packages/graphql-codegen#readme",
+  "publishConfig": {
+    "access": "public"
+  },
+  "bin": {
+    "davinci-graphql-codegen": "./bin/davinci-graphql-codegen.js"
+  },
+  "main": "./src/index.js",
+  "scripts": {
+    "build:package": "../../bin/build-package.js",
+    "prepublishOnly": "../../bin/prepublish.js",
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "sideEffects": false,
+  "dependencies": {
+    "@google-cloud/storage": "^5.16.1",
+    "@graphql-codegen/add": "^3.1.0",
+    "@graphql-codegen/cli": "^2.2.0",
+    "@graphql-codegen/introspection": "^2.1.0",
+    "@graphql-codegen/near-operation-file-preset": "^2.2.8",
+    "@graphql-codegen/typed-document-node": "^2.2.7",
+    "@graphql-codegen/typescript": "^2.2.2",
+    "@graphql-codegen/typescript-operations": "^2.1.4",
+    "@graphql-codegen/typescript-resolvers": "^2.2.1",
+    "@graphql-typed-document-node/core": "^3.1.0",
+    "@toptal/davinci-cli-shared": "^1.5.1",
+    "@toptal/davinci-monorepo": "6.4.2",
+    "chalk": "^4.1.2",
+    "graphql": "^15.7.1"
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/davinci-graphql-codegen",
-  "version": "0.1.2-alpha-feature-comm-745-monolith-support.39+090116c4",
+  "version": "0.2.0",
   "description": "Codegen",
   "author": "Toptal",
   "license": "ISC",
@@ -29,10 +29,9 @@
     "@graphql-codegen/typescript-operations": "^2.1.4",
     "@graphql-codegen/typescript-resolvers": "^2.2.1",
     "@graphql-typed-document-node/core": "^3.1.0",
-    "@toptal/davinci-cli-shared": "1.5.1-alpha-feature-comm-745-monolith-support.149+090116c4",
-    "@toptal/davinci-monorepo": "6.4.2-alpha-feature-comm-745-monolith-support.110+090116c4",
+    "@toptal/davinci-cli-shared": "^1.5.1",
+    "@toptal/davinci-monorepo": "6.4.2",
     "chalk": "^4.1.2",
     "graphql": "^15.7.1"
-  },
-  "gitHead": "090116c4add42ab28ee748f29af64ad63f2a70d0"
+  }
 }

package/src/services/get-monolith-schema-path.js

@@ -1,11 +1,11 @@
 const getRelativeFilePath = require('../utils/get-relative-file-path')
 
 const getMonolithSchemaPath = schemaPath => {
-  const target = schemaPath
+  const schemaPathResolution = getRelativeFilePath(
+    `${schemaPath}/schema.graphql`
+  )
 
-  const schemaPathResolution = getRelativeFilePath(`${target}/schema.graphql`)
-
-  return { target, schemaPath, schemaPathResolution }
+  return { target: schemaPath, schemaPath, schemaPathResolution }
 }
 
 module.exports = getMonolithSchemaPath

package/src/services/get-schema-path.test.js

@@ -0,0 +1,61 @@
+jest.mock('@toptal/davinci-monorepo', () => ({
+  commands: [],
+  utils: { checkIfMonorepo: jest.fn() }
+}))
+
+jest.mock('./get-monorepo-schema-path', () =>
+  jest.fn(() => ({
+    target: 'talent',
+    schemaPath: '@toptal/modularity-template-graphql',
+    schemaPathResolution:
+      'home/users/alexvcasillas/toptal/libs/graphql/schema.graphql'
+  }))
+)
+
+jest.mock('./get-monolith-schema-path', () =>
+  jest.fn(() => ({
+    target: 'src/modules/graphql',
+    schemaPath: 'src/modules/graphql',
+    schemaPathResolution:
+      'home/users/alexvcasillas/toptal/screening-wizard/src/modules/graphql/schema.graphql'
+  }))
+)
+
+const {
+  utils: { checkIfMonorepo }
+} = require('@toptal/davinci-monorepo')
+
+const getSchemaPath = require('./get-schema-path')
+
+const monorepoSchema = '@toptal/modularity-template-graphql/talent'
+const monolithSchema = 'src/modules/graphql'
+
+describe('getSchemaPath', () => {
+  it('returns target, schemaPath and schemaPathResolution for monorepo', () => {
+    checkIfMonorepo.mockReturnValue(() => true)
+
+    const { target, schemaPath, schemaPathResolution } = getSchemaPath(
+      monorepoSchema
+    )
+
+    expect(target).toBe('talent')
+    expect(schemaPath).toBe('@toptal/modularity-template-graphql')
+    expect(schemaPathResolution).toBe(
+      'home/users/alexvcasillas/toptal/libs/graphql/schema.graphql'
+    )
+  })
+
+  it('returns target, schemaPath and schemaPathResolution for monolith', () => {
+    checkIfMonorepo.mockReturnValue(false)
+
+    const { target, schemaPath, schemaPathResolution } = getSchemaPath(
+      monolithSchema
+    )
+
+    expect(target).toBe('src/modules/graphql')
+    expect(schemaPath).toBe('src/modules/graphql')
+    expect(schemaPathResolution).toBe(
+      'home/users/alexvcasillas/toptal/screening-wizard/src/modules/graphql/schema.graphql'
+    )
+  })
+})

package/src/utils/detect-schema-source.test.js

@@ -0,0 +1,29 @@
+const {
+  isSchemaFromBucket,
+  isSchemaFromHttp,
+  isLocalSchema
+} = require('./detect-schema-source')
+
+const gsBucketSchema = 'gs://toptal.net/gateway/graphql/talent'
+const httpSchema = 'https://toptal.net/gateway/graphql/talent'
+const localSchema = '../../graphql/talent'
+
+describe('Detect Schema Sources', () => {
+  it('detects that schema is from GS Bucket', () => {
+    expect(isSchemaFromBucket(gsBucketSchema)).toBe(true)
+    expect(isSchemaFromHttp(gsBucketSchema)).toBe(false)
+    expect(isLocalSchema(gsBucketSchema)).toBe(false)
+  })
+
+  it('detects that schema is from http', () => {
+    expect(isSchemaFromBucket(httpSchema)).toBe(false)
+    expect(isSchemaFromHttp(httpSchema)).toBe(true)
+    expect(isLocalSchema(httpSchema)).toBe(false)
+  })
+
+  it('detects that schema is from local folder', () => {
+    expect(isSchemaFromBucket(localSchema)).toBe(false)
+    expect(isSchemaFromHttp(localSchema)).toBe(false)
+    expect(isLocalSchema(localSchema)).toBe(true)
+  })
+})

package/src/utils/parse-gs-uri.test.js

@@ -0,0 +1,12 @@
+const parseGSURI = require('./parse-gs-uri')
+
+const bucketURI = 'gs://gqlgw-introspection/staging_talent_schema.graphql'
+
+describe('Parse Google Storage Bucket URI', () => {
+  it('parses a Google Storage Bucket URI correctly', () => {
+    const { bucketName, fileName } = parseGSURI(bucketURI)
+
+    expect(bucketName).toBe('gqlgw-introspection')
+    expect(fileName).toBe('staging_talent_schema.graphql')
+  })
+})

package/src/utils/process-args.test.js

@@ -0,0 +1,10 @@
+const processArgs = require('./process-args')
+
+describe('Argument processor', () => {
+  it('process arguments correctly', () => {
+    const args = processArgs(['generate-operations', '--projectId=toptal'])
+
+    expect(args.operation).toBe('generate-operations')
+    expect(args.projectId).toBe('toptal')
+  })
+})

package/src/utils/to-array.test.js

@@ -0,0 +1,15 @@
+const toArray = require('./to-array')
+
+describe('toArray', () => {
+  it("converts a value into an array if it's not one", () => {
+    const asArray = toArray('hello')
+
+    expect(Array.isArray(asArray)).toBe(true)
+  })
+
+  it("returns the array as is if it's an array", () => {
+    const asArray = toArray(['hello', 'there'])
+
+    expect(Array.isArray(asArray)).toBe(true)
+  })
+})